Server admin 21b: fluxer-devserver serveradmin scenario: channels, members, bans, invites, sudo (#689) #727
Closed
charles
wants to merge 0 commits from
serveradmin-21b-devserver-channels-members-sudo into serveradmin
pull from: serveradmin-21b-devserver-channels-members-sudo
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!727
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-21b-devserver-channels-members-sudo"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: serveradmin-21a-devserver-community-roles (already merged into
serveradmin; the merge was a no-op)What this builds
The second half of the
serveradmindevserver scenario (Server administration spec §9, plan Task 21b), answered as the fork's API does at ba98441b. Everything is incrates/fluxer-devserver.admin.rs):PATCH /channels/{id}for a guild channel or category: the §3.6 fields with the schema's limits (namenormalised with #663'schannel_nameunlessTEXT_CHANNEL_FLEXIBLE_NAMES,topic1–1024 or null, slowmode 0–21600,type0 ↔ 5, linkurl, voicebitrate8000–384000 clamped to the guild's maximum,user_limit0–99,voice_connection_limit1–100,rtc_regionfromrest/rtc_regions.jsonwithUPDATE_RTC_REGION),MANAGE_CHANNELSin the channel;permission_overwritesreplaces the whole list (MANAGE_ROLES, a non-owner cannot grant a bit they lack in the channel,overwriteGrantedBits); a category's new list reaches its synced children;CHANNEL_UPDATE.PATCH /guilds/{id}/channelsportsupdateChannelPositionsByList/computeGuildChannelReorderPlan(GuildChannelOrdering.ts): parent, preceding sibling or position, categories move with their channels, the voice-below-text rule, 50 per category,lock_permissions, every channel renumbered from 1,CHANNEL_UPDATE_BULKwith all of them (as the server sends).DELETE /channels/{id}: a category's channels lose their parent first (CHANNEL_UPDATEeach), the channel's invites go,CHANNEL_DELETE.GET /channels/{id}/follower-stats.moderation.rs): memberPATCH(and@me) fornick,roles,communication_disabled_until/timeout_reasonwith the server's checks (CHANGE_NICKNAME/MANAGE_NICKNAMES,MODERATE_MEMBERS, never oneself or an administrator, 365 days); a body with only voice fields keeps the existing voice behaviour. RolePUT/DELETE, kick (GUILD_MEMBER_REMOVE; oneself or the owner reads asUNKNOWN_MEMBER, asremoveMemberdoes), ban (GUILD_BAN_ADDthenGUILD_MEMBER_REMOVE), bans list, unban (GUILD_BAN_REMOVE,USER_IS_NOT_BANNEDonuser_id), andmembers-search(query, roles, dates, bots, join method withMANAGE_GUILDonly, sort, paging;indexing: truefirst when[serveradmin] indexing_first). The target check is the gateway'scheck_target_member.invites.rs):GET /guilds/{id}/invites(MANAGE_GUILD;serveradmin/invites.jsonplus the guild's other invites, each code once) andDELETE /invites/{code}(its inviter, elseMANAGE_GUILD;INVITE_DELETE {code, channel_id, guild_id}).sudo.rs):POST /guilds/{id}/delete,transfer-ownershipand anmfa_levelchange answer 403SUDO_MODE_REQUIRED(has_mfa,methods) without a valid token or verification, 400INVALID_FORM_BODYonpassword(INVALID_PASSWORD) ormfa_code(INVALID_MFA_CODE) for a wrong one, and succeed withX-Fluxer-Sudo-Mode-JWT(five minutes) for[serveradmin] passwordor, withaccount_has_2fa = true,totp_code. Delete sendsGUILD_DELETEand later READYs lack the guild; transfer sendsGUILD_UPDATEwith the newowner_id(UNKNOWN_MEMBER,CANNOT_TRANSFER_OWNERSHIP_TO_BOT). Anmfa_levelchange also needs 2FA on the account (MUST_ENABLE_2FA_BEFORE_REQUIRING_FOR_MODS).AdminScript::recorded() -> Vec<RecordedRequest>. NewAdminScript::index_members_first()andset_account_has_2fa(bool).serveradmin.tomlgainsindexing_first,password = "demo",totp_code = "000000",account_has_2fa(the demo account's values, not secrets). README updated.No new fixture file: the requests and events reuse the proto fixtures of Tasks 1–3; bodies are built from the
fluxer-protorequest types in the tests.Tests
crates/fluxer-devserver/tests/serveradmin.rs:channel_patch_echoes_update,overwrites_replaced_whole,positions_apply_parent_and_sibling_and_emit_bulk,delete_category_orphans_children,follower_stats_count_following_channels,member_patch_nick_roles_timeout,kick_and_ban_events_in_order,unban_and_not_banned_error,members_search_filters_sort_paging,indexing_first_answer,invite_delete_event,sudo_required_then_password_then_token,wrong_password_field_error,totp_when_account_has_2fa,transfer_changes_owner_and_emits_guild_update,moderator_refusals; unit tests for the sudo state, the target check, the search limits and the nick rules. Written first and seen failing (committest(devserver): …), then passing.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No display tests involved.Deviations from the plan, and things to look at
X-Fluxer-Sudo-Mode-JWTafter a password only to accounts that can hold a token (TOTP or passkey enrolled); the plan asks for the header on every success, so the devserver issues one for the password too. Documented insudo.rsand the README.PATCH /guilds/{id}/channels's category limit and voice rule followexecuteChannelReorder; categories with a parent areCATEGORIES_CANNOT_HAVE_PARENTS(fromapplySinglePositionUpdate, which runs before the planner'sCATEGORIES_CANNOT_HAVE_PARENT_CHANNEL).guild_channels.rs(channel_namemadepub(crate)to reuse #663's normalisation instead of duplicating it) andlib.rs(registration: twomods, theRecordedRequestre-export, threeAdminScriptmethods).chat.rs'sRefusedgained an optionaldatamap thathttp::refusedspreads into the body (forhas_mfa/methods).Closes #689
🤖 Generated with Claude Code
The second half of the serveradmin scenario (Server administration spec §9), answered as the fork's API does at ba98441b: - PATCH /channels/{id} for guild channels and categories (channel_data/ChannelOperationsService.ts editChannel, ChannelRequestSchemas.ts): the §3.6 fields and limits, the whole-array permission_overwrites with the grant check, synced children; CHANNEL_UPDATE. - PATCH /guilds/{id}/channels (guild/services/channel/ ChannelOperationsService.ts updateChannelPositionsByList, GuildChannelOrdering.ts computeGuildChannelReorderPlan): parent and preceding sibling, the voice placement rule, 50 per category; CHANNEL_UPDATE_BULK with every channel. - DELETE /channels/{id} (children orphaned first), follower-stats. - Member PATCH (nick, roles, timeout; @me), role PUT/DELETE, kick, ban (GUILD_BAN_ADD then GUILD_MEMBER_REMOVE), bans list, unban (USER_IS_NOT_BANNED), members-search with filters, sort, paging and the indexing answer (GuildMemberOperationsService.ts, GuildModerationService.ts, GuildMemberSearchController.ts, GuildMemberSearchSchemas.ts; target check from guild_members_roles.erl). - Guild invites list and DELETE /invites/{code} (InviteService.ts; INVITE_DELETE). - The identity check (SudoVerificationService.ts, SudoModeMiddleware.ts): SUDO_MODE_REQUIRED, INVALID_PASSWORD / INVALID_MFA_CODE on the field, the X-Fluxer-Sudo-Mode-JWT token; POST /guilds/{id}/delete, transfer-ownership and an mfa_level change behind it. - Every accepted administration request is recorded (AdminScript::recorded). Refs #689 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Independent review: Task 21b (devserver: channels, members, bans, invites, sudo)
Scope:
git diff f1bf88fc..origin/serveradmin-21b-devserver-channels-members-sudo(69147a29).Plan tests: all 15 named tests exist in
crates/fluxer-devserver/tests/serveradmin.rsand check the spec's values: 32-char nick, 365-day timeout, ban duration 0 or 60–63072000 s, delete history ≤ 604800,USER_IS_NOT_BANNEDonuser_id,PRECEDING_CHANNEL_MUST_SHARE_PARENT,CATEGORIES_CANNOT_HAVE_PARENTS,VOICE_CHANNELS_CANNOT_BE_ABOVE_TEXT_CHANNELS,CANNOT_POSITION_CHANNEL_RELATIVE_TO_ITSELF,MAX_CATEGORY_CHANNELSat 50,SUDO_MODE_REQUIREDwithhas_mfa/methods, password andmfa_codefield errors, the token header. They parse answers and events through the proto types. There is also an extra test,follower_stats_count_following_channels.Interfaces: every endpoint and event in the Interfaces block is there. So are the
[serveradmin] indexing_first / password / totp_code / account_has_2fakeys, and recording of accepted requests (AdminScript::recorded,RecordedRequest).Invariants: only
fluxer-devserver(and one scenario TOML) changed. Malformed bodies getINVALID_FORMATand never panic. The only credentials are the demo password and code, which are not secrets.Parity spot-checks against the fork (ba98441b4):
reorder_plan/sort_for_ordering/move_blockmatchpackages/schema/.../GuildChannelOrdering.ts(computeGuildChannelReorderPlan, the category span,orderUnchanged) line for line.apply_channel_movematchesapplySinglePositionUpdate: the derived preceding sibling fromposition, voice at the end, text before the first voice,assertCategoryCapacityonly on a parent change, andvalidateChannelVoicePlacement.channel_data/ChannelOperationsService.tsandoverwriteGrantedBits: (after.allow & ~before.allow) | (before.deny & ~after.deny), checked against the channel permissions for every target id, owner exempt. Synced children followpropagatePermissionsToSyncedChildren.verifySudoModematches: totp only with 2FA, the password only without it,INVALID_PASSWORD/INVALID_MFA_CODE.removeMembermatches: the owner or oneself givesUNKNOWN_MEMBER. So doesbanMember(self givesUNKNOWN_MEMBER, a non-member can be banned without the target check).validateTimeoutmatches (an administrator target is refused, a past time clears the timeout), as do theGuildMemberSearchControllerpermission set, thesupplementalmasking and the request and response shapes, andChannelFollowerStatsResponse.Findings
MAX_TIMEOUT_MSis 365 days. The server usesms('1 year'), which is 365.25 days, so a timeout between 365 and 365.25 days is refused here but accepted by the server. This only matters at the edge.reorder_planreturns "unchanged" beforecheck_voice_placementruns. The server validates placement before itsorderUnchangedearly return, so a no-op move over an already invalid layout answers 204 here and 400 there.lock_permissions: truesync checksMANAGE_ROLESin the guild, not in the channel, and skips the server's allow/deny grant checks (syncPermissionsWithParent). The client always sendsfalse(spec §3.8).permission_overwriteswith a duplicate id is kept twice. The server's Map keeps only the last one.sudo.rssays the password and code are "never stored".RecordedRequest.bodydoes keep them, in memory, which Task 22 needs to assert the replay (Review Focus 6). Reword the doc comment. The README's "supplementalisnull" should say "an object with null fields". The code is right in both cases.PATCH …/members/@mewithrolesapplies them, but the server ignores them. A body that mixes voice and moderation fields drops the voice ones. No client sends either.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh worktree at69147a29: all steps passed.Verdict: APPROVED. No blocking findings. The minor ones can be follow-ups or left as they are.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed