Task 22: Settings skeleton and parity list (#22) #59

Manually merged
charles merged 0 commits from task/22-ui-settings-parity into foundation 2026-11-11 18:28:20 +00:00
Owner

Stacked on: task/18-ui-main-layout, task/12-platform-persistence

What this builds

  • cargo xtask extract-parity --fork <path> [--dry-run] [--out <file>] (xtask/src/extract_parity.rs): reads the fork's 21 settings_utils/search_index/*Index.ts files as text (strings, comments and bracket nesting are understood; no regex or TypeScript dependency) and writes docs/parity/settings.toml: one [[setting]] per entry with id, tab, section, label, audience, tags, status = "planned", owner. Labels are the message of the msg() descriptor the entry names, looked up in the index file and then in the @app/… module it is imported from (aliases and {...DESCRIPTOR, values: {…}} included). Re-running merges: existing entries keep place, status, owner and hand-added keys; new ids are appended.
  • cargo xtask parity-check [--fork <path>] [--file <file>] (xtask/src/parity_check.rs): fails on a missing or duplicate id, a missing tab, a status outside done/planned/dropped, an owner outside "1".."7", and, with a fork checkout (--fork or FLUXER_FORK_PATH), on fork ids the list lacks. It is a new step of cargo xtask ci.
  • docs/parity/settings.toml: the 117 extracted settings plus two fork additions the search index does not have (Companion apps: done, owner 1; Kokoro "Natural voice": planned, owner 7).
  • fluxer_core::settings_tabs: TABS (22 tabs in the web app's order), GROUPS, and on SettingsTab: id, from_id, label, group, owner, sections, owner_of. Sections come from the fork's section registry.
  • fluxer_ui::screens::settings: view(&App) = navigation + page. Built panels: Account (username, email, log out), Appearance (theme: dark only), Notifications (desktop notifications on/off, in LocalSettings), Companion apps (switch, ws://127.0.0.1:21863/status?token=… shown masked with a copy button, regenerate). Every other section is placeholder::view(..): "Coming in sub-project N". The shell shows the settings while app.ui.settings is Some; Escape or the close button closes them.

Screenshots of the native client: docs/screenshots/settings-account.png, docs/screenshots/settings-companion-apps.png. There is no Electron side-by-side: it needs a session on the live instance, which this task may not touch. Metrics are from SettingsModalLayout.module.css and SettingsSection.module.css (each constant names its rule).

How it was tested

  • xtask/tests/parity.rs: extract_parity_finds_117_items (against the fork at FLUXER_FORK_PATH; prints that it is skipped when unset), parity_check_fails_on_missing_status, and stand-in-fork tests for label resolution, merge on re-run, --dry-run, unknown status / missing owner / duplicates, and new fork ids.
  • crates/fluxer-ui/tests/settings_nav.rs: settings_tabs_in_web_app_order, companion_apps_regenerate_changes_token, navigation model, placeholders with their owners, the four panels, Debug output without the token, and skeleton_covers_every_tab_and_section_of_the_parity_list (every tab, section and owner of the parity list agrees with settings_tabs).
  • Unit tests in extract_parity.rs, parity_check.rs, settings_tabs.rs, companion_apps.rs; a fluxer-platform test for the new persist operation.
  • By hand under Xvfb (tiny-skia, xdotool): fluxer --devserver, gear → settings, switching tabs, toggling the status API switch.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally, and the parity tests also pass with FLUXER_FORK_PATH set.

Deviations from the plan

  • Outside the task's file list (needed for "regenerate token" to work at all): the store has no randomness, and no merged code handled UserAction::RegenerateStatusToken. Added PersistOp::RegenerateStatusToken and PersistResult::StatusToken(SecretString) in fluxer-core/src/persist.rs (one arm in session.rs), answered by Store::execute in fluxer-platform and by the ephemeral store in apps/fluxer/src/runtime.rs. Any other code that matches these two enums exhaustively needs the new arm. Also touched: fluxer-ui app.rs, message.rs (WindowEvent::Escape), screens/mod.rs; xtask main.rs, Cargo.toml (toml, already a workspace dependency), tests/ci_smoke.rs; four READMEs.
  • Tab labels are the web app's actual messages, not the descriptor names the plan quotes: LOOK_AND_FEEL_DESCRIPTOR is "Appearance" and MESSAGES_AND_MEDIA_DESCRIPTOR is "Chat" in the fork. The desktop tab is "Linux app" / "Windows app" as in getDesktopSettingsTabLabel.
  • The plan lists all 22 tabs in the navigation; the web app hides my_profile, authorized_apps, blocked_users and devices from its primary navigation (they are nested under Account). The plan is followed.
  • SettingsTab already exists as an enum in fluxer_core::event, so TABS is [SettingsTab; 22] and the metadata are methods on it.
  • parity-check compares with the fork only when it has a checkout (CI has none); "would extract-parity --dry-run add ids" is therefore checked locally, not on the runners.
  • owner is per tab by default (voice 2, chat 4, notifications/shortcuts/desktop 6, rest 7); the five screen-share settings were moved to 3 by hand. All 117 are planned: the Foundation panels are basics, not the listed settings.
  • placeholder::view(tab, section, owner) takes the section too.
  • The connection URL carries the token as the plan says (the Electron panel shows URL and token separately).

Follow-up: #58 (nothing starts fluxer-status-api from apps/fluxer yet, so the Companion apps switch only changes the settings file).

Closes #22

🤖 Generated with Claude Code

Stacked on: task/18-ui-main-layout, task/12-platform-persistence ## What this builds - **`cargo xtask extract-parity --fork <path> [--dry-run] [--out <file>]`** (`xtask/src/extract_parity.rs`): reads the fork's 21 `settings_utils/search_index/*Index.ts` files as text (strings, comments and bracket nesting are understood; no regex or TypeScript dependency) and writes `docs/parity/settings.toml`: one `[[setting]]` per entry with `id`, `tab`, `section`, `label`, `audience`, `tags`, `status = "planned"`, `owner`. Labels are the `message` of the `msg()` descriptor the entry names, looked up in the index file and then in the `@app/…` module it is imported from (aliases and `{...DESCRIPTOR, values: {…}}` included). Re-running merges: existing entries keep place, `status`, `owner` and hand-added keys; new ids are appended. - **`cargo xtask parity-check [--fork <path>] [--file <file>]`** (`xtask/src/parity_check.rs`): fails on a missing or duplicate `id`, a missing `tab`, a `status` outside `done`/`planned`/`dropped`, an `owner` outside `"1"`..`"7"`, and, with a fork checkout (`--fork` or `FLUXER_FORK_PATH`), on fork ids the list lacks. It is a new step of `cargo xtask ci`. - **`docs/parity/settings.toml`**: the 117 extracted settings plus two fork additions the search index does not have (Companion apps: `done`, owner 1; Kokoro "Natural voice": `planned`, owner 7). - **`fluxer_core::settings_tabs`**: `TABS` (22 tabs in the web app's order), `GROUPS`, and on `SettingsTab`: `id`, `from_id`, `label`, `group`, `owner`, `sections`, `owner_of`. Sections come from the fork's section registry. - **`fluxer_ui::screens::settings`**: `view(&App)` = navigation + page. Built panels: Account (username, email, log out), Appearance (theme: dark only), Notifications (desktop notifications on/off, in `LocalSettings`), Companion apps (switch, `ws://127.0.0.1:21863/status?token=…` shown masked with a copy button, regenerate). Every other section is `placeholder::view(..)`: "Coming in sub-project N". The shell shows the settings while `app.ui.settings` is `Some`; Escape or the close button closes them. Screenshots of the native client: `docs/screenshots/settings-account.png`, `docs/screenshots/settings-companion-apps.png`. There is no Electron side-by-side: it needs a session on the live instance, which this task may not touch. Metrics are from `SettingsModalLayout.module.css` and `SettingsSection.module.css` (each constant names its rule). ## How it was tested - `xtask/tests/parity.rs`: `extract_parity_finds_117_items` (against the fork at `FLUXER_FORK_PATH`; prints that it is skipped when unset), `parity_check_fails_on_missing_status`, and stand-in-fork tests for label resolution, merge on re-run, `--dry-run`, unknown status / missing owner / duplicates, and new fork ids. - `crates/fluxer-ui/tests/settings_nav.rs`: `settings_tabs_in_web_app_order`, `companion_apps_regenerate_changes_token`, navigation model, placeholders with their owners, the four panels, `Debug` output without the token, and `skeleton_covers_every_tab_and_section_of_the_parity_list` (every tab, section and owner of the parity list agrees with `settings_tabs`). - Unit tests in `extract_parity.rs`, `parity_check.rs`, `settings_tabs.rs`, `companion_apps.rs`; a `fluxer-platform` test for the new persist operation. - By hand under Xvfb (tiny-skia, xdotool): `fluxer --devserver`, gear → settings, switching tabs, toggling the status API switch. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally, and the parity tests also pass with `FLUXER_FORK_PATH` set. ## Deviations from the plan - **Outside the task's file list** (needed for "regenerate token" to work at all): the store has no randomness, and no merged code handled `UserAction::RegenerateStatusToken`. Added `PersistOp::RegenerateStatusToken` and `PersistResult::StatusToken(SecretString)` in `fluxer-core/src/persist.rs` (one arm in `session.rs`), answered by `Store::execute` in `fluxer-platform` and by the ephemeral store in `apps/fluxer/src/runtime.rs`. Any other code that matches these two enums exhaustively needs the new arm. Also touched: `fluxer-ui` `app.rs`, `message.rs` (`WindowEvent::Escape`), `screens/mod.rs`; `xtask` `main.rs`, `Cargo.toml` (`toml`, already a workspace dependency), `tests/ci_smoke.rs`; four READMEs. - **Tab labels** are the web app's actual messages, not the descriptor names the plan quotes: `LOOK_AND_FEEL_DESCRIPTOR` is "Appearance" and `MESSAGES_AND_MEDIA_DESCRIPTOR` is "Chat" in the fork. The desktop tab is "Linux app" / "Windows app" as in `getDesktopSettingsTabLabel`. - The plan lists all 22 tabs in the navigation; the web app hides `my_profile`, `authorized_apps`, `blocked_users` and `devices` from its primary navigation (they are nested under Account). The plan is followed. - `SettingsTab` already exists as an enum in `fluxer_core::event`, so `TABS` is `[SettingsTab; 22]` and the metadata are methods on it. - `parity-check` compares with the fork only when it has a checkout (CI has none); "would `extract-parity --dry-run` add ids" is therefore checked locally, not on the runners. - `owner` is per tab by default (voice 2, chat 4, notifications/shortcuts/desktop 6, rest 7); the five screen-share settings were moved to 3 by hand. All 117 are `planned`: the Foundation panels are basics, not the listed settings. - `placeholder::view(tab, section, owner)` takes the section too. - The connection URL carries the token as the plan says (the Electron panel shows URL and token separately). Follow-up: #58 (nothing starts `fluxer-status-api` from `apps/fluxer` yet, so the Companion apps switch only changes the settings file). Closes #22 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(ui): generated theme tokens, fonts and icons
All checks were successful
ci / Windows (x64) (push) Successful in 22s
ci / Windows (x64) (pull_request) Successful in 15s
ci / Linux (x86_64) (push) Successful in 1m22s
ci / Linux (x86_64) (pull_request) Successful in 1m23s
64430a109d
- xtask gen-theme --fork <path>: parses the Electron app's colour system,
  globals and message-layout CSS into crates/fluxer-ui/src/theme/tokens.rs
  (hsl/hsla/rgb/hex, saturation-factor calc, var() fallbacks, color-mix in
  srgb and oklab; rem to px).
- fluxer-ui::theme: tokens (DARK), palette::Theme with iced's Base and
  widget catalogs, fonts (Fluxer Sans/Mono as TTF) and icons (Phosphor SVGs).
- Adds iced 0.14 to the workspace; deny.toml allows BSL-1.0 and CC0-1.0 and
  ignores three unmaintained-crate advisories that iced pulls in.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge origin/foundation into task/16-ui-theme-fonts-icons
All checks were successful
ci / Windows (x64) (push) Successful in 1m32s
ci / Windows (x64) (pull_request) Successful in 38s
ci / Linux (x86_64) (push) Successful in 1m28s
ci / Linux (x86_64) (pull_request) Successful in 1m34s
897ebaae93
Conflicts in xtask (both sides implemented dispatch stubs: gen-theme here,
vendor-spec/spec-check on foundation) and Cargo.lock resolved as the union.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge origin/foundation into task/16-ui-theme-fonts-icons
All checks were successful
ci / Windows (x64) (push) Successful in 44s
ci / Linux (x86_64) (push) Successful in 1m41s
ci / Windows (x64) (pull_request) Successful in 52s
ci / Linux (x86_64) (pull_request) Successful in 1m31s
301b889ef7
Mechanical conflicts: both sides added workspace dependencies (iced, futures-util)
and Cargo.lock entries.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #8

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): store skeleton and session reducer
All checks were successful
ci / Windows (x64) (push) Successful in 42s
ci / Linux (x86_64) (push) Successful in 1m0s
ci / Windows (x64) (pull_request) Successful in 41s
ci / Linux (x86_64) (pull_request) Successful in 1m5s
cacedcbbf7
Refs #8

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Adds the gateway crate's dependencies (rustls, rustls-native-certs and zstd are
new to the workspace; Task 7 names tokio-tungstenite with rustls and zstd).

Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #11

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): presence, users and ui state
All checks were successful
ci / Windows (x64) (push) Successful in 39s
ci / Windows (x64) (pull_request) Successful in 39s
ci / Linux (x86_64) (push) Successful in 1m7s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
f4ce82e123
Refs #11

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(gateway): websocket transport with zstd streaming
All checks were successful
ci / Windows (x64) (push) Successful in 57s
ci / Windows (x64) (pull_request) Successful in 48s
ci / Linux (x86_64) (push) Successful in 1m3s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
e60021584a
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): guild and channel reducers and sidebar selectors
All checks were successful
ci / Windows (x64) (pull_request) Successful in 45s
ci / Windows (x64) (push) Successful in 43s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
ci / Linux (x86_64) (push) Successful in 1m10s
e753f32ec6
Refs #9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #10

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): messages, typing and read state
All checks were successful
ci / Windows (x64) (push) Successful in 44s
ci / Windows (x64) (pull_request) Successful in 44s
ci / Linux (x86_64) (push) Successful in 1m4s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
38a4f01a14
Refs #10

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #13

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/src/lib.rs
#	crates/fluxer-core/src/selectors/mod.rs
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/src/lib.rs
#	crates/fluxer-core/src/selectors/mod.rs
feat(devserver): fixture-backed API and gateway for tests
All checks were successful
ci / Windows (x64) (pull_request) Successful in 1m11s
ci / Linux (x86_64) (pull_request) Successful in 1m20s
ci / Windows (x64) (push) Successful in 57s
ci / Linux (x86_64) (push) Successful in 1m10s
4c00cf12fd
Refs #13

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(platform,core): settings, keyring token and sqlite cache
Some checks failed
ci / Windows (x64) (push) Failing after 23s
ci / Linux (x86_64) (push) Failing after 56s
ci / Windows (x64) (pull_request) Failing after 13s
ci / Linux (x86_64) (pull_request) Failing after 54s
6eb27db77c
Core: PersistOp/PersistResult/LocalSettings in fluxer_core::persist, the
stored-token login (Loaded -> Discover -> Me -> ConnectGateway), cached READY
data marked App::stale until the live READY, and the CacheReady/CacheMessages/
SaveSettings writes.

Platform: Paths, settings.toml (defaults on missing, .bad on invalid), the
keyring token, the SQLite cache (rebuilt when corrupt or of another schema
version, in memory if the file is unusable) and Store, which ties them to
PersistOp for the runtime.

New dependencies: directories, keyring, rusqlite (bundled), toml, base64,
getrandom, tempfile (dev), keyring-core (dev, mock store).

Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
chore(deps): bump num-bigint 0.4.7 -> 0.4.8 (0.4.7 was yanked)
All checks were successful
ci / Windows (x64) (push) Successful in 1m2s
ci / Linux (x86_64) (push) Successful in 1m20s
ci / Windows (x64) (pull_request) Successful in 51s
ci / Linux (x86_64) (pull_request) Successful in 1m18s
6b043c3a08
cargo deny (yanked = deny) failed on both runners for run 71/72: num-bigint 0.4.7,
a transitive dependency of keyring's Secret Service store, was yanked from crates.io.
Lockfile-only patch bump; no manifest change.

Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	Cargo.lock
# Conflicts:
#	Cargo.lock
#	Cargo.toml
Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ApiClient::with_observer shows each exchange that got a response (no
headers); Connection::connect_with_tap shows each frame received and
sent. Both are off unless asked for.

Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(app): effect runtime, config, logging and record mode
Some checks failed
ci / Windows (x64) (pull_request) Failing after 19s
ci / Windows (x64) (push) Failing after 4s
ci / Linux (x86_64) (pull_request) Successful in 1m37s
ci / Linux (x86_64) (push) Successful in 1m43s
a2ce504001
Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ci(windows): free the build cache when the runner disk is low
All checks were successful
ci / Linux (x86_64) (push) Successful in 1m9s
ci / Windows (x64) (push) Successful in 1m33s
ci / Linux (x86_64) (pull_request) Successful in 1m12s
ci / Windows (x64) (pull_request) Successful in 1m21s
6ada26ce7e
The persistent Windows runner ran out of space on C: (os error 112). Log free
space, remove this project's own target dirs when it drops below 30 GB, and
turn off incremental compilation there. Also correct CLAUDE.md: one target dir
per worktree, and run the screenshot step locally before pushing.

Refs #51

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/ci/51-windows-disk-space' into task/14-app-runtime
All checks were successful
ci / Linux (x86_64) (push) Successful in 1m49s
ci / Windows (x64) (push) Successful in 2m59s
ci / Linux (x86_64) (pull_request) Successful in 1m53s
ci / Windows (x64) (pull_request) Successful in 2m46s
d0f3c10f86
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	deny.toml
feat(ui): iced shell and login screen
All checks were successful
ci / Linux (x86_64) (push) Successful in 2m18s
ci / Windows (x64) (push) Successful in 3m51s
ci / Linux (x86_64) (pull_request) Successful in 2m9s
ci / Windows (x64) (pull_request) Successful in 3m38s
9e1bc0a481
fluxer_ui::run shows the runtime's snapshots in an iced window and sends
what the user does back as CoreEvents; the login screen covers the
instance field, credentials, the TOTP step and one text per AuthError
(captcha included). apps/fluxer launches it in place of the headless loop.

Refs #17

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): main three-pane layout
All checks were successful
ci / Linux (x86_64) (push) Successful in 2m12s
ci / Windows (x64) (push) Successful in 3m50s
ci / Linux (x86_64) (pull_request) Successful in 2m12s
ci / Windows (x64) (pull_request) Successful in 3m12s
f9183ef0ef
screens::main draws the guild rail, the resizable channel sidebar, the
channel header and the member list from main::model(&App), which reads
the store through the core selectors. Its messages map to UserActions.
New widgets: mention badge, tooltip card and resizable split. The shell
shows the main screen once logged in.

Refs #18

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #22

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
extract-parity reads the fork's 21 settings search index files (117
entries) into docs/parity/settings.toml and merges on re-run;
parity-check validates status and owner and is a step of xtask ci.

Refs #22

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #22

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): settings skeleton and settings parity list
All checks were successful
ci / Linux (x86_64) (push) Successful in 2m20s
ci / Windows (x64) (push) Successful in 3m59s
ci / Linux (x86_64) (pull_request) Successful in 2m19s
ci / Windows (x64) (pull_request) Successful in 3m32s
4deffe7c3f
screens::settings draws the web app's settings navigation (22 tabs in
four groups, from fluxer_core::settings_tabs) and the open tab's page:
Account, Appearance, Notifications and Companion apps panels are built,
every other section is a "Coming in sub-project N" placeholder whose
owner matches docs/parity/settings.toml. Regenerating the status API
token goes through PersistOp::RegenerateStatusToken, which the runtime
answers with PersistResult::StatusToken.

Refs #22

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Task 22 (ui-settings-parity), head 4deffe7

Reviewed git diff f9183ef..4deffe7 only.

Checks

  1. Tests named by the plan: all four exist and assert the plan's values. extract_parity_finds_117_items (skips with a clear message without FLUXER_FORK_PATH; with it set to the fork checkout it passes: 117 entries, all planned with owner, then parity-check --fork on the repo list), parity_check_fails_on_missing_status, settings_tabs_in_web_app_order (22 ids in the plan's order, groups 7/2/10/3), companion_apps_regenerate_changes_token (URL ws://127.0.0.1:21863/status?token=… changes after the runtime's answer and is saved).
  2. Interfaces: extract-parity --fork [--dry-run], parity-check, settings_tabs::TABS, settings::view(&App) exist. Fork has 21 *Index.ts files (+ SearchIndexTypes.ts, ignored). Merge keeps statuses/owners and appends new ids (tested).
  3. Invariants: fluxer-core gains no dependency (core-isolation step green); fluxer-ui does no file/network I/O (clipboard goes through an iced task); no unwrap/index on server data in the new views; the status token is masked on screen and redacted in Debug (CompanionAppsModel, Outcome::Copy, SecretString in PersistResult::StatusToken), empty token answers are ignored; no secrets in code, fixtures or settings.toml.
  4. No Review Focus item belongs to this task.
  5. cargo xtask ci in the review worktree: green, also with FLUXER_SCREENSHOT_TESTS=1. Parity step: 119 settings, all accounted for.

Findings

  • minor — xtask/src/parity_check.rs: the Interfaces block says parity-check fails if extract-parity --dry-run would add ids; that comparison only runs with --fork / FLUXER_FORK_PATH, so CI (no fork checkout) checks the list's own completeness only. Documented in the module and README; whoever bumps the fork pin must run it by hand.
  • minor — crates/fluxer-ui/src/screens/settings/placeholder.rs: placeholder::view(tab, section_label, owner) instead of the plan's placeholder::view(tab, owner). Only used inside the settings screen.
  • minor — crates/fluxer-core/src/persist.rs: new variants PersistOp::RegenerateStatusToken and PersistResult::StatusToken(SecretString) are outside the task's Files list. All matches in this branch are updated and CI is green, but any other open branch matching these enums exhaustively needs the arm when merged.
  • minor — crates/fluxer-ui/src/screens/settings/companion_apps.rs: the switch only changes settings.toml; nothing starts fluxer-status-api (follow-up #58 exists, affects acceptance criterion 9).
  • minor — docs/screenshots/: native screenshots only, no Electron side-by-side as CLAUDE.md asks for UI PRs.
  • note (not a finding) — tab labels "Appearance" / "Chat" differ from the plan's "Look and feel" / "Messages and media"; verified against the fork: LOOK_AND_FEEL_DESCRIPTOR.message is 'Appearance' and MESSAGES_AND_MEDIA_DESCRIPTOR.message is 'Chat', so the code matches the web app. On macOS the fork says "macOS app" where the code says "Desktop app" (not a Foundation target).

Verdict: APPROVED — 0 blocking, 5 minor; local ci green.

## Independent review: Task 22 (ui-settings-parity), head 4deffe7 Reviewed `git diff f9183ef..4deffe7` only. **Checks** 1. Tests named by the plan: all four exist and assert the plan's values. `extract_parity_finds_117_items` (skips with a clear message without `FLUXER_FORK_PATH`; with it set to the fork checkout it passes: 117 entries, all `planned` with owner, then `parity-check --fork` on the repo list), `parity_check_fails_on_missing_status`, `settings_tabs_in_web_app_order` (22 ids in the plan's order, groups 7/2/10/3), `companion_apps_regenerate_changes_token` (URL `ws://127.0.0.1:21863/status?token=…` changes after the runtime's answer and is saved). 2. Interfaces: `extract-parity --fork [--dry-run]`, `parity-check`, `settings_tabs::TABS`, `settings::view(&App)` exist. Fork has 21 `*Index.ts` files (+ `SearchIndexTypes.ts`, ignored). Merge keeps statuses/owners and appends new ids (tested). 3. Invariants: `fluxer-core` gains no dependency (core-isolation step green); `fluxer-ui` does no file/network I/O (clipboard goes through an iced task); no `unwrap`/index on server data in the new views; the status token is masked on screen and redacted in `Debug` (`CompanionAppsModel`, `Outcome::Copy`, `SecretString` in `PersistResult::StatusToken`), empty token answers are ignored; no secrets in code, fixtures or `settings.toml`. 4. No Review Focus item belongs to this task. 5. `cargo xtask ci` in the review worktree: **green**, also with `FLUXER_SCREENSHOT_TESTS=1`. Parity step: 119 settings, all accounted for. **Findings** - minor — `xtask/src/parity_check.rs`: the Interfaces block says `parity-check` fails if `extract-parity --dry-run` would add ids; that comparison only runs with `--fork` / `FLUXER_FORK_PATH`, so CI (no fork checkout) checks the list's own completeness only. Documented in the module and README; whoever bumps the fork pin must run it by hand. - minor — `crates/fluxer-ui/src/screens/settings/placeholder.rs`: `placeholder::view(tab, section_label, owner)` instead of the plan's `placeholder::view(tab, owner)`. Only used inside the settings screen. - minor — `crates/fluxer-core/src/persist.rs`: new variants `PersistOp::RegenerateStatusToken` and `PersistResult::StatusToken(SecretString)` are outside the task's Files list. All matches in this branch are updated and CI is green, but any other open branch matching these enums exhaustively needs the arm when merged. - minor — `crates/fluxer-ui/src/screens/settings/companion_apps.rs`: the switch only changes `settings.toml`; nothing starts `fluxer-status-api` (follow-up #58 exists, affects acceptance criterion 9). - minor — `docs/screenshots/`: native screenshots only, no Electron side-by-side as CLAUDE.md asks for UI PRs. - note (not a finding) — tab labels "Appearance" / "Chat" differ from the plan's "Look and feel" / "Messages and media"; verified against the fork: `LOOK_AND_FEEL_DESCRIPTOR.message` is `'Appearance'` and `MESSAGES_AND_MEDIA_DESCRIPTOR.message` is `'Chat'`, so the code matches the web app. On macOS the fork says "macOS app" where the code says "Desktop app" (not a Foundation target). **Verdict: APPROVED** — 0 blocking, 5 minor; local ci green.
charles manually merged commit 24e7c9d137 into foundation 2026-11-11 18:28:20 +00:00
Sign in to join this conversation.
No description provided.