Task 22: Settings skeleton and parity list (#22) #59
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "task/22-ui-settings-parity"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: task/18-ui-main-layout, task/12-platform-persistence
What this builds
cargo xtask extract-parity --fork <path> [--dry-run] [--out <file>](xtask/src/extract_parity.rs): reads the fork's 21settings_utils/search_index/*Index.tsfiles as text (strings, comments and bracket nesting are understood; no regex or TypeScript dependency) and writesdocs/parity/settings.toml: one[[setting]]per entry withid,tab,section,label,audience,tags,status = "planned",owner. Labels are themessageof themsg()descriptor the entry names, looked up in the index file and then in the@app/…module it is imported from (aliases and{...DESCRIPTOR, values: {…}}included). Re-running merges: existing entries keep place,status,ownerand hand-added keys; new ids are appended.cargo xtask parity-check [--fork <path>] [--file <file>](xtask/src/parity_check.rs): fails on a missing or duplicateid, a missingtab, astatusoutsidedone/planned/dropped, anowneroutside"1".."7", and, with a fork checkout (--forkorFLUXER_FORK_PATH), on fork ids the list lacks. It is a new step ofcargo xtask ci.docs/parity/settings.toml: the 117 extracted settings plus two fork additions the search index does not have (Companion apps:done, owner 1; Kokoro "Natural voice":planned, owner 7).fluxer_core::settings_tabs:TABS(22 tabs in the web app's order),GROUPS, and onSettingsTab:id,from_id,label,group,owner,sections,owner_of. Sections come from the fork's section registry.fluxer_ui::screens::settings:view(&App)= navigation + page. Built panels: Account (username, email, log out), Appearance (theme: dark only), Notifications (desktop notifications on/off, inLocalSettings), Companion apps (switch,ws://127.0.0.1:21863/status?token=…shown masked with a copy button, regenerate). Every other section isplaceholder::view(..): "Coming in sub-project N". The shell shows the settings whileapp.ui.settingsisSome; Escape or the close button closes them.Screenshots of the native client:
docs/screenshots/settings-account.png,docs/screenshots/settings-companion-apps.png. There is no Electron side-by-side: it needs a session on the live instance, which this task may not touch. Metrics are fromSettingsModalLayout.module.cssandSettingsSection.module.css(each constant names its rule).How it was tested
xtask/tests/parity.rs:extract_parity_finds_117_items(against the fork atFLUXER_FORK_PATH; prints that it is skipped when unset),parity_check_fails_on_missing_status, and stand-in-fork tests for label resolution, merge on re-run,--dry-run, unknown status / missing owner / duplicates, and new fork ids.crates/fluxer-ui/tests/settings_nav.rs:settings_tabs_in_web_app_order,companion_apps_regenerate_changes_token, navigation model, placeholders with their owners, the four panels,Debugoutput without the token, andskeleton_covers_every_tab_and_section_of_the_parity_list(every tab, section and owner of the parity list agrees withsettings_tabs).extract_parity.rs,parity_check.rs,settings_tabs.rs,companion_apps.rs; afluxer-platformtest for the new persist operation.fluxer --devserver, gear → settings, switching tabs, toggling the status API switch.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally, and the parity tests also pass withFLUXER_FORK_PATHset.Deviations from the plan
UserAction::RegenerateStatusToken. AddedPersistOp::RegenerateStatusTokenandPersistResult::StatusToken(SecretString)influxer-core/src/persist.rs(one arm insession.rs), answered byStore::executeinfluxer-platformand by the ephemeral store inapps/fluxer/src/runtime.rs. Any other code that matches these two enums exhaustively needs the new arm. Also touched:fluxer-uiapp.rs,message.rs(WindowEvent::Escape),screens/mod.rs;xtaskmain.rs,Cargo.toml(toml, already a workspace dependency),tests/ci_smoke.rs; four READMEs.LOOK_AND_FEEL_DESCRIPTORis "Appearance" andMESSAGES_AND_MEDIA_DESCRIPTORis "Chat" in the fork. The desktop tab is "Linux app" / "Windows app" as ingetDesktopSettingsTabLabel.my_profile,authorized_apps,blocked_usersanddevicesfrom its primary navigation (they are nested under Account). The plan is followed.SettingsTabalready exists as an enum influxer_core::event, soTABSis[SettingsTab; 22]and the metadata are methods on it.parity-checkcompares with the fork only when it has a checkout (CI has none); "wouldextract-parity --dry-runadd ids" is therefore checked locally, not on the runners.owneris per tab by default (voice 2, chat 4, notifications/shortcuts/desktop 6, rest 7); the five screen-share settings were moved to 3 by hand. All 117 areplanned: the Foundation panels are basics, not the listed settings.placeholder::view(tab, section, owner)takes the section too.Follow-up: #58 (nothing starts
fluxer-status-apifromapps/fluxeryet, so the Companion apps switch only changes the settings file).Closes #22
🤖 Generated with Claude Code
Independent review: Task 22 (ui-settings-parity), head
4deffe7Reviewed
git diff f9183ef..4deffe7only.Checks
extract_parity_finds_117_items(skips with a clear message withoutFLUXER_FORK_PATH; with it set to the fork checkout it passes: 117 entries, allplannedwith owner, thenparity-check --forkon the repo list),parity_check_fails_on_missing_status,settings_tabs_in_web_app_order(22 ids in the plan's order, groups 7/2/10/3),companion_apps_regenerate_changes_token(URLws://127.0.0.1:21863/status?token=…changes after the runtime's answer and is saved).extract-parity --fork [--dry-run],parity-check,settings_tabs::TABS,settings::view(&App)exist. Fork has 21*Index.tsfiles (+SearchIndexTypes.ts, ignored). Merge keeps statuses/owners and appends new ids (tested).fluxer-coregains no dependency (core-isolation step green);fluxer-uidoes no file/network I/O (clipboard goes through an iced task); nounwrap/index on server data in the new views; the status token is masked on screen and redacted inDebug(CompanionAppsModel,Outcome::Copy,SecretStringinPersistResult::StatusToken), empty token answers are ignored; no secrets in code, fixtures orsettings.toml.cargo xtask ciin the review worktree: green, also withFLUXER_SCREENSHOT_TESTS=1. Parity step: 119 settings, all accounted for.Findings
xtask/src/parity_check.rs: the Interfaces block saysparity-checkfails ifextract-parity --dry-runwould add ids; that comparison only runs with--fork/FLUXER_FORK_PATH, so CI (no fork checkout) checks the list's own completeness only. Documented in the module and README; whoever bumps the fork pin must run it by hand.crates/fluxer-ui/src/screens/settings/placeholder.rs:placeholder::view(tab, section_label, owner)instead of the plan'splaceholder::view(tab, owner). Only used inside the settings screen.crates/fluxer-core/src/persist.rs: new variantsPersistOp::RegenerateStatusTokenandPersistResult::StatusToken(SecretString)are outside the task's Files list. All matches in this branch are updated and CI is green, but any other open branch matching these enums exhaustively needs the arm when merged.crates/fluxer-ui/src/screens/settings/companion_apps.rs: the switch only changessettings.toml; nothing startsfluxer-status-api(follow-up #58 exists, affects acceptance criterion 9).docs/screenshots/: native screenshots only, no Electron side-by-side as CLAUDE.md asks for UI PRs.LOOK_AND_FEEL_DESCRIPTOR.messageis'Appearance'andMESSAGES_AND_MEDIA_DESCRIPTOR.messageis'Chat', so the code matches the web app. On macOS the fork says "macOS app" where the code says "Desktop app" (not a Foundation target).Verdict: APPROVED — 0 blocking, 5 minor; local ci green.