Daily use 22b: fluxer-core composer barriers, typing, draft race, blocked-message groups (#509) #582

Closed
charles wants to merge 0 commits from dailyuse-22b-core-composer-barriers-blocked into dailyuse
Owner

Daily use 22b, fluxer-core only: the composer's barriers, the typing rules, the draft echo race and the blocked-message groups (spec §3.9, §6.2 "Blocked messages", §12). The UI half is Daily use 37b.

Stacked on: origin/dailyuse-15-core-friends-blocking, origin/dailyuse-18-core-user-dm-menus, origin/dailyuse-20-core-keyboard-navigation

What was built

  • selectors::composer::composer_barrier(&App, channel) -> Option<Barrier>. The checks run in the original's order (DMChannelView.tsx:476-495, GuildChannelView.tsx:362-445, VerificationBarrier.tsx, ThreadComposerArea.tsx, ChannelTextarea.tsx):
    • DM: SystemDm (the recipient is FLUXERBOT_ID = 0), then BlockedUser { user_id, username }, whose "Unblock" unblocks at once like unblockUser.
    • Guild: TimedOut { until, remaining_ms } with an M:SS countdown, then ThreadLocked for a non-moderator, then without SEND_MESSAGES either AnnouncementFollow ("Follow" → OpenFollowChannel) or NoPermission. NoPermission keeps the composer but disables it, with the placeholder "You can't send messages in this channel.".
    • Strings are copied from BarrierComponents.tsx, CommonMessageDescriptors.ts:197 and ThreadMessageDescriptors.ts:133.
  • composer_context(&App, channel) -> ComposerContext: the UI builds ComposerOptions from it in 37b. It has the placeholder (a forum post's Send a message in "{name}", otherwise the disabled placeholder), send_on_enter, slash_commands, typing, thread, forum_post, editing and disabled.
  • typing::composer_typing(previous, value, editing, enabled) -> TypingDecision follows RollingComposerTypingGate.ts. Nothing is announced while editing, while the composer is disabled, for an unchanged text, for +/+:emoji:, for /… or for s/a/b. Emptying the text stops the announcement. Both the composer and the Foundation DraftChanged path use it.
  • Draft echo race (#400 finding 1, core side): after a send, a ComposerEdited with the text just sent but a different cursor is a stale echo. It does not bring the draft back and does not announce typing. On the Foundation path, a DraftChanged with the sent text is treated the same way. The guard ends at any other text or at a channel switch.
  • selectors::message_list(&App, channel) -> Vec<MessageListItem>. It is timeline with consecutive blocked user messages (plain or replies) collapsed into MessageListItem::BlockedGroup { first_id, count, revealed }, following MessageGroupingUtils.ts:97-260:
    • A day separator or anyone else's message ends a group.
    • The message after a group starts a new message group.
    • Only one group per channel is open at a time (ui.revealed_blocked).
    • blocked_group_label gives "1 blocked message" / "{n} blocked messages".
    • When the first unread message is inside a group, the unread divider goes before the group's row, or inside the open group (as the original's hasUnread / leadingUnreadDivider).

Deviations

  • New action UserAction::RevealBlockedGroup { channel_id, message_id: Option<Snowflake> }, the original's revealMessage(channelId, messageId|null). The plan names no action for the click, so this is a one-variant addition to event.rs.
  • The plan's MessageListItem is a new enum returned by the new message_list. timeline/TimelineItem are unchanged, so fluxer-ui still compiles; 37b moves the message list over to message_list.
  • A jump to a message opens the group that holds it (plan test jump_target_inside_group_opens_it). The original does not do this. A side effect: jumping elsewhere closes the channel's open group.
  • The echo guard only catches the exact sent text with a different cursor (a cursor move before the cleared snapshot arrives). The issue's other case is a stale snapshot overwriting the box and then being typed on ("helx"). The store cannot tell that apart from new typing, so the fix belongs in the UI (Mirror::sync: keep sent across expect_change, as the issue suggests) in 37b. #400 is also covered by 37b, so this PR says Refs.
  • Not built because the client has no data for them: the account/member-age gates, the limited account, and "Messaging is temporarily paused in this community." (disabled_operations).

Testing

  • New: tests/composer_barriers.rs (barrier_table, countdown_is_minutes_and_seconds_rounded_up, composer_context_per_kind, typing_decision_as_the_original, no_typing_while_editing_or_commands, stale_draft_echo_ignored).
  • New: tests/blocked_messages.rs (consecutive_blocked_messages_group_and_count, group_breaks_on_other_author_and_day_divider, reveal_toggles_group, jump_target_inside_group_opens_it, unread_divider_opens_the_group).
  • I saw them fail (they did not compile) before the implementation and pass after it.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally. No desktop tests apply. No new fixtures: the tests build relationships as RelationshipResponse (S/user/UserResponseSchemas.ts:492).

Refs #400

Closes #509

🤖 Generated with Claude Code

Daily use 22b, `fluxer-core` only: the composer's barriers, the typing rules, the draft echo race and the blocked-message groups (spec §3.9, §6.2 "Blocked messages", §12). The UI half is Daily use 37b. Stacked on: origin/dailyuse-15-core-friends-blocking, origin/dailyuse-18-core-user-dm-menus, origin/dailyuse-20-core-keyboard-navigation ## What was built - `selectors::composer::composer_barrier(&App, channel) -> Option<Barrier>`. The checks run in the original's order (`DMChannelView.tsx:476-495`, `GuildChannelView.tsx:362-445`, `VerificationBarrier.tsx`, `ThreadComposerArea.tsx`, `ChannelTextarea.tsx`): - DM: `SystemDm` (the recipient is `FLUXERBOT_ID` = 0), then `BlockedUser { user_id, username }`, whose "Unblock" unblocks at once like `unblockUser`. - Guild: `TimedOut { until, remaining_ms }` with an `M:SS` countdown, then `ThreadLocked` for a non-moderator, then without SEND_MESSAGES either `AnnouncementFollow` ("Follow" → `OpenFollowChannel`) or `NoPermission`. `NoPermission` keeps the composer but disables it, with the placeholder "You can't send messages in this channel.". - Strings are copied from `BarrierComponents.tsx`, `CommonMessageDescriptors.ts:197` and `ThreadMessageDescriptors.ts:133`. - `composer_context(&App, channel) -> ComposerContext`: the UI builds `ComposerOptions` from it in 37b. It has the placeholder (a forum post's `Send a message in "{name}"`, otherwise the disabled placeholder), `send_on_enter`, `slash_commands`, `typing`, `thread`, `forum_post`, `editing` and `disabled`. - `typing::composer_typing(previous, value, editing, enabled) -> TypingDecision` follows `RollingComposerTypingGate.ts`. Nothing is announced while editing, while the composer is disabled, for an unchanged text, for `+`/`+:emoji:`, for `/…` or for `s/a/b`. Emptying the text stops the announcement. Both the composer and the Foundation `DraftChanged` path use it. - Draft echo race (#400 finding 1, core side): after a send, a `ComposerEdited` with the text just sent but a different cursor is a stale echo. It does not bring the draft back and does not announce typing. On the Foundation path, a `DraftChanged` with the sent text is treated the same way. The guard ends at any other text or at a channel switch. - `selectors::message_list(&App, channel) -> Vec<MessageListItem>`. It is `timeline` with consecutive blocked user messages (plain or replies) collapsed into `MessageListItem::BlockedGroup { first_id, count, revealed }`, following `MessageGroupingUtils.ts:97-260`: - A day separator or anyone else's message ends a group. - The message after a group starts a new message group. - Only one group per channel is open at a time (`ui.revealed_blocked`). - `blocked_group_label` gives "1 blocked message" / "{n} blocked messages". - When the first unread message is inside a group, the unread divider goes before the group's row, or inside the open group (as the original's `hasUnread` / `leadingUnreadDivider`). ## Deviations - New action `UserAction::RevealBlockedGroup { channel_id, message_id: Option<Snowflake> }`, the original's `revealMessage(channelId, messageId|null)`. The plan names no action for the click, so this is a one-variant addition to `event.rs`. - The plan's `MessageListItem` is a new enum returned by the new `message_list`. `timeline`/`TimelineItem` are unchanged, so `fluxer-ui` still compiles; 37b moves the message list over to `message_list`. - A jump to a message opens the group that holds it (plan test `jump_target_inside_group_opens_it`). The original does not do this. A side effect: jumping elsewhere closes the channel's open group. - The echo guard only catches the exact sent text with a different cursor (a cursor move before the cleared snapshot arrives). The issue's other case is a stale snapshot overwriting the box and then being typed on ("helx"). The store cannot tell that apart from new typing, so the fix belongs in the UI (`Mirror::sync`: keep `sent` across `expect_change`, as the issue suggests) in 37b. #400 is also covered by 37b, so this PR says Refs. - Not built because the client has no data for them: the account/member-age gates, the limited account, and "Messaging is temporarily paused in this community." (`disabled_operations`). ## Testing - New: `tests/composer_barriers.rs` (`barrier_table`, `countdown_is_minutes_and_seconds_rounded_up`, `composer_context_per_kind`, `typing_decision_as_the_original`, `no_typing_while_editing_or_commands`, `stale_draft_echo_ignored`). - New: `tests/blocked_messages.rs` (`consecutive_blocked_messages_group_and_count`, `group_breaks_on_other_author_and_day_divider`, `reveal_toggles_group`, `jump_target_inside_group_opens_it`, `unread_divider_opens_the_group`). - I saw them fail (they did not compile) before the implementation and pass after it. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally. No desktop tests apply. No new fixtures: the tests build relationships as `RelationshipResponse` (`S/user/UserResponseSchemas.ts:492`). Refs #400 Closes #509 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings from READY, USER_GUILD_SETTINGS_UPDATE and the patch answers;
immediate menu mutes (guild scalars, whole channel_overrides map for
channels, categories and DMs in @me), mute_config in ms, local expiry
timers, 3 s debounced modal changes, revert on failure, selectors
is_muted / muted_until / level / guild_settings_modal, and the shared
mute menu row (MuteTargetMenuItem.tsx, MuteOptions.ts,
UserGuildSettings.ts, UserGuildSettingsCommands.ts).

Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
format_date_time shifted the end with to_offset, which panics when the
local date leaves year 9999 (a 9999-12-31T23:30Z end read east of UTC).
It now uses checked_to_offset and falls back to UTC. The
event_replaces_guild_settings test now checks the staff override is
really gone instead of an always-true assertion.

Refs #497

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Uses the existing server-shaped fixtures: rest/invite_metadata.json
(POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the
metadata fields), rest/guild.json (POST /guilds, GuildResponse) and
gateway/guild_create.json.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The invite modal (default invite at open, settings clamped to the
server's limits, link, expiry text, friends and group DMs with
Invite -> Sent through SendMessage), can_invite / invite_channel for the
menus, "Create or join a community" (name, static icon, create then
select the system channel once its GUILD_CREATE is in, join through the
accept flow), and "Leave community" (Confirm::LeaveGuild, no Shift
bypass, no delete_messages; hidden for the owner; on success the guild
goes as its GUILD_DELETE would, so a selected one leaves for the DMs).

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dailyuse_ports listed them among the stubs that do nothing.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Table tests for the notification decision (Notification.ts:187-256) and
tests for mute consumers: unread, guild pill, hide muted channels, DM
mentions. Stubs for SidebarSection.{category_muted,muted} and
notif_settings::hides_muted_channels so the tests compile.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notif_settings::mentions_me as MessageUtils.isMentioned and
  Notification.isMessageMentionLike: blocked author no, user mention,
  @everyone unless suppressed or in an unjoined thread, own role unless
  suppressed, unmuted DM.
- notification_for follows Notification.ts:187-256: own, blocked, DND,
  SUPPRESS_NOTIFICATIONS, then thread levels (member level, parent level,
  forum new-post level, else only mentions) or mute at any level and the
  effective level.
- read_state::unread is false for a muted channel (mention counts kept);
  has_unread_messages keeps the raw answer for the new-messages bar and
  the thread menu's Mark as read.
- channel_tree: category_muted and muted rows; hide muted channels per
  guild (default_hide_muted_channels without an entry), unless selected,
  connected or with a mention; all-hidden categories hidden.
- DmRowModel.muted from the @me override; a thread is muted by its
  membership or its parent at any level.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Own presence from the user settings; SetStatus / SetCustomStatus write only
their fields (optimistic, reverted on failure); reset timer; idle and afk
from CoreEvent::Idle; op 3 whenever the computed presence changes; status
popout, custom status modal and custom status selectors.

Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #505

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The switcher of spec §3.7: default sections from the recent visits, mentions and
unread channels; prefixes @ @@ # ! *; the original's scoring
(SearchTextMatching.ts:41-47, ForwardDestinationSearch.ts) and listing scores
(QuickSwitcherResultGenerators.ts:84-90,410-416); wraparound; links first.
Every change of the selected channel is recorded as a visit and persisted in
[navigation] (SelectedChannel.ts recentlyVisitedChannels).

Refs #505

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
menus::{channel, category, guild} build the original's desktop menus
(AM/ChannelContextMenu.tsx, ChannelMenuData.tsx:429-632,
CategoryMenuData.tsx:263-339, GuildMenuData.tsx:314-497) with the "B"
rows of spec 3.2 (a)-(d). MarkCategoryRead and MarkGuildRead ack in
bulk through POST /read-states/ack; CopyId, CopyChannelLink and the
link channel's "Copy link" write the clipboard. Collapsed categories
are synced as the category override's `collapsed`
(UserGuildSettingsCommands.ts:198-246), written debounced 3 s with the
whole override map; "Hide muted channels" likewise. The sidebar reads
notif_settings::is_collapsed and emits UserAction::ToggleCategory
instead of keeping a local set.

New UserAction variants: CopyLinkChannelUrl, OpenNotificationSettings,
OpenFollowChannel (the last two open UI-owned modals).

Refs #503

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A failed reset PATCH was re-sent at once by the same refresh, with no
limit (a request storm while offline or on 4xx/429). Remember the reset
whose write failed and skip it until READY, USER_SETTINGS_UPDATE or a
patch answer brings new settings, as StatusExpiry.handleExpiry does not
retry. The custom status test now asserts the profile popout exists.

Refs #499

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Selecting the channel already open (listed in a search) left heading_to set,
because follow_selection returned on an unchanged selection before clearing
it; every later visit was then dropped, in memory and in [navigation].
heading_to is now cleared whenever the target is the selected channel.

Refs #505

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Relationship fixtures are shaped like RelationshipResponse
(packages/schema/src/domains/user/UserResponseSchemas.ts:492 of the
fork): id, type, user, nickname (nullable, always sent),
share_voice_activity, friend_shares_voice_activity.

Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/tests/dailyuse_ports.rs
The navigation keybinds of spec §3.7 as core actions (NavAction): guild
slots and cycle, channel/DM/unread/mention walks, back/forward history,
Escape and Shift+Escape, copy channel link, group DM, add guild, current
call, top inbox channel and oldest unread message. The last channel per
guild is loaded from and written to [navigation] selected_channels.

Refs #506

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
menus::user and menus::dm with the rows of GuildMemberContextMenu,
UserContextMenu, DMContextMenu and GroupDMContextMenu that this client
builds; Mention into the composer; Pin DM; Close DM and Open DM (blocked)
confirms; Invite to community; Report message in the message menu.

Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/tests/dailyuse_ports.rs
Fixture shapes: relationships as RelationshipResponse
(fluxer_api S/user/UserResponseSchemas.ts:492), channels and threads as
ChannelResponse; no new fixture file.

Refs #509

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- selectors::composer::composer_barrier: system DM, blocked DM (Unblock),
  timeout (M:SS countdown), locked thread, announcement Follow, no
  SEND_MESSAGES (disabled, "You can't send messages in this channel."),
  in the order of DMChannelView.tsx / GuildChannelView.tsx.
- composer_context: what the UI's ComposerOptions are built from.
- typing::composer_typing, the original's decideComposerTyping (no typing
  while editing, disabled, for +:emoji:, /..., s/a/b; empty text stops),
  used by the composer and the Foundation DraftChanged path.
- Draft echo race (#400): after a send, the sent text told again with
  another cursor (or a DraftChanged with it) is ignored.
- selectors::message_list: consecutive messages from blocked users
  collapse into MessageListItem::BlockedGroup { first_id, count, revealed },
  revealed by UserAction::RevealBlockedGroup or a jump into the group.

Refs #509
Refs #400

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Review: Daily use 22b (independent, read cold), diff 2d1164f..613cf0c

Tests named by the plan. All seven exist (barrier_table, no_typing_while_editing_or_commands, stale_draft_echo_ignored, consecutive_blocked_messages_group_and_count, group_breaks_on_other_author_and_day_divider, reveal_toggles_group, jump_target_inside_group_opens_it), plus four extra. They assert the spec's exact strings: blocked DM, system DM, timeout, the disabled placeholder "You can't send messages in this channel.", Follow, locked thread, "{n} blocked message(s)".

Interfaces. composer_barrier(&App, Snowflake) -> Option<Barrier> and MessageListItem::BlockedGroup { first_id, count, revealed } match the plan. ComposerContext carries thread, forum post and edit for 37b. timeline/TimelineItem are unchanged, so fluxer-ui compiles. The new UserAction::RevealBlockedGroup is a reasonable one-variant addition (the original's revealMessage).

Invariants. Only fluxer-core changes. No I/O, no banned imports, no fixtures, no secrets. Server data cannot panic it: the timeout uses saturating arithmetic and try_from.

Parity spot-checks against the fork (all match):

  • FLUXERBOT_ID = '0' and isSystemDmChannel = DM type with that recipient.
  • DM order: system DM, then blocked user (DMChannelView.tsx:476-485, getNickname).
  • Guild order: verification/timeout (GuildVerification.ts:133-141), then ThreadComposerArea locked check, then announcement-without-SEND_MESSAGES Follow inside renderComposer (GuildChannelView.tsx:362-372,618).
  • unblockUser runs with no confirm.
  • CountdownTimer uses Math.ceil and M:SS.
  • decideComposerTyping ported line for line (RollingComposerTypingGate.ts:15-37).
  • ChannelTextarea disables on SEND_MESSAGES only (not the threads permission).
  • Blocked grouping: isUserMessage + blocked; a day divider or another type ends the group; the message after a group starts a new group (MessageGroupingUtils.ts:170-230); the plural descriptor is BlockedMessageGroups.tsx:28-32.

Review Focus. No numbered item is this task's own. Item 5 (unblock confirms) is per surface: the barrier's Unblock acts at once, as the original does.

CI. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: all steps passed, exit 0.

Findings

  1. minor, chat/composer.rs on_edited echo guard: the guard keys on the cursor at send time. If a message is sent with the caret mid-text (for example "hello" sent with the cursor at 2) and the same text is then pasted into the emptied box (cursor 5), the paste is taken for an echo. The store keeps "" while the box shows "hello", until the next keystroke. This is rare and recovers on the next edit. It could be documented, or the UI-side Mirror::sync fix in 37b could make the core guard unnecessary.
  2. minor, ui.rs / typing.rs SendEcho (Foundation DraftChanged path): any DraftChanged equal to the text just sent is ignored, so re-pasting the same text right after a send is dropped on that path. The UI no longer emits DraftChanged (only apps/fluxer/tests/runtime.rs does), so this has no user impact today.
  3. minor (follow-up): "Messaging is temporarily paused in this community." is not built because fluxer-proto's Guild has no disabled_operations (the fork reads it in Guild.ts:250; GuildVerification.ts:143 checks SEND_MESSAGE). It needs a proto task. Suggest a follow-up issue so it is not lost with #400.
  4. minor: a jump opens the group it lands in, which the original does not do (the plan asks for it, and the PR states it). A side effect is that any jump closes a group the user opened. This is acceptable as specified.

Verdict: approve. No blocking findings, CI green locally.

## Review: Daily use 22b (independent, read cold), diff 2d1164f..613cf0c **Tests named by the plan.** All seven exist (`barrier_table`, `no_typing_while_editing_or_commands`, `stale_draft_echo_ignored`, `consecutive_blocked_messages_group_and_count`, `group_breaks_on_other_author_and_day_divider`, `reveal_toggles_group`, `jump_target_inside_group_opens_it`), plus four extra. They assert the spec's exact strings: blocked DM, system DM, timeout, the disabled placeholder "You can't send messages in this channel.", Follow, locked thread, "{n} blocked message(s)". **Interfaces.** `composer_barrier(&App, Snowflake) -> Option<Barrier>` and `MessageListItem::BlockedGroup { first_id, count, revealed }` match the plan. `ComposerContext` carries thread, forum post and edit for 37b. `timeline`/`TimelineItem` are unchanged, so fluxer-ui compiles. The new `UserAction::RevealBlockedGroup` is a reasonable one-variant addition (the original's `revealMessage`). **Invariants.** Only fluxer-core changes. No I/O, no banned imports, no fixtures, no secrets. Server data cannot panic it: the timeout uses saturating arithmetic and `try_from`. **Parity spot-checks against the fork (all match):** - `FLUXERBOT_ID = '0'` and `isSystemDmChannel` = DM type with that recipient. - DM order: system DM, then blocked user (`DMChannelView.tsx:476-485`, `getNickname`). - Guild order: verification/timeout (`GuildVerification.ts:133-141`), then `ThreadComposerArea` locked check, then announcement-without-SEND_MESSAGES Follow inside `renderComposer` (`GuildChannelView.tsx:362-372,618`). - `unblockUser` runs with no confirm. - `CountdownTimer` uses `Math.ceil` and M:SS. - `decideComposerTyping` ported line for line (`RollingComposerTypingGate.ts:15-37`). - `ChannelTextarea` disables on SEND_MESSAGES only (not the threads permission). - Blocked grouping: `isUserMessage` + blocked; a day divider or another type ends the group; the message after a group starts a new group (`MessageGroupingUtils.ts:170-230`); the plural descriptor is `BlockedMessageGroups.tsx:28-32`. **Review Focus.** No numbered item is this task's own. Item 5 (unblock confirms) is per surface: the barrier's Unblock acts at once, as the original does. **CI.** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: all steps passed, exit 0. ### Findings 1. **minor**, `chat/composer.rs` `on_edited` echo guard: the guard keys on the cursor at send time. If a message is sent with the caret mid-text (for example "hello" sent with the cursor at 2) and the same text is then pasted into the emptied box (cursor 5), the paste is taken for an echo. The store keeps "" while the box shows "hello", until the next keystroke. This is rare and recovers on the next edit. It could be documented, or the UI-side `Mirror::sync` fix in 37b could make the core guard unnecessary. 2. **minor**, `ui.rs` / `typing.rs` `SendEcho` (Foundation `DraftChanged` path): any `DraftChanged` equal to the text just sent is ignored, so re-pasting the same text right after a send is dropped on that path. The UI no longer emits `DraftChanged` (only `apps/fluxer/tests/runtime.rs` does), so this has no user impact today. 3. **minor (follow-up)**: "Messaging is temporarily paused in this community." is not built because `fluxer-proto`'s `Guild` has no `disabled_operations` (the fork reads it in `Guild.ts:250`; `GuildVerification.ts:143` checks `SEND_MESSAGE`). It needs a proto task. Suggest a `follow-up` issue so it is not lost with #400. 4. **minor**: a jump opens the group it lands in, which the original does not do (the plan asks for it, and the PR states it). A side effect is that any jump closes a group the user opened. This is acceptable as specified. **Verdict: approve.** No blocking findings, CI green locally.
Author
Owner

Merged into dailyuse at f7972c3 (combined merge of 23 Daily use tasks plus textchat).

Merged into `dailyuse` at f7972c3 (combined merge of 23 Daily use tasks plus `textchat`).
charles closed this pull request 2026-11-15 06:08:33 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.