Daily use 22b: fluxer-core composer barriers, typing, draft race, blocked-message groups (#509) #582
Closed
charles
wants to merge 0 commits from
dailyuse-22b-core-composer-barriers-blocked into dailyuse
pull from: dailyuse-22b-core-composer-barriers-blocked
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!582
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-22b-core-composer-barriers-blocked"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Daily use 22b,
fluxer-coreonly: the composer's barriers, the typing rules, the draft echo race and the blocked-message groups (spec §3.9, §6.2 "Blocked messages", §12). The UI half is Daily use 37b.Stacked on: origin/dailyuse-15-core-friends-blocking, origin/dailyuse-18-core-user-dm-menus, origin/dailyuse-20-core-keyboard-navigation
What was built
selectors::composer::composer_barrier(&App, channel) -> Option<Barrier>. The checks run in the original's order (DMChannelView.tsx:476-495,GuildChannelView.tsx:362-445,VerificationBarrier.tsx,ThreadComposerArea.tsx,ChannelTextarea.tsx):SystemDm(the recipient isFLUXERBOT_ID= 0), thenBlockedUser { user_id, username }, whose "Unblock" unblocks at once likeunblockUser.TimedOut { until, remaining_ms }with anM:SScountdown, thenThreadLockedfor a non-moderator, then without SEND_MESSAGES eitherAnnouncementFollow("Follow" →OpenFollowChannel) orNoPermission.NoPermissionkeeps the composer but disables it, with the placeholder "You can't send messages in this channel.".BarrierComponents.tsx,CommonMessageDescriptors.ts:197andThreadMessageDescriptors.ts:133.composer_context(&App, channel) -> ComposerContext: the UI buildsComposerOptionsfrom it in 37b. It has the placeholder (a forum post'sSend a message in "{name}", otherwise the disabled placeholder),send_on_enter,slash_commands,typing,thread,forum_post,editinganddisabled.typing::composer_typing(previous, value, editing, enabled) -> TypingDecisionfollowsRollingComposerTypingGate.ts. Nothing is announced while editing, while the composer is disabled, for an unchanged text, for+/+:emoji:, for/…or fors/a/b. Emptying the text stops the announcement. Both the composer and the FoundationDraftChangedpath use it.ComposerEditedwith the text just sent but a different cursor is a stale echo. It does not bring the draft back and does not announce typing. On the Foundation path, aDraftChangedwith the sent text is treated the same way. The guard ends at any other text or at a channel switch.selectors::message_list(&App, channel) -> Vec<MessageListItem>. It istimelinewith consecutive blocked user messages (plain or replies) collapsed intoMessageListItem::BlockedGroup { first_id, count, revealed }, followingMessageGroupingUtils.ts:97-260:ui.revealed_blocked).blocked_group_labelgives "1 blocked message" / "{n} blocked messages".hasUnread/leadingUnreadDivider).Deviations
UserAction::RevealBlockedGroup { channel_id, message_id: Option<Snowflake> }, the original'srevealMessage(channelId, messageId|null). The plan names no action for the click, so this is a one-variant addition toevent.rs.MessageListItemis a new enum returned by the newmessage_list.timeline/TimelineItemare unchanged, sofluxer-uistill compiles; 37b moves the message list over tomessage_list.jump_target_inside_group_opens_it). The original does not do this. A side effect: jumping elsewhere closes the channel's open group.Mirror::sync: keepsentacrossexpect_change, as the issue suggests) in 37b. #400 is also covered by 37b, so this PR says Refs.disabled_operations).Testing
tests/composer_barriers.rs(barrier_table,countdown_is_minutes_and_seconds_rounded_up,composer_context_per_kind,typing_decision_as_the_original,no_typing_while_editing_or_commands,stale_draft_echo_ignored).tests/blocked_messages.rs(consecutive_blocked_messages_group_and_count,group_breaks_on_other_author_and_day_divider,reveal_toggles_group,jump_target_inside_group_opens_it,unread_divider_opens_the_group).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally. No desktop tests apply. No new fixtures: the tests build relationships asRelationshipResponse(S/user/UserResponseSchemas.ts:492).Refs #400
Closes #509
🤖 Generated with Claude Code
Uses the existing server-shaped fixtures: rest/invite_metadata.json (POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the metadata fields), rest/guild.json (POST /guilds, GuildResponse) and gateway/guild_create.json. Refs #502 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>menus::{channel, category, guild} build the original's desktop menus (AM/ChannelContextMenu.tsx, ChannelMenuData.tsx:429-632, CategoryMenuData.tsx:263-339, GuildMenuData.tsx:314-497) with the "B" rows of spec 3.2 (a)-(d). MarkCategoryRead and MarkGuildRead ack in bulk through POST /read-states/ack; CopyId, CopyChannelLink and the link channel's "Copy link" write the clipboard. Collapsed categories are synced as the category override's `collapsed` (UserGuildSettingsCommands.ts:198-246), written debounced 3 s with the whole override map; "Hide muted channels" likewise. The sidebar reads notif_settings::is_collapsed and emits UserAction::ToggleCategory instead of keeping a local set. New UserAction variants: CopyLinkChannelUrl, OpenNotificationSettings, OpenFollowChannel (the last two open UI-owned modals). Refs #503 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Review: Daily use 22b (independent, read cold), diff 2d1164f..613cf0c
Tests named by the plan. All seven exist (
barrier_table,no_typing_while_editing_or_commands,stale_draft_echo_ignored,consecutive_blocked_messages_group_and_count,group_breaks_on_other_author_and_day_divider,reveal_toggles_group,jump_target_inside_group_opens_it), plus four extra. They assert the spec's exact strings: blocked DM, system DM, timeout, the disabled placeholder "You can't send messages in this channel.", Follow, locked thread, "{n} blocked message(s)".Interfaces.
composer_barrier(&App, Snowflake) -> Option<Barrier>andMessageListItem::BlockedGroup { first_id, count, revealed }match the plan.ComposerContextcarries thread, forum post and edit for 37b.timeline/TimelineItemare unchanged, so fluxer-ui compiles. The newUserAction::RevealBlockedGroupis a reasonable one-variant addition (the original'srevealMessage).Invariants. Only fluxer-core changes. No I/O, no banned imports, no fixtures, no secrets. Server data cannot panic it: the timeout uses saturating arithmetic and
try_from.Parity spot-checks against the fork (all match):
FLUXERBOT_ID = '0'andisSystemDmChannel= DM type with that recipient.DMChannelView.tsx:476-485,getNickname).GuildVerification.ts:133-141), thenThreadComposerArealocked check, then announcement-without-SEND_MESSAGES Follow insiderenderComposer(GuildChannelView.tsx:362-372,618).unblockUserruns with no confirm.CountdownTimerusesMath.ceiland M:SS.decideComposerTypingported line for line (RollingComposerTypingGate.ts:15-37).ChannelTextareadisables on SEND_MESSAGES only (not the threads permission).isUserMessage+ blocked; a day divider or another type ends the group; the message after a group starts a new group (MessageGroupingUtils.ts:170-230); the plural descriptor isBlockedMessageGroups.tsx:28-32.Review Focus. No numbered item is this task's own. Item 5 (unblock confirms) is per surface: the barrier's Unblock acts at once, as the original does.
CI.
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed, exit 0.Findings
chat/composer.rson_editedecho guard: the guard keys on the cursor at send time. If a message is sent with the caret mid-text (for example "hello" sent with the cursor at 2) and the same text is then pasted into the emptied box (cursor 5), the paste is taken for an echo. The store keeps "" while the box shows "hello", until the next keystroke. This is rare and recovers on the next edit. It could be documented, or the UI-sideMirror::syncfix in 37b could make the core guard unnecessary.ui.rs/typing.rsSendEcho(FoundationDraftChangedpath): anyDraftChangedequal to the text just sent is ignored, so re-pasting the same text right after a send is dropped on that path. The UI no longer emitsDraftChanged(onlyapps/fluxer/tests/runtime.rsdoes), so this has no user impact today.fluxer-proto'sGuildhas nodisabled_operations(the fork reads it inGuild.ts:250;GuildVerification.ts:143checksSEND_MESSAGE). It needs a proto task. Suggest afollow-upissue so it is not lost with #400.Verdict: approve. No blocking findings, CI green locally.
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed