Daily use 23: fluxer-core full profile, popout additions, report flow (#511) #574
Closed
charles
wants to merge 0 commits from
dailyuse-23-core-profile-report-flow into dailyuse
pull from: dailyuse-23-core-profile-report-flow
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!574
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-23-core-profile-report-flow"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-11b-core-state-skeleton, dailyuse-14-core-status-idle-presence
What this builds (spec §3.10, §3.12, §17 Q14)
Profiles (
profiles.rs,selectors/profile.rs)OpenProfileModal { user_id, guild_id, tab }opensapp.profiles.modaland closes the popout. It fetches the profile the same way as the popout (the runtime adds the mutual flags) and fetches the note once per user per session (FetchUserNote).CloseProfileModal,MessageUserandOpenSettingsclose the modal.ApiResult::UserNote/UserNotesandUSER_NOTE_UPDATEfillprofiles.notes.SaveNotewritesPUTonly when the text differs from what is shown (at most 256 characters,nullwhen emptied), asUserNoteEditor.tsx. The new note shows at once and the old one comes back if the write fails.timezone_offset, a timer runs every 30 s (LOCAL_TIME_REFRESH) so the local time stays current.profiles::user_click(user, guild, anchor, shift_only): Shift alone sendsMentionUser, anything else sendsOpenProfile(PreloadableUserPopout.tsx:83-90).ProfilePopoutgains:badges:{static_cdn}/badges/{asset}.webp, else{asset_url}?size=96, plus label, caption, href and aspect ratiovoice_activitylocal_time { text, relative }: "2:05 PM" or "14:05" fromtime_format, else the locale; "Same time as you", "2 hours ahead of you", "5 hours 30 minutes behind you"connections: bsky and domain URLsview_full_profile(&popout)returns the action for "View full profile".profile_modal(&App) -> ProfileModalModel:Report flow (
report.rs): a port ofReportFlowWalk.tsandReportFlowModal.tsxmessage?surface=in_app&locale=and start atstart_screen_id.screen,submit(leads to the summary),end(shows the notice, or "Thanks for flagging this" with the long or short text), andlink(Effect::OpenUrl, http(s) only; a/reportpage getstype=message&message_link=, asresolveLinkUrl).min_checked, and their item ids are sent in checklist order. Info screens have Next, and only their link options can be chosen.revision_hash,localeand the steps.describeSubmitFailure.CONFLICTends with Done.REPORT_FLOW_OUTDATEDandINVALID_REPORT_FLOW_ANSWERSrefetch and restart with "The report form changed. Please start again."BlockAuthorsends the menus'Friend { Block, Menu, confirmed: false }, so it asks for confirmation as the original does.POST /reports/message {category: "other"}. It goes through the same "Check your report" summary, so the user still confirms. Back returns to the walk.report_modal(&App) -> ReportModalModelcovers title, subtitle, body, urgent banner, footer buttons and flash.block_action(&App)is also provided.Tests
tests/profile_full.rs:tabs_and_counts_bot_has_no_mutual_friends,mutual_label_by_kind,local_time_ahead_behind_same,local_time_refresh_scheduled,badges_from_profile,note_loaded_and_saved_debounced,shift_click_mentions_instead.tests/report_flow.rs:report_walk_option_outcomes,report_checklist_min_checked_and_item_ids,report_info_screen_next,report_end_outcome_shows_notice,report_link_outcome_opens_url,report_back,report_submit_steps_revision_hash_locale,report_unknown_outcome_falls_back,report_done_offers_block. They run over the Daily use 2 fixturefixtures/rest/report_flow_message.json; the info-screen and broken-flow variants are edited copies made inside the tests.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses locally. There are no desktop or real-display tests in this task, and no screenshots (core only).Deviations from the plan, for review
report_modaland the report view types live influxer_core::report, not inselectors, to stay inside this task's file list.ReportAction::OpenLinkopens the summary's "community guidelines" link. Link options open throughChoose, as the original's option list does.ProfileAnchorvariants. The anchor is the clicked bounds and already works for mentions, reply authors, voice participants and avatar stacks.profiles::user_clickis what every trigger emits, so the UI tasks (38) get Shift+click from one place.app.rs:report::reducenow takes aReportCtx(me, session, channels, messages, social) and its follow-up events are applied.tests/dailyuse_ports.rs: the 11a/11b "stub does nothing" tests now skipReport,OpenProfileModalandSaveNote, as Daily use 12 and 14 did for theirs.ReadyPayloaddoes not carry the original's READYnotesmap.time_formatis auto uses a short list of 12-hour locales in place ofIntl(en-USdefault). Voice activity is a plain list, without the "And n other calls" grouping.message_linkforresolveLinkUrlis a 10-line copy ofchat::actions::link, so this task does not editchat/actions.rs, which unmerged tasks own.Closes #511
🤖 Generated with Claude Code
Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 23 (fac6649..1b3fca5)
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree: all steps passed (EXIT=0).Checks
tests/profile_full.rsandtests/report_flow.rsand assert the spec's values: tabs and the bot rule, the communities/groups/places labels, ahead/behind/same with "2 hours", "5 hours 30 minutes" and "1 hour 1 minute", the 30 sEffect::Schedule, badge URLs, note GET/PUT/null/256 and USER_NOTE_UPDATE, Shift+click, every outcome kind, checklistmin_checkedand item order, the info screen's Next, Back, the submission body with revision_hash and locale, the Q14 fallbacks and "Block {name}".profile_modal,ProfileModalModel,ProfilePopout.{badges, custom_status, voice_activity, local_time, connections},LocalTime { text, relative },view_full_profile,report_modal/ReportModalModeland everyReportActionarm are present. Deviations accepted:report_modallives influxer_core::report, and there are no newProfileAnchorvariants (ProfileAnchoris a bounds struct;profiles::user_clickcovers every trigger).checked_add,unsigned_abs) and the server's aspect ratio is filtered to finite and positive. Link outcomes open http/https only. No secrets.ReportFlowWalk.ts(applyOutcome, info, checklist, back, answer labels): matches.describeSubmitFailure/isTerminalSubmitFailure: matches, including CONFLICT ending in Done, 429/RATE_LIMITED, server text for the REPORT_* and CANNOT_REPORT_* codes, and a restart on REPORT_FLOW_OUTDATED/INVALID_REPORT_FLOW_ANSWERS.ReportFlowCommands.ts: the submission usesflow.locale.ReportFlowCopy.ts: the strings match.getMutualItemsDescriptor: matches.profileBadgeImageUrl,getConnectionUrl,formatOffsetDifferenceDurationandopenExternalUrl(no warning modal): match.report_unknown_outcome_falls_back.Findings
getReportedUserreturns null for webhook messages (ReportFlowModal.tsx), so the original never offers "Block {name}" for them. The nativeMessagehas nowebhook_id, so a webhook message's author is offered. Follow-up: once proto carrieswebhook_id, exclude those authors.locale_uses_12_hour). A bareenlocale reads as 24 h, but Intl gives 12 h. Accessibility's "use the browser locale for time format" is also not consulted. Settings default to en-US and an explicittime_formatwins, so few users are affected.LocalSettings::utc_offset_minutes). The original readsnew Date().getTimezoneOffset()on every render, so the native "ahead/behind" text can be an hour off after a DST change until restart.GET /users/@me/notes/{id}answer that arrives after aSaveNotereplaces the note the user just typed on screen. The PUT still goes out, so no data is lost.report_done_offers_blockchecks thatBlockAuthorkeeps the report open but not that the block confirm is raised.None of these breaks an interface, an invariant or data, and none leaves CI red.
Verdict: APPROVED (0 blocking findings, local CI green).
Independent review: Daily use 23 (full profile, popout details, report flow)
Scope:
git diff fac6649..origin/dailyuse-23-core-profile-report-flowat1b3fca5.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed in a fresh review worktree. Every step passed: ffmpeg, fmt, clippy, deny, core-isolation, parity, test, vendored-tests, screenshot-tests and livekit-interop.What I checked
tests/profile_full.rsand 9 intests/report_flow.rs. They assert the spec's values: the tab labels, "Same time as you" and "{d} ahead of you" / "{d} behind you", the 30 sEffect::Schedule, the badge URLs, the note fetch/PUT/null/256 andUSER_NOTE_UPDATE, Shift+click producingMentionUser, the screen, submit, end, link, checklist (min_checked, item ids in the checklist's order) and info outcomes, Back restoring ticks, the submission carryingrevision_hash,localeand the steps, the legacy fallback withcategory: "other", and "Block {name}" / "Blocked". The tests reuse the existing fixtures (user_profile.json,report_flow_message.json) and add no new ones.ReportActionis handled in full.report_modal,profile_modal, the popout'sbadges,custom_status,voice_activityandlocal_time { text, relative },view_full_profile,SaveNoteanduser_clickare all present. The deviations listed in the PR body are acceptable (details below).urlwas already a dependency). There is no indexing or unwrap on server data: offsets usechecked_add, durations useunsigned_abs, and badge ratios are filtered to finite positive values. Logs carry no secrets, and no settings are written.ReportFlowWalk.ts: applyOutcome, the info-screen step{screen_id}, the checklist item order, back restoring drafts, and answer labels all match.ReportFlowModal.tsx:getReportedUser/blockTargetis decided once at open, and links go throughopenExternalUrldirectly withresolveLinkUrl. Both match.ReportFlowCopy.ts: the strings match, including "Your options".UserProfileShared.tsx:79-97,213-262: offset minus the viewer's offset, the hours/minutes plurals, and the 30 s interval all match.MutualItemsDescriptors.ts: the communities/groups/places choice matches.ProfileUtils.ts:56-64: the badge URLs match.UserNoteEditor.tsx:maxLength256 and save on blur match.Unknownoutcome, a missing screen, a missing start screen, a Decode error and a 404/405 all fall back to the legacy report. A network failure shows "Couldn't load the report form." with Try again.Findings
report.rsReportFlowState::openoffers "Block {name}" on webhook messages. The original'sgetReportedUserreturns null formessage.webhookId, but the nativeMessagehas nowebhook_idfield, so the check cannot be made. Follow-up candidate: the proto would need the field.profiles.rs:note_fetchesis only cleaned on failure. A successfulUserNoteanswer leaves its entry behind, so the map grows by one entry per user per session. It is bounded and harmless.profiles.rsnotes race. If aSaveNotehappens while the firstFetchUserNoteis still in flight, the fetch answer can overwrite the note just saved in the view (the server still holds the saved text). If a write fails after aUSER_NOTE_UPDATE, the revert puts the older text back. These are rare edge cases.[Overview, MutualFriends(n), MutualPlaces(label, n)]. The branch usesProfileTabItem { tab, label }with the count inside the label.report_modalreturnsOption<ReportModalModel>and lives influxer_core::report.ProfileAnchorstays a bounds struct, so every trigger can use it and no new variants are needed. All of this is noted in the PR body. Task 38/39 should build against these names.submitcuts the steps at 16 and the item ids at 32 without telling the user. The original sends everything and lets the server refuse. Real flows cannot get that deep.No blocking findings.
Verdict: approve. CI is green locally (with screenshots), and there are no blocking findings.
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed