Daily use 15: core friends, requests and blocking (#500) #572
Closed
charles
wants to merge 0 commits from
dailyuse-15-core-friends-blocking into dailyuse
pull from: dailyuse-15-core-friends-blocking
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!572
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-15-core-friends-blocking"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Daily use 15 (spec §3.5, §6.2 "Friends"): relationships, the friends page and blocking in
fluxer-core.UserAction::Friend { action, surface, confirmed }acts or asks first per the original's per-action, per-surface table:social::confirm_rule(&FriendAction, FriendSurface) -> ConfirmRule::{None, Confirm, ConfirmShiftSkips}. Accept, Remove, Block and Unblock (menus, DM list, Blocked users) ask and Shift skips; Ignore and Cancel ask from a friends page row without a Shift bypass and act at once from the DM welcome and the menus; Send, Send by tag and Set nickname never ask. A confirm is the store'sConfirm::Relationship, cancelled byCloseConfirm, accepted by re-sending confirmed (social::confirm_accept).social::confirm_textgives the original's strings (RelationshipActionUtils.tsx,FriendListItem.tsx:120-167).SendFriendRequest,SendFriendRequestByTag,AcceptFriendRequest,BlockUser,RemoveRelationship(ignore, cancel, remove, unblock),SetFriendNickname(friends only, trimmed, blank clears, more than 32 characters refused with "Nickname must not exceed 32 characters"). The relationships change only when the answer arrives; failures open the original's error dialogs (RelationshipErrorModalUtils.tsx) insocial.error, closed byCloseConfirm.social::parse_tag(trimmed,#split,0000without a tag,^\d{4}$,#0…#0000on unique-username instances) andsocial::add_friend_error(the API code strings ofAddFriendForm.getErrorMessage/getSendFriendRequestErrorMessage; onlyNEW_CONVERSATIONS_LIMITEDshows the server's message). Success: "Friend request sent", field emptied.social::friends_page(&App) -> FriendsPageModel: tabs Online (default) / All / Pending (badge = incoming count) / Add friend (primary), search placeholders, case-insensitive search over"{nickname} {username}", sections ("Online", "All friends", "Incoming friend requests", "Outgoing friend requests") sorted by name, rows with tag, 36 px avatar, status, subtext (friend custom status, else "Incoming friend request" / "Friend request sent" / status label) and buttons (FriendButton::action(shift)applies the Shift rule), and all five empty states. No "Active now" sidebar (spec §17 Q7).social::friend_more_menu(a friend row's "More"),social::blocked_users(Settings → Blocked users, sorted, "No blocked users" empty state),social::welcome_buttons→DmWelcome::Dm::friend_buttons(none / incoming / outgoing / friend / blocked / bot rules ofDMWelcomeSection.tsx:130-205).UserAction::LeaveGroup { channel_id, silent, confirmed }(inchat/dms.rs): asks withConfirm::LeaveGroup(no Shift bypass, "Leave silently" switch), thenLeaveGroupDm { silent, delete_messages: false }; "Left group" toast, "Couldn't leave group" / "Try again in a moment." on failure.selectors::members::display_name= guild nick, else friend nickname, else global name, else username (NicknameUtils.ts:85-115);dm_namealready had it.Tests
crates/fluxer-core/tests/social.rs(confirm_and_shift_rule_per_action_and_surfacetable,ignore_and_cancel_act_at_once_from_welcome_and_menus,confirm_strings_per_action,add_by_tag_parsing_table,send_by_tag_flow,error_codes_map_to_strings,welcome_buttons_by_relationship,leave_group_query_flags,leave_group_failure,friend_nickname_precedence,set_nickname_request,state_changes_only_after_the_server_answers,blocked_users_sorted_by_name,friend_row_more_menu, ...) andcrates/fluxer-core/tests/friends_page.rs(tabs_and_counts,pending_badge_counts_incoming_only,sections_sorted_by_display_name,search_matches_nickname_and_username,empty_states_per_tab,search_placeholder_per_tab, ...). Relationship fixtures are shaped likeRelationshipResponse(packages/schema/src/domains/user/UserResponseSchemas.ts:492of the fork).dailyuse_ports.rs:Friend,OpenFriends,FriendsSearchandLeaveGroupnow have behaviour, so they left the "ignored until implemented" list;stubs_emit_nothingnow expects the tab and search to be kept.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No desktop (FLUXER_DESKTOP_TESTS=1) tests touched or run; no UI change, no goldens.Deviations / notes for review
Social::reducenow takes the session and the store's confirm (app.rs), andDms::reducethe confirm (chat/mod.rs): the same pattern as Daily use 16b'sInvites::reduce, so the merge with 16b inapp.rsis mechanical.social.error,chat.dms.leave_error) close withCloseConfirm: no dismiss action exists among the Task 11a ports.ApiResults carry no request id, so successes are matched to the requests by user id.StartCalltakes a DM channel); "Start video call" is left out (camera, sub-project 5).promptForAccountTier,RuntimeConfig.friendsDisabled/directMessagesDisabledgates.BlockedUsersTab.tsx:53-60: asks, Shift skips (bypassConfirmpassed).Stacked on: dailyuse-14-core-status-idle-presence
Closes #500
Refs #383
🤖 Generated with Claude Code
Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 15 (core friends, requests, blocking)
Reviewed
git diff fac6649..9f0269c(commits9ce0034,9f0269c) without relying on the implementer's notes.Plan tests (1): all 13 named tests exist (
tabs_and_counts,pending_badge_counts_incoming_only,sections_sorted_by_display_name,search_matches_nickname_and_username,empty_states_per_tab,add_by_tag_parsing_table,error_codes_map_to_strings,confirm_strings_per_action,confirm_and_shift_rule_per_action_and_surface,ignore_and_cancel_act_at_once_from_welcome_and_menus,welcome_buttons_by_relationship,leave_group_query_flags,friend_nickname_precedence). They check the spec §3.5 strings and the confirm table word for word. The table test also drives the reducer: it checks that the confirm opens, thatconfirmed: trueacts and that the confirm closes.Interfaces (2):
friends_page -> FriendsPageModel { tab, pending_badge, search_placeholder, sections: [FriendSection { title, count, rows: [FriendRowModel { user, name, tag, subtext, status, buttons, .. }] }], empty },blocked_users,DmWelcome::Dm::friend_buttons,LeaveGroup { silent }→Confirm::LeaveGroup,Confirm::Relationshipclosed byCloseConfirm, andsocial::confirm_rule(&action, surface) -> ConfirmRule::{None, Confirm, ConfirmShiftSkips}are all present. TheSocial::reduce/Dms::reducesignature changes are crate-private.Invariants (3): fluxer-core only (std + fluxer_proto, no I/O). There is no unwrap or indexing on server data. Users the client has never seen are skipped, and a test covers it. The relationship fixtures match
RelationshipResponse(UserResponseSchemas.ts:492) andUserPartialResponse, and the commit message names the source file. No secrets.Parity spot-checks (4): I checked these against the fork:
FriendListItem.tsx:126-180: Ignore and Cancel open a danger confirm that usesgetDisplayNameand has no bypass. Accept passesbypassConfirm.DMWelcomeSection.tsx:99-205: buttons by relationship, secondary variants, Ignore and Cancel act at once, Accept and Remove pass the bypass.AddFriendForm.tsx:65-115:parseInput,/^0{1,4}$/on username-only instances,^\d{4}$, error mapping,NEW_CONVERSATIONS_LIMITEDshowing the server message.getSendFriendRequestErrorMessage, where the message comes before the code.RelationshipErrorModalUtils.tsx: titles and messages per action.FriendsList.tsx/PendingFriendsView.tsx: empty-state order and strings ("Try a different name." for pending).useLeaveGroup.tsx: strings, plus "Couldn't leave group" / "Try again in a moment.".BlockedUsersTab.tsx:53-60: Unblock passes the bypass.All of these match.
Review Focus 5: satisfied for this task's actions and surfaces. Accept, Remove, Block and Unblock confirm and Shift skips the confirm. Ignore and Cancel confirm on friend rows with no Shift skip, and act at once from the welcome and menus. Leave group confirms with no bypass.
FriendButton::action(shift)sendsconfirmedonly forConfirmShiftSkips.CI (6):
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed.Findings
NicknameUtils.ts:120(getUntruncatedGuildMemberNickname, which the plan cites) puts the friend nickname above the guild nick.display_nameapplies the:85order (guild nick first) everywhere. That matches the spec text and every surface this task touches. The fork uses the:120order only in mention autocomplete (AutocompleteMention.tsx,AutocompleteOptionBuilders.ts), so whoever builds autocomplete names should use the friend-first order there.laterparity row if one is not already there.CloseConfirmclearssocial.error,chat.dms.leave_errorand the store confirm together. This is harmless today, because only one dialog shows at a time. Task 33 should know about it.promptForAccountTier, and thefriendsDisabled/directMessagesDisabledgates.Verdict: APPROVED. No blocking findings, local CI green.
Independent review: Daily use 15 (diff fac6649..9f0269c)
Tests (plan Step 1): all 13 named tests exist (
friends_page.rs: tabs_and_counts, pending_badge_counts_incoming_only, sections_sorted_by_display_name, search_matches_nickname_and_username, empty_states_per_tab;social.rs: the other 8). The confirm table test covers every row of spec §3.5 and also checks that the reducer asks, accepts and closes as the rule says.Interfaces:
friends_page,FriendsPageModel { tab, pending_badge, search_placeholder, sections, empty, .. },FriendSection { title, count, rows },FriendRowModel { user, name, tag, subtext, status, buttons, .. },blocked_users,DmWelcome::Dm::friend_buttons,UserAction::LeaveGroup { silent }withConfirm::LeaveGroup, andsocial::confirm_rule -> ConfirmRule::{None, Confirm, ConfirmShiftSkips}are all present.confirm_ruletakes&FriendAction; that is fine for its consumers.Invariants: fluxer-core does no I/O and imports nothing forbidden. There are no unwraps on server data (the badge count uses
try_from(..).unwrap_or). No fixtures, secrets or paths were added. Relationships change only when the API answers.Parity spot-checks (fluxer-soundboard):
AddFriendForm.tsx:65-103:parseInput(split on the first#,/^0{1,4}$/→0000when usernames are unique,^\d{4}$) andgetErrorMessage(the server message shown only for NEW_CONVERSATIONS_LIMITED) match.RelationshipActionUtils.tsx:121-147:getSendFriendRequestErrorMessage(apiMessage first, then the codes) matches.NicknameUtils.ts:85-117: the guild nick wins over the friend nickname, which wins over the global name. Line 120 (friend first) is used only by AutocompleteMention and AutocompleteOptionBuilders, so leaving it out ofdisplay_nameis correct.FriendListItem.tsx:126-180: Ignore and Cancel confirm with nobypassConfirmand usegetDisplayName; Accept passesbypassConfirm. Matches.DMWelcomeSection.tsx:100-131: Accept and Remove bypass, Ignore and Cancel act at once, bots get no buttons. Matches.Review Focus 5: implemented as the table says for this task's actions. Close DM and Open DM while blocked belong to Task 18.
Findings:
CloseConfirmclearschat.confirm,social.erroranddms.leave_errortogether. Task 33 should draw at most one of these at a time (already noted by the implementer).social.toastanddms.toastexcept the next action. The UI (Task 33) should time them out without writing to core state, or a later task should add a dismiss.SendByTagwhile one is already sending clearstoastanderrorbefore it returns with no request. Harmless.laterrow in docs/parity/dailyuse.md (Task 40).CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed, exit 0.Verdict: APPROVED (no blocking findings, CI green).
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed