Daily use 13: honour mutes: unread, badges, hide muted, notifications, DND, mentions (#498) #564
Closed
charles
wants to merge 0 commits from
dailyuse-13-core-honour-mutes into dailyuse
pull from: dailyuse-13-core-honour-mutes
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!564
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-13-core-honour-mutes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-12-core-notification-settings-mutes
What this builds (Daily use 13, spec §3.4 "Consumers", §6.2)
notif_settings::mentions_meas the original (MessageUtils.isMentioned+Notification.isMessageMentionLike): blocked author never; the user inmentions;@everyone/@hereoutside a 1:1 DM unlesssuppress_everyoneor in a thread the user has not joined; a role of the user's unlesssuppress_roles; any message of a DM/group DM that is not muted.notification_forfollowsfeat/ui/state/Notification.ts:187-256, in order: own message, blocked author, chosen status DND (app.presence.me.chosen),SUPPRESS_NOTIFICATIONS(1 << 12) → none; threads: muted (membership mute, or parent muted at any level,isThreadMuted) → none, elsenotif_settings::thread_level(joined: member flags, Default = parent's effective level; unjoined: forum level for a post's first message, else ONLY_MENTIONS); other channels: muted at any level → none, NO_MESSAGES → none, ALL_MESSAGES → notify, ONLY_MENTIONS →mentions_me. Module header rewritten.read_state::unreadis false for a channel muted at any level;mention_countunchanged, so the guild rail (fluxer-uimodel.rs) and DM rows follow with no UI change. Newread_state::has_unread_messageskeeps the mute-blind answer.channel_tree:SidebarSectiongainscategory_mutedandmuted(rows/category muted by their own override, dimmed asChannelItem.tsx:242-273,546); withhide_muted_channels(or, without a settings entry,user_settings.default_hide_muted_channels()), channels muted by their own or their category's override are left out unless selected, connected or with a mention, and a category whose channels are all left out goes too (ChannelListVisibility.ts,ChannelListContent.tsx:381-500).notif_settings::hides_muted_channels(app, guild).DmRowModel.mutedfrom the@meoverride;is_mutedon a thread = membership mute or parent muted at any level.notif_settings::muted_until(&App, MuteTarget::Guild)for the rail tooltip already exists from Daily use 12; Daily use 30 draws it.Tests
crates/fluxer-core/tests/notification_rules.rs:notification_decision_table(54 rows: DND ×SUPPRESS_NOTIFICATIONS× mute guild/category/channel/DM/thread member × guild/category/channel level × suppress everyone/roles × mention user/everyone/role/other role × DM × joined/unjoined thread × forum post first/later message × blocked),own_message_never_notifies_even_at_all_messages.crates/fluxer-core/tests/mute_consumers.rs:muted_channel_not_unread_mentions_still_count,guild_unread_ignores_muted_channels,sidebar_rows_carry_muted,hide_muted_channels_rules,hide_muted_default_from_user_settings_when_no_entry,all_hidden_category_hidden,selected_muted_channel_still_shown,dm_counts_as_mention_unless_muted,guild_mentions_follow_suppress_settings.fixtures/gateway/user_guild_settings_update.jsonwith fields reset, threads shaped asfixtures/gateway/thread_create.json.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No desktop (FLUXER_DESKTOP_TESTS=1) tests involved.Deviations and points for the reviewer
resolvesToNoMessagesusesisGuildOrChannelMuted, which does not look at the parent category, so in Electron a muted category still notifies for its channels. Built as the plan says; flip to guild-or-channel innotifications::should_notifyif parity is preferred.ChannelItem.tsx:273), the guild pill for any level. Hereunreadis false at any level for both, as the plan's interface says.DEFAULT_GUILD_SETTINGS), so every guild message now notifies by default.tests/notifications.rs::guild_message_without_mention_does_not_notifynow sets ONLY_MENTIONS first, andtests/messages.rs::message_create_in_a_channel_that_is_not_loaded_only_moves_the_unread_markerallows the notification effect. INHERIT/NULL at guild level still fall back to ALL_MESSAGES instead of the guild'sdefault_message_notifications/ ONLY_MENTIONS for large guilds: tracked in #558 (a server-created entry is INHERIT,GuildMemberOperationsService.ts:683-700).chat/navigation.rs(new_messages_bar) andchat/thread_admin.rs(thread menu "Mark as read") now readhas_unread_messages, so a muted channel keeps its new-messages bar and a muted thread its "Mark as read" as in the original;lib.rsre-exportshas_unread_messages.@everyonecheck no longer requirescan_view(the original does not; the server only setsmention_everyonewhen allowed).app.presence.me.chosen, which Daily use 14 fills; the table sets it directly (anduser_settings.status = "dnd"in READY).Closes #498
🤖 Generated with Claude Code
Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 13 (core honour mutes)
Reviewed cold:
git diff 44794a88..origin/dailyuse-13-core-honour-mutes(61e2eba).Plan tests (1): every test the plan's Step 1 names exists.
notification_decision_tablehas 54 rows (the plan asks for at least 36) and covers DND ×SUPPRESS_NOTIFICATIONS(1 << 12) × guild/category/channel/DM/thread-member mute × guild/category/channel level × suppress everyone/roles × user/everyone/role/other-role mention × DM × joined/unjoined thread × forum post first/later message × blocked author. The other tests aremuted_channel_not_unread_mentions_still_count,guild_unread_ignores_muted_channels,hide_muted_channels_rules,hide_muted_default_from_user_settings_when_no_entry,all_hidden_category_hidden,selected_muted_channel_still_shownanddm_counts_as_mention_unless_muted, plus two extra tests. Thread member flag bits (1<<1, 1<<2, 1<<3) matchpackages/constants/src/ThreadConstants.ts:64-69.Interfaces (2): these exist as the plan writes them:
mentions_me,read_state::unread(false when the channel is muted at any level,mention_countunchanged),DmRowModel.muted,notif_settings::muted_until(&App, Guild)(from Daily use 12) andhides_muted_channels. The plan's "sidebar rows carrymuted: bool" is built asSidebarSection { category_muted, muted: BTreeSet<Snowflake> }, because sidebar rows are plainChannels. Daily use 30 can read it as it is, so nothing breaks. The newhas_unread_messagesstays mute-blind, so the new-messages bar and the thread "Mark as read" item keep their behaviour.Invariants (3): fluxer-core still has no forbidden imports and does no I/O. The change adds no fixtures: the tests reuse
user_guild_settings_update.jsonand thread shapes taken fromthread_create.json. Nothing new writes synced settings. Unknown notification levels fall through to the only-mentions path, so they cannot panic. No secrets or file paths.Parity spot-checks (4) against the fork:
MessageUtils.isMentioned: @everyone is skipped for a 1:1 DM, when suppressed, or whenignoreEveryoneis set; then the user mention; then a role check thatsuppressRolesturns off. The Rust port is equivalent, including the unjoined-thread ignoreEveryone fromNotification.ts:191-197.ThreadNotificationUtils.isThreadMuted/resolveThreadNotificationLevelandForumNotificationUtils.resolveNewPostNotificationLevel(the first message of a post, parentisThreadOnly): ported exactly.ChannelListVisibility.shouldShowChannelWhenHidingMutedChannels/shouldShowCategoryWhenHidingMutedChannels, and dimming only forisChannelDirectlyMuted(ChannelListContent.tsx:353,377-408): match. For a muted channel with unread badges off,hasVisibleUnreadis mention-only (ChannelUnreadState.tsdefault branch), as implemented.UserGuildSettingsdefaults: a guild without settings is at ALL_MESSAGES (DEFAULT_GUILD_SETTINGS), so the two adjusted existing tests are correct.Review Focus 2 (5): the order follows
validateNotificationData(own message, blocked, DND, SUPPRESS flag, then mute, then level), and a mention in a muted channel still adds to its badge (mention_countis untouched).Findings
resolvesToNoMessageschecks onlyisGuildOrChannelMuted, not the category. Spec §3.4/§6.2 and the plan say "any level", so building it this way is right. The spec's parity claim is still wrong, though. Suggest afollow-up/questionissue so Charles can choose.unreadhides the row dot for a mute at any level. The original's channel row andDMListItem.tsx:133useisChannelDirectlyMuted. The guild pill does use any level. The plan asks for oneunread, so this is acceptable. The difference would matter for a channel whose category or guild is muted: the original still shows its dot.@mescope is not muted by amuted: trueat the scope level. The original'sisGuildOrChannelMuted(null, id)also checksisWholeGuildMuted(null). This cannot be reached from any UI and is an edge case of the Daily use 12is_muted, not this diff.is_mutedon a thread now means "parent muted at any level" (isThreadMuted), and the sidebar/unread consumers use it too. The original's sidebar usesisThreadMutedInSidebar(parent directly muted). Same any-level choice as finding 2.No blocking findings.
Local gate (6):
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: green ("all steps passed", exit 0; livekit-interop skipped as usual).Verdict: approve: no blocking findings and CI is green. The minor findings 1, 2 and 4 are the spec/plan's any-level choice and are worth a follow-up question to Charles.
Independent review: Daily use 13 (core honour mutes)
Reviewed
git diff 44794a8..origin/dailyuse-13-core-honour-mutes(61e2eba) cold.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed (exit 0).Checks
notification_decision_table(54 rows: DND ×SUPPRESS_NOTIFICATIONS× mute guild/category/channel/DM/thread-member × level incl. overrides/INHERIT × suppress everyone/roles × mention user/everyone/role/other role × DM × joined/unjoined thread × forum post × blocked),muted_channel_not_unread_mentions_still_count,guild_unread_ignores_muted_channels,hide_muted_channels_rules,hide_muted_default_from_user_settings_when_no_entry,all_hidden_category_hidden,selected_muted_channel_still_shown,dm_counts_as_mention_unless_muted. There are also extras for the sidebar's muted flags and suppress settings.mentions_me,read_state::unread(false when muted, mention counts unchanged),notif_settings::muted_until(&App, MuteTarget::Guild),hides_muted_channels,thread_level, andnotification_forin the plan's order are all present. The plan says "sidebar rows carrymuted: bool". Sidebar rows areChannels here, so the flag lives onSidebarSectionasmuted: BTreeSet<Snowflake>pluscategory_muted: bool. Task 30 can read it withsection.muted.contains(&id). See finding 1.ready.json/user_guild_settings_update.json). The thread → parent recursion inis_mutedis guarded (the parent must be a different channel that is not a thread), so server data cannot loop it. No secrets.MessageUtils.isMentioned: @everyone only outside a DM, and not when suppressed orignoreEveryone. Then the user is named. Then a role of the member, unless roles are suppressed. Nativementions_mematches, adding the blocked-author check that spec §6.2 asks for.ThreadNotificationUtils: the ALL / ONLY / NO member-flag order, then the parent's effective level, else ONLY_MENTIONS.resolveNewPostNotificationLevelapplies only whenmessageId === post.id.isThreadMutedis a membership mute (withend_time) or a parent muted at any level. Nativethread_levelandis_mutedmatch.ChannelListVisibility.tsandChannelListContent.tsx:376-500: the selected / connected / not-muted / visible-unread rule. Category hiding needshasChannels && !hasVisibleChannels. Rows and categories are dimmed only for their own override (isChannelDirectlyMuted), and a guild mute alone hides nothing. Native matches.DEFAULT_GUILD_SETTINGS.message_notifications = ALL_MESSAGES(UserGuildSettings.ts:67), so a guild without an entry notifies every message. This matches, and explains the changes totests/messages.rsandtests/notifications.rs.Findings
muted: bool, but the code has a per-sectionmuted: BTreeSet<Snowflake>+category_muted. This is equivalent and documented in the README, and no consumer exists yet. Task 30's implementer should be told the actual shape.isGuildOrChannelMuted.unreadis false when its parent is muted at any level, where the original's sidebar usesisThreadMutedInSidebar, which checks only a direct parent mute.guild.effectiveMessageNotifications, now has a visible effect. Such guilds notify on every message. The server writes INHERIT on join when "hide muted by default" is on (GuildMemberOperationsService.ts:683-698). This is already tracked in #558; worth prioritising before daily use.is_privatealso countsDmPersonalNotes; the original'sisPrivatecovers only DM and group DM. Moot in practice, because only the user writes there.No blocking findings.
Verdict: approve (0 blocking, CI green locally).
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed