Daily use 16b: core create invites, add and leave guilds (#502) #563
Closed
charles
wants to merge 0 commits from
dailyuse-16b-core-create-invites-guilds into dailyuse
pull from: dailyuse-16b-core-create-invites-guilds
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!563
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-16b-core-create-invites-guilds"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-16a-core-invite-links
What this builds (spec §3.6, plan Task 16b)
All in
fluxer-core(invites.rs, wired inapp.rs):InviteModal.tsx):InviteAction::Create { channel_id }opens it and creates the default invite{max_age: 604800, max_uses: 0, temporary: false}; a channel the user may not invite to shows the original's "unavailable" modal.Configure("Create new link") replaces the link with the settings clamped to 604800 s / 100 uses;Copywrites{endpoints.invite}/{code}to the clipboard (the original suppresses the toast).invites::invite_modal(&App) -> InviteModalModel: title "Invite friends to {guild}", "Recipients will be taken to", paused warning, recipients (friends with a DM in DM-list order, group DMs, other friends, asuseRecipientItems), "Invite" → "Sent" with a sending flag, link + "expires in" text (largest whole unit, asgetExpirationText), and the settings view's lists ("Expire after", "Max number of uses", "Custom…", hints, "Temporary membership") with the selected entry.custom_max_age/custom_max_usesparse the custom inputs asclampNumber.SendToFriend { user_id }sends the link withSendMessageto the DM (opened withOpenDmfirst, not selected) or, when the id is a group DM's channel id, to that group (the original keys group rows by channel id). A failure shows "Something went wrong" / "Couldn't send invite. Try again." and the row can be tried again.invites::can_invite(&App, channel_id)(CREATE_INSTANT_INVITE) andinvites::invite_channel(&App, guild_id)(getInvitableChannelId: the open text/voice/announcement channel if invitable, else the first in sidebar order) for the menus of Task 17/18.AddGuild(..)actions andinvites::add_guild(&App) -> AddGuildModel(landing / create / join with the original's strings). Name ≤ 100 chars, submit disabled when blank; static icon only (check_group_icon: no GIF/APNG, ≤ 10 MiB) with "Animated icons are not supported…" / "Icon file is too large. Choose a file smaller than 10MB.";CreateGuild { name, icon }; the answer closes the modal and the guild'ssystem_channel_idis selected once itsGUILD_CREATEis in (either order). Join: code fromlink_code, else the raw text, through 16a's accept flow; the modal closes once joined, 16a's error modals on refusal.LeaveGuild { guild_id, confirmed }does nothing for the owner or a non-member (invites::can_leave_guild); otherwiseConfirm::LeaveGuild(no Shift bypass), thenDELETE /users/@me/guilds/{id}withdelete_messages: false(spec §13, §17 Q11).GuildLeftremoves the guild at once through a follow-upGUILD_DELETE(aschat::dmsdoes withCHANNEL_DELETE), so a selected guild goes to the DMs; toast "Left community"; failure "Failed to leave community" / "Couldn't leave right now. Try again in a moment.". Strings asLEAVE_COMMUNITY_TITLE/LEAVE_COMMUNITY_BODYfor Task 33.Tests
crates/fluxer-core/tests/guild_membership.rs:invite_modal_defaults_7_days_no_limit,custom_expiry_bounds,send_to_friend_sends_link_in_dm,add_guild_create_and_join,leave_guild_owner_hidden_and_confirm,leave_guild_selected_goes_to_dms,create_selects_system_channel(seen failing first, commitb5ee094). Fixtures reused, all server-shaped:rest/invite_metadata.json,rest/guild.json,gateway/guild_create.json.tests/dailyuse_ports.rs: the invite/add-guild/leave actions andGuildLeftare no longer listed as stubs.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No UI or desktop tests involved.Deviations from the plan
crates/fluxer-core/src/guilds.rsis not modified: removing a left guild goes through the existingGUILD_DELETEhandling of every domain (follow-up event), and "select after create" lives with the add-guild state ininvites.rs.app.rsgets two lines (the channels inInviteCtx,&mut chat.confirmfor the leave confirm).InviteActionhas no variants for them (Task 11a's ports). The model gives both views andInviteRecipient::matches(query).InviteError::LeaveFailed,SendFailed, shown throughinvite_accept_modal(..).error).vanity_url_code), the "account tier" prompt, the guidelines note (the original shows it only on hosted instances), the random join placeholder (a fixed sample code).invite_channelreturns the first invitable channel in sidebar order, which (as in the original'sgetChannelsInChannelListOrder) puts channels without a category first.Closes #502
🤖 Generated with Claude Code
Uses the existing server-shaped fixtures: rest/invite_metadata.json (POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the metadata fields), rest/guild.json (POST /guilds, GuildResponse) and gateway/guild_create.json. Refs #502 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 16b (diff 995e64a..18ca551)
Checks
crates/fluxer-core/tests/guild_membership.rs(invite_modal_defaults_7_days_no_limit,custom_expiry_bounds,send_to_friend_sends_link_in_dm,add_guild_create_and_join,leave_guild_owner_hidden_and_confirm,leave_guild_selected_goes_to_dms,create_selects_system_channel). They assert the spec's values:{max_age: 604800, max_uses: 0, temporary: false}, the expiry and uses lists, clamping to 604800 and 100,{endpoints.invite}/{code}, Invite → Sent, owner hidden, the confirm strings,delete_messages: false, and DMs after leaving the selected guild.invite_modal(&App) -> InviteModalModel,invites::can_invite(&App, channel) -> bool,add_guild(&App) -> AddGuildModel,LeaveGuildwithConfirm::LeaveGuild(no Shift bypass, no delete-messages switch), and guild create →GUILD_CREATE→system_channel_idall exist as written. The extrainvite_channelandcan_leave_guildare useful for Tasks 17 and 18.clamp_numberslices only after an ASCII sign byte, and parse overflow saturates. No secrets are added. Toasts reuse the existingtoast: Option<String>pattern. Not touchingguilds.rsis acceptable: a follow-upGUILD_DELETEreuses the existing cleanup inguilds.rs,ui.rsandchannels.rs, and the test shows a later realGUILD_DELETEchanges nothing more.InviteModal.tsx(option lists, strings,getExpirationTextlargest-whole-unit rule,clampNumber, "Something went wrong" / "Couldn't send invite. Try again.");InviteUtils.getInvitableChannelId(the guild's selected channel if it is text-based and invitable, else the first invitable channel);useLeaveGuild.tsx(title, body, toast, error strings);LimitConstants.ts(MAX_INVITE_USES100,MAX_INVITE_AGE_SECONDS604800);GuildJoinForm.tsx(findInvite(...) ?? raw, maxLength 100);GuildCreateForm.tsx(selectssystem_channel_id);RecipientList.useRecipientItems(DM friends, then group DMs, then other friends). The server accepts a non-numeric nonce likei<digits>(MessageNonceRequestis a 1–32 character string).UserAction::LeaveGuildhas no shift path, andconfirmed: falsealways setsConfirm::LeaveGuild.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree passed (exit 0).Findings
InviteCreatedanswer is not matched to its request. If the user picks "Create new link" while the first invite is still being created, the earlier answer shows its link and clearscreating, and the newer answer replaces it later. ASendToFriendin between sends the older (still valid) link. Matching on theEffectId, or ignoring answers while a newer request is out, would fix it.useRecipientItemskeeps the recipient order from when the modal opened (initialOrderRef). Here the rows are rebuilt fromdm_listevery time, so sending a link (which moves that DM to the top), or opening a DM for a friend who had none, reorders the list under the cursor._branch ofaccept_resolved) leavesadd_guild.joiningset. The button then shows its spinner and stays disabled until the modal is closed.showDmActionErrorModalin that case (InviteModal.tsx,failureCode(error)). This could be a parity row or a follow-up.Verdict: approve. No blocking findings, and local ci is green.
Independent review: Daily use 16b (head
18ca551)I reviewed
git diff 995e64a..origin/dailyuse-16b-core-create-invites-guildsfrom scratch.Plan tests: all 7 are in
crates/fluxer-core/tests/guild_membership.rsand use the spec values: the default{max_age: 604800, max_uses: 0, temporary: false}; the original's "Expire after" and "Max uses" lists; clamping at 604800 and 100; the link{endpoints.invite}/{code}; send then Sent; the DM opened without being selected; create and join; the owner sees no leave item; the confirm with no Shift bypass anddelete_messages: false; DMs selected after leaving;system_channel_idselected in both arrival orders.Interfaces:
invite_modal(&App) -> InviteModalModel,invites::can_invite(&App, channel) -> bool,add_guild(&App) -> AddGuildModel,LeaveGuildthroughConfirm::LeaveGuild, and the create-then-select flow all exist. Task 11a'sUserAction,ApiRequestandApiResulttypes are reused, not duplicated.Invariants: fluxer-core has no new dependency and does no I/O. There are no new fixtures (existing ones are reused). There are no secrets or real paths. Panics:
clamp_numberslices only after an ASCII byte, andfile_sizecannot overflow. The send nonce isi<u64>, 21 characters at most, which is within the server'sMessageNonceRequestlimit of 1 to 32 characters.Parity spot checks against the fork:
InviteModal.tsx: option lists, default invite on open,clampNumber,getExpirationText(it uses the selected maxAge, as here), and the send error "Something went wrong" / "Couldn't send invite. Try again." fromCommonMessageDescriptors.ts:727. All match.useLeaveGuild.tsx: the strings, the toast, the error modal, and going to DMs only when the guild was selected. All match.GuildCreateForm.tsx:58-60: pop, thenselectChannel(guild.id, system_channel_id). Matches; here it waits forGUILD_CREATE.Review Focus 5: leave community confirms with no Shift bypass. Verified.
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed (exit 0). livekit-interop was skipped.Findings
InviteCreatedanswer is not matched to the effect that asked for it. If an older answer arrives after "Create new link", the older link replaces the newer one.add_guild.joiningstays set when the joined invite is neither a guild nor a group DM, so the Join button stays disabled.showDmActionErrorModalfor it.invites.toastis never cleared. A second "Left community" leaves the value unchanged, so a UI that shows the toast on change misses it. Other modules use the same pattern.These are non-blocking. File each one as a
follow-upissue before merge.Verdict: APPROVE. No blocking findings, and CI is green locally.
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed