Daily use 16b: core create invites, add and leave guilds (#502) #563

Closed
charles wants to merge 0 commits from dailyuse-16b-core-create-invites-guilds into dailyuse
Owner

Stacked on: dailyuse-16a-core-invite-links

What this builds (spec §3.6, plan Task 16b)

All in fluxer-core (invites.rs, wired in app.rs):

  • Invite modal (InviteModal.tsx): InviteAction::Create { channel_id } opens it and creates the default invite {max_age: 604800, max_uses: 0, temporary: false}; a channel the user may not invite to shows the original's "unavailable" modal. Configure ("Create new link") replaces the link with the settings clamped to 604800 s / 100 uses; Copy writes {endpoints.invite}/{code} to the clipboard (the original suppresses the toast). invites::invite_modal(&App) -> InviteModalModel: title "Invite friends to {guild}", "Recipients will be taken to", paused warning, recipients (friends with a DM in DM-list order, group DMs, other friends, as useRecipientItems), "Invite" → "Sent" with a sending flag, link + "expires in" text (largest whole unit, as getExpirationText), and the settings view's lists ("Expire after", "Max number of uses", "Custom…", hints, "Temporary membership") with the selected entry. custom_max_age / custom_max_uses parse the custom inputs as clampNumber.
  • Send to a friend: SendToFriend { user_id } sends the link with SendMessage to the DM (opened with OpenDm first, not selected) or, when the id is a group DM's channel id, to that group (the original keys group rows by channel id). A failure shows "Something went wrong" / "Couldn't send invite. Try again." and the row can be tried again.
  • invites::can_invite(&App, channel_id) (CREATE_INSTANT_INVITE) and invites::invite_channel(&App, guild_id) (getInvitableChannelId: the open text/voice/announcement channel if invitable, else the first in sidebar order) for the menus of Task 17/18.
  • Create or join a community: AddGuild(..) actions and invites::add_guild(&App) -> AddGuildModel (landing / create / join with the original's strings). Name ≤ 100 chars, submit disabled when blank; static icon only (check_group_icon: no GIF/APNG, ≤ 10 MiB) with "Animated icons are not supported…" / "Icon file is too large. Choose a file smaller than 10MB."; CreateGuild { name, icon }; the answer closes the modal and the guild's system_channel_id is selected once its GUILD_CREATE is in (either order). Join: code from link_code, else the raw text, through 16a's accept flow; the modal closes once joined, 16a's error modals on refusal.
  • Leave community: LeaveGuild { guild_id, confirmed } does nothing for the owner or a non-member (invites::can_leave_guild); otherwise Confirm::LeaveGuild (no Shift bypass), then DELETE /users/@me/guilds/{id} with delete_messages: false (spec §13, §17 Q11). GuildLeft removes the guild at once through a follow-up GUILD_DELETE (as chat::dms does with CHANNEL_DELETE), so a selected guild goes to the DMs; toast "Left community"; failure "Failed to leave community" / "Couldn't leave right now. Try again in a moment.". Strings as LEAVE_COMMUNITY_TITLE / LEAVE_COMMUNITY_BODY for Task 33.

Tests

  • New crates/fluxer-core/tests/guild_membership.rs: invite_modal_defaults_7_days_no_limit, custom_expiry_bounds, send_to_friend_sends_link_in_dm, add_guild_create_and_join, leave_guild_owner_hidden_and_confirm, leave_guild_selected_goes_to_dms, create_selects_system_channel (seen failing first, commit b5ee094). Fixtures reused, all server-shaped: rest/invite_metadata.json, rest/guild.json, gateway/guild_create.json.
  • tests/dailyuse_ports.rs: the invite/add-guild/leave actions and GuildLeft are no longer listed as stubs.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No UI or desktop tests involved.

Deviations from the plan

  • crates/fluxer-core/src/guilds.rs is not modified: removing a left guild goes through the existing GUILD_DELETE handling of every domain (follow-up event), and "select after create" lives with the add-guild state in invites.rs. app.rs gets two lines (the channels in InviteCtx, &mut chat.confirm for the leave confirm).
  • Which invite modal view is shown ("Edit invite link" / "Cancel") and the friends search text are left to the UI's own state: InviteAction has no variants for them (Task 11a's ports). The model gives both views and InviteRecipient::matches(query).
  • Leave and send failures reuse 16a's single error-modal slot (InviteError::LeaveFailed, SendFailed, shown through invite_accept_modal(..).error).
  • Not built: vanity invite URLs (the guild model has no vanity_url_code), the "account tier" prompt, the guidelines note (the original shows it only on hosted instances), the random join placeholder (a fixed sample code).
  • invite_channel returns the first invitable channel in sidebar order, which (as in the original's getChannelsInChannelListOrder) puts channels without a category first.

Closes #502

🤖 Generated with Claude Code

Stacked on: dailyuse-16a-core-invite-links ## What this builds (spec §3.6, plan Task 16b) All in `fluxer-core` (`invites.rs`, wired in `app.rs`): - **Invite modal** (`InviteModal.tsx`): `InviteAction::Create { channel_id }` opens it and creates the default invite `{max_age: 604800, max_uses: 0, temporary: false}`; a channel the user may not invite to shows the original's "unavailable" modal. `Configure` ("Create new link") replaces the link with the settings clamped to 604800 s / 100 uses; `Copy` writes `{endpoints.invite}/{code}` to the clipboard (the original suppresses the toast). `invites::invite_modal(&App) -> InviteModalModel`: title "Invite friends to {guild}", "Recipients will be taken to", paused warning, recipients (friends with a DM in DM-list order, group DMs, other friends, as `useRecipientItems`), "Invite" → "Sent" with a sending flag, link + "expires in" text (largest whole unit, as `getExpirationText`), and the settings view's lists ("Expire after", "Max number of uses", "Custom…", hints, "Temporary membership") with the selected entry. `custom_max_age` / `custom_max_uses` parse the custom inputs as `clampNumber`. - **Send to a friend**: `SendToFriend { user_id }` sends the link with `SendMessage` to the DM (opened with `OpenDm` first, not selected) or, when the id is a group DM's channel id, to that group (the original keys group rows by channel id). A failure shows "Something went wrong" / "Couldn't send invite. Try again." and the row can be tried again. - `invites::can_invite(&App, channel_id)` (`CREATE_INSTANT_INVITE`) and `invites::invite_channel(&App, guild_id)` (`getInvitableChannelId`: the open text/voice/announcement channel if invitable, else the first in sidebar order) for the menus of Task 17/18. - **Create or join a community**: `AddGuild(..)` actions and `invites::add_guild(&App) -> AddGuildModel` (landing / create / join with the original's strings). Name ≤ 100 chars, submit disabled when blank; static icon only (`check_group_icon`: no GIF/APNG, ≤ 10 MiB) with "Animated icons are not supported…" / "Icon file is too large. Choose a file smaller than 10MB."; `CreateGuild { name, icon }`; the answer closes the modal and the guild's `system_channel_id` is selected once its `GUILD_CREATE` is in (either order). Join: code from `link_code`, else the raw text, through 16a's accept flow; the modal closes once joined, 16a's error modals on refusal. - **Leave community**: `LeaveGuild { guild_id, confirmed }` does nothing for the owner or a non-member (`invites::can_leave_guild`); otherwise `Confirm::LeaveGuild` (no Shift bypass), then `DELETE /users/@me/guilds/{id}` with `delete_messages: false` (spec §13, §17 Q11). `GuildLeft` removes the guild at once through a follow-up `GUILD_DELETE` (as `chat::dms` does with `CHANNEL_DELETE`), so a selected guild goes to the DMs; toast "Left community"; failure "Failed to leave community" / "Couldn't leave right now. Try again in a moment.". Strings as `LEAVE_COMMUNITY_TITLE` / `LEAVE_COMMUNITY_BODY` for Task 33. ## Tests - New `crates/fluxer-core/tests/guild_membership.rs`: `invite_modal_defaults_7_days_no_limit`, `custom_expiry_bounds`, `send_to_friend_sends_link_in_dm`, `add_guild_create_and_join`, `leave_guild_owner_hidden_and_confirm`, `leave_guild_selected_goes_to_dms`, `create_selects_system_channel` (seen failing first, commit b5ee094). Fixtures reused, all server-shaped: `rest/invite_metadata.json`, `rest/guild.json`, `gateway/guild_create.json`. - `tests/dailyuse_ports.rs`: the invite/add-guild/leave actions and `GuildLeft` are no longer listed as stubs. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No UI or desktop tests involved. ## Deviations from the plan - `crates/fluxer-core/src/guilds.rs` is not modified: removing a left guild goes through the existing `GUILD_DELETE` handling of every domain (follow-up event), and "select after create" lives with the add-guild state in `invites.rs`. `app.rs` gets two lines (the channels in `InviteCtx`, `&mut chat.confirm` for the leave confirm). - Which invite modal view is shown ("Edit invite link" / "Cancel") and the friends search text are left to the UI's own state: `InviteAction` has no variants for them (Task 11a's ports). The model gives both views and `InviteRecipient::matches(query)`. - Leave and send failures reuse 16a's single error-modal slot (`InviteError::LeaveFailed`, `SendFailed`, shown through `invite_accept_modal(..).error`). - Not built: vanity invite URLs (the guild model has no `vanity_url_code`), the "account tier" prompt, the guidelines note (the original shows it only on hosted instances), the random join placeholder (a fixed sample code). - `invite_channel` returns the first invitable channel in sidebar order, which (as in the original's `getChannelsInChannelListOrder`) puts channels without a category first. Closes #502 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Uses the existing server-shaped fixtures: rest/invite_metadata.json
(POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the
metadata fields), rest/guild.json (POST /guilds, GuildResponse) and
gateway/guild_create.json.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The invite modal (default invite at open, settings clamped to the
server's limits, link, expiry text, friends and group DMs with
Invite -> Sent through SendMessage), can_invite / invite_channel for the
menus, "Create or join a community" (name, static icon, create then
select the system channel once its GUILD_CREATE is in, join through the
accept flow), and "Leave community" (Confirm::LeaveGuild, no Shift
bypass, no delete_messages; hidden for the owner; on success the guild
goes as its GUILD_DELETE would, so a selected one leaves for the DMs).

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dailyuse_ports listed them among the stubs that do nothing.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Daily use 16b (diff 995e64a..18ca551)

Checks

  1. Plan tests: all 7 are in crates/fluxer-core/tests/guild_membership.rs (invite_modal_defaults_7_days_no_limit, custom_expiry_bounds, send_to_friend_sends_link_in_dm, add_guild_create_and_join, leave_guild_owner_hidden_and_confirm, leave_guild_selected_goes_to_dms, create_selects_system_channel). They assert the spec's values: {max_age: 604800, max_uses: 0, temporary: false}, the expiry and uses lists, clamping to 604800 and 100, {endpoints.invite}/{code}, Invite → Sent, owner hidden, the confirm strings, delete_messages: false, and DMs after leaving the selected guild.
  2. Interfaces: invite_modal(&App) -> InviteModalModel, invites::can_invite(&App, channel) -> bool, add_guild(&App) -> AddGuildModel, LeaveGuild with Confirm::LeaveGuild (no Shift bypass, no delete-messages switch), and guild create → GUILD_CREATE → system_channel_id all exist as written. The extra invite_channel and can_leave_guild are useful for Tasks 17 and 18.
  3. Invariants: fluxer-core does no I/O and imports no forbidden crates. There are no new fixtures. Server data cannot panic the client here: clamp_number slices only after an ASCII sign byte, and parse overflow saturates. No secrets are added. Toasts reuse the existing toast: Option<String> pattern. Not touching guilds.rs is acceptable: a follow-up GUILD_DELETE reuses the existing cleanup in guilds.rs, ui.rs and channels.rs, and the test shows a later real GUILD_DELETE changes nothing more.
  4. Parity spot-checks against the fork, all match: InviteModal.tsx (option lists, strings, getExpirationText largest-whole-unit rule, clampNumber, "Something went wrong" / "Couldn't send invite. Try again."); InviteUtils.getInvitableChannelId (the guild's selected channel if it is text-based and invitable, else the first invitable channel); useLeaveGuild.tsx (title, body, toast, error strings); LimitConstants.ts (MAX_INVITE_USES 100, MAX_INVITE_AGE_SECONDS 604800); GuildJoinForm.tsx (findInvite(...) ?? raw, maxLength 100); GuildCreateForm.tsx (selects system_channel_id); RecipientList.useRecipientItems (DM friends, then group DMs, then other friends). The server accepts a non-numeric nonce like i<digits> (MessageNonceRequest is a 1–32 character string).
  5. Review Focus 5 (leave community confirms without a Shift bypass): met. UserAction::LeaveGuild has no shift path, and confirmed: false always sets Confirm::LeaveGuild.
  6. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree passed (exit 0).

Findings

  • minor: an InviteCreated answer is not matched to its request. If the user picks "Create new link" while the first invite is still being created, the earlier answer shows its link and clears creating, and the newer answer replaces it later. A SendToFriend in between sends the older (still valid) link. Matching on the EffectId, or ignoring answers while a newer request is out, would fix it.
  • minor: the original's useRecipientItems keeps the recipient order from when the modal opened (initialOrderRef). Here the rows are rebuilt from dm_list every time, so sending a link (which moves that DM to the top), or opening a DM for a friend who had none, reorders the list under the cursor.
  • minor: Join from "Join a community" with an invite whose type is neither guild nor group DM (the _ branch of accept_resolved) leaves add_guild.joining set. The button then shows its spinner and stays disabled until the modal is closed.
  • minor: a send failure with a known failure code shows the generic error. The original shows showDmActionErrorModal in that case (InviteModal.tsx, failureCode(error)). This could be a parity row or a follow-up.

Verdict: approve. No blocking findings, and local ci is green.

## Independent review: Daily use 16b (diff 995e64a..18ca551) **Checks** 1. Plan tests: all 7 are in `crates/fluxer-core/tests/guild_membership.rs` (`invite_modal_defaults_7_days_no_limit`, `custom_expiry_bounds`, `send_to_friend_sends_link_in_dm`, `add_guild_create_and_join`, `leave_guild_owner_hidden_and_confirm`, `leave_guild_selected_goes_to_dms`, `create_selects_system_channel`). They assert the spec's values: `{max_age: 604800, max_uses: 0, temporary: false}`, the expiry and uses lists, clamping to 604800 and 100, `{endpoints.invite}/{code}`, Invite → Sent, owner hidden, the confirm strings, `delete_messages: false`, and DMs after leaving the selected guild. 2. Interfaces: `invite_modal(&App) -> InviteModalModel`, `invites::can_invite(&App, channel) -> bool`, `add_guild(&App) -> AddGuildModel`, `LeaveGuild` with `Confirm::LeaveGuild` (no Shift bypass, no delete-messages switch), and guild create → `GUILD_CREATE` → `system_channel_id` all exist as written. The extra `invite_channel` and `can_leave_guild` are useful for Tasks 17 and 18. 3. Invariants: fluxer-core does no I/O and imports no forbidden crates. There are no new fixtures. Server data cannot panic the client here: `clamp_number` slices only after an ASCII sign byte, and parse overflow saturates. No secrets are added. Toasts reuse the existing `toast: Option<String>` pattern. Not touching `guilds.rs` is acceptable: a follow-up `GUILD_DELETE` reuses the existing cleanup in `guilds.rs`, `ui.rs` and `channels.rs`, and the test shows a later real `GUILD_DELETE` changes nothing more. 4. Parity spot-checks against the fork, all match: `InviteModal.tsx` (option lists, strings, `getExpirationText` largest-whole-unit rule, `clampNumber`, "Something went wrong" / "Couldn't send invite. Try again."); `InviteUtils.getInvitableChannelId` (the guild's selected channel if it is text-based and invitable, else the first invitable channel); `useLeaveGuild.tsx` (title, body, toast, error strings); `LimitConstants.ts` (`MAX_INVITE_USES` 100, `MAX_INVITE_AGE_SECONDS` 604800); `GuildJoinForm.tsx` (`findInvite(...) ?? raw`, maxLength 100); `GuildCreateForm.tsx` (selects `system_channel_id`); `RecipientList.useRecipientItems` (DM friends, then group DMs, then other friends). The server accepts a non-numeric nonce like `i<digits>` (`MessageNonceRequest` is a 1–32 character string). 5. Review Focus 5 (leave community confirms without a Shift bypass): met. `UserAction::LeaveGuild` has no shift path, and `confirmed: false` always sets `Confirm::LeaveGuild`. 6. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree passed (exit 0). **Findings** - minor: an `InviteCreated` answer is not matched to its request. If the user picks "Create new link" while the first invite is still being created, the earlier answer shows its link and clears `creating`, and the newer answer replaces it later. A `SendToFriend` in between sends the older (still valid) link. Matching on the `EffectId`, or ignoring answers while a newer request is out, would fix it. - minor: the original's `useRecipientItems` keeps the recipient order from when the modal opened (`initialOrderRef`). Here the rows are rebuilt from `dm_list` every time, so sending a link (which moves that DM to the top), or opening a DM for a friend who had none, reorders the list under the cursor. - minor: Join from "Join a community" with an invite whose type is neither guild nor group DM (the `_` branch of `accept_resolved`) leaves `add_guild.joining` set. The button then shows its spinner and stays disabled until the modal is closed. - minor: a send failure with a known failure code shows the generic error. The original shows `showDmActionErrorModal` in that case (`InviteModal.tsx`, `failureCode(error)`). This could be a parity row or a follow-up. Verdict: **approve**. No blocking findings, and local ci is green.
Author
Owner

Independent review: Daily use 16b (head 18ca551)

I reviewed git diff 995e64a..origin/dailyuse-16b-core-create-invites-guilds from scratch.

Plan tests: all 7 are in crates/fluxer-core/tests/guild_membership.rs and use the spec values: the default {max_age: 604800, max_uses: 0, temporary: false}; the original's "Expire after" and "Max uses" lists; clamping at 604800 and 100; the link {endpoints.invite}/{code}; send then Sent; the DM opened without being selected; create and join; the owner sees no leave item; the confirm with no Shift bypass and delete_messages: false; DMs selected after leaving; system_channel_id selected in both arrival orders.

Interfaces: invite_modal(&App) -> InviteModalModel, invites::can_invite(&App, channel) -> bool, add_guild(&App) -> AddGuildModel, LeaveGuild through Confirm::LeaveGuild, and the create-then-select flow all exist. Task 11a's UserAction, ApiRequest and ApiResult types are reused, not duplicated.

Invariants: fluxer-core has no new dependency and does no I/O. There are no new fixtures (existing ones are reused). There are no secrets or real paths. Panics: clamp_number slices only after an ASCII byte, and file_size cannot overflow. The send nonce is i<u64>, 21 characters at most, which is within the server's MessageNonceRequest limit of 1 to 32 characters.

Parity spot checks against the fork:

  • InviteModal.tsx: option lists, default invite on open, clampNumber, getExpirationText (it uses the selected maxAge, as here), and the send error "Something went wrong" / "Couldn't send invite. Try again." from CommonMessageDescriptors.ts:727. All match.
  • useLeaveGuild.tsx: the strings, the toast, the error modal, and going to DMs only when the guild was selected. All match.
  • GuildCreateForm.tsx:58-60: pop, then selectChannel(guild.id, system_channel_id). Matches; here it waits for GUILD_CREATE.

Review Focus 5: leave community confirms with no Shift bypass. Verified.

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci passed (exit 0). livekit-interop was skipped.

Findings

  • minor: an InviteCreated answer is not matched to the effect that asked for it. If an older answer arrives after "Create new link", the older link replaces the newer one.
  • minor: add_guild.joining stays set when the joined invite is neither a guild nor a group DM, so the Join button stays disabled.
  • minor: a send failure that has a failure code shows the generic error. The original shows showDmActionErrorModal for it.
  • minor: invites.toast is never cleared. A second "Left community" leaves the value unchanged, so a UI that shows the toast on change misses it. Other modules use the same pattern.
  • minor: the recipient order is rebuilt on every change instead of being kept from when the modal opened.

These are non-blocking. File each one as a follow-up issue before merge.

Verdict: APPROVE. No blocking findings, and CI is green locally.

## Independent review: Daily use 16b (head 18ca551) I reviewed `git diff 995e64a..origin/dailyuse-16b-core-create-invites-guilds` from scratch. **Plan tests:** all 7 are in `crates/fluxer-core/tests/guild_membership.rs` and use the spec values: the default `{max_age: 604800, max_uses: 0, temporary: false}`; the original's "Expire after" and "Max uses" lists; clamping at 604800 and 100; the link `{endpoints.invite}/{code}`; send then Sent; the DM opened without being selected; create and join; the owner sees no leave item; the confirm with no Shift bypass and `delete_messages: false`; DMs selected after leaving; `system_channel_id` selected in both arrival orders. **Interfaces:** `invite_modal(&App) -> InviteModalModel`, `invites::can_invite(&App, channel) -> bool`, `add_guild(&App) -> AddGuildModel`, `LeaveGuild` through `Confirm::LeaveGuild`, and the create-then-select flow all exist. Task 11a's `UserAction`, `ApiRequest` and `ApiResult` types are reused, not duplicated. **Invariants:** fluxer-core has no new dependency and does no I/O. There are no new fixtures (existing ones are reused). There are no secrets or real paths. Panics: `clamp_number` slices only after an ASCII byte, and `file_size` cannot overflow. The send nonce is `i<u64>`, 21 characters at most, which is within the server's `MessageNonceRequest` limit of 1 to 32 characters. **Parity spot checks against the fork:** - `InviteModal.tsx`: option lists, default invite on open, `clampNumber`, `getExpirationText` (it uses the selected maxAge, as here), and the send error "Something went wrong" / "Couldn't send invite. Try again." from `CommonMessageDescriptors.ts:727`. All match. - `useLeaveGuild.tsx`: the strings, the toast, the error modal, and going to DMs only when the guild was selected. All match. - `GuildCreateForm.tsx:58-60`: pop, then `selectChannel(guild.id, system_channel_id)`. Matches; here it waits for `GUILD_CREATE`. **Review Focus 5:** leave community confirms with no Shift bypass. Verified. **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` passed (exit 0). livekit-interop was skipped. ### Findings - minor: an `InviteCreated` answer is not matched to the effect that asked for it. If an older answer arrives after "Create new link", the older link replaces the newer one. - minor: `add_guild.joining` stays set when the joined invite is neither a guild nor a group DM, so the Join button stays disabled. - minor: a send failure that has a failure code shows the generic error. The original shows `showDmActionErrorModal` for it. - minor: `invites.toast` is never cleared. A second "Left community" leaves the value unchanged, so a UI that shows the toast on change misses it. Other modules use the same pattern. - minor: the recipient order is rebuilt on every change instead of being kept from when the modal opened. These are non-blocking. File each one as a `follow-up` issue before merge. **Verdict: APPROVE.** No blocking findings, and CI is green locally.
Author
Owner

Merged into dailyuse at f7972c3 (combined merge of 23 Daily use tasks plus textchat).

Merged into `dailyuse` at f7972c3 (combined merge of 23 Daily use tasks plus `textchat`).
charles closed this pull request 2026-11-15 06:08:51 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.