Daily use 16a: core invite links: detection, cards, accept (#501) #560

Closed
charles wants to merge 0 commits from dailyuse-16a-core-invite-links into dailyuse
Owner

What

Daily use 16a (spec §3.6): invite links in fluxer-core.

  • invites::invite_codes(content, &Endpoints) / link_code(url, &Endpoints): the original's findInvites (CodeLinkUtils.ts, InviteUtils.ts) over the discovery endpoints.invite base and {webapp host}/invite; optional scheme and /#, case-insensitive host/path, code 2-32 [a-zA-Z0-9-] not followed by another, <...>-wrapped skipped, deduped, max 10, code spans/blocks skipped (extractEmbeddableCodeLinkContent). Hand-written matcher (no regex dependency).
  • Cache with one GET /invites/{code} per code (InviteAction::Resolve, OpenModal, Accept).
  • invites::cards(&App, channel_id, message_id) -> Vec<InviteCardModel>: Loading / Unknown ("Unknown invite", "Try asking for a new invite.", disabled "Invite unavailable") / Guild ("{n} online", "{n} members", "Join community" / "Go to community" / disabled "Invites disabled" + paused or raid notice) / Group ("Unnamed group" or names, inviter, "Join group" / disabled "Already joined", local member count).
  • Accept flow as acceptAndTransitionToChannel (InviteCommands.tsx:219-289): fetch when not cached; group DM -> POST then select the DM; member -> select the channel; else POST then select the channel (guild root for category/link channels), via follow-up events. visits_enabled joins instead of Preview (spec §13, §17 Q11).
  • invite_accept_modal(&App) -> InviteAcceptModel { modal, error }: header variants, "Join community" / "Join group DM" / "Go to community" / "Invites paused" + notice, "Invite not found"; errors -> InviteError modals with the original's strings (banned, IP banned, gateway required, adults only, invites paused/raid, 403 feature disabled, at capacity, too many communities with max_guilds, generic "Couldn't join community"); no modal when no HTTP answer, as the original. 404/UNKNOWN_INVITE marks the code Failed.
  • chat::links: an invite link of the instance no longer opens the browser or the external-link warning; the invites reducer opens the accept modal.

Tests

crates/fluxer-core/tests/invites.rs: codes_found_in_content_table, one_get_per_code, card_states, visits_enabled_joins_instead_of_preview, accept_flow_branches, accept_errors_to_modals, accept_modal_states, invite_link_click_opens_modal_not_warning, proptest arbitrary_content_never_panics. Fixtures: existing fixtures/rest/invite_guild.json, invite_group_dm.json (Daily use 2). FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No desktop tests apply.

Deviations / notes for review

  • invite_codes takes &Endpoints instead of &WellKnown: the store keeps only the discovery document's endpoints (Session::endpoints). The official fluxer.app/fluxer.gg bases of non-self-hosted builds are not included (their codes belong to another instance; the plan names only the invite endpoint and the webapp host).
  • invite_accept_modal also carries the error modal (InviteAcceptModel.error), since the card button joins without the accept modal. InviteAction::Close closes the error first, then the accept modal (16b extends it for the invite modal).
  • Outside the Files list (minimal): app.rs passes an InviteCtx { session, guilds } to Invites::reduce and applies Invites::take_follow_ups; tests/dailyuse_ports.rs drops Resolve/Accept/OpenModal and ApiResult::InviteAccepted from its "not implemented yet" lists.
  • Not built: adults-only pre-check (the invite guild has no nsfw field in proto), account-limited and account-tier modals (ACCOUNT_LIMITED shows the generic error), spoiler wrapping of cards, live presence counts for member guilds (member count comes from the store). GUILD_VISIT_AGE_RESTRICTED is a local constant in invites.rs (not in fluxer_proto::errors).

Stacked on: dailyuse-11b-core-state-skeleton

Closes #501

🤖 Generated with Claude Code

## What Daily use 16a (spec §3.6): invite links in `fluxer-core`. - `invites::invite_codes(content, &Endpoints)` / `link_code(url, &Endpoints)`: the original's `findInvites` (`CodeLinkUtils.ts`, `InviteUtils.ts`) over the discovery `endpoints.invite` base and `{webapp host}/invite`; optional scheme and `/#`, case-insensitive host/path, code 2-32 `[a-zA-Z0-9-]` not followed by another, `<...>`-wrapped skipped, deduped, max 10, code spans/blocks skipped (`extractEmbeddableCodeLinkContent`). Hand-written matcher (no regex dependency). - Cache with one `GET /invites/{code}` per code (`InviteAction::Resolve`, `OpenModal`, `Accept`). - `invites::cards(&App, channel_id, message_id) -> Vec<InviteCardModel>`: Loading / Unknown ("Unknown invite", "Try asking for a new invite.", disabled "Invite unavailable") / Guild ("{n} online", "{n} members", "Join community" / "Go to community" / disabled "Invites disabled" + paused or raid notice) / Group ("Unnamed group" or names, inviter, "Join group" / disabled "Already joined", local member count). - Accept flow as `acceptAndTransitionToChannel` (`InviteCommands.tsx:219-289`): fetch when not cached; group DM -> POST then select the DM; member -> select the channel; else POST then select the channel (guild root for category/link channels), via follow-up events. `visits_enabled` joins instead of Preview (spec §13, §17 Q11). - `invite_accept_modal(&App) -> InviteAcceptModel { modal, error }`: header variants, "Join community" / "Join group DM" / "Go to community" / "Invites paused" + notice, "Invite not found"; errors -> `InviteError` modals with the original's strings (banned, IP banned, gateway required, adults only, invites paused/raid, 403 feature disabled, at capacity, too many communities with `max_guilds`, generic "Couldn't join community"); no modal when no HTTP answer, as the original. 404/`UNKNOWN_INVITE` marks the code Failed. - `chat::links`: an invite link of the instance no longer opens the browser or the external-link warning; the invites reducer opens the accept modal. ## Tests `crates/fluxer-core/tests/invites.rs`: `codes_found_in_content_table`, `one_get_per_code`, `card_states`, `visits_enabled_joins_instead_of_preview`, `accept_flow_branches`, `accept_errors_to_modals`, `accept_modal_states`, `invite_link_click_opens_modal_not_warning`, proptest `arbitrary_content_never_panics`. Fixtures: existing `fixtures/rest/invite_guild.json`, `invite_group_dm.json` (Daily use 2). `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No desktop tests apply. ## Deviations / notes for review - `invite_codes` takes `&Endpoints` instead of `&WellKnown`: the store keeps only the discovery document's endpoints (`Session::endpoints`). The official `fluxer.app`/`fluxer.gg` bases of non-self-hosted builds are not included (their codes belong to another instance; the plan names only the invite endpoint and the webapp host). - `invite_accept_modal` also carries the error modal (`InviteAcceptModel.error`), since the card button joins without the accept modal. `InviteAction::Close` closes the error first, then the accept modal (16b extends it for the invite modal). - Outside the Files list (minimal): `app.rs` passes an `InviteCtx { session, guilds }` to `Invites::reduce` and applies `Invites::take_follow_ups`; `tests/dailyuse_ports.rs` drops `Resolve`/`Accept`/`OpenModal` and `ApiResult::InviteAccepted` from its "not implemented yet" lists. - Not built: adults-only pre-check (the invite guild has no `nsfw` field in proto), account-limited and account-tier modals (`ACCOUNT_LIMITED` shows the generic error), spoiler wrapping of cards, live presence counts for member guilds (member count comes from the store). `GUILD_VISIT_AGE_RESTRICTED` is a local constant in `invites.rs` (not in `fluxer_proto::errors`). Stacked on: dailyuse-11b-core-state-skeleton Closes #501 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Reviewed git diff a1a50d02..origin/dailyuse-16a-core-invite-links (995e64a) cold.

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: all steps passed (exit 0).

Checks

  1. Plan tests: all seven named tests are in crates/fluxer-core/tests/invites.rs: codes_found_in_content_table, one_get_per_code, card_states, visits_enabled_joins_instead_of_preview, accept_flow_branches, accept_errors_to_modals, invite_link_click_opens_modal_not_warning. There are also accept_modal_states and a proptest. The table test covers the instance host, /invite/, /#/, <…>, 11 codes giving 10, case, 2–32 length bounds and code spans. The expected strings match the spec and the fork.
  2. Interfaces: cards(&App, channel_id, message_id) -> Vec<InviteCardModel> and invite_accept_modal(&App) -> InviteAcceptModel exist as the plan writes them. The accept flow branches, the error modal mapping and the visits_enabled join (labelled "Join community") are present. invite_codes takes &Endpoints, not &WellKnown (see finding 1).
  3. Invariants: fluxer-core gains no iced, wgpu, winit, reqwest or tokio-tungstenite dependency and does no I/O. There are no new fixtures (the tests use the existing invite_guild.json and invite_group_dm.json). Invite codes are logged only at debug level, and nothing secret is logged. Server data cannot panic the client: an unknown InviteType or a guild invite without a guild gives an Unknown card and no POST, counts are saturated, and find_codes stays on byte and char boundaries (the proptest covers this).
  4. Parity spot checks against the fork, all matching:
    • CodeLinkUtils.ts createPattern and findCodeMatches: bases sorted longest first, optional https?://, (?:/#)? between host and path, code [a-zA-Z0-9-]{2,32} not followed by another such character, case-insensitive, exact-case dedup, limit counted on pushed codes.
    • isLinkWrappedInAngleBrackets (LinkSuppressionUtils.ts:3-11).
    • InviteCommands.tsx showGuildInviteAcceptFailure: same order (INVITES_DISABLED with raid, then 403 FEATURE_TEMPORARILY_DISABLED, MAX_GUILD_MEMBERS, MAX_GUILDS, TEMPORARY_INVITE_REQUIRES_PRESENCE, GUILD_VISIT_AGE_RESTRICTED, banned, IP banned, then any status ≥400 as the generic modal, and nothing when there is no status). removeInviteIfMissing (404 or UNKNOWN_INVITE) and inviteTargetChannelId (category or link channel → guild root) also match.
    • Strings: InviteEmbed.tsx (card raid notice and paused notice, "Invites disabled", "Unknown invite" and the rest), InvitesDisabledModal.tsx, InviteMessageDescriptors.ts (RAID_INVITES_PAUSED_SHORT and INVITES_PAUSED_TRY_AGAIN, which InviteAcceptModal.tsx:254-255 uses), GuildAtCapacityModal, FeatureTemporarilyDisabledModal, MaxGuildsModal (one/other plural).
    • When Accept finds the code in a failed state, it fetches again. This matches Invites.fetchInvite, which only reuses cached.data.
  5. Review Focus 7 ("invite answers for unknown guilds"): covered as described in check 3.

Findings

  1. minor: invite_codes(content, &Endpoints) instead of the plan's &WellKnown. Spec §6.2 says invite_codes(content, endpoints), and the store keeps only Session::endpoints, so this is acceptable. Tasks 16b and 34a must call it with &Endpoints (or use link_code).
  2. minor: without_code approximates extractEmbeddableCodeLinkContent. The original parses markdown and also drops escaped <…> links, mentions and emoji, and keeps markdown link URLs. The approximation removes the code spans and blocks that the test table covers. Unclosed or uneven fences can still differ from the original in edge cases.
  3. minor (follow-up): spoilered invites are not built. The original's findInvites still finds codes inside ||…|| and the card renders masked (findSpoileredInvites). Here such a code gets a normal, unmasked card. This needs a follow-up issue before 34a ships cards.
  4. minor (follow-up): expired invites are not filtered. Invites.fetchInvite runs filterAlive and turns an invite whose expires_at has passed into an error. The native cache keeps it as Resolved, so the card shows Join until the POST fails.
  5. minor (follow-up): not built, as documented: the ACCOUNT_LIMITED modal and the account-tier prompt (the generic modal shows instead), the adults-only pre-check, and live presence counts. Each should get a follow-up issue.
  6. minor: GUILD_VISIT_AGE_RESTRICTED and ACCOUNT_LIMITED are local consts in fluxer-core::invites rather than fluxer_proto::errors. This is fine for now, but a later proto task should move them, following "reuse before adding".

No blocking findings.

Verdict: APPROVED. CI is green locally, there are no blocking findings, and findings 3–5 should become follow-up issues.

## Independent review: Daily use 16a (core invite links) Reviewed `git diff a1a50d02..origin/dailyuse-16a-core-invite-links` (995e64a) cold. **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: **all steps passed** (exit 0). ### Checks 1. **Plan tests**: all seven named tests are in `crates/fluxer-core/tests/invites.rs`: `codes_found_in_content_table`, `one_get_per_code`, `card_states`, `visits_enabled_joins_instead_of_preview`, `accept_flow_branches`, `accept_errors_to_modals`, `invite_link_click_opens_modal_not_warning`. There are also `accept_modal_states` and a proptest. The table test covers the instance host, `/invite/`, `/#/`, `<…>`, 11 codes giving 10, case, 2–32 length bounds and code spans. The expected strings match the spec and the fork. 2. **Interfaces**: `cards(&App, channel_id, message_id) -> Vec<InviteCardModel>` and `invite_accept_modal(&App) -> InviteAcceptModel` exist as the plan writes them. The accept flow branches, the error modal mapping and the visits_enabled join (labelled "Join community") are present. `invite_codes` takes `&Endpoints`, not `&WellKnown` (see finding 1). 3. **Invariants**: fluxer-core gains no iced, wgpu, winit, reqwest or tokio-tungstenite dependency and does no I/O. There are no new fixtures (the tests use the existing `invite_guild.json` and `invite_group_dm.json`). Invite codes are logged only at debug level, and nothing secret is logged. Server data cannot panic the client: an unknown `InviteType` or a guild invite without a `guild` gives an Unknown card and no POST, counts are saturated, and `find_codes` stays on byte and char boundaries (the proptest covers this). 4. **Parity spot checks against the fork**, all matching: - `CodeLinkUtils.ts` `createPattern` and `findCodeMatches`: bases sorted longest first, optional `https?://`, `(?:/#)?` between host and path, code `[a-zA-Z0-9-]{2,32}` not followed by another such character, case-insensitive, exact-case dedup, limit counted on pushed codes. - `isLinkWrappedInAngleBrackets` (`LinkSuppressionUtils.ts:3-11`). - `InviteCommands.tsx` `showGuildInviteAcceptFailure`: same order (`INVITES_DISABLED` with raid, then 403 `FEATURE_TEMPORARILY_DISABLED`, `MAX_GUILD_MEMBERS`, `MAX_GUILDS`, `TEMPORARY_INVITE_REQUIRES_PRESENCE`, `GUILD_VISIT_AGE_RESTRICTED`, banned, IP banned, then any status ≥400 as the generic modal, and nothing when there is no status). `removeInviteIfMissing` (404 or `UNKNOWN_INVITE`) and `inviteTargetChannelId` (category or link channel → guild root) also match. - Strings: `InviteEmbed.tsx` (card raid notice and paused notice, "Invites disabled", "Unknown invite" and the rest), `InvitesDisabledModal.tsx`, `InviteMessageDescriptors.ts` (`RAID_INVITES_PAUSED_SHORT` and `INVITES_PAUSED_TRY_AGAIN`, which `InviteAcceptModal.tsx:254-255` uses), `GuildAtCapacityModal`, `FeatureTemporarilyDisabledModal`, `MaxGuildsModal` (one/other plural). - When Accept finds the code in a failed state, it fetches again. This matches `Invites.fetchInvite`, which only reuses `cached.data`. 5. **Review Focus 7** ("invite answers for unknown guilds"): covered as described in check 3. ### Findings 1. **minor**: `invite_codes(content, &Endpoints)` instead of the plan's `&WellKnown`. Spec §6.2 says `invite_codes(content, endpoints)`, and the store keeps only `Session::endpoints`, so this is acceptable. Tasks 16b and 34a must call it with `&Endpoints` (or use `link_code`). 2. **minor**: `without_code` approximates `extractEmbeddableCodeLinkContent`. The original parses markdown and also drops escaped `<…>` links, mentions and emoji, and keeps markdown link URLs. The approximation removes the code spans and blocks that the test table covers. Unclosed or uneven fences can still differ from the original in edge cases. 3. **minor** (follow-up): spoilered invites are not built. The original's `findInvites` still finds codes inside `||…||` and the card renders masked (`findSpoileredInvites`). Here such a code gets a normal, unmasked card. This needs a follow-up issue before 34a ships cards. 4. **minor** (follow-up): expired invites are not filtered. `Invites.fetchInvite` runs `filterAlive` and turns an invite whose `expires_at` has passed into an error. The native cache keeps it as Resolved, so the card shows Join until the POST fails. 5. **minor** (follow-up): not built, as documented: the `ACCOUNT_LIMITED` modal and the account-tier prompt (the generic modal shows instead), the adults-only pre-check, and live presence counts. Each should get a `follow-up` issue. 6. **minor**: `GUILD_VISIT_AGE_RESTRICTED` and `ACCOUNT_LIMITED` are local consts in `fluxer-core::invites` rather than `fluxer_proto::errors`. This is fine for now, but a later proto task should move them, following "reuse before adding". No blocking findings. **Verdict: APPROVED.** CI is green locally, there are no blocking findings, and findings 3–5 should become follow-up issues.
Author
Owner

Scope: git diff a1a50d0..origin/dailyuse-16a-core-invite-links (invites.rs, chat/links.rs, app.rs, README, tests/invites.rs, tests/dailyuse_ports.rs).

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh worktree (du-review-16a) passed: all steps, exit 0.

Checks

  1. Plan tests: all seven are present and assert the spec's values. They are codes_found_in_content_table (instance host, /invite/, <…>, 11 → 10, case, /#, code length 2–32), one_get_per_code, card_states, visits_enabled_joins_instead_of_preview, accept_flow_branches, accept_errors_to_modals and invite_link_click_opens_modal_not_warning. There are also accept_modal_states and a no-panic proptest.
  2. Interfaces: cards(&App, channel_id, message_id) -> Vec<InviteCardModel> and invite_accept_modal(&App) -> InviteAcceptModel are as written. invite_codes takes &Endpoints, not &WellKnown (see finding 1).
  3. Invariants: fluxer-core does no I/O and has no forbidden imports. The parser does byte slicing only on ASCII boundaries or checked boundaries, and the proptest covers arbitrary content. Invite codes are logged only at debug level (spec §12). No fixtures were added, and the existing invite_guild.json and invite_group_dm.json are reused.
  4. Parity, spot-checked against the fork:
    • CodeLinkUtils.findCodeMatches: the limit counts deduplicated matches, <> is skipped, and the pattern is not anchored. This matches.
    • InviteCommands.showGuildInviteAcceptFailure: the error order, the 403-only FEATURE_TEMPORARILY_DISABLED, and "nothing shown without a status" all match.
    • acceptAndTransitionToChannel: group DM → POST + open; member → open; category or link → guild root. This matches.
    • Strings checked in InviteEmbed.tsx:90,94, MaxGuildsModal.tsx, GuildAtCapacityModal.tsx, FeatureTemporarilyDisabledModal.tsx and the "potential raid in this community" text of the modal. They match.
  5. Review Focus 7 (no panic on server invite data): an unknown invite type and a guild invite with no guild both give an Unknown card and no accept request. A malformed max_guilds limit falls back to 200.

Findings

  1. minor: invite_codes(content, &Endpoints) instead of the plan's &WellKnown. This matches spec §6.2 ("invite_codes(content, endpoints)") and the store only keeps Endpoints. Tasks 16b, 22c and 34a must call it with &app.session.endpoints.
  2. minor (follow-up): Spoilered invites (findSpoileredCodeMatches / masked cards) are not handled, so a card inside ||…|| shows unmasked. The spec does not require this; it needs a follow-up issue.
  3. minor (follow-up): The online count on a member's card is invite.presence_count. The original uses live counts (InviteEmbed.tsx:285 liveCounts?.onlineCount ?? …). Not built: the account-limited and account-tier modals (ACCOUNT_LIMITED falls back to the generic modal) and filtering out expired invites.
  4. minor: without_code only approximates extractEmbeddableCodeLinkContent, which runs the markdown parser. Escaped backticks, and code inside other markdown, can differ. GUILD_VISIT_AGE_RESTRICTED and ACCOUNT_LIMITED are local consts, not in fluxer_proto::errors.
  5. minor (process): The deferred items in 2 and 3 have no follow-up issues linked from this PR yet. CLAUDE.md requires them before merge.

None of these break an interface, violate an invariant, lose data, leak a secret or contradict the behaviour the spec requires.

Verdict: APPROVED (0 blocking, 5 minor; CI green locally).

## Independent review: Daily use 16a (core invite links), at 995e64a Scope: `git diff a1a50d0..origin/dailyuse-16a-core-invite-links` (invites.rs, chat/links.rs, app.rs, README, tests/invites.rs, tests/dailyuse_ports.rs). **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh worktree (`du-review-16a`) passed: all steps, exit 0. **Checks** 1. Plan tests: all seven are present and assert the spec's values. They are `codes_found_in_content_table` (instance host, `/invite/`, `<…>`, 11 → 10, case, `/#`, code length 2–32), `one_get_per_code`, `card_states`, `visits_enabled_joins_instead_of_preview`, `accept_flow_branches`, `accept_errors_to_modals` and `invite_link_click_opens_modal_not_warning`. There are also `accept_modal_states` and a no-panic proptest. 2. Interfaces: `cards(&App, channel_id, message_id) -> Vec<InviteCardModel>` and `invite_accept_modal(&App) -> InviteAcceptModel` are as written. `invite_codes` takes `&Endpoints`, not `&WellKnown` (see finding 1). 3. Invariants: fluxer-core does no I/O and has no forbidden imports. The parser does byte slicing only on ASCII boundaries or checked boundaries, and the proptest covers arbitrary content. Invite codes are logged only at debug level (spec §12). No fixtures were added, and the existing `invite_guild.json` and `invite_group_dm.json` are reused. 4. Parity, spot-checked against the fork: - `CodeLinkUtils.findCodeMatches`: the limit counts deduplicated matches, `<>` is skipped, and the pattern is not anchored. This matches. - `InviteCommands.showGuildInviteAcceptFailure`: the error order, the 403-only `FEATURE_TEMPORARILY_DISABLED`, and "nothing shown without a status" all match. - `acceptAndTransitionToChannel`: group DM → POST + open; member → open; category or link → guild root. This matches. - Strings checked in `InviteEmbed.tsx:90,94`, `MaxGuildsModal.tsx`, `GuildAtCapacityModal.tsx`, `FeatureTemporarilyDisabledModal.tsx` and the "potential raid in this community" text of the modal. They match. 5. Review Focus 7 (no panic on server invite data): an unknown invite type and a guild invite with no guild both give an `Unknown` card and no accept request. A malformed `max_guilds` limit falls back to 200. **Findings** 1. *minor*: `invite_codes(content, &Endpoints)` instead of the plan's `&WellKnown`. This matches spec §6.2 ("`invite_codes(content, endpoints)`") and the store only keeps `Endpoints`. Tasks 16b, 22c and 34a must call it with `&app.session.endpoints`. 2. *minor (follow-up)*: Spoilered invites (`findSpoileredCodeMatches` / masked cards) are not handled, so a card inside `||…||` shows unmasked. The spec does not require this; it needs a follow-up issue. 3. *minor (follow-up)*: The online count on a member's card is `invite.presence_count`. The original uses live counts (`InviteEmbed.tsx:285` `liveCounts?.onlineCount ?? …`). Not built: the account-limited and account-tier modals (`ACCOUNT_LIMITED` falls back to the generic modal) and filtering out expired invites. 4. *minor*: `without_code` only approximates `extractEmbeddableCodeLinkContent`, which runs the markdown parser. Escaped backticks, and code inside other markdown, can differ. `GUILD_VISIT_AGE_RESTRICTED` and `ACCOUNT_LIMITED` are local consts, not in `fluxer_proto::errors`. 5. *minor (process)*: The deferred items in 2 and 3 have no `follow-up` issues linked from this PR yet. CLAUDE.md requires them before merge. None of these break an interface, violate an invariant, lose data, leak a secret or contradict the behaviour the spec requires. **Verdict: APPROVED** (0 blocking, 5 minor; CI green locally).
Author
Owner

Merged into dailyuse at f7972c3 (combined merge of 23 Daily use tasks plus textchat).

Merged into `dailyuse` at f7972c3 (combined merge of 23 Daily use tasks plus `textchat`).
charles closed this pull request 2026-11-15 06:08:55 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.