Daily use 16a: core invite links: detection, cards, accept (#501) #560
Closed
charles
wants to merge 0 commits from
dailyuse-16a-core-invite-links into dailyuse
pull from: dailyuse-16a-core-invite-links
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!560
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-16a-core-invite-links"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Daily use 16a (spec §3.6): invite links in
fluxer-core.invites::invite_codes(content, &Endpoints)/link_code(url, &Endpoints): the original'sfindInvites(CodeLinkUtils.ts,InviteUtils.ts) over the discoveryendpoints.invitebase and{webapp host}/invite; optional scheme and/#, case-insensitive host/path, code 2-32[a-zA-Z0-9-]not followed by another,<...>-wrapped skipped, deduped, max 10, code spans/blocks skipped (extractEmbeddableCodeLinkContent). Hand-written matcher (no regex dependency).GET /invites/{code}per code (InviteAction::Resolve,OpenModal,Accept).invites::cards(&App, channel_id, message_id) -> Vec<InviteCardModel>: Loading / Unknown ("Unknown invite", "Try asking for a new invite.", disabled "Invite unavailable") / Guild ("{n} online", "{n} members", "Join community" / "Go to community" / disabled "Invites disabled" + paused or raid notice) / Group ("Unnamed group" or names, inviter, "Join group" / disabled "Already joined", local member count).acceptAndTransitionToChannel(InviteCommands.tsx:219-289): fetch when not cached; group DM -> POST then select the DM; member -> select the channel; else POST then select the channel (guild root for category/link channels), via follow-up events.visits_enabledjoins instead of Preview (spec §13, §17 Q11).invite_accept_modal(&App) -> InviteAcceptModel { modal, error }: header variants, "Join community" / "Join group DM" / "Go to community" / "Invites paused" + notice, "Invite not found"; errors ->InviteErrormodals with the original's strings (banned, IP banned, gateway required, adults only, invites paused/raid, 403 feature disabled, at capacity, too many communities withmax_guilds, generic "Couldn't join community"); no modal when no HTTP answer, as the original. 404/UNKNOWN_INVITEmarks the code Failed.chat::links: an invite link of the instance no longer opens the browser or the external-link warning; the invites reducer opens the accept modal.Tests
crates/fluxer-core/tests/invites.rs:codes_found_in_content_table,one_get_per_code,card_states,visits_enabled_joins_instead_of_preview,accept_flow_branches,accept_errors_to_modals,accept_modal_states,invite_link_click_opens_modal_not_warning, proptestarbitrary_content_never_panics. Fixtures: existingfixtures/rest/invite_guild.json,invite_group_dm.json(Daily use 2).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No desktop tests apply.Deviations / notes for review
invite_codestakes&Endpointsinstead of&WellKnown: the store keeps only the discovery document's endpoints (Session::endpoints). The officialfluxer.app/fluxer.ggbases of non-self-hosted builds are not included (their codes belong to another instance; the plan names only the invite endpoint and the webapp host).invite_accept_modalalso carries the error modal (InviteAcceptModel.error), since the card button joins without the accept modal.InviteAction::Closecloses the error first, then the accept modal (16b extends it for the invite modal).app.rspasses anInviteCtx { session, guilds }toInvites::reduceand appliesInvites::take_follow_ups;tests/dailyuse_ports.rsdropsResolve/Accept/OpenModalandApiResult::InviteAcceptedfrom its "not implemented yet" lists.nsfwfield in proto), account-limited and account-tier modals (ACCOUNT_LIMITEDshows the generic error), spoiler wrapping of cards, live presence counts for member guilds (member count comes from the store).GUILD_VISIT_AGE_RESTRICTEDis a local constant ininvites.rs(not influxer_proto::errors).Stacked on: dailyuse-11b-core-state-skeleton
Closes #501
🤖 Generated with Claude Code
Independent review: Daily use 16a (core invite links)
Reviewed
git diff a1a50d02..origin/dailyuse-16a-core-invite-links(995e64a) cold.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed (exit 0).Checks
crates/fluxer-core/tests/invites.rs:codes_found_in_content_table,one_get_per_code,card_states,visits_enabled_joins_instead_of_preview,accept_flow_branches,accept_errors_to_modals,invite_link_click_opens_modal_not_warning. There are alsoaccept_modal_statesand a proptest. The table test covers the instance host,/invite/,/#/,<…>, 11 codes giving 10, case, 2–32 length bounds and code spans. The expected strings match the spec and the fork.cards(&App, channel_id, message_id) -> Vec<InviteCardModel>andinvite_accept_modal(&App) -> InviteAcceptModelexist as the plan writes them. The accept flow branches, the error modal mapping and the visits_enabled join (labelled "Join community") are present.invite_codestakes&Endpoints, not&WellKnown(see finding 1).invite_guild.jsonandinvite_group_dm.json). Invite codes are logged only at debug level, and nothing secret is logged. Server data cannot panic the client: an unknownInviteTypeor a guild invite without aguildgives an Unknown card and no POST, counts are saturated, andfind_codesstays on byte and char boundaries (the proptest covers this).CodeLinkUtils.tscreatePatternandfindCodeMatches: bases sorted longest first, optionalhttps?://,(?:/#)?between host and path, code[a-zA-Z0-9-]{2,32}not followed by another such character, case-insensitive, exact-case dedup, limit counted on pushed codes.isLinkWrappedInAngleBrackets(LinkSuppressionUtils.ts:3-11).InviteCommands.tsxshowGuildInviteAcceptFailure: same order (INVITES_DISABLEDwith raid, then 403FEATURE_TEMPORARILY_DISABLED,MAX_GUILD_MEMBERS,MAX_GUILDS,TEMPORARY_INVITE_REQUIRES_PRESENCE,GUILD_VISIT_AGE_RESTRICTED, banned, IP banned, then any status ≥400 as the generic modal, and nothing when there is no status).removeInviteIfMissing(404 orUNKNOWN_INVITE) andinviteTargetChannelId(category or link channel → guild root) also match.InviteEmbed.tsx(card raid notice and paused notice, "Invites disabled", "Unknown invite" and the rest),InvitesDisabledModal.tsx,InviteMessageDescriptors.ts(RAID_INVITES_PAUSED_SHORTandINVITES_PAUSED_TRY_AGAIN, whichInviteAcceptModal.tsx:254-255uses),GuildAtCapacityModal,FeatureTemporarilyDisabledModal,MaxGuildsModal(one/other plural).Invites.fetchInvite, which only reusescached.data.Findings
invite_codes(content, &Endpoints)instead of the plan's&WellKnown. Spec §6.2 saysinvite_codes(content, endpoints), and the store keeps onlySession::endpoints, so this is acceptable. Tasks 16b and 34a must call it with&Endpoints(or uselink_code).without_codeapproximatesextractEmbeddableCodeLinkContent. The original parses markdown and also drops escaped<…>links, mentions and emoji, and keeps markdown link URLs. The approximation removes the code spans and blocks that the test table covers. Unclosed or uneven fences can still differ from the original in edge cases.findInvitesstill finds codes inside||…||and the card renders masked (findSpoileredInvites). Here such a code gets a normal, unmasked card. This needs a follow-up issue before 34a ships cards.Invites.fetchInviterunsfilterAliveand turns an invite whoseexpires_athas passed into an error. The native cache keeps it as Resolved, so the card shows Join until the POST fails.ACCOUNT_LIMITEDmodal and the account-tier prompt (the generic modal shows instead), the adults-only pre-check, and live presence counts. Each should get afollow-upissue.GUILD_VISIT_AGE_RESTRICTEDandACCOUNT_LIMITEDare local consts influxer-core::invitesrather thanfluxer_proto::errors. This is fine for now, but a later proto task should move them, following "reuse before adding".No blocking findings.
Verdict: APPROVED. CI is green locally, there are no blocking findings, and findings 3–5 should become follow-up issues.
Independent review: Daily use 16a (core invite links), at
995e64aScope:
git diff a1a50d0..origin/dailyuse-16a-core-invite-links(invites.rs, chat/links.rs, app.rs, README, tests/invites.rs, tests/dailyuse_ports.rs).Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh worktree (du-review-16a) passed: all steps, exit 0.Checks
codes_found_in_content_table(instance host,/invite/,<…>, 11 → 10, case,/#, code length 2–32),one_get_per_code,card_states,visits_enabled_joins_instead_of_preview,accept_flow_branches,accept_errors_to_modalsandinvite_link_click_opens_modal_not_warning. There are alsoaccept_modal_statesand a no-panic proptest.cards(&App, channel_id, message_id) -> Vec<InviteCardModel>andinvite_accept_modal(&App) -> InviteAcceptModelare as written.invite_codestakes&Endpoints, not&WellKnown(see finding 1).invite_guild.jsonandinvite_group_dm.jsonare reused.CodeLinkUtils.findCodeMatches: the limit counts deduplicated matches,<>is skipped, and the pattern is not anchored. This matches.InviteCommands.showGuildInviteAcceptFailure: the error order, the 403-onlyFEATURE_TEMPORARILY_DISABLED, and "nothing shown without a status" all match.acceptAndTransitionToChannel: group DM → POST + open; member → open; category or link → guild root. This matches.InviteEmbed.tsx:90,94,MaxGuildsModal.tsx,GuildAtCapacityModal.tsx,FeatureTemporarilyDisabledModal.tsxand the "potential raid in this community" text of the modal. They match.Unknowncard and no accept request. A malformedmax_guildslimit falls back to 200.Findings
invite_codes(content, &Endpoints)instead of the plan's&WellKnown. This matches spec §6.2 ("invite_codes(content, endpoints)") and the store only keepsEndpoints. Tasks 16b, 22c and 34a must call it with&app.session.endpoints.findSpoileredCodeMatches/ masked cards) are not handled, so a card inside||…||shows unmasked. The spec does not require this; it needs a follow-up issue.invite.presence_count. The original uses live counts (InviteEmbed.tsx:285liveCounts?.onlineCount ?? …). Not built: the account-limited and account-tier modals (ACCOUNT_LIMITEDfalls back to the generic modal) and filtering out expired invites.without_codeonly approximatesextractEmbeddableCodeLinkContent, which runs the markdown parser. Escaped backticks, and code inside other markdown, can differ.GUILD_VISIT_AGE_RESTRICTEDandACCOUNT_LIMITEDare local consts, not influxer_proto::errors.follow-upissues linked from this PR yet. CLAUDE.md requires them before merge.None of these break an interface, violate an invariant, lose data, leak a secret or contradict the behaviour the spec requires.
Verdict: APPROVED (0 blocking, 5 minor; CI green locally).
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed