Daily use 12: core-notification-settings-mutes (#497) #557
Closed
charles
wants to merge 0 commits from
dailyuse-12-core-notification-settings-mutes into dailyuse
pull from: dailyuse-12-core-notification-settings-mutes
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!557
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-12-core-notification-settings-mutes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-11b-core-state-skeleton
What
fluxer-corenotification settings and mutes (plan Task 12; spec §3.2 mute submenu, §3.4, §6.2 "Mute state").notif_settings::NotifSettingsfollowsREADY,USER_GUILD_SETTINGS_UPDATEandApiResult::GuildSettingsPatched; each replaces the scope's entry whole, and changes that haven't been sent yet are applied on top. Mutes whoseend_timehas passed are dropped as they arrive (sanitizeGuildMute/sanitizeChannelMutes). Every mute still running gets anEffect::Schedulethat unmutes it locally when it ends and writes nothing back. A timer for a mute that was replaced in the meantime does nothing.UserAction::Mute/Unmuteare written at once. A guild sends only{muted, mute_config}. A channel, category or DM sends the wholechannel_overridesmap, withnullwhen the map is empty; DMs go to the@mescope.mute_configis{selected_time_window: ms, end_time}, ornullfor "Until I turn it back on" (§17 Q10).UserAction::SetGuildNotifications(the modal) shows each change at once. The changes are merged and sent 3 s after the last one. An immediate write takes any waiting changes with it, aspersistImmediatelydoes.OverrideChange::Adddoes nothing when an override already exists;RemoveOverridedrops the entry from the map.is_muted: the channel's override, its parent's or its guild's; for a DM, its@meoverride.muted_until: the target's own mute.level: channel, then parent (guild channels only), then guild/@me. INHERIT and NULL are skipped; the default is ALL_MESSAGES.guild_settings_modal(&App, guild) -> Option<NotifModalModel>: the original's labels, a picker with categories first, and the override rows sorted by position then id, with resolved columns and "No category".muted_text: "Muted until 11/14/2026, 6:15 PM" (en-USgetFormattedDateTimein the system offset) or "Muted".menus::mute::item: when not muted, a "Mute …" submenu of the nine durations ("For 15 minutes" … "Until I turn it back on"), and clicking the row itself mutes until turned back on. When muted, one "Unmute …" row with the hint.Tests
crates/fluxer-core/tests/notif_settings.rscontains every test the plan names, plusguild_settings_modal_rowsandconverge_example. It also has a proptest,writes_and_events_converge_to_server_state, that runs against a server model where scalars are partial and the override map is replaced.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally. I ran no desktop tests (none apply).Deviations
end_timeand expiry needs one. I addednotif_settings::Clock { System, Fixed(Timestamp) }, which readsSystemTime, withNotifSettings::set_clockfor tests. No new dependency. Daily use 14 (status expiry) could reuse it.app.rsnow passes&self.channelstoNotifSettings::reduce, because it needs the channel → guild mapping.tests/dailyuse_ports.rs: the 11b stub assertions now skip Mute, Unmute and SetGuildNotifications.GuildSettingsPatchedis only asserted not to write, and the mute row is now expected to have 9 items.default_message_notifications. The nativeGuildmodel has no such field, so the fallback is ALL_MESSAGES, as the plan says. Follow-up: #558.guild_settings_modalreturnsOption<NotifModalModel>(the plan's interface saysNotifModalModel): it isNonefor a guild the store does not know. Task 30 (the modal view) must handleNone, e.g. by not opening the modal.GuildSettingsPatchedcarries no request id, so an answer retires the oldest write in flight for that scope. With two writes in flight, the first answer briefly hides the second write's optimistic change until its own answer arrives (transient; follow-up #559).Closes #497
🤖 Generated with Claude Code
Independent review: Daily use 12 (diff a1a50d0..b9a14eb)
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: green (exit 0).What I checked: every plan-named test exists in
crates/fluxer-core/tests/notif_settings.rsand asserts the spec values (900 000 ms / 18:15 end for 15 min,{"muted":false,"mute_config":null}, the whole override map with untouched overrides byte-equal,@mescope, null config for Forever, no write on expiry, 3 s debounce with merge, revert, the nine labels). Review Focus 1 (wholechannel_overridesmap) holds and is tested. No new fixtures, no I/O or forbidden crates in fluxer-core. Parity spot checks against the fork, all matching:MuteOptions.tscreateMuteConfig(ms plus ISO end),UserGuildSettingsCommands.tsscheduleUpdate(an immediate write takes the waiting payload with it; a failure is only logged, so not adding a toast is right and spec §6.2's "error toast" does not exist),UserGuildSettings.ts:355-435(isMutedAtAnyLevel,resolveEffectiveMessageNotifications),GuildNotificationSettingsModal.tsx:282-305,470-623(sort by position then id, unknown channels skipped, INHERIT rows show the guild level),MuteTargetMenuItem.tsx(the parent row mutes indefinitely).Findings
notif_settings.rsformat_date_timecallsat.as_offset_date_time().to_offset(offset).time0.3 panics when the shifted date falls outside year 9999, andTimestampaccepts any end up to9999-12-31T23:59:59.999Z. Example: a muteend_timeof9999-12-31T23:30:00Z(sent by the server or another client) with a positiveutc_offset. The mute stays active (end > now), somenus::mute::item(and Task 30's tooltip) callsmuted_text, and that panics. I confirmed theto_offsetpanic with a throwaway test. Everything else in the codebase useschecked_to_offset(offset).unwrap_or(utc)(selectors/messages.rs:94,message_row.rs:273). Fix: do the same, and add a test with a year-9999end_timeand offset +01:00.guild_settings_modal(&App, guild) -> NotifModalModel, but the code returnsOption<NotifModalModel>(Nonefor an unknown guild). The choice is reasonable, and Task 30 builds against the code. Please note this in the PR body so Task 30 doesn't follow the plan's signature.guild.effectiveMessageNotifications(Guild.ts:408-416: the guild'sdefault_message_notifications, or ONLY_MENTIONS for large guilds). The spec and plan both say ALL_MESSAGES, so this isn't blocking here. But the protoGuilddropsdefault_message_notifications, so Task 13's notifications will over-notify in guilds whose default is mentions-only. Suggest afollow-upissue (proto field plus fallback).event_replaces_guild_settingshasassert!(!is_muted(&app, STAFF) || stored(..).muted), which is always true because the fixture guild is muted. It checks nothing. Replace it withmuted_until(Channel(STAFF)) == None.GuildSettingsPatchedretires the oldest in-flight write of its scope and replaces the shown settings. With two writes in flight, the first answer briefly hides the second write's change until its own answer arrives. This is transient and the proptest shows convergence. Noting it only.Verdict: changes requested. One blocking finding (1); CI green.
Review round 1 addressed in
44794a8.format_date_timepanic. It now useschecked_to_offset(offset).unwrap_or(utc), like the rest of the codebase. The new unit testnotif_settings::tests::format_date_time_past_year_9999_does_not_panicfailed first with "local datetime out of valid range". It covers an end of 9999-12-31T23:30Z read at +02:00, which falls back to UTC, and at -02:00.guild_settings_modalreturnsOption. The PR body now says so under Deviations, for Task 30: it returnsNonefor an unknown guild.default_message_notificationsand large-guild ONLY_MENTIONS, then the fallback. It is linked from the PR body.event_replaces_guild_settings. It now asserts that the stored guild entry no longer has the local STAFF override.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally.🤖 Generated with Claude Code
Independent review (round 2): Daily use 12 (diff a1a50d0..44794a8)
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree (du-review-12, its own target dir): green (exit 0, "all steps passed").What I checked:
crates/fluxer-core/tests/notif_settings.rsand assert the spec's values: 15 min =selected_time_window900 000 andend_time18:15Z; a guild mute sends only{muted, mute_config}; the whole override map is sent with the untouched overrides byte-equal; DMs go to@me; Forever sendsmute_config: nulland no timer; an expiry writes nothing and a stale timer is a no-op; expired mutes are dropped on READY; channel → category → guild inheritance with INHERIT/NULL skipped; the event and the answer replace the entry; a 3 s debounce with merge, and an immediate write that takes the pending changes; failure reverts; the nine labels, the row-click Forever, and the "Muted until 11/14/2026, 6:15 PM" / "Muted" hints. The proptestwrites_and_events_converge_to_server_stateruns against a server model that replaces the map whole.format_date_timenow useschecked_to_offset(offset).unwrap_or(utc), and the unit test covers 9999-12-31T23:30Z at ±02:00. Theevent_replaces_guild_settingsassertion is no longer always true. #558 and #559 exist (labelfollow-up, milestone Daily use) and are linked from the body.MuteTarget/MuteDurationwrites,is_muted,muted_until,levelandmenus::mute::item(&App, MuteTarget, &str) -> MenuItemmatch the plan.guild_settings_modalreturnsOption<NotifModalModel>, and the PR body records that for Task 30.unread_badges/flags(the map comes from the stored entry). The far-futureend_time→Effect::Schedulepath is safe:tokio::time::sleepclamps it. No secrets.MuteOptions.tscreateMuteConfig;TimeWindowPresets.ts:82-139and the "For {n} hour(s)" strings;OverlayContextMenu.tsx:163-174getMutedText;MuteTargetMenuItem.tsx(parent row = indefinite); the own-levelisMutedofChannelMenuItems.tsx:181,CategoryMenuItems.tsx:23andGuildMenuItems.tsx:39;UserGuildSettings.ts:356-435(isMutedAtAnyLevel,resolveEffectiveMessageNotifications); theGuildNotificationSettingsModal.tsx:258-281handlers (Add is a no-op when the override exists; the override mute sends{muted}only).channel_overridesmap, never clobbered) holds and is tested.Findings
collapsed: trueand is debounced rather than immediate (CategoryMenuItems.tsx:26-36, nopersistImmediately). The native client mutes the category at once and leaves it expanded. Spec §3.2 doesn't mention the collapse, so this doesn't block here. I suggest afollow-upissue, perhaps folded into Task 17, which owns collapsing.isWholeGuildMuted(null)also treats a top-levelmutedin the@mescope as muting every DM (UserGuildSettings.ts:356-358, 401-407). The nativeis_mutedfor a DM reads only the DM's override. No UI surface sets the@metop-level mute, so the practical impact is nil. Worth a line in #558 or its own follow-up.notif_settings::Clock::Systemis the first wall-clock read in fluxer-core. It isn't I/O, and tests fix it withset_clock. Task 14 (status expiry, "today at 14:30") should reuse it rather than add a second clock.Verdict: approve. No blocking findings, and the local CI is green.
🤖 Generated with Claude Code
Independent review, round 3: Daily use 12 (
44794a8)I read the diff
a1a50d0..44794a8without relying on the earlier reviews.Tests (plan Step 1): all 12 named tests exist and assert what the plan says, with the spec's values: 900 000 / 3 600 000 ms windows, ISO
end_time, the wholechannel_overridesmap (4 entries, the others sent unchanged),{muted, mute_config}only for a guild, the@mescope for DMs,mute_config: nullfor Forever, the 3 s debounce with merging and immediate writes taking pending changes, revert on failure, the nine labels with the "Muted until 11/14/2026, 6:15 PM" and "Muted" hints, and the convergence proptest. There is also a year-9999 no-panic unit test.Interfaces:
MuteTarget,MuteDuration,GuildNotifChangeandOverrideChangeare used as Task 11a defined them.is_muted,muted_until,levelandmenus::mute::item(&App, MuteTarget, &str) -> MenuItemmatch the plan.guild_settings_modalreturnsOption<NotifModalModel>, which differs from the plan but is listed in the PR (see below).Invariants: no forbidden dependencies and no I/O in fluxer-core. No new fixtures.
ChannelOverridekeepsunread_badgesandflags, so a whole-map write does not clear them (Review Focus 1 holds for this task). Time arithmetic saturates or is checked, so server data cannot cause a panic. No secrets.Parity, checked against fluxer-soundboard:
TimeWindowPresets.tsBASE_PRESETS give 15m/30m/1h/3h/4h/8h/24h/3d/never, and "For {oneHour} hour" is singular. Matches.MuteOptions.tscreateMuteConfiguses ms andnow + valueISO. Matches.UserGuildSettings.ts:401-435:isMutedAtAnyLevelchecks guild, then parent, then channel;resolveEffectiveMessageNotificationsskips NULL/INHERIT. Matches.UserGuildSettingsCommands.tsscheduleUpdateresets a 3 s timer on each change, and an immediate write cancels the timer and flushes the merged payload. Matches.GuildNotificationSettingsModal.tsx:296-305sorts by position, then by id string. Matches.Findings (none blocking):
guild_settings_modalreturnsOption<NotifModalModel>instead ofNotifModalModel(documented). Task 30 must handleNone.notif_settings::Clock::SystemreadsSystemTime::now(). No other fluxer-core module does; they derive "now" from data. It is injectable and the tests fix it. However,fixtures/gateway/dailyuse_ready.json:705has a mute ending2026-11-14T12:02Z, so with the default clock any devserver or screenshot run from today on drops that mute on READY. Tasks 26a, 28 and 30 should setClock::Fixed(or have the runtime supply the time) wherever they rely on that mute.isMutedAtAnyLevel(null, …)also honours a top-level@memute (isWholeGuildMuted(null)). Nativeis_mutedfor DMs reads only the override. The spec's §6.2 wording allows this, but it still needs a follow-up issue, as round 2 noted.CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciat44794a8in a fresh worktree (du-review-12): all steps passed (livekit-interop skipped as usual).Verdict: APPROVED (0 blocking).
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed