Daily use 26a: fluxer-devserver dailyuse scenario: READY, settings, presence, relationships, acks (#514) #550

Closed
charles wants to merge 0 commits from dailyuse-26a-devserver-dailyuse-a into dailyuse
Owner

Stacked on: origin/dailyuse-1-proto-notification-presence, origin/dailyuse-2-proto-relationships-invites-reports

What

The first half of the dailyuse devserver scenario (Daily use spec §9), in fluxer-devserver:

  • fixtures/scenarios/dailyuse.toml (extends textchat), fixtures/gateway/dailyuse_ready.json (the text chat READY plus): user_guild_settings with #releases muted, the category "Quiet corner" muted until 2 minutes after server start ([[dailyuse.expiring_mute]] rewrites end_time at load), "Archive" collapsed, #gallery on Only mentions, and an @me scope muting the group DM; relationships of all four types (new user nova#0042 as the outgoing request); voice channel "Small room" with user_limit = 2 and grace and linus in it; #announcements stays read-only.
  • fixtures/dailyuse/history.json: #general gets three invite links (forked valid, oldparty unknown, w33kend group DM, rewritten to this server's invite endpoint), a mention of the user by linus (for Mark unread), and messages from blocked mallory.
  • fixtures/dailyuse/big_guild.json: "Big", 300 members, not selected. Large guilds (>250 members) are passive per session until op 14 active: true. Passive sessions get none of the guild's MESSAGE_CREATE or TYPING_START, but every passive_interval_ms (30 s) a member posts and they get PASSIVE_UPDATES with the changed channels (guild_passive_sync.erl, session_passive.erl).
  • guild_settings.rs: PATCH /users/@me/guilds/{id|@me}/settings. Scalars are partial and channel_overrides replaces the whole map (null clears it). Overrides are validated per ChannelOverrideSchema, a new row uses the server defaults, version is bumped, the whole object is answered and echoed as USER_GUILD_SETTINGS_UPDATE, and later READYs carry it.
  • presence.rs: every op 3 is recorded. The presence (op 3, plus status/custom_status from a settings PATCH) is published as PRESENCE_UPDATE for the user's own id to a watcher view (DevServer::presence() → PresenceWatch { ops, published, subscribe }), only when it changes. Invisible publishes as offline with no custom status. IDENTIFY's presence is applied but not recorded as an op 3. DevServer::passive_tick() plays a passive tick on demand.
  • social.rs: every relationship verb, as UserRelationshipService.ts (by tag with NO_USERS_WITH_FLUXERTAG_EXIST for #9999, DISCRIMINATOR_REQUIRED, ALREADY_FRIENDS; send/accept/block/remove/nickname with the server's errors; RELATIONSHIP_ADD/UPDATE/REMOVE{id}); POST /read-states/ack (1–100 entries, answers read_states, one MESSAGE_ACK each, legacy_ack = true → 404, dailyuse_legacy_ack.toml); DM pin/unpin with USER_PINNED_DMS_UPDATE.

Tests

crates/fluxer-devserver/tests/dailyuse.rs: ready_parses_with_proto_types, guild_settings_patch_echoes_update, override_map_replaced_whole, op3_recorded_and_echoed, relationship_verbs_emit_events, unknown_tag_error_code, passive_updates_until_active, legacy_ack_flag_404, plus dm_pin_emits_pinned_dms_update, and unit tests in guild_settings.rs and presence.rs. I committed the tests first and saw them fail (they did not compile without the new API), then made them pass. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally. I ran no display (FLUXER_DESKTOP_TESTS) tests; this task needs none.

Deviations and notes for review

  • The plan's Files list covers scenario.rs, http.rs, gateway.rs, chat.rs and lib.rs. I also added fixtures/scenarios/dailyuse_legacy_ack.toml for the legacy_ack flag, following the same pattern as textchat_presigned.toml. Read-state acks and DM pins live in social.rs, and passive sync lives in presence.rs, because the plan names no other modules.
  • The scenario's [[messages]] list replaces the one from textchat (TOML list merge), so the #general history entry is repeated.
  • A settings PATCH of status also changes the published status. That is a simplification: the real gateway takes the status from sessions and only reads "invisible" from the settings.
  • On a block, the server sends RELATIONSHIP_REMOVE only to the target. Only the user's own side is dispatched here, so the user gets just RELATIONSHIP_ADD with type 2.
  • Override flags from the client are kept; otherwise the stored flags are kept. The server only writes client flags for thread-capable viewers.
  • Bug #549, opened separately: one local CI run hit a SIGSEGV at exit of the fluxer lib test binary after all 82 tests passed. The re-run was green. It is unrelated to this change.

Closes #514

🤖 Generated with Claude Code

Stacked on: origin/dailyuse-1-proto-notification-presence, origin/dailyuse-2-proto-relationships-invites-reports ## What The first half of the `dailyuse` devserver scenario (Daily use spec §9), in `fluxer-devserver`: - `fixtures/scenarios/dailyuse.toml` (extends `textchat`), `fixtures/gateway/dailyuse_ready.json` (the text chat READY plus): `user_guild_settings` with #releases muted, the category "Quiet corner" muted until 2 minutes after server start (`[[dailyuse.expiring_mute]]` rewrites `end_time` at load), "Archive" collapsed, #gallery on Only mentions, and an `@me` scope muting the group DM; relationships of all four types (new user `nova#0042` as the outgoing request); voice channel "Small room" with `user_limit = 2` and grace and linus in it; #announcements stays read-only. - `fixtures/dailyuse/history.json`: #general gets three invite links (`forked` valid, `oldparty` unknown, `w33kend` group DM, rewritten to this server's `invite` endpoint), a mention of the user by linus (for Mark unread), and messages from blocked mallory. - `fixtures/dailyuse/big_guild.json`: "Big", 300 members, not selected. Large guilds (>250 members) are passive per session until op 14 `active: true`. Passive sessions get none of the guild's MESSAGE_CREATE or TYPING_START, but every `passive_interval_ms` (30 s) a member posts and they get `PASSIVE_UPDATES` with the changed channels (`guild_passive_sync.erl`, `session_passive.erl`). - `guild_settings.rs`: `PATCH /users/@me/guilds/{id|@me}/settings`. Scalars are partial and `channel_overrides` replaces the whole map (`null` clears it). Overrides are validated per `ChannelOverrideSchema`, a new row uses the server defaults, `version` is bumped, the whole object is answered and echoed as `USER_GUILD_SETTINGS_UPDATE`, and later READYs carry it. - `presence.rs`: every op 3 is recorded. The presence (op 3, plus `status`/`custom_status` from a settings PATCH) is published as `PRESENCE_UPDATE` for the user's own id to a watcher view (`DevServer::presence()` → `PresenceWatch { ops, published, subscribe }`), only when it changes. Invisible publishes as offline with no custom status. IDENTIFY's `presence` is applied but not recorded as an op 3. `DevServer::passive_tick()` plays a passive tick on demand. - `social.rs`: every relationship verb, as `UserRelationshipService.ts` (by tag with `NO_USERS_WITH_FLUXERTAG_EXIST` for `#9999`, `DISCRIMINATOR_REQUIRED`, `ALREADY_FRIENDS`; send/accept/block/remove/nickname with the server's errors; RELATIONSHIP_ADD/UPDATE/REMOVE{id}); `POST /read-states/ack` (1–100 entries, answers `read_states`, one `MESSAGE_ACK` each, `legacy_ack = true` → 404, `dailyuse_legacy_ack.toml`); DM pin/unpin with `USER_PINNED_DMS_UPDATE`. ## Tests `crates/fluxer-devserver/tests/dailyuse.rs`: `ready_parses_with_proto_types`, `guild_settings_patch_echoes_update`, `override_map_replaced_whole`, `op3_recorded_and_echoed`, `relationship_verbs_emit_events`, `unknown_tag_error_code`, `passive_updates_until_active`, `legacy_ack_flag_404`, plus `dm_pin_emits_pinned_dms_update`, and unit tests in `guild_settings.rs` and `presence.rs`. I committed the tests first and saw them fail (they did not compile without the new API), then made them pass. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally. I ran no display (`FLUXER_DESKTOP_TESTS`) tests; this task needs none. ## Deviations and notes for review - The plan's Files list covers `scenario.rs`, `http.rs`, `gateway.rs`, `chat.rs` and `lib.rs`. I also added `fixtures/scenarios/dailyuse_legacy_ack.toml` for the `legacy_ack` flag, following the same pattern as `textchat_presigned.toml`. Read-state acks and DM pins live in `social.rs`, and passive sync lives in `presence.rs`, because the plan names no other modules. - The scenario's `[[messages]]` list replaces the one from textchat (TOML list merge), so the #general history entry is repeated. - A settings PATCH of `status` also changes the published status. That is a simplification: the real gateway takes the status from sessions and only reads "invisible" from the settings. - On a block, the server sends RELATIONSHIP_REMOVE only to the target. Only the user's own side is dispatched here, so the user gets just RELATIONSHIP_ADD with type 2. - Override `flags` from the client are kept; otherwise the stored flags are kept. The server only writes client flags for thread-capable viewers. - Bug #549, opened separately: one local CI run hit a SIGSEGV at exit of the `fluxer` lib test binary after all 82 tests passed. The re-run was green. It is unrelated to this change. Closes #514 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Shaped like the server:
- rest/user_guild_settings.json, rest/user_guild_settings_me.json and
  gateway/user_guild_settings_update.json: UserGuildSettingsResponse,
  packages/schema/src/domains/user/UserResponseSchemas.ts:447-486, as
  fluxer_api/src/api/user/UserMappers.ts:409-466 writes it (channel_overrides an
  object keyed by channel id, null when empty; mute_config null or
  {end_time, selected_time_window}; unread_badges null; flags only when set).
  selected_time_window in ms as the client sends it
  (fluxer_app/src/features/channel/components/MuteOptions.ts:50-56; an
  indefinite mute is mute_config null).
- gateway/passive_updates.json: fluxer_gateway/src/guild/guild_passive_sync.erl:211-217
  ({guild_id, channels: {channel_id: last_message_id}, voice_states?}); voice
  states as guild_passive_sync_voice.erl:61-128 (a removed one has channel_id null).
- gateway/presence_update_custom_status.json and rest/user_settings_status.json:
  CustomStatusResponse and UserSettingsResponse, UserResponseSchemas.ts:330-336,
  :340-460, as UserMappers.ts:296-372 writes them.

Refs #486

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fork ba98441b4 sources, each fixture copied from the server's shape:
- relationship_add_by_tag.json: FriendRequestByTagRequest as the client sends it
  (fluxer_app/src/features/relationship/commands/RelationshipCommands.ts:33)
- relationship_errors.json: FluxerError.toJSON {code, message}
  (packages/errors/src/FluxerError.ts:50-56; messages from errors i18n weblate/messages.json)
- invite_guild.json, invite_group_dm.json, invite_metadata.json:
  fluxer_api/src/api/invite/InviteModel.ts:43-174 (mapInviteTo*Response), guild from
  fluxer_api/src/api/guild/GuildModel.ts:29-52, channel from ChannelMappers.ts:247-253
- invite_unknown.json: UnknownInviteError body (unknown_entities.unknown_invite)
- guild_create.json: mapGuildToGuildResponse, fluxer_api/src/api/guild/GuildModel.ts:54-80
- read_states_ack.json: ReadStateAckRequest,
  packages/schema/src/domains/channel/ChannelRequestSchemas.ts:440-452
- member_voice_patch.json: GuildMemberUpdateRequest voice fields,
  packages/schema/src/domains/guild/GuildRequestSchemas.ts:157-166
- report_flow_message.json: getReportFlowResponse / renderScreen,
  fluxer_api/src/api/report/flows/ReportFlowRegistry.ts:136-210, a trimmed walk of the
  message flow of ReportFlowScreens.ts:60-460 with the English copy of content_i18n
- report_submission.json: ReportFlowMessageSubmissionRequest,
  packages/schema/src/domains/report/ReportFlowSchemas.ts:129-149
- profile_connections.json: ConnectionResponse in the profile,
  fluxer_api/src/api/user/services/UserAccountRequestService.ts:400-441,
  fluxer_api/src/api/connection/ConnectionMappers.ts:6-15
- user_note.json, user_notes.json: UserNoteResponse / UserNotesRecordResponse,
  packages/schema/src/domains/user/UserResponseSchemas.ts:705-713
- gateway/user_note_update.json: fluxer_api/src/api/user/services/UserAccountUpdatePropagator.ts:35-42

Refs #487

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UserGuildSettings, ChannelOverride, MuteConfig (ms), MessageNotifications and
UserGuildSettingsPatch (whole channel_overrides map or null); READY
user_guild_settings, USER_GUILD_SETTINGS_UPDATE and PASSIVE_UPDATES typed;
CustomStatus replaces the raw Value in presences, member-list rows and op 3
(garbage reads as None); UserSettings status/custom status/afk/trusted
domains/hide-muted/developer-mode accessors and patch fields; Channel.user_limit.
fluxer-core's thread-to-channel literal gains user_limit: None to compile.

Refs #486

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Daily use Task 2 (Task 3 merged in): FriendRequestByTag, RelationshipPut,
RelationshipNickname and the voice-activity flags of Relationship; API error
bodies and codes (fluxer_proto::errors); InviteResponse/InviteMetadata,
ChannelInviteCreate, Endpoints::invite; GuildCreateRequest, leave queries,
MemberVoicePatch; ReadStatesAck and AckBody; the report flow, submission and
legacy report; typed connected accounts, user notes and USER_NOTE_UPDATE;
MessageReferenceRequest.attachment_ids/embed_indices (no longer Copy, so
fluxer-core's three builders and their tests clone or fill the new fields).

Refs #487

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-proto/src/gateway/events.rs
#	crates/fluxer-proto/src/models/mod.rs
#	crates/fluxer-proto/tests/models_roundtrip.rs
#	crates/fluxer-proto/tests/spec_contract.rs
Fixtures shaped like the server: user_guild_settings as
UserGuildSettingsResponse (packages/schema/src/domains/user/UserResponseSchemas.ts:447-486,
mapper fluxer_api/src/api/user/UserMappers.ts:438-466; channel_overrides keyed by channel id,
null when empty, mute_config {end_time, selected_time_window} in ms); relationships as
RelationshipResponse (UserMappers.ts:375-394); PASSIVE_UPDATES as
fluxer_gateway/src/guild/guild_passive_sync.erl:206-213 (large guild > 250 members,
passive until op 14 active, session_passive.erl:30-38).

Refs #514

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dailyuse scenario (READY with user_guild_settings, all four relationship
types, the 300-member guild Big with passive sync, a full small voice room)
and its endpoints: user guild settings PATCH (UserAccountSettingsService.ts:300-375),
presence op 3 recorded and published to a watcher, relationship verbs
(UserRelationshipService.ts), POST /read-states/ack (ReadStateService.ts:97-140)
with the legacy_ack flag, and DM pins (UserChannelService.ts:229-255).

Refs #514

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Daily use 26a (diff 13fb8ecc..e727c34)

Local gate: I ran FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree. It is green ("all steps passed"). tests/dailyuse.rs passed 9 of 9.

What I checked

  • Plan tests: all 8 exist under their plan names, plus dm_pin_emits_pinned_dms_update. Each one asserts what the plan describes:
    • the end_time of the "Quiet corner" mute is checked at about 120 s after start, with selected_time_window 900000 ms;
    • all four relationship types are in READY;
    • user_limit = 2 with grace and linus in the voice room;
    • SEND_MESSAGES is denied on #announcements;
    • Big has member_count 300;
    • the three invite codes are rewritten to this server;
    • #9999 answers NO_USERS_WITH_FLUXERTAG_EXIST with a 400;
    • legacy_ack answers 404 and the per-message ack still works.
  • Interfaces: everything in the scenario contents is present. DevServer::presence() -> PresenceWatch {ops, published, subscribe} and DevServer::passive_tick() are public and documented in the README. dailyuse_legacy_ack.toml uses table merge (scenario.rs merge), so it keeps all of [dailyuse] and only flips the flag. Task 28's legacy_ack_fallback can use it.
  • Invariants: only fluxer-devserver and fixtures are touched. No secrets, tokens, signed URLs or local paths are in the fixtures or the code. The fixture commit cites the server files and lines.
    • user_guild_settings follows the shape of UserResponseSchemas.ts:447-486: channel_overrides is keyed by channel id, mute_config is in ms, and null means empty.
    • RELATIONSHIP_REMOVE carries only {id}.
    • PASSIVE_UPDATES follows the shape of guild_passive_sync.erl:213-216.
    • Other scenarios are unaffected: no other READY fixture has a guild over 250 members, so the passive clock never starts for them.
  • Parity, checked against the fork:
    • updateGuildSettings (UserAccountSettingsService.ts:300-375): scalars are partial, the whole override map is replaced, null or an empty map gives null, and a new row starts with INHERIT, mobile_push true and version 1. Matches.
    • Levels 0..3 (UserNotificationSettingsSchema). Matches.
    • updateRelationshipType (UserRelationshipRequestService.ts:106-130): {type:2} blocks; otherwise it accepts and then opens the DM with ensureDmOpenForBothUsers. Accept sends RELATIONSHIP_UPDATE and block sends RELATIONSHIP_ADD (UserRelationshipService.ts:210-318). Matches.
    • NoUsersWithFluxertagError is a BadRequest. Matches.
    • presence_payload.erl:35-46: invisible becomes offline with a null custom_status. presence_broadcast.erl:26-40 publishes only on a change. Matches.
    • LARGE_GUILD_MEMBER_COUNT 250 with a strict >, a 30 000 ms interval, and a first sync that names every channel. Matches.
    • ReadStateAckRequest takes 1..100 entries, and the answer has the shape of ReadStateResponse. Matches.
  • Review focus item 1 (synced settings never clobbered): override_map_replaced_whole covers the whole map being replaced and null clearing it. A scalar PATCH keeps the overrides (guild_settings_patch_echoes_update).
  • social.rs pin_dm: as you asked, I checked the channel-type handling.
    • DM (1) and GROUP_DM (3) are accepted, and the constants match ChannelConstants.ts.
    • A guild channel answers 400 CHANNEL_MUST_BE_DM_OR_GROUP_DM, as UserChannelService.ts:241-243 does.
    • A DM opened during the run is found through guild_of_in, and an unknown channel answers 404.
    • This is correct.

Findings (all minor, none blocking)

  1. minor: the passive filter (gateway.rs / SessionPassive::holds_back) is narrower than session_passive.erl. It holds back only MESSAGE_CREATE and TYPING_START, so for a passive Big these still get through: MESSAGE_UPDATE (the server lets it through only with a mention), MESSAGE_DELETE, reactions and other events. The server passes a message_create when it has @everyone, @here or a role mention, or when it is the session's own message (is_session_author_event, session_passive.erl:132-134,186-200). The devserver only checks mentions and holds back the user's own message. No current test hits this, but a later client test of passive behaviour could get a false pass. Please file it as a follow-up.
  2. minor: pin_dm on a DM that is already pinned moves it to the end of pinned_dms. The server leaves the order unchanged (UserChannelRepository.ts:190-195, which returns early on existingDm).
  3. minor: an acked read state replaces the READY entry in full and sets last_pin_timestamp: null. After an ack, a later READY loses the fixture's last_pin_timestamp for #general (2026-09-28T22:18:36.568Z).
  4. minor: override flags are stored as the client sent them. The server keeps them only when the viewer is active, masked with CHANNEL_OVERRIDE_FLAG_MASK, and otherwise keeps the stored ones. This is the documented simplification and does not matter for the scenario.

The other declared simplifications are acceptable. Spec §9 asks for a settings PATCH of status to republish the presence. A block dispatching only the user's own side is fine, because there is no second account.

Verdict: APPROVED. No blocking findings and local CI is green. Findings 1 to 3 can be follow-ups.

## Independent review: Daily use 26a (diff 13fb8ecc..e727c34) **Local gate:** I ran `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree. It is green ("all steps passed"). `tests/dailyuse.rs` passed 9 of 9. **What I checked** - Plan tests: all 8 exist under their plan names, plus `dm_pin_emits_pinned_dms_update`. Each one asserts what the plan describes: - the `end_time` of the "Quiet corner" mute is checked at about 120 s after start, with `selected_time_window` 900000 ms; - all four relationship types are in READY; - `user_limit = 2` with grace and linus in the voice room; - SEND_MESSAGES is denied on #announcements; - Big has `member_count` 300; - the three invite codes are rewritten to this server; - `#9999` answers `NO_USERS_WITH_FLUXERTAG_EXIST` with a 400; - `legacy_ack` answers 404 and the per-message ack still works. - Interfaces: everything in the scenario contents is present. `DevServer::presence() -> PresenceWatch {ops, published, subscribe}` and `DevServer::passive_tick()` are public and documented in the README. `dailyuse_legacy_ack.toml` uses table merge (`scenario.rs` `merge`), so it keeps all of `[dailyuse]` and only flips the flag. Task 28's `legacy_ack_fallback` can use it. - Invariants: only `fluxer-devserver` and fixtures are touched. No secrets, tokens, signed URLs or local paths are in the fixtures or the code. The fixture commit cites the server files and lines. - `user_guild_settings` follows the shape of `UserResponseSchemas.ts:447-486`: `channel_overrides` is keyed by channel id, `mute_config` is in ms, and `null` means empty. - `RELATIONSHIP_REMOVE` carries only `{id}`. - `PASSIVE_UPDATES` follows the shape of `guild_passive_sync.erl:213-216`. - Other scenarios are unaffected: no other READY fixture has a guild over 250 members, so the passive clock never starts for them. - Parity, checked against the fork: - `updateGuildSettings` (`UserAccountSettingsService.ts:300-375`): scalars are partial, the whole override map is replaced, `null` or an empty map gives `null`, and a new row starts with INHERIT, `mobile_push` true and version 1. Matches. - Levels 0..3 (`UserNotificationSettingsSchema`). Matches. - `updateRelationshipType` (`UserRelationshipRequestService.ts:106-130`): `{type:2}` blocks; otherwise it accepts and then opens the DM with `ensureDmOpenForBothUsers`. Accept sends `RELATIONSHIP_UPDATE` and block sends `RELATIONSHIP_ADD` (`UserRelationshipService.ts:210-318`). Matches. - `NoUsersWithFluxertagError` is a BadRequest. Matches. - `presence_payload.erl:35-46`: invisible becomes offline with a null `custom_status`. `presence_broadcast.erl:26-40` publishes only on a change. Matches. - `LARGE_GUILD_MEMBER_COUNT` 250 with a strict `>`, a 30 000 ms interval, and a first sync that names every channel. Matches. - `ReadStateAckRequest` takes 1..100 entries, and the answer has the shape of `ReadStateResponse`. Matches. - Review focus item 1 (synced settings never clobbered): `override_map_replaced_whole` covers the whole map being replaced and `null` clearing it. A scalar PATCH keeps the overrides (`guild_settings_patch_echoes_update`). - `social.rs` `pin_dm`: as you asked, I checked the channel-type handling. - DM (1) and GROUP_DM (3) are accepted, and the constants match `ChannelConstants.ts`. - A guild channel answers 400 `CHANNEL_MUST_BE_DM_OR_GROUP_DM`, as `UserChannelService.ts:241-243` does. - A DM opened during the run is found through `guild_of_in`, and an unknown channel answers 404. - This is correct. **Findings** (all minor, none blocking) 1. **minor**: the passive filter (`gateway.rs` / `SessionPassive::holds_back`) is narrower than `session_passive.erl`. It holds back only `MESSAGE_CREATE` and `TYPING_START`, so for a passive Big these still get through: `MESSAGE_UPDATE` (the server lets it through only with a mention), `MESSAGE_DELETE`, reactions and other events. The server passes a `message_create` when it has `@everyone`, `@here` or a role mention, or when it is the session's own message (`is_session_author_event`, `session_passive.erl:132-134,186-200`). The devserver only checks `mentions` and holds back the user's own message. No current test hits this, but a later client test of passive behaviour could get a false pass. Please file it as a follow-up. 2. **minor**: `pin_dm` on a DM that is already pinned moves it to the end of `pinned_dms`. The server leaves the order unchanged (`UserChannelRepository.ts:190-195`, which returns early on `existingDm`). 3. **minor**: an acked read state replaces the READY entry in full and sets `last_pin_timestamp: null`. After an ack, a later READY loses the fixture's `last_pin_timestamp` for #general (`2026-09-28T22:18:36.568Z`). 4. **minor**: override `flags` are stored as the client sent them. The server keeps them only when the viewer is active, masked with `CHANNEL_OVERRIDE_FLAG_MASK`, and otherwise keeps the stored ones. This is the documented simplification and does not matter for the scenario. The other declared simplifications are acceptable. Spec §9 asks for a settings PATCH of status to republish the presence. A block dispatching only the user's own side is fine, because there is no second account. **Verdict: APPROVED.** No blocking findings and local CI is green. Findings 1 to 3 can be follow-ups.
Author
Owner

Merged into dailyuse at 863726f (combined merge of the first twelve Daily use tasks).

Merged into `dailyuse` at 863726f (combined merge of the first twelve Daily use tasks).
charles closed this pull request 2026-11-14 13:04:10 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.