Task 17: iced application shell and login screen (#17) #53

Manually merged
charles merged 0 commits from task/17-ui-shell-login into foundation 2026-11-11 18:28:13 +00:00
Owner

What this builds

  • fluxer_ui::run(snapshot: watch::Receiver<Arc<App>>, events: mpsc::Sender<CoreEvent>) -> iced::Result: the iced application. It draws the latest snapshot, sends user actions into the runtime's event queue (try_send, falling back to an awaited send when the queue is full), and exits when the snapshot channel or the queue closes. Tab / Shift+Tab move the keyboard focus; the login (or code) field is focused when its step opens.
  • UiMessage { Core, Snapshot, Login, Main, Settings, Window } and view(&App, &Local) routing by app.session.auth. Until Task 18, a logged-in session shows a placeholder (user name, connection state, "Log out").
  • screens::login: model(&App) -> LoginModel { instance, show_totp, error_text, busy, status_text }, view(&LoginModel, &Form), update(&mut Form, Message, &App) -> Vec<UserAction> emitting SetInstance (only when the instance field was edited to another URL), SubmitLogin, SubmitTotp, and Logout for "Back to sign-in". Enter submits from every field. One text per AuthError; the captcha one is the plan's sentence (login::CAPTCHA_MESSAGE, Review Focus 3).
  • widgets::button and widgets::text_input with the metrics of the web app's Button.module.css and FormInput.module.css; the card follows LoginPage.module.css, AuthLoginEmailPasswordForm.module.css and MfaScreen.module.css. Colours are tokens only.
  • apps/fluxer/src/main.rs: starts the effect runtime on its own tokio runtime and runs the window on the main thread. Closing the window, Ctrl-C or the runtime stopping all end in Handle::shutdown.

How it was tested

  • crates/fluxer-ui/tests/login_view.rs (13 tests), written first and seen failing: the two the plan names (login_view_shows_totp_field_when_awaiting_totp, login_view_shows_captcha_message) drive the real store through SubmitLogin, the well_known.json / login_mfa.json fixtures and an EffectFailed(CaptchaRequired); the rest cover every AuthError text, the busy state, the instance prefill from the loaded settings, what Submit emits (and does not emit with missing or invalid fields, or while busy), the TOTP step, and that Debug output never contains the password.
  • Manual, under Xvfb with the tiny-skia renderer: fluxer --devserver logs in as demo, "Log out" shows the login screen with the devserver's URL prefilled, logging in as mfa opens the TOTP step, 111111 shows "Invalid or expired code.", 000000 logs in and the gateway reaches ready; Ctrl-C exits with status 0.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally.

Screenshots of the native client: docs/screenshots/login.png, docs/screenshots/login-totp.png. There is no Electron side-by-side: the web app's login is a multi-step flow (instance, method, credentials) against a live instance, which this task may not touch.

Deviations from the plan

  • screens::main::Message and screens::settings::Message are empty placeholder enums declared inline in screens/mod.rs, so that UiMessage has the shape the plan gives; Tasks 18 and 22 replace them with their modules.
  • WindowEvent is not specified by the plan; it is { Focused, Unfocused, FocusNext, FocusPrevious, Close }. Close is what the snapshot stream emits when the runtime is gone.
  • LoginModel::instance comes from app.session.instance, not from app.settings: the session takes the settings' instance at the startup load and --instance / --devserver override it, so it is the URL a login really goes to.
  • Outside the Files list: apps/fluxer/Cargo.toml (+fluxer-ui), crates/fluxer-ui/Cargo.toml (+fluxer-core, tokio for the channel types of run, secrecy, url; dev: fluxer-proto, serde_json, uuid; all already workspace dependencies), both READMEs, docs/screenshots/.
  • The window opens at the saved size (or 1280x720) but window position/size is not written back: there is no UserAction for it yet.
  • The binary now needs a display; without one fluxer_ui::run fails and it exits with status 1 after shutting the runtime down.

Stacked on: task/16-ui-theme-fonts-icons, task/14-app-runtime

Closes #17

🤖 Generated with Claude Code

## What this builds - `fluxer_ui::run(snapshot: watch::Receiver<Arc<App>>, events: mpsc::Sender<CoreEvent>) -> iced::Result`: the iced application. It draws the latest snapshot, sends user actions into the runtime's event queue (`try_send`, falling back to an awaited send when the queue is full), and exits when the snapshot channel or the queue closes. Tab / Shift+Tab move the keyboard focus; the login (or code) field is focused when its step opens. - `UiMessage { Core, Snapshot, Login, Main, Settings, Window }` and `view(&App, &Local)` routing by `app.session.auth`. Until Task 18, a logged-in session shows a placeholder (user name, connection state, "Log out"). - `screens::login`: `model(&App) -> LoginModel { instance, show_totp, error_text, busy, status_text }`, `view(&LoginModel, &Form)`, `update(&mut Form, Message, &App) -> Vec<UserAction>` emitting `SetInstance` (only when the instance field was edited to another URL), `SubmitLogin`, `SubmitTotp`, and `Logout` for "Back to sign-in". Enter submits from every field. One text per `AuthError`; the captcha one is the plan's sentence (`login::CAPTCHA_MESSAGE`, Review Focus 3). - `widgets::button` and `widgets::text_input` with the metrics of the web app's `Button.module.css` and `FormInput.module.css`; the card follows `LoginPage.module.css`, `AuthLoginEmailPasswordForm.module.css` and `MfaScreen.module.css`. Colours are tokens only. - `apps/fluxer/src/main.rs`: starts the effect runtime on its own tokio runtime and runs the window on the main thread. Closing the window, Ctrl-C or the runtime stopping all end in `Handle::shutdown`. ## How it was tested - `crates/fluxer-ui/tests/login_view.rs` (13 tests), written first and seen failing: the two the plan names (`login_view_shows_totp_field_when_awaiting_totp`, `login_view_shows_captcha_message`) drive the real store through `SubmitLogin`, the `well_known.json` / `login_mfa.json` fixtures and an `EffectFailed(CaptchaRequired)`; the rest cover every `AuthError` text, the busy state, the instance prefill from the loaded settings, what `Submit` emits (and does not emit with missing or invalid fields, or while busy), the TOTP step, and that `Debug` output never contains the password. - Manual, under Xvfb with the tiny-skia renderer: `fluxer --devserver` logs in as demo, "Log out" shows the login screen with the devserver's URL prefilled, logging in as `mfa` opens the TOTP step, `111111` shows "Invalid or expired code.", `000000` logs in and the gateway reaches ready; Ctrl-C exits with status 0. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally. Screenshots of the native client: `docs/screenshots/login.png`, `docs/screenshots/login-totp.png`. There is no Electron side-by-side: the web app's login is a multi-step flow (instance, method, credentials) against a live instance, which this task may not touch. ## Deviations from the plan - `screens::main::Message` and `screens::settings::Message` are empty placeholder enums declared inline in `screens/mod.rs`, so that `UiMessage` has the shape the plan gives; Tasks 18 and 22 replace them with their modules. - `WindowEvent` is not specified by the plan; it is `{ Focused, Unfocused, FocusNext, FocusPrevious, Close }`. `Close` is what the snapshot stream emits when the runtime is gone. - `LoginModel::instance` comes from `app.session.instance`, not from `app.settings`: the session takes the settings' instance at the startup load and `--instance` / `--devserver` override it, so it is the URL a login really goes to. - Outside the Files list: `apps/fluxer/Cargo.toml` (+`fluxer-ui`), `crates/fluxer-ui/Cargo.toml` (+`fluxer-core`, `tokio` for the channel types of `run`, `secrecy`, `url`; dev: `fluxer-proto`, `serde_json`, `uuid`; all already workspace dependencies), both READMEs, `docs/screenshots/`. - The window opens at the saved size (or 1280x720) but window position/size is not written back: there is no `UserAction` for it yet. - The binary now needs a display; without one `fluxer_ui::run` fails and it exits with status 1 after shutting the runtime down. Stacked on: task/16-ui-theme-fonts-icons, task/14-app-runtime Closes #17 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(ui): generated theme tokens, fonts and icons
All checks were successful
ci / Windows (x64) (push) Successful in 22s
ci / Windows (x64) (pull_request) Successful in 15s
ci / Linux (x86_64) (push) Successful in 1m22s
ci / Linux (x86_64) (pull_request) Successful in 1m23s
64430a109d
- xtask gen-theme --fork <path>: parses the Electron app's colour system,
  globals and message-layout CSS into crates/fluxer-ui/src/theme/tokens.rs
  (hsl/hsla/rgb/hex, saturation-factor calc, var() fallbacks, color-mix in
  srgb and oklab; rem to px).
- fluxer-ui::theme: tokens (DARK), palette::Theme with iced's Base and
  widget catalogs, fonts (Fluxer Sans/Mono as TTF) and icons (Phosphor SVGs).
- Adds iced 0.14 to the workspace; deny.toml allows BSL-1.0 and CC0-1.0 and
  ignores three unmaintained-crate advisories that iced pulls in.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge origin/foundation into task/16-ui-theme-fonts-icons
All checks were successful
ci / Windows (x64) (push) Successful in 1m32s
ci / Windows (x64) (pull_request) Successful in 38s
ci / Linux (x86_64) (push) Successful in 1m28s
ci / Linux (x86_64) (pull_request) Successful in 1m34s
897ebaae93
Conflicts in xtask (both sides implemented dispatch stubs: gen-theme here,
vendor-spec/spec-check on foundation) and Cargo.lock resolved as the union.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge origin/foundation into task/16-ui-theme-fonts-icons
All checks were successful
ci / Windows (x64) (push) Successful in 44s
ci / Linux (x86_64) (push) Successful in 1m41s
ci / Windows (x64) (pull_request) Successful in 52s
ci / Linux (x86_64) (pull_request) Successful in 1m31s
301b889ef7
Mechanical conflicts: both sides added workspace dependencies (iced, futures-util)
and Cargo.lock entries.

Refs #16

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #8

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): store skeleton and session reducer
All checks were successful
ci / Windows (x64) (push) Successful in 42s
ci / Linux (x86_64) (push) Successful in 1m0s
ci / Windows (x64) (pull_request) Successful in 41s
ci / Linux (x86_64) (pull_request) Successful in 1m5s
cacedcbbf7
Refs #8

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Adds the gateway crate's dependencies (rustls, rustls-native-certs and zstd are
new to the workspace; Task 7 names tokio-tungstenite with rustls and zstd).

Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #11

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): presence, users and ui state
All checks were successful
ci / Windows (x64) (push) Successful in 39s
ci / Windows (x64) (pull_request) Successful in 39s
ci / Linux (x86_64) (push) Successful in 1m7s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
f4ce82e123
Refs #11

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(gateway): websocket transport with zstd streaming
All checks were successful
ci / Windows (x64) (push) Successful in 57s
ci / Windows (x64) (pull_request) Successful in 48s
ci / Linux (x86_64) (push) Successful in 1m3s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
e60021584a
Refs #7

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): guild and channel reducers and sidebar selectors
All checks were successful
ci / Windows (x64) (pull_request) Successful in 45s
ci / Windows (x64) (push) Successful in 43s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
ci / Linux (x86_64) (push) Successful in 1m10s
e753f32ec6
Refs #9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #10

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(core): messages, typing and read state
All checks were successful
ci / Windows (x64) (push) Successful in 44s
ci / Windows (x64) (pull_request) Successful in 44s
ci / Linux (x86_64) (push) Successful in 1m4s
ci / Linux (x86_64) (pull_request) Successful in 1m3s
38a4f01a14
Refs #10

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #13

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/src/lib.rs
#	crates/fluxer-core/src/selectors/mod.rs
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/src/lib.rs
#	crates/fluxer-core/src/selectors/mod.rs
feat(devserver): fixture-backed API and gateway for tests
All checks were successful
ci / Windows (x64) (pull_request) Successful in 1m11s
ci / Linux (x86_64) (pull_request) Successful in 1m20s
ci / Windows (x64) (push) Successful in 57s
ci / Linux (x86_64) (push) Successful in 1m10s
4c00cf12fd
Refs #13

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(platform,core): settings, keyring token and sqlite cache
Some checks failed
ci / Windows (x64) (push) Failing after 23s
ci / Linux (x86_64) (push) Failing after 56s
ci / Windows (x64) (pull_request) Failing after 13s
ci / Linux (x86_64) (pull_request) Failing after 54s
6eb27db77c
Core: PersistOp/PersistResult/LocalSettings in fluxer_core::persist, the
stored-token login (Loaded -> Discover -> Me -> ConnectGateway), cached READY
data marked App::stale until the live READY, and the CacheReady/CacheMessages/
SaveSettings writes.

Platform: Paths, settings.toml (defaults on missing, .bad on invalid), the
keyring token, the SQLite cache (rebuilt when corrupt or of another schema
version, in memory if the file is unusable) and Store, which ties them to
PersistOp for the runtime.

New dependencies: directories, keyring, rusqlite (bundled), toml, base64,
getrandom, tempfile (dev), keyring-core (dev, mock store).

Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
chore(deps): bump num-bigint 0.4.7 -> 0.4.8 (0.4.7 was yanked)
All checks were successful
ci / Windows (x64) (push) Successful in 1m2s
ci / Linux (x86_64) (push) Successful in 1m20s
ci / Windows (x64) (pull_request) Successful in 51s
ci / Linux (x86_64) (pull_request) Successful in 1m18s
6b043c3a08
cargo deny (yanked = deny) failed on both runners for run 71/72: num-bigint 0.4.7,
a transitive dependency of keyring's Secret Service store, was yanked from crates.io.
Lockfile-only patch bump; no manifest change.

Refs #12

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	Cargo.lock
# Conflicts:
#	Cargo.lock
#	Cargo.toml
Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ApiClient::with_observer shows each exchange that got a response (no
headers); Connection::connect_with_tap shows each frame received and
sent. Both are off unless asked for.

Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(app): effect runtime, config, logging and record mode
Some checks failed
ci / Windows (x64) (pull_request) Failing after 19s
ci / Windows (x64) (push) Failing after 4s
ci / Linux (x86_64) (pull_request) Successful in 1m37s
ci / Linux (x86_64) (push) Successful in 1m43s
a2ce504001
Refs #14

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ci(windows): free the build cache when the runner disk is low
All checks were successful
ci / Linux (x86_64) (push) Successful in 1m9s
ci / Windows (x64) (push) Successful in 1m33s
ci / Linux (x86_64) (pull_request) Successful in 1m12s
ci / Windows (x64) (pull_request) Successful in 1m21s
6ada26ce7e
The persistent Windows runner ran out of space on C: (os error 112). Log free
space, remove this project's own target dirs when it drops below 30 GB, and
turn off incremental compilation there. Also correct CLAUDE.md: one target dir
per worktree, and run the screenshot step locally before pushing.

Refs #51

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/ci/51-windows-disk-space' into task/14-app-runtime
All checks were successful
ci / Linux (x86_64) (push) Successful in 1m49s
ci / Windows (x64) (push) Successful in 2m59s
ci / Linux (x86_64) (pull_request) Successful in 1m53s
ci / Windows (x64) (pull_request) Successful in 2m46s
d0f3c10f86
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	deny.toml
feat(ui): iced shell and login screen
All checks were successful
ci / Linux (x86_64) (push) Successful in 2m18s
ci / Windows (x64) (push) Successful in 3m51s
ci / Linux (x86_64) (pull_request) Successful in 2m9s
ci / Windows (x64) (pull_request) Successful in 3m38s
9e1bc0a481
fluxer_ui::run shows the runtime's snapshots in an iced window and sends
what the user does back as CoreEvents; the login screen covers the
instance field, credentials, the TOTP step and one text per AuthError
(captcha included). apps/fluxer launches it in place of the headless loop.

Refs #17

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Task 17 (ui-shell-login) at 9e1bc0a

Scope: git diff 8bef1dd..origin/task/17-ui-shell-login (17 files).

1. Tests named by the plan — OK

  • login_view_shows_totp_field_when_awaiting_totp: drives the real store with login_mfa.json and asserts model.show_totp.
  • login_view_shows_captcha_message: fails the login effect with CoreError::CaptchaRequired, asserts error_text == CAPTCHA_MESSAGE, pins the constant to the plan's exact string, and asserts the form is no longer busy and not on the TOTP step.
  • 11 further tests (per-error texts, submit/SetInstance ordering, busy, secret redaction). 13/13 pass.

2. Interfaces — OK

  • fluxer_ui::run(snapshot: watch::Receiver<Arc<App>>, events: mpsc::Sender<CoreEvent>) -> iced::Result, UiMessage { Core, Snapshot, Login, Main, Settings, Window }, view(app: &App, local: &Local) -> Element<UiMessage> routing on app.session.auth, screens::login::model(&App) -> LoginModel { show_totp, error_text, .. } all exist as written. Login emits SetInstance (only when changed, before SubmitLogin), SubmitLogin, SubmitTotp; Enter submits from every field.

3. Invariants — OK

  • fluxer-ui does no I/O: tokio is used for the watch/mpsc types only (workspace features are rt-multi-thread, macros, sync, time; no net/fs). No unwrap/expect/panic! in the new non-test code. fluxer-core is untouched. No secrets: the password is held in the view-local Form, redacted in Debug for both Form and Message, cleared on LoggedIn; the only token-shaped string in the tree is the existing scrubbed fixture.

4. Review Focus 3 (captcha) — OK. Clear message, form re-enabled, no hang; covered by the test above.

5. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: all steps passed (remote runners not checked).

Findings

  • minor — apps/fluxer/src/main.rs supervise(): when the runtime stops on its own, the UI exits via WindowEvent::Close and main sends window_closed; the supervisor's select! can then see window_closed and snapshots.changed() ready together and pick the former at random, returning true (exit 0) instead of the documented exit 1. Use biased; with the changed() arm first, or re-check snapshots.has_changed().is_err() after the loop.
  • minor — crates/fluxer-ui/src/screens/login.rs Form::sync: the password stays in the form while on the TOTP step and after "Back to sign-in" (intended, mirrors the web app), but the instance field keeps the user's raw text after a successful SetInstance; harmless, noted only because LoginModel.instance is then never shown again for that window.
  • minor — no Electron side-by-side screenshot attached (CLAUDE.md asks for one on UI PRs); only docs/screenshots/login.png and login-totp.png. Window size/position is read but not persisted back (no UserAction for it); the non-captcha error wording is the implementer's own. These want a follow-up issue rather than a change here.
  • minor — screens::main::Message / screens::settings::Message are empty placeholder enums in screens/mod.rs; Tasks 18 and 22 must replace the inline modules (expected by the plan, flagged so those tasks do not add a second definition).

Verdict: APPROVE — zero blocking findings, local ci green.

## Independent review: Task 17 (ui-shell-login) at 9e1bc0a Scope: `git diff 8bef1dd..origin/task/17-ui-shell-login` (17 files). **1. Tests named by the plan** — OK - `login_view_shows_totp_field_when_awaiting_totp`: drives the real store with `login_mfa.json` and asserts `model.show_totp`. - `login_view_shows_captcha_message`: fails the login effect with `CoreError::CaptchaRequired`, asserts `error_text == CAPTCHA_MESSAGE`, pins the constant to the plan's exact string, and asserts the form is no longer busy and not on the TOTP step. - 11 further tests (per-error texts, submit/SetInstance ordering, busy, secret redaction). 13/13 pass. **2. Interfaces** — OK - `fluxer_ui::run(snapshot: watch::Receiver<Arc<App>>, events: mpsc::Sender<CoreEvent>) -> iced::Result`, `UiMessage { Core, Snapshot, Login, Main, Settings, Window }`, `view(app: &App, local: &Local) -> Element<UiMessage>` routing on `app.session.auth`, `screens::login::model(&App) -> LoginModel { show_totp, error_text, .. }` all exist as written. Login emits `SetInstance` (only when changed, before `SubmitLogin`), `SubmitLogin`, `SubmitTotp`; Enter submits from every field. **3. Invariants** — OK - `fluxer-ui` does no I/O: tokio is used for the `watch`/`mpsc` types only (workspace features are `rt-multi-thread, macros, sync, time`; no net/fs). No `unwrap`/`expect`/`panic!` in the new non-test code. `fluxer-core` is untouched. No secrets: the password is held in the view-local `Form`, redacted in `Debug` for both `Form` and `Message`, cleared on `LoggedIn`; the only token-shaped string in the tree is the existing scrubbed fixture. **4. Review Focus 3 (captcha)** — OK. Clear message, form re-enabled, no hang; covered by the test above. **5. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`** in the review worktree: all steps passed (remote runners not checked). ### Findings - **minor** — `apps/fluxer/src/main.rs` `supervise()`: when the runtime stops on its own, the UI exits via `WindowEvent::Close` and `main` sends `window_closed`; the supervisor's `select!` can then see `window_closed` and `snapshots.changed()` ready together and pick the former at random, returning `true` (exit 0) instead of the documented exit 1. Use `biased;` with the `changed()` arm first, or re-check `snapshots.has_changed().is_err()` after the loop. - **minor** — `crates/fluxer-ui/src/screens/login.rs` `Form::sync`: the password stays in the form while on the TOTP step and after "Back to sign-in" (intended, mirrors the web app), but the instance field keeps the user's raw text after a successful `SetInstance`; harmless, noted only because `LoginModel.instance` is then never shown again for that window. - **minor** — no Electron side-by-side screenshot attached (CLAUDE.md asks for one on UI PRs); only `docs/screenshots/login.png` and `login-totp.png`. Window size/position is read but not persisted back (no `UserAction` for it); the non-captcha error wording is the implementer's own. These want a `follow-up` issue rather than a change here. - **minor** — `screens::main::Message` / `screens::settings::Message` are empty placeholder enums in `screens/mod.rs`; Tasks 18 and 22 must replace the inline modules (expected by the plan, flagged so those tasks do not add a second definition). **Verdict: APPROVE** — zero blocking findings, local ci green.
charles manually merged commit 24e7c9d137 into foundation 2026-11-11 18:28:13 +00:00
Sign in to join this conversation.
No description provided.