Text chat 44: Thread view: full view, starter message, notices, browser, menu, settings, members (#329) #463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-44-ui-thread-view"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/textchat-40-core-announcements-thread-admin
What this builds (spec §18.2.5)
ThreadParentCrumbheader (parent icon + name as a button back to the parent, boldCaretRight, thread icon + name; right click = thread menu) and the buttons bell (Bell/BellSlash, member only), "Threads" (browser) and "Thread members" (popout). The guild member-list toggle is hidden in a thread.ThreadWelcomeSection: 3.5 rem disc, name 1.5 rem/600, "Started by {name}", none for posts) at the top once the history reaches the start, in the full view and in the side panel.Trash16 + "Original message was deleted.".system.rsgains theis_thread_starterhook.LockSimple), closed notice (Archive), "Join this thread…" with "Join thread".OpenThreadFull, "..." opens the thread menu.thread_menuwith the original's labels, groups, danger colour and the notification submenu; the bell's dropdown (mute + levels); delete and private-leave confirms; Copy link / Copy thread ID through the clipboard.EditThread { Settings(..) }.THREAD_MEMBER_LIST_UPDATE, "Remove from thread" for removable rows.Testing
crates/fluxer-ui/tests/thread_view.rs: the 11 tests of the plan (written first, failing commit745a79f).FLUXER_SCREENSHOT_TESTS=1):thread_full_view,thread_starter_message,thread_browser,thread_settings,thread_locked_notice. No Electron reference screenshot was available; dimensions come fromThreadParentCrumb.module.css,ThreadWelcomeSection.module.css,ThreadSystemMessages.module.css,ThreadComposerArea.module.css,BarrierComponents.module.css,ThreadBrowser.module.css,ThreadSidePanel.module.css(.membersPopout).thread_panel.pngregenerated: the panel now shows the welcome section above the messages (intended).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally.Deviations / for the reviewer
UserAction::ThreadMembers(Option<Snowflake>)setsthreads.members_open, so op 14thread_member_listssubscribes while the popout is open. No action existed for it (Task 38 left it "for Text chat 44").threads::menu::Message::Copy(text)to the clipboard (same pattern as the lightbox's Copy link).openThreadFullView, asSidebarThreadList.tsx);tests/threads.rsupdated accordingly.ThreadNotifyLevelhas no "default" value to send.crumb::icon_of).lock-simple-fill,archive-fillfrom@phosphor-icons/core2.1.1.popout::Placement).Closes #329
🤖 Generated with Claude Code
Independent review: Text chat 44 (thread view)
Reviewed
git diff e177770d..origin/textchat-44-ui-thread-view(d65b729) cold.Plan tests: all 11 named tests exist in
crates/fluxer-ui/tests/thread_view.rsand assert what the plan asks for. The strings match the fork:Active/Closed/Closed privatetabs (ThreadMessageDescriptors.ts:149-170), "Other active threads", the locked and closed notices, "Original message was deleted.", the private-leave confirm, the placeholderSend a message in "{name}", auto-archive 60/1440/4320/10080, popout 264 × ≤480 px. All 5 named goldens exist, andthread_panel.pngwas regenerated because the panel now shows the welcome section.Interfaces: the full view, crumb, welcome, starter (type 21 with deleted state), notices, browser, menu, settings and members are all in place. "See all threads" (
system::Link::SeeAllThreads) opens the browser. The panel's "Open in full view" sendsOpenThreadFull. The settings modal sends only the fields that changed, sends nothing when none did, and checks the name length (1–100 UTF-16 units). Invitable shows only for private threads.Invariants: fluxer-ui has no new I/O path; text Copy goes through
iced::clipboard::write. fluxer-core gains onlyUserAction::ThreadMembers(Option<Snowflake>), with no new dependency, and the existing op 14 subscription code already reacts tomembers_open. There is no new fixture. I found no panics on server data: no indexing or unwraps, andrelative()saturates. There are no secrets or paths in the diff.Review Focus: none of the items belongs to Task 44.
Local CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green (exit 0, screenshot step included).Findings
ThreadMembersPanel.tsxalso groups by hoisted roles (getHoistedRoles). This needs a follow-up.chat.threads.members_openis cleared only by the popout's own Close or toggle. If the selection changes without a click on the backdrop (for example a keyboard channel switch or a jump), the popout and its op 14 member-list subscription stay open for the old thread. I suggest clearing it onSelectChannelor when the thread leaves the view.fluxer-core/src/event.rsandchat/threads.rsis outside the Files list. It is small, it is needed (nothing could setmembers_openbefore), and the README is updated. Not blocking.Verdict: APPROVED. There are no blocking findings and local CI is green.