Text chat 60: Entrance sound section in Settings → Voice & video; "Entrance sound" participant submenu (#389) #453
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-60-ui-entrance-sounds"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Text chat 60: the entrance-sound section of Settings → Voice & video and the "Entrance sound" submenu of the voice participant menu.
Settings → Voice & video → "Entrance sound" (
crates/fluxer-ui/src/screens/settings/voice_video/entrance.rs,EntranceSoundSection.tsx+useEntranceSound.ts):entrance::model(&App, &EntranceViewState) -> EntranceSectionModelover the store'sentrance_settings. The scope starts at the selected guild's scope, else global, as in the original.SetEntranceSound. The resolved-sound card has a preview button, the name, the duration, a "Set here" / "Inherited" badge and "Inherited from {label}". With nothing resolved it says "No entrance sound set here".trimmer::ENTRANCEtrimmer, then sendsUploadEntranceSound { select_for: scope }. When the library is full the button is disabled and says "Library full (8 sounds max). Delete one before adding another.". Next to it: "Library: {count} of {max}".PreviewEntranceSound), the name, the duration with " · Active here", and "Delete from library", which asks for confirmation and then sendsDeleteEntranceSound.feature_voice_entrance_sounds, the section shows only "Custom entrance sounds are not enabled on this instance.".settings::sync(&mut State, &App)runs on every snapshot. It sendsLoadEntranceSoundsonce each time Voice & video opens, however it was opened.settings::update_withhandles the section's messages. The newsettings::Outcome::{PickSoundFile, ReadSoundFile, OutlineSound, TrimSound}are run by the shell (app.rs) with the injectedDialogs/SoundFileReader. No new I/O path; nothing of a file or a path is logged (FileRequest'sDebugleaves the path out).soundboard::ENTRANCE_PENDINGandentrance_vieware removed.Participant menu (
VoiceParticipantMenuData.tsx:183-193,423-440,886):Entry::Submenu"Entrance sound", holding "Mute entrance sound" (SetEntranceListenerMute) and the "Entrance sound volume" slider (0–200 %, default 100, the 100 % detent;SetEntranceListenerVolume).How it was tested
cargo test -p fluxer-ui --test settings_voiceadds 12 tests:opening_the_page_loads_the_library,scope_tiles_and_community_overrides,scope_starts_at_the_current_guild,dropdown_lists_none_and_library_with_durations,choosing_a_sound_sends_set_entrance_sound,choosing_none_clears_the_scope,resolved_card_shows_set_here_or_inherited_from,empty_scope_says_no_entrance_sound_set_here,upload_new_goes_through_the_entrance_trimmer,library_full_disables_upload_with_the_message,library_rows_preview_and_delete_with_confirmation,not_enabled_instance_shows_only_the_notice.--test participant_menuadds 4 tests:entrance_submenu_after_mute_for_other_users,entrance_submenu_in_dm_calls,entrance_mute_and_volume_send_their_actions,entrance_volume_default_100_max_200. The existing label lists now include "Entrance sound".settings_entrance_soundandparticipant_menu_entrance_submenu.participant_menu.pngis redrawn because the new row is in it. Goldens were written withUPDATE_GOLDEN=1on this machine's Vulkan adapter (NVIDIA; lavapipe is not installed here), so the integrator may need to redraw them on lavapipe. The rest of the suite (84 tests) passes locally against the existing goldens.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses locally. Two earlier runs hit the known intermittent SIGSEGV of thefluxerlib tests at process exit (#304), which is unrelated to this change.tests/stream_menu.rsgain "Entrance sound".tests/settings_screenshare.rs's match onsettings::Outcomecovers the new variants.FLUXER_DESKTOP_TESTStest applies: the dialog and reader are injected, and the real runtime wiring of the reader's outline/trim is Task 61.Deviations from the plan
crates/fluxer-ui/src/app.rsis outside the Files list, but the shell has to run the new settings outcomes and callsettings::sync. The change is minimal and in the same crate.context_menu.rsis unchanged: a slider already fits in a submenu.pick_listhas no description column.settings::Messageandsettings::StateloseEq/Copy, because the trimmer's state holdsf32s.This finishes the entrance-sound items of #142. #142 stays open for its other items.
Closes #389
🤖 Generated with Claude Code
Independent review: Text chat 60 (ui-entrance-sounds)
Reviewed
git diff 9cf9a68..origin/textchat-60-ui-entrance-sounds(deb73db) cold.Tests (plan Step 1): all 16 named tests exist (12 in
tests/settings_voice.rs::entrance_section, 4 intests/participant_menu.rs), plus the screenshotssettings_entrance_sound_matches_goldenandparticipant_menu_entrance_submenu_matches_golden. They assert the spec's strings verbatim (checked againstEntranceSoundSection.tsxandVoiceParticipantMenuData.tsx:183-193,423-440,886): the tiles and descriptions, the scope hints, "None" + "Door (1.3s)", "Set here" / "Inherited from All communities and DMs", "Library: 2 of 8", "Library full (8 sounds max). Delete one before adding another.", the 20 MiB read limit,trimmer::ENTRANCE→UploadEntranceSound { select_for: scope }, the four toast texts, the not-enabled notice only, the submenu right after "Mute" and in DM calls, and volume 0–200 % with 100 as the default.Interfaces:
entrance::model(app, &EntranceViewState) -> EntranceSectionModelexists as written. Scope starts at the current guild, else global. It uses Task 57'sentrance_settings/entrance_listeners/entranceUserActions and Task 59'strimmer/confirm/SoundFileReader::{outline, trim}. The newsettings::Outcomevariants are run inapp.rsthrough the injecteddialogs/filesviaTask::perform.Invariants: the diff does not touch fluxer-core, so it adds no core dependency and no file bytes in core. fluxer-ui adds no new I/O path.
FileRequest,PickedFileandOutcomeDebug output leaves out paths and bytes. Every newMessage/Outcomevariant is reachable without panics on server data (no indexing or unwraps in non-test code). The test helper's limits rule has the same shape aswell_known.json'srules[].Findings
participant_menu,participant_menu_entrance_submenuandsettings_entrance_soundon the lavapipe Linux runner (re-render there if they drift).FileError::Io(message)is shown verbatim in the status line. It goes to the UI only, never to logs. Task 61's reader should make sure that message does not embed the file path.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed (exit 0). Both new screenshot tests andparticipant_menupassed. No #304 SIGSEGV on this run.Verdict: approve (no blocking findings, ci green locally).