Text chat 69: fluxer-proto update manifest, channels and release versions (#431) #452
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-69-proto-update-manifest"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
fluxer_proto::update(Text chat 69, auto-update spec §3.2, §3.5, §4.3):ReleaseVersion { year, mmdd, n }: strictYYYY.MMDD.NFromStr, zero-paddedDisplay, serde as that string,Ordby field order;velopack_version()(2026.105.412) andfrom_velopack_version().Channel { Nightly, Stable }(lowercase,ALL),PlatformKey { LinuxX86_64, WindowsX86_64, Other }withcurrent()fromcfg!,AssetKind { AppImage, Exe, Zip, Velopack, Unknown },Asset,Manifest::asset_for.parse_manifest(bytes, &feed_url, expected): schema check first (UnsupportedSchema), then channel, version, minimum_version, commit (7-40 hex), RFC 3339published_at, and per asset name / url (resolved against the feed, no credentials, https or loopback http, same origin) / sha256 / size (1 B..1 GiB).SCHEMA_VERSION,MAX_ASSET_SIZE,ASSET_NAME_PATTERN.fixtures/update/, README section.Tests
crates/fluxer-proto/tests/update.rs: every test named in the plan plusmalformed_documents_are_json_errors,velopack_version_examples,channels_serialise_lowercase,errors_never_carry_urls, and a second never-panics proptest that swaps each field for odd JSON values. Seen failing (no module), then passing.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally (Linux).Choices the plan leaves open (reviewer please check)
fluxer-proto/Cargo.tomlgainsurl(already a workspace dependency, no new crate in the lock) because the interface typesAsset::url/notes_urlasUrl.ReleaseVersion::from_stralso requiresMMDDto be a month-day (01-12 / 01-31), matchingfrom_velopack_version.PlatformKey::Otherand silently drops an invalid one; a known platform's bad asset fails the manifest.notes_urlthat breaks the URL rules is dropped (warned), not an error. Badpublished_atisJson(..)(no dedicated variant in the interface).ManifestError::Jsonkeeps only serde's category and position, never document values (so no URL in logs).ORDER_TABLEin the test is the table Text chat 70'sversion_key_orders_like_release_versionshould share.Closes #431
🤖 Generated with Claude Code
Independent review: Text chat 69 (proto-update-manifest)
Reviewed
9cf9a68..b566fef(3 commits) cold, against plan Task 69 and auto-update spec §3.2, §3.5, §4.3, §7.Tests (1): all 22 tests the plan names exist in
crates/fluxer-proto/tests/update.rsand assert the spec's values (version2026.1113.412,MAX_ASSET_SIZE = 1 << 30, oversize fixture1073741825,2026.105.412Velopack mapping, the name pattern, loopback http for 127.0.0.1, localhost and [::1], relative../native-…resolved against theupdate-feedURL, protocol-relative and other-port URLs rejected as Origin). There are 27 tests in total, including two never-panic proptests anderrors_never_carry_urls.Interfaces (2):
ReleaseVersion {year,mmdd,n}with FromStr, Display, Ord, serde,velopack_versionandfrom_velopack_version;Channel(lowercase,ALL, Display);PlatformKey(withcurrent()fromcfg!only);AssetKindincludingVelopack;Asset;Manifestandasset_for;parse_manifest(&[u8], &Url, Channel);ManifestErrorandAssetProblemwith every variant named;SCHEMA_VERSION,MAX_ASSET_SIZEandASSET_NAME_PATTERN. All of these match the Interfaces block exactly.Invariants (3): the only new dependency is
url.workspacein fluxer-proto. It was already a workspace dependency, does no I/O, and the interface requires theUrltype. cargo deny and core isolation pass. fluxer-core, fluxer-ui and fluxer-emoji are untouched. The fixtures are shaped like the spec's §3.2 document; this is our own release workflow's format, not server data, and the commit message cites the spec lines andUpdateFeed.ts:44. Error messages and logs carry no URLs or document values:Json(..)keeps only the serde category and position, and the unknown-platform debug log names only the key. Hostile input cannot panic the parser (no indexing or unwrap on document data, and proptests cover it). No secrets or paths appear in fixtures.Review Focus (4): no Review Focus item belongs to this task. Item 7 (server data never panics) is covered anyway.
CI (5):
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: all steps passed (27/27 intests/update.rs).Findings
FromStraccepts leading zeros inN(2026.1113.0412parses to the same value as2026.1113.412), soDisplaydoes not round-trip that input. This matches the spec's\d+regex, and jq'stonumberorders it the same way, so nothing breaks. A test pinning either behaviour would help.ORDER_TABLEis apub constinside an integration-test file, so Text chat 70's xtask tests cannot import it. Text chat 70 will have to copy it orinclude!it. Moving it to apubitem influxer_proto::update(or a fixture file) would let Text chat 70 share it as the plan intends. This does not block this task.schema: 0is reported asUnsupportedSchema(0). The spec only names higher schemas; this is harmless.Otherrather than ignored; this is harmless because consumers look upcurrent(). A badnotes_urlis dropped with a warning, and a badpublished_atis reported asJson. All of these fit the interface.Verdict: approve. No blocking findings; local CI is green.