Text chat 40: fluxer-core announcements, thread administration and personal notes (#325) #448
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-40-core-announcements-thread-admin"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: textchat-38-core-channel-routing
What
chat::announcements:can_crosspost(canCrosspostMessagerules),announcement_actions("Publish" / disabled "Published"),Confirm::Crosspost(Shift =confirmed: true),crosspost_nudge(newest own unpublished message; per-message dismiss; "Don't show again" saved ashide_crosspost_nudge),can_follow,follow_targets,FollowChannel,crosspost_card(CrosspostSource fetched once per copy; 403/404 -> Unavailable), toast strings.chat::thread_admin: thread browser (tabs, archived pages + Load more, search debounced 300 ms with relevance sort, index-not-ready retries, offset paging),thread_browser,thread_header,thread_composer_notice(Locked/Closed/Join),thread_starter(type 21; parent message fetched withFetchMessages { around, limit: 1 }when absent),thread_welcome,thread_menu(original items +ThreadPermissionUtilsrules),thread_link,thread_members; EditThread (close/reopen/lock/unlock/settings underthreadPatchRequirement), DeleteThread and private LeaveThread confirms, Join, RemoveThreadMember, SetThreadNotifications (exactly one flag), MuteThread; PurgeNotes with confirm and toasts.chat::threads(additive):member_listsfromTHREAD_MEMBER_LIST_UPDATE.Tests
tests/chat_announcements.rs(6) andtests/chat_thread_admin.rs(15), the plan's names;FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally.Deviations / outside the Files list
chat/actions.rs: newConfirm::{Crosspost, DeleteThread, LeaveThread, PurgeNotes}andMessageAction::{Publish, Published}.chat/mod.rs: announcements/thread_admin reducers receive&mut chat.confirm(and thread_admin&chat.threads); re-exports.selectors/mod.rs: re-exports (thread menu item exported asThreadMenuItem; the type isthread_admin::MenuItem).event.rs: newUserAction::MuteThread { thread_id, muted }(spec 18.2.5 Mute/Unmute had no port).tests/chat_channel_kinds.rs: Task 38'sphase5_stubs_emit_nothingno longer lists the Task 40 actions (they now act).ThreadHeaderModelgainsjoined(the notification button shows only for members).users/@me/...,ArchivedKind::MinePrivate).chat.announcements.toast/chat.thread_admin.toast(no toast mechanism in core yet).Closes #325
🤖 Generated with Claude Code
Independent review: Text chat 40 (head
97237f1, diff 29bca22..97237f1)Tests (1): all 21 tests named in the plan exist (
tests/chat_announcements.rs,tests/chat_thread_admin.rs) and assert what the plan asks for: the canCrosspostMessage table (type, state, snapshots, copy, SEND_MESSAGES, author/MANAGE_MESSAGES), confirm vsconfirmed, Published afterCROSSPOSTEDor the answer, MESSAGE_ALREADY_CROSSPOSTED toast, nudge + "Don't show again" saved ashide_crosspost_nudge, notify flags 2/4/8 exactly one, the purge toast strings (checked againstDirectMessageList.tsx:82-89).Interfaces (2):
announcement_actions,can_crosspost,Confirm::Crosspost,crosspost_nudge,can_follow,follow_targets,crosspost_card,thread_header,thread_composer_notice/ThreadNotice::{Locked, Closed, Join},thread_starter -> Option<StarterModel::{Message(Box<Message>), Deleted, Loading}>,thread_welcome,thread_browser,thread_menu,thread_members -> Vec<MemberRow>are all inselectors. No new fixtures; Task 38's stub test was updated, not deleted.Invariants (3): fluxer-core gains no dependency, and holds no file bytes, URLs or secrets. There is no unwrap/index on server data.
retry_delayhandles non-finiteretry_after. The starter fetch (FetchMessages { around, limit: 1 }) cannot disturb the parent's loaded window:Messages::on_arounddrops pages nobody is waiting for.Review Focus (4): none of the 7 items belongs to Task 40.
CI (5):
cargo xtask ciin a clean review worktree: all steps passed.Findings
ThreadBrowser.tsx:369-371, withkind = moderator ? 'private' : 'joined'at:255. SoArchivedKind::MinePrivate(users/@me/threads/archived/private) is never used, and a non-moderator cannot browse the archived private threads they are in. Suggest aquestion/follow-upissue for Charles (spec §18.2.5 vs the original).Optionwhere the plan wrote a bare model.thread_header,thread_welcomeandthread_browserreturnOption<…>(reasonable: the thread may be unknown or the browser closed).ThreadHeaderModelalso has an extrajoinedfield andThreadBrowserModelan extraparent.selectorsre-exports the menu item asThreadMenuItem, so it does not clash withchat::MenuItem. Tasks 44/48 should use these names.ThreadMenuAction::Notifications(None)advertises "Default", butThreadNotifyLevel(Task 38) has no Default variant. The UI therefore cannot send flags 0 to go back to the parent's setting, whichgetThreadNotificationFlagdoes in the original.ApiResultcarries no effect id). With twoRequest::Otheractions in flight, a success can remove the other request's id, and a later failure of that request then shows no error toast. Inannouncements,crosspost_requestsis never cleared on success, so it grows by one id per publish. Cosmetic only.Verdict: APPROVED. No blocking findings and CI is green. Items 1 and 3 deserve follow-up issues.