Text chat 29: Message hover bar, context menu, confirm and forward modals (#279) #437
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-29-ui-message-actions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: textchat-27-ui-expression-picker
What
Text chat spec §3.6 / §9.6 and #129, in
crates/fluxer-ui/src/screens/main/message_actions/:hover_bar.rs,MessageActionBar.{tsx,module.css},ActionToolbar.module.css): 1.75 rem buttons, 20 px Phosphor icons, tooltips, three quick reactions. Its items are the store'sActionsModel::bar. Shift expands it. The settings work: bar off, only More, no quick reactions, Shift expand off. It floats over the row's top edge as an icedfloatoverlay, inside a smallOverhangwidget so that it keeps its full height over one-line grouped rows. While the pointer is on the bar it counts as hovered.menu.rs,MessageContextMenu.tsx) onwidgets::context_menu, opened by a right click or the bar's More (left-start of the button):getQuickReactionEmojis) and "Other reaction…" (the emoji picker);confirm.rs,ConfirmModal,Modal.module.css .root.small, 440 px):app.chat.confirm. "Remove all reactions" is held in this view's state because the store has no confirm for it.forward.rs,ForwardModal): search, DMs and group DMs (latest first) then guild text and announcement channels the user can send in, ≤5 destinations, comment, "Send (n/5)". It sendsUserAction::Forward.messageDoubleClickActions). Shift-click on Reply leaves the mention off, and on Copy message ID it copies{channel}-{message}. "View reactions" opens the reactors modal.Tests
tests/message_actions.rs(headless):hover_bar_items_and_shift,menu_matches_actions_model,shift_click_delete_skips_confirm,confirm_modal_strings,forward_limit_5,double_click_edit_or_reply_setting.message_hover_bar,message_context_menu,delete_confirm,forward_modal. Their goldens were generated locally (no lavapipe on this machine).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses locally. All existing goldens are unchanged.Deviations / notes for review
theme/palette.rsgains afloatcatalog, which iced'sFloatneeds.testing/offscreen.rsnow draws overlays after the base, as iced's UI does. Without it the floating bar is invisible in screenshots. No existing golden changed.docs/parity/settings.tomlgets notes on the action-bar and double-click settings.requestToggleSuppressEmbedsdoes. The embed's X still asks.widgets::context_menuhas none yet.@phosphor-icons/core@2.1.1): arrow-bend-up-right-fill, chats-fill, snowflake-regular, arrows-clockwise-fill, envelope-open-fill.Closes #279
🤖 Generated with Claude Code
Independent review: Text chat 29 (ui-message-actions)
Reviewed
31e58b3..origin/textchat-29-ui-message-actions(6ed05ec) cold.Checks
crates/fluxer-ui/tests/message_actions.rsand assert the plan/spec values: bar order + Shift expansion, the 1.75 rem (28 px) items and 20 px icons, the quick-reaction / Shift-expand / only-More / bar-off settings, the menu equal toselectors::message_actionswith 4 quick reactions, a 16-item "Add reaction" submenu and "Other reaction…", the Shift bypass for Delete/Pin (and Remove all reactions), the exact confirm strings from spec §3.6, forward limit 5 with "Send ({n}/{limit})" and "Add a comment (optional)", and the double-click setting. All 4 screenshots (message_hover_bar,message_context_menu,delete_confirm,forward_modal) exist and pass.widgets::context_menu, the confirm modals with preview and the Shift tip, the forward modal and the failed-message menu ("Try again" →RetrySendwith the nonce, which matches how the core keys provisional messages) are all present. The core types it uses (ActionsModel,Confirm,UserAction::Forward,CopyWhat::IdPair) are used as merged.fluxer-coreand every Cargo.toml are untouched. No new I/O influxer-ui: text copies go throughUserAction::CopyMessage→Effect::Clipboard. No fixtures added, no secrets or paths. I found no panics on server data: lookups useOption, and indexing is only on fixed iced tree children.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree is green (all steps passed, including the 4 new goldens).Findings
forward::LIMIT(5) copiesfluxer_core::chat::actions::MAX_FORWARD_DESTINATIONSinstead of using it, so the two could drift apart.Retry→RetrySend { nonce }mapping. The interface names it, but no plan test asks for it.follow-upissue before merge: Create thread does nothing until Task 31, suppress embeds from the menu does not ask first, forward destinations are not ordered by frecency, the confirm cards have no 12.5 rem minimum height, and the Remove all reactions confirm lives in UI state.Verdict: approved (no blocking findings, local CI green).