Text chat 33: Message list polish and chat settings (#283) #426
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-33-ui-message-list-settings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was built
Message list (spec §9.9):
widgets/message_list/dividers.rs).MarkRead, preceded byJumpToPresentwhen away from the present, asonScrollToPresentAndAck).MessageList::on_at_bottom: reports at-bottom once per change, on a redraw (AtBottomrule), mapped toUserAction::ViewportAtBottom(#60).messages::content_images.ChannelMessage.handleDoubleClick).ChatColumnnow takes any number of overlays (popup, top bar, bottom pill).Settings (spec §9.10, §11):
Message::Chat(ChatSettingChange)→SetChatSetting.advanced_chat.rs): the original's chat rows inChatSettingsIndex.tsorder with descriptions; "Configure" opens switch-group dialogs (media buttons, message action bar with its disabled rules, expression autocomplete, input buttons). Escape closes a dialog.docs/parity/settings.toml: §11 entries set to done; four newsection-chat_settings-*entries.Testing
tests/message_list_polish.rs(divider_at_marker, bar_mark_read_emits, jump_to_present_shown_when_not_at_newest, reports_viewport_at_bottom_once_per_change, typing_avatars_max_5, double_click_edits_own_message_or_replies) andtests/settings_chat.rs(chat_settings_bind, parity_check_passes).message_list_new_divider,jump_to_present,settings_chat,settings_advanced_chat, rendered on lavapipe in the Ubuntu 22.04 CI image (docker). Dimensions fromChannelDivider.module.css,ChannelMessages.module.css,NewMessagesBar.tsx,DisplayTab.tsx,AdvancedChatControls.tsx; no Electron reference image attached.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally; the screenshot suite also green on lavapipe in docker.Deviations from the plan
screens/main/composer/status_rail.rs(the code moved there fromwidgets/composer.rs);composer::view_with_mediaadded.settings_tabschange)..messageHighlight; the existing 2000 ms highlight is kept.textchat.mdparity table andvoice.mdrow updates left to Task 34.tests/headless/mod.rsgainsFrame::node();settings_nav.rsexpects the new Advanced → Chat panel.Closes #283
🤖 Generated with Claude Code
Message list (spec §9.9): the new-messages divider ("NEW") at the read marker, the new-messages bar over the list ("{n} new messages since {time}", click jumps to the first unread, "Mark as read"), the "You're viewing older messages" / "Jump to present" pill while the loaded messages do not reach the newest one, the list's at-bottom report (once per change, on a redraw) as UserAction::ViewportAtBottom (#60), typing avatars (12 px, at most 5, "+N", #211), and double-click a message to edit (own) or reply when the setting is on. Settings (spec §9.10, §11): the Chat tab's Display and Input sections bound to the synced display settings and the local chat settings, and Advanced -> Chat with the original's rows, switches and "Configure" switch-group dialogs. Parity entries of spec §11 set; four new section entries. Goldens regenerated on lavapipe for the #general screens, which now show the unread bar and divider. Refs #283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Text chat 33 (message list polish and chat settings)
Reviewed
git diff 67da1c73..origin/textchat-33-ui-message-list-settings(df5c987) cold.Plan tests: all present and asserting the planned behaviour:
divider_at_marker,bar_mark_read_emits,jump_to_present_shown_when_not_at_newest,reports_viewport_at_bottom_once_per_change,typing_avatars_max_5(5 avatars, 12 px, "+2"),chat_settings_bind,parity_check_passes; screenshotsmessage_list_new_divider,jump_to_present,settings_chat,settings_advanced_chat.Interfaces: the NEW divider, the bar with "Mark as read" (which also jumps to present first, as the original's
onScrollToPresentAndAck), the "Jump to present" pill,UserAction::ViewportAtBottomthroughMessageList::on_at_bottom, typing avatars, the Chat tab (Display, Input), and Advanced -> Chat bound toChatSettingChangeare all there. No core or Cargo changes.Invariants: no new I/O in fluxer-ui, no fluxer-core or dependency changes, no secrets, URLs or paths. The server timestamp in the bar falls back safely (
checked_to_offset), so it cannot panic.Review Focus 6 (#60): the list reports at-bottom only on
RedrawRequested, once per change, and again after a key (channel) change because the list state is reset. The ack decision stays in corebeing_read(selected channel, window focused, no settings screen or lightbox, at present, not marked unread by hand). It cannot ack a channel the user is not looking at.Findings
message_rowhighlight is on/off with the 2 s timer. Not mentioned in the notes.message_list_new_dividergolden, the first message after the NEW divider still draws as a grouped continuation (no avatar or name). Check the original's grouping across the unread divider (Task 34 parity).CI:
cargo xtask ciin the review worktree: green (exit 0). Screenshot goldens were not re-rendered, because this host has no lavapipe.Verdict: approve (0 blocking).