Text chat 27: Expression picker: emoji, stickers, saved media (#277) #415

Manually merged
charles merged 0 commits from textchat-27-ui-expression-picker into textchat 2026-11-13 08:46:34 +00:00
Owner

Stacked on: origin/textchat-25-ui-composer (already merged into textchat at 220acce; the branch merge only brought its later merge commit, resolved to textchat's side, so the base tree equals origin/textchat).

What this builds

Text chat 27, the expression picker (spec §3.4, §9.5), in crates/fluxer-ui/src/screens/main/expressions/:

  • mod.rs: the popout (ExpressionPickerPopout.{tsx,module.css}): 592 x 690 by default, min 360 x 360, resizable from its top and left edges (it is anchored at its bottom right, top-end above the button with offsetCrossAxis: 16), width snapped by clampResizablePaneDimension (64 + n x 48), kept inside the window with 16 px padding. Tabs GIFs / Media / Stickers / Emojis (GIFs only when the instance has a GIF provider; emoji only for a reaction target), default tab Emojis and remembered between openings. State::toggle is the composer buttons' toggle (handleExpressionPickerTabToggle), Message::Shortcut is Ctrl+E / Ctrl+S, Message::Open { target, anchor } is for Text chat 29's "Add Reaction". Picks emit PickEmoji { target, emoji, keep_open }, PickSticker, PickMeme; Shift (tracked from ModifiersChanged) keeps it open. Premium banner ("Unlock N custom emojis from M communities with Plutonium.") when the instance offers premium, nothing is searched and emoji are hidden.
  • emoji_grid.rs: search ("Find the emoji of your dreams", the hovered emoji's names as placeholder), the virtualised grid (EmojiPickerConstants.ts, PickerRowLayout.ts: 48 px cells, columns = max(5, floor(w/48)), 32+8 px headers, 12 px section gap; only the rows in view are built), the 2.875 rem category rail with guild icons and the category icons, the 3 rem inspector, the empty state.
  • stickers.rs: 120 px tracks with 8 px gaps (4 per row at the default size), sections from selectors::sticker_picker, search on name / description / tags, rail, inspector, empty states.
  • memes.rs: saved media header (search, All / Images / Videos / Audio / GIFs pills, filterMemesByContentType) and masonry (computeMasonryColumns: 200 px lanes, 8 px gaps, shortest lane).
  • skin_tone.rs: the 24 px clap button and the six-tone column (current first), SetSkinTone.
  • Icons (Phosphor 2.1.10 path data, as assets/icons/README.md says): leaf, bowl-food, game-controller, bicycle, magnet, heart, flag (fill), smiley-sad (duotone), image, music-note.

Wiring outside the Files list, kept minimal:

  • composer/mod.rs (Text chat 25's): the GIFs / Media / Stickers / Emojis buttons report their bounds (Message::OpenExpressions), are drawn selected while their tab shows (State::expression_button), and State::expect_store_change lets an emoji picked into the composer reach the text box.
  • main/media.rs: wanted adds expressions::wanted (only the cells in view).
  • app.rs: Local::expressions; Ctrl+E / Ctrl+S and ModifiersChanged; Escape closes the picker; the rail's scroll (take_scroll) and the search field's focus (take_focus) become iced tasks; switching channels closes it.

Tests

  • crates/fluxer-ui/tests/expression_picker.rs: tabs_and_default_tab, grid_columns_from_width, rail_jumps_to_section, search_filters, pick_emits_with_target_and_keep_open, locked_banner_counts, resize_snaps_48, only_visible_cells_request_images (first written and seen failing, then passing). Unit tests for the masonry and the skin tone order.
  • Screenshots emoji_picker, emoji_picker_search, sticker_picker (goldens rendered on lavapipe in the fluxer-native-shots:u2204 image, as docs/screenshots/README.md describes; they also pass on this machine's GPU). No Electron side-by-side was captured: dimensions come from ExpressionPickerPopout.module.css, EmojiPicker.module.css, EmojiPickerConstants.ts, StickerPickerConstants.ts, PickerSearchInput.module.css, MemesPicker.module.css.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally.

Deviations (follow-up #414)

  • The size is kept for the session, not across restarts (that needs a fluxer-core local setting).
  • No keyboard navigation of the grids, no collapsible section headers, still images for animated emoji/stickers, an icon instead of video previews in saved media, banner dismissal per session.
  • With the picker open, a click on another composer expression button closes it (the backdrop takes the click) instead of switching tabs.
  • The GIFs tab has no content yet (Text chat 28 adds gifs.rs; Ctrl+G is its).
  • The rail is drawn from the current model, so it is empty while searching.
  • The commit trailer says Claude Opus 5.5 (the session's attribution line) rather than CLAUDE.md's Claude Fable 5.2; it is already pushed and force-push is not allowed.

Closes #277

🤖 Generated with Claude Code

Stacked on: origin/textchat-25-ui-composer (already merged into `textchat` at 220acce; the branch merge only brought its later merge commit, resolved to `textchat`'s side, so the base tree equals `origin/textchat`). ## What this builds Text chat 27, the expression picker (spec §3.4, §9.5), in `crates/fluxer-ui/src/screens/main/expressions/`: - `mod.rs`: the popout (`ExpressionPickerPopout.{tsx,module.css}`): 592 x 690 by default, min 360 x 360, resizable from its top and left edges (it is anchored at its bottom right, `top-end` above the button with `offsetCrossAxis: 16`), width snapped by `clampResizablePaneDimension` (`64 + n x 48`), kept inside the window with 16 px padding. Tabs GIFs / Media / Stickers / Emojis (GIFs only when the instance has a GIF provider; emoji only for a reaction target), default tab Emojis and remembered between openings. `State::toggle` is the composer buttons' toggle (`handleExpressionPickerTabToggle`), `Message::Shortcut` is Ctrl+E / Ctrl+S, `Message::Open { target, anchor }` is for Text chat 29's "Add Reaction". Picks emit `PickEmoji { target, emoji, keep_open }`, `PickSticker`, `PickMeme`; Shift (tracked from `ModifiersChanged`) keeps it open. Premium banner ("Unlock N custom emojis from M communities with Plutonium.") when the instance offers premium, nothing is searched and emoji are hidden. - `emoji_grid.rs`: search ("Find the emoji of your dreams", the hovered emoji's names as placeholder), the virtualised grid (`EmojiPickerConstants.ts`, `PickerRowLayout.ts`: 48 px cells, `columns = max(5, floor(w/48))`, 32+8 px headers, 12 px section gap; only the rows in view are built), the 2.875 rem category rail with guild icons and the category icons, the 3 rem inspector, the empty state. - `stickers.rs`: 120 px tracks with 8 px gaps (4 per row at the default size), sections from `selectors::sticker_picker`, search on name / description / tags, rail, inspector, empty states. - `memes.rs`: saved media header (search, All / Images / Videos / Audio / GIFs pills, `filterMemesByContentType`) and masonry (`computeMasonryColumns`: 200 px lanes, 8 px gaps, shortest lane). - `skin_tone.rs`: the 24 px clap button and the six-tone column (current first), `SetSkinTone`. - Icons (Phosphor 2.1.10 path data, as `assets/icons/README.md` says): leaf, bowl-food, game-controller, bicycle, magnet, heart, flag (fill), smiley-sad (duotone), image, music-note. Wiring outside the Files list, kept minimal: - `composer/mod.rs` (Text chat 25's): the GIFs / Media / Stickers / Emojis buttons report their bounds (`Message::OpenExpressions`), are drawn selected while their tab shows (`State::expression_button`), and `State::expect_store_change` lets an emoji picked into the composer reach the text box. - `main/media.rs`: `wanted` adds `expressions::wanted` (only the cells in view). - `app.rs`: `Local::expressions`; Ctrl+E / Ctrl+S and `ModifiersChanged`; Escape closes the picker; the rail's scroll (`take_scroll`) and the search field's focus (`take_focus`) become iced tasks; switching channels closes it. ## Tests - `crates/fluxer-ui/tests/expression_picker.rs`: `tabs_and_default_tab`, `grid_columns_from_width`, `rail_jumps_to_section`, `search_filters`, `pick_emits_with_target_and_keep_open`, `locked_banner_counts`, `resize_snaps_48`, `only_visible_cells_request_images` (first written and seen failing, then passing). Unit tests for the masonry and the skin tone order. - Screenshots `emoji_picker`, `emoji_picker_search`, `sticker_picker` (goldens rendered on lavapipe in the `fluxer-native-shots:u2204` image, as `docs/screenshots/README.md` describes; they also pass on this machine's GPU). No Electron side-by-side was captured: dimensions come from `ExpressionPickerPopout.module.css`, `EmojiPicker.module.css`, `EmojiPickerConstants.ts`, `StickerPickerConstants.ts`, `PickerSearchInput.module.css`, `MemesPicker.module.css`. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. ## Deviations (follow-up #414) - The size is kept for the session, not across restarts (that needs a `fluxer-core` local setting). - No keyboard navigation of the grids, no collapsible section headers, still images for animated emoji/stickers, an icon instead of video previews in saved media, banner dismissal per session. - With the picker open, a click on another composer expression button closes it (the backdrop takes the click) instead of switching tabs. - The GIFs tab has no content yet (Text chat 28 adds `gifs.rs`; Ctrl+G is its). - The rail is drawn from the current model, so it is empty while searching. - The commit trailer says `Claude Opus 5.5` (the session's attribution line) rather than `CLAUDE.md`'s `Claude Fable 5.2`; it is already pushed and force-push is not allowed. Closes #277 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Text chat 21-24 landed. The inline edit box now replaces only the text in
the new message row (attachments, embeds, stickers, forward and reactions
stay below it); the row's new events are routed next to the editor's. The
13 goldens Text chat 22-24 added were regenerated on lavapipe: only the
list's position moved, the composer box being taller.

Refs #275

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/README.md
#	crates/fluxer-ui/src/screens/main/media.rs
#	crates/fluxer-ui/src/screens/main/messages.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	crates/fluxer-ui/src/widgets/message_row.rs
#	crates/fluxer-ui/tests/screenshots.rs
#	docs/screenshots/README.md
#	fixtures/golden/attachment_file_card.png
#	fixtures/golden/attachment_spoiler.png
#	fixtures/golden/attachments_mosaic_4.png
#	fixtures/golden/attachments_mosaic_7.png
#	fixtures/golden/embed_article.png
#	fixtures/golden/embed_gifv.png
#	fixtures/golden/embed_rich_fields.png
#	fixtures/golden/embed_youtube.png
#	fixtures/golden/message_forwarded.png
#	fixtures/golden/message_reactions.png
#	fixtures/golden/message_reply.png
#	fixtures/golden/message_system_pin.png
#	fixtures/golden/reactors_modal.png
The expression picker popout of Text chat spec §3.4/§9.5
(ExpressionPickerPopout.tsx, EmojiPicker.tsx, StickersPicker.tsx,
pickers/memes/*): 592 x 690, resizable from its top and left edges with
the width snapped to 64 + n x 48 (min 360), tabs GIFs/Media/Stickers/
Emojis, a virtualised emoji grid (48 px cells, >= 5 columns) with the
category rail and guild icons, search, the inspector footer, the skin
tone selector and the premium banner; the sticker grid (120 px tracks)
and the saved media masonry. Opened from the composer's buttons,
Ctrl+E/Ctrl+S and (Text chat 29) Message::Open with a reaction target;
Shift keeps it open. Only the cells in view request images.

Refs #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Text chat 27 (expression picker)

Scope: git diff c0eada8..origin/textchat-27-ui-expression-picker (ec1efe7). I read it without relying on the implementer's notes.

Checks

  1. Plan tests: all 8 are in tests/expression_picker.rs (tabs_and_default_tab, grid_columns_from_width, rail_jumps_to_section, search_filters, pick_emits_with_target_and_keep_open, locked_banner_counts, resize_snaps_48, only_visible_cells_request_images). They use the spec §3.4 values: 592 × 690, min 360, a 48 px snap (64 + n·48), 48 px cells, at least 5 columns with 9 by default, 4 sticker tracks of 120 px at the default width, the "Find the emoji of your dreams" placeholder, tab order GIFs/Media/Stickers/Emojis with Emojis as the default, a reaction target showing the emoji tab only, and Shift keeping the picker open. The screenshots emoji_picker, emoji_picker_search and sticker_picker exist and pass.
  2. Interfaces: screens::main::expressions has State, Tab, Message::{Open{target,anchor}, Shortcut, …}, update -> Vec<UserAction>, wanted, over, and the emoji_grid/stickers/memes/skin_tone modules. It emits PickEmoji{target,emoji,keep_open}, PickSticker, PickMeme and SetSkinTone against Task 14's core API. Task 28 can add gifs.rs and Ctrl+G, because Tab::Gifs and Message::Shortcut are already in place. Task 29 has Message::Open with PickTarget::Reaction.
  3. Invariants: no new dependencies and no Cargo changes. fluxer-ui gains no I/O path: images come through media::wanted and the ImageLoader. No new fixtures. Every index into the model is derived from that same model, the masonry guards against zero or unknown sizes, and the resize handles NaN and infinite values. I found no secrets, file paths or signed URLs.
  4. Review Focus: none of the items belongs to this task. (#3, the synced prefs, is Task 14's; here the skin tone only emits SetSkinTone.)
  5. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: green ("all steps passed"; 8/8 picker tests and the 3 new goldens pass).

Findings (none blocking)

  • minor: The size is not persisted. The Interfaces block and spec §3.4/§9.5 say "size persisted locally", but here the size lasts only for the session. The implementer tracks this in #414. It loses no user data, but it is an Interfaces deviation, so #414 should stay linked from this PR.
  • minor: The skin tone choices never request their images. emoji_grid::wanted asks only for the button's clap (clap(tone)). When skin_tones_open, the five other tones (skin_tone::options_view) are never requested, so they fall back to system glyphs. Add options(tone) to wanted while the choices are open.
  • minor: Escape takes two presses. Opening the picker focuses its search field, and iced's text_input captures Escape to unfocus itself. The first Escape therefore only blurs the field, and WindowEvent::Escape (which needs free) closes the picker on the second press. The original closes on the first.
  • minor: Picks are addressed by index. Pick(section, item) and the hover are (section, item) indices resolved against a model recomputed at click time. If the store changes between the frame and the click (a Shift-pick adds "Frequently used" or reorders it, or a GUILD_EMOJIS_UPDATE arrives), the hover and the next pick can land on another cell. Addressing the cell by its EmojiRef (or by key) would make it exact.
  • minor (perf, implementer asked): emoji_picker() runs several times per frame. It runs in popout, again in search_bar while a cell is hovered, in wanted (on every media pass) and on every Pick or Jump. That is about 3700 candidates each time. The tests pass, but a small cache keyed by (query, channel, store revision) in State would remove it. Not blocking.
  • minor: Resizing is not bounded to the window. ResizeMove clamps against an unbounded window, so state.size can grow past the window while only the view clamps it. The next drag then starts from the oversized size and seems stuck until the pointer covers the excess. Also, the origin is taken at the first move rather than at the press. Releasing outside the window leaves the overlay in resize mode until the next release.
  • minor (known, #414): Clicking another composer button while the picker is open closes the picker instead of switching tabs, because the backdrop takes the click. Also deferred there: keyboard grid navigation and still images where the original animates.
  • minor (process): The commit trailer is Claude Opus 5.5, but CLAUDE.md asks for Claude Fable 5.2. Force-push is denied, so it is noted only.

The virtualisation in emoji_grid::view (spacers above and below the visible Layout::visible range, rows built only in view) and the resize overlay are correct for what they claim, and the tests cover both.

Verdict: approve (no blocking findings, local CI green).

## Independent review: Text chat 27 (expression picker) Scope: `git diff c0eada8..origin/textchat-27-ui-expression-picker` (ec1efe7). I read it without relying on the implementer's notes. **Checks** 1. Plan tests: all 8 are in `tests/expression_picker.rs` (`tabs_and_default_tab`, `grid_columns_from_width`, `rail_jumps_to_section`, `search_filters`, `pick_emits_with_target_and_keep_open`, `locked_banner_counts`, `resize_snaps_48`, `only_visible_cells_request_images`). They use the spec §3.4 values: 592 × 690, min 360, a 48 px snap (`64 + n·48`), 48 px cells, at least 5 columns with 9 by default, 4 sticker tracks of 120 px at the default width, the "Find the emoji of your dreams" placeholder, tab order GIFs/Media/Stickers/Emojis with Emojis as the default, a reaction target showing the emoji tab only, and Shift keeping the picker open. The screenshots `emoji_picker`, `emoji_picker_search` and `sticker_picker` exist and pass. 2. Interfaces: `screens::main::expressions` has `State`, `Tab`, `Message::{Open{target,anchor}, Shortcut, …}`, `update -> Vec<UserAction>`, `wanted`, `over`, and the emoji_grid/stickers/memes/skin_tone modules. It emits `PickEmoji{target,emoji,keep_open}`, `PickSticker`, `PickMeme` and `SetSkinTone` against Task 14's core API. Task 28 can add `gifs.rs` and Ctrl+G, because `Tab::Gifs` and `Message::Shortcut` are already in place. Task 29 has `Message::Open` with `PickTarget::Reaction`. 3. Invariants: no new dependencies and no Cargo changes. fluxer-ui gains no I/O path: images come through `media::wanted` and the `ImageLoader`. No new fixtures. Every index into the model is derived from that same model, the masonry guards against zero or unknown sizes, and the resize handles NaN and infinite values. I found no secrets, file paths or signed URLs. 4. Review Focus: none of the items belongs to this task. (#3, the synced prefs, is Task 14's; here the skin tone only emits `SetSkinTone`.) 5. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: **green** ("all steps passed"; 8/8 picker tests and the 3 new goldens pass). **Findings** (none blocking) - minor: **The size is not persisted.** The Interfaces block and spec §3.4/§9.5 say "size persisted locally", but here the size lasts only for the session. The implementer tracks this in #414. It loses no user data, but it is an Interfaces deviation, so #414 should stay linked from this PR. - minor: **The skin tone choices never request their images.** `emoji_grid::wanted` asks only for the button's clap (`clap(tone)`). When `skin_tones_open`, the five other tones (`skin_tone::options_view`) are never requested, so they fall back to system glyphs. Add `options(tone)` to `wanted` while the choices are open. - minor: **Escape takes two presses.** Opening the picker focuses its search field, and iced's `text_input` captures Escape to unfocus itself. The first Escape therefore only blurs the field, and `WindowEvent::Escape` (which needs `free`) closes the picker on the second press. The original closes on the first. - minor: **Picks are addressed by index.** `Pick(section, item)` and the hover are `(section, item)` indices resolved against a model recomputed at click time. If the store changes between the frame and the click (a Shift-pick adds "Frequently used" or reorders it, or a `GUILD_EMOJIS_UPDATE` arrives), the hover and the next pick can land on another cell. Addressing the cell by its `EmojiRef` (or by key) would make it exact. - minor (perf, implementer asked): **`emoji_picker()` runs several times per frame.** It runs in `popout`, again in `search_bar` while a cell is hovered, in `wanted` (on every media pass) and on every Pick or Jump. That is about 3700 candidates each time. The tests pass, but a small cache keyed by (query, channel, store revision) in `State` would remove it. Not blocking. - minor: **Resizing is not bounded to the window.** `ResizeMove` clamps against an unbounded window, so `state.size` can grow past the window while only the view clamps it. The next drag then starts from the oversized size and seems stuck until the pointer covers the excess. Also, the origin is taken at the first move rather than at the press. Releasing outside the window leaves the overlay in resize mode until the next release. - minor (known, #414): Clicking another composer button while the picker is open closes the picker instead of switching tabs, because the backdrop takes the click. Also deferred there: keyboard grid navigation and still images where the original animates. - minor (process): The commit trailer is `Claude Opus 5.5`, but CLAUDE.md asks for `Claude Fable 5.2`. Force-push is denied, so it is noted only. The virtualisation in `emoji_grid::view` (spacers above and below the visible `Layout::visible` range, rows built only in view) and the resize overlay are correct for what they claim, and the tests cover both. **Verdict: approve** (no blocking findings, local CI green).
Author
Owner

Independent review: Text chat 27 (expression picker)

I reviewed 67da1c7..origin/textchat-27-ui-expression-picker (ec1efe7 plus the merge 5874c94).

Tests (plan step): all 8 named tests are in crates/fluxer-ui/tests/expression_picker.rs and check the spec §3.4 values: 592 × 690, min 360, a 48 px snap, ≥5 columns (9 by default), 4 stickers per row on 120 px tracks, the placeholder "Find the emoji of your dreams", the tab order GIFs/Media/Stickers/Emojis, Shift keeps the picker open, and only the visible cells request images. The screenshots emoji_picker, emoji_picker_search and sticker_picker have goldens and pass.

Interfaces: expressions::{State, Tab, Message::Open { target, anchor }, Message::Shortcut, update, wanted, over} exist for Text chat 28 and 29 to use. The picker is opened from the composer buttons and by Ctrl+E/Ctrl+S, and picks are UserAction::{PickEmoji, PickSticker, PickMeme, SetSkinTone}.

Invariants: the diff touches only fluxer-ui and docs. fluxer-core and fluxer-emoji are unchanged, there are no new dependencies and no new fixtures. The picker adds no I/O: images go only through media::wanted → ImageLoader. Picks by index are bounds-checked (get), and masonry and column math guard zero or unknown sizes. There are no secrets, URLs or paths in the diff.

Findings

  • minor: the size is kept for the session only. The Interfaces block and spec §3.4 say "persisted locally". Tracked in #414.
  • minor: other deviations tracked in #414: no keyboard grid navigation; clicking another composer button closes the picker instead of switching tabs; the GIFs tab is empty until Text chat 28.
  • minor: carried over from the earlier review and still open: the skin-tone option images are not in wanted; Escape takes two presses; picks are addressed by (section, item) index, so an emoji update between the frame and the click could pick a neighbouring cell; emoji_picker() is recomputed several times per frame; ResizeMove clamps to an unbounded window, and only the view clamps.
  • minor: the trailer on ec1efe7 says Claude Opus 5.5, not the Claude Fable 5.2 that CLAUDE.md asks for. Fixing it would need a force-push, so I left it.

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: all steps passed (exit 0). livekit-interop was skipped as configured.

Verdict: APPROVED (no blocking findings, ci green locally).

## Independent review: Text chat 27 (expression picker) I reviewed `67da1c7..origin/textchat-27-ui-expression-picker` (ec1efe7 plus the merge 5874c94). **Tests (plan step):** all 8 named tests are in `crates/fluxer-ui/tests/expression_picker.rs` and check the spec §3.4 values: 592 × 690, min 360, a 48 px snap, ≥5 columns (9 by default), 4 stickers per row on 120 px tracks, the placeholder "Find the emoji of your dreams", the tab order GIFs/Media/Stickers/Emojis, Shift keeps the picker open, and only the visible cells request images. The screenshots `emoji_picker`, `emoji_picker_search` and `sticker_picker` have goldens and pass. **Interfaces:** `expressions::{State, Tab, Message::Open { target, anchor }, Message::Shortcut, update, wanted, over}` exist for Text chat 28 and 29 to use. The picker is opened from the composer buttons and by Ctrl+E/Ctrl+S, and picks are `UserAction::{PickEmoji, PickSticker, PickMeme, SetSkinTone}`. **Invariants:** the diff touches only `fluxer-ui` and docs. fluxer-core and fluxer-emoji are unchanged, there are no new dependencies and no new fixtures. The picker adds no I/O: images go only through `media::wanted` → ImageLoader. Picks by index are bounds-checked (`get`), and masonry and column math guard zero or unknown sizes. There are no secrets, URLs or paths in the diff. **Findings** - minor: the size is kept for the session only. The Interfaces block and spec §3.4 say "persisted locally". Tracked in #414. - minor: other deviations tracked in #414: no keyboard grid navigation; clicking another composer button closes the picker instead of switching tabs; the GIFs tab is empty until Text chat 28. - minor: carried over from the earlier review and still open: the skin-tone option images are not in `wanted`; Escape takes two presses; picks are addressed by `(section, item)` index, so an emoji update between the frame and the click could pick a neighbouring cell; `emoji_picker()` is recomputed several times per frame; `ResizeMove` clamps to an unbounded window, and only the view clamps. - minor: the trailer on ec1efe7 says Claude Opus 5.5, not the Claude Fable 5.2 that CLAUDE.md asks for. Fixing it would need a force-push, so I left it. **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: all steps passed (exit 0). livekit-interop was skipped as configured. **Verdict: APPROVED** (no blocking findings, ci green locally).
charles manually merged commit 15154126d0 into textchat 2026-11-13 08:46:34 +00:00
Sign in to join this conversation.
No description provided.