Text chat 24: Message row: reply preview, forwards, system messages, highlights, reactions row (#274) #380
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-24-ui-message-row"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Text chat 24 (spec §3.5, §9.3): the message row gains
widgets/message_content/reply_preview.rs): spine from the avatar centre (2 px, 0.625 rem corner, 82 %--text-chat-muted), 16 px avatar (#211), name at 64 % role colour with "@" when the reply pings, one line of the target; "Original message was deleted" / "Original message failed to load" / "Message contains attached media"; click →JumpToMessage.ReplyPreview.tsx,Message.module.css.replied*.forward.rs): 4 px--interactive-mutedbar, "↪ Forwarded", the snapshot text and its "(edited)", "Forwarded from › #channel" (jumps).MessageAttachments.{tsx,module.css}.system.rs): join (17 welcomes,timestamp % 17), pin with its two links (JumpToMessage,OpenPins), recipient add/remove/leave, name/icon change, call, follow add (12), thread created (thread name →OpenThread, "See all threads"); type 21 returnsNone(Text chat 44). Icons and colours from the components and their CSS.rgb(234 197 50 / .1)+ 2 px bar; user, role, @everyone outside DMs) and jump highlight (--message-reply-bg+--brand-primary-lightbar, fromchat.nav.jump); "(edited)" tooltip with the edit date after 750 ms.reactions.rs): pills (radius 0.5 rem, 1 px border, 0.125/0.375 rem padding, 1.25 rem emoji, count 600), mine in--brand-tint/--brand-tint-border/--text-on-brand-tint, click →ToggleReaction, add-reaction button, hidden whenrender_reactionsis false. The 500 ms tooltip ("{:emoji:} reacted by A, B, and N others" + "Click to view all reactions") is a small clickable hover card; its click opens the reactors modal.screens/main/modals/reactors.rs): 36.25 × 27.5 rem, 6 rem emoji column (selected ringed), reactor rows (24 px avatar, name, tag), X to remove (own, or anyone for MANAGE_MESSAGES) with "Remove reaction", loads the next page past 80 % scroll, backdrop/Escape close.fluxer-core/src/selectors/messages.rs, minimal core change): the suppress-notifications rule ofMessageGroupingUtils.ts:77-89; REPLY already started a group.Tests
crates/fluxer-ui/tests/message_row_content.rs: all nine tests of the plan (models only, run on Windows too).message_reply,message_reactions,message_system_pin,message_forwarded,reactors_modalbuilt from Text chat 20'stextchat_ready.json+textchat/history.json; goldens drawn on lavapipe in the Ubuntu 22.04 image (fluxer-native-shots:u2204); the whole screenshot suite (37) passes there, existing goldens unchanged.cargo xtask cigreen locally (screenshot step run in the lavapipe container, not on the host GPU).Deviations
timestamp % 17, not% 11as the spec says: the fork'sSystemMessageUtilshas 17 strings and takesmessageList.length.Message.callis not modelled: follow-up #375.ReactionModel.tooltip_names); the core does not fetch 3 reactors on hover as the original does, so before that it shows only:emoji:.OpenThreadBrowser= Text chat 38). Mods' right-click "Remove reaction" on a modal tab is not built; the per-row X covers removals.widgets/message_content/mod.rs(Text chat 22 also creates it; mechanical merge),screens/main/modals/mod.rs,screens/main/mod.rs(draws the modal),model.rs(channel_namecrate-visible),screenshare/picker.rs(on_escapecrate-visible),theme/icons.rs+ 8 Phosphor SVGs,fluxer-coregrouping rule.Closes #274
🤖 Generated with Claude Code
Independent review: Text chat 24 (
76a7098)Scope:
git diff 12e0695..origin/textchat-24-ui-message-row.(1) Plan tests: all 9 exist in
crates/fluxer-ui/tests/message_row_content.rsand check what the plan names, with the spec's values: modal 580 × 440 (36.25 × 27.5 rem), tooltip after 500 ms, "(edited)" after 750 ms, mention bar rgb(234 197 50), the reply strings, the reaction pill colours (mine and other), and therender_reactionstoggle. All 5 screenshot goldens are present.(2) Interfaces: every behaviour the Produces line names is there. This task's block names no type or signature that other tasks consume.
(3) Invariants: fluxer-core gains only the grouping rule, which uses
MessageFlagsfrom fluxer-proto. There are no new dependencies and no I/O in fluxer-ui (images go throughmedia::wanted). There are no new fixtures and nothing secret. I found no panics on server data: indexes are bounded, andtree.children[0]always has 2 children.(4) Review Focus: no item belongs to this task.
(5)
cargo xtask ci: green in the review worktree ("all steps passed", exit 0). It ran withoutFLUXER_SCREENSHOT_TESTS.Findings
% 17, not the spec's% 11. I checked the fork'sSystemMessageUtils.tsx: it has 17 strings and usesextractTimestamp(id) % messageList.length, andSnowflake::timestamp_millisadds the epoch the same way. The code is right. The spec §3.5 text should be corrected.Message.callis not modelled. #375 tracks this.HoverCard(reactions.rs) builds its "bridge" upward from the card (y: card.y,height: card.height + GAP). When the card flips below the pill (not enough room above), the gap sits above the card and is not covered. Moving the pointer from the pill down to the card then closes it, so the "Click to view all reactions" card cannot be reached near the top of the window.Spine(reply_preview.rs) draws below its own layout bounds (height: HEIGHT + SPACING + SPINE_GAP - top), in awith_layerclip it computes itself. Check that it stays clipped by the message list's scrollable at the top edge.system::content, each word is padded on its left (SPACE), so a wrapped line can start with a 4.4 px indent (the implementer flagged this). Cosmetic.highlighted()prefers the mention style over the jump style when both apply. Please confirm the original does the same (.messageMentionedvs.messageHighlightorder).Verdict: approve. There are no blocking findings, and local CI is green.