Screen share 31: Acceptance (#178) #289
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "screenshare-31-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: screenshare-21-app-screenshare-runtime, screenshare-29-parity-screenshots, screenshare-30-packaging-ci, screenshare-19-spike-hw-encode-windows
What this builds
apps/fluxer/tests/screenshare_acceptance.rs::screenshare_session_end_to_end: one session of the whole client on the devserverscreensharescenario withFakeRoom,NullHostand the fake capture backends. login → join → go live (in-app picker, fake screen) → publication, then the op 4 sequence from--record(noself_stream: truebefore the publication, own key after) → own tile and room frames → preview upload → relay joins and watches the own stream (viewer count 1 instreams_in_channel/spectatorsand on the devserver), then leaves (0) → quality changed live (Custom, 480p, 15 fps: capture target and room encoding change in place, same publication) → stop (unpublished, capture off, server clear, own key dropped,self_stream: false) → watch ada (subscribed, her devserver viewer count 2 → 3, frames on the bus) → stream volume 50 % (store curve ratio, user volume does not apply) → stop watching (unsubscribed, frames gone, count 3 → 2, nothing heard) → go live again and the devserver'shangout-loses-stream(STREAM revoked) stops the share while voice stays connected.docs/acceptance/screenshare.md: spec §2 item by item (tests covering each), the live checklist for Charles (items 1–7 and 9 with exact steps, what to look for, the Electron console lines for codec selection and "Copy stats JSON" /chrome://webrtc-internalsas the stats check), openquestionandfollow-upissues, known gaps.How it was tested
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally on Linux (on the merged base before any change, and again with this commit).FLUXER_LIVEKIT_TESTS(#120),FLUXER_CAPTURE_TESTS,FLUXER_HW_ENCODER_TESTS(this task adds no real-device test); nothing against the live instance, nothing on Windows.Deviations and findings
self_stream: false; the viewer-leave chime plays when watching stops), now waited for. No client bug found.FrameBusto the views), so native-side video and previews cannot be checked live until it lands. #193 (stream chimes) looks done on this base; Charles to confirm and close.Closes #178
🤖 Generated with Claude Code
Review: Screen share 31 Acceptance (independent reviewer)
I reviewed the diff
7fc45fd..origin/screenshare-31-acceptancewithout relying on the implementer's notes. It touches 2 files, both in the task's Files list:apps/fluxer/tests/screenshare_acceptance.rsanddocs/acceptance/screenshare.md.Plan steps
stream_gain, her viewer count from 2 to 3 to 2), stop watching, and STREAM revoked mid-share. Assertions are made on snapshots and selectors, on the fake room and capture, on the devserver streams and on the--recordop 4s.questionandfollow-upissues, and the known gaps.ScreenShareCodecNegotiation.ts,VoiceEngineV2AppScreenShareLiveKitFlows.ts), as do "Copy stats JSON" in the stream menu, the log linevoice: screen share encoder opened(rtc.rs),FLUXER_LOGand the Linux log directory.Handle::frame_bus, but is not handed to the views). #288 is open with thefollow-uplabel.Interfaces: this task has no Interfaces block, and the diff changes no public API.
Invariants: no crate code changed, so the dependency rules hold. The test contains no secrets or tokens and uses only the devserver and fakes.
Review Focus: item 7 (self-exclusion) is in the live checklist (§2 step 2 and step 4), and the test asserts
excluded_pid == std::process::id(). Item 1 is checked at acceptance level; its tests live in Screen share 10.Findings
self_stream: truebefore the publication". The test reads the op 4s only after the publication is confirmed and checks thatself_streamcomes at or before the own key. It never checks that no op 4 withself_stream: truewas sent before the room published. The guarantee itself is tested bystream_golive.rs::self_stream_never_true_before_publication. Either reword the row or cite that test.self_stream: falsefirst, then the key leaves) that the test does not check. The test only checks that the last op 4 hasself_stream: falseand no own key. It also does not check thatself_stream: falsewas sent before the unpublish (Review Focus 1). That order is covered in Screen share 10, not here.CI: I ran
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree at867ad08. It is green: all steps passed andscreenshare_session_end_to_endpassed. LiveKit interop was skipped (env var not set).Verdict: approved. There are no blocking findings and local CI is green. The two minor findings are doc wording only.
🤖 Generated with Claude Code