fix(app): join voice rooms with the LiveKit room on real instances #203
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-wire-livekit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on #197.
The application runtime (Voice task 14) used a placeholder room that refused every join with "this build cannot join voice rooms yet (no LiveKit client)". It was meant to be replaced when the LiveKit room (task 13) landed; task 13 merged later and nothing replaced it, so voice only worked with
--devserver. The acceptance task did not catch it because every automated voice path uses the fake room or the interop test offluxer-voicealone.VoiceBackend::systemnow usesLiveKitRoom.Not yet verified: a join against a real instance (being tried by the owner), Windows.
🤖 Generated with Claude Code
The server deduplicates users in READY: guilds[].members[].user is {"id"} only and the full users are in the top-level `users` list (session_ready_collect.erl). fluxer-proto required a full user on every member, so a real READY failed to parse as a whole and the client showed no guilds, no DMs and "Unknown User". - fluxer-proto: `UserRef` (full user or `{"id"}` reference) for GuildMember::user, Presence::user (the offline PRESENCE_UPDATE sent when a friend/group-DM subscription is dropped) and GUILD_MEMBER_REMOVE's user (always a reference). `ReadyPayload::resolve_users()` fills the references from `users` and `user`. - Every list of ReadyPayload / GuildReadyData is read leniently: a malformed entry is dropped with a warning instead of losing the session; a malformed guild object leaves `properties: None`. Adds `tracing` to fluxer-proto for that warning. - fluxer-core: members and presences that are references add nothing to the user cache; names come from READY.users, unknown users show as Unknown User. - fixtures/gateway/ready.json now has the real structure (member user references, `users` with every member, relationships without `user`, empty guild presences, sessions/version/...), with the same fake identities. The devserver resolves it before indexing message authors. - tests/replay.rs in fluxer-core: with FLUXER_REPLAY_DIR set, replays a --record recording through the parsers and the store and reports mismatches by key path and redacted error only; skipped otherwise. - Regression tests: references resolved via `users`, an unknown member user id kept, malformed members/channels/users/guilds dropped without failing READY, references in GUILD_MEMBER_REMOVE and PRESENCE_UPDATE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>The real server sends only the user's own member in READY and no guild presences; the other members arrive in GUILD_MEMBER_LIST_UPDATE after an op 14 (LAZY_REQUEST) subscription, which the client never sent. - fluxer-proto: LazyRequest/GuildSubscription/MemberListRange, the GUILD_MEMBER_LIST_UPDATE and GUILD_SYNC dispatches, with a fixture. - fluxer-core: MemberLists sends {active, sync} on guild select and the shown channel's member list ranges, again after every reconnect; keeps the server list and feeds member_list, users and presences from it; falls back to READY's members when no answer comes. GUILD_CREATE and GUILD_SYNC add their partial members instead of replacing them. - fluxer-ui: group headers show the server's count. - fluxer-devserver: READY and GUILD_CREATE carry only the signed-in member; op 14 is answered with a server-shaped member list, and presence changes resend it. New end-to-end test. Follow-ups: #195 (scroll ranges past 1,000 rows), #196 (PASSIVE_UPDATES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>The runtime of Voice task 14 used a placeholder room that refused every join ("this build cannot join voice rooms yet") until the LiveKit room of task 13 existed. Task 13 merged later and nothing replaced the placeholder, so voice only worked with --devserver. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>