Voice 24: Parity list and screenshot suite for voice (#85) #143

Manually merged
charles merged 0 commits from voice-24-parity-screenshots into voice 2026-11-11 23:43:32 +00:00
Owner

Stacked on: voice-19-ui-soundboard, voice-20-ui-participant-menu, voice-21-ui-voice-settings, voice-22-ui-dm-calls (merged into this branch; conflicts in app.rs, message.rs, screens/main/mod.rs, theme/icons.rs, tests/screenshots.rs and the fluxer-ui README were resolved by keeping both sides: Escape closes the participant menu, then the settings, then the soundboard; FileDropped and the push-to-talk Key events both stay).

What this builds

  • docs/parity/voice.md: a feature-level parity table. It covers every item of the facts §7 voice UI inventory (sidebar, connection panel, control bar, call view, DM calls, soundboard, every participant-menu item, stats for nerds) and every voice setting of facts §8. Each row is done (with "Partial:" when something is missing), later (N), or not planned with a reason.
  • docs/parity/settings.toml: the voice entries that were still open now point at #142, and the keybinds entries for push-to-talk, mute and deafen say what works now and what waits for sub-project 6.
  • docs/parity/README.md (new): what the two parity files are and how they are checked.
  • cargo xtask parity-check now also validates voice.md when no --file is given. A row fails without a status, with a later that names no sub-project, or with a not planned that gives no reason.
  • Screenshot suite: all nine Phase 4 screens (sidebar_voice, voice_panel_connected, voice_panel_failed, call_view_4, call_view_compact, soundboard_popout, participant_menu, settings_voice, incoming_call) run in the one tests/screenshots.rs suite. The README table in docs/screenshots/ now lists the three that were missing, and their reference images were added to docs/screenshots/. The new crates/fluxer-ui/tests/screenshot_suite.rs reads files only (no GPU) and checks that:
    • every golden has a test, and every test has a golden;
    • every voice screen is in the suite;
    • the README table lists every test;
    • every voice screen has a reference image.

Testing

  • I wrote the tests first and saw them fail: 2 of the 5 suite tests and 2 of the 3 xtask voice_problems unit tests (commit 5ce9b77). With the implementation they pass.
  • cargo xtask parity-check --fork ~/src/fluxer-soundboard passes: 126 settings. extract-parity --dry-run adds nothing, so the hand-edited notes survive a re-extract.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally, and all 12 screenshot tests pass.

Deviations

  • The plan's Modify: docs/parity/README.md did not exist, so I created it.
  • I extended xtask/src/parity_check.rs so that "parity-check passes" also covers voice.md. This is outside the task's Files list but small, and it comes with unit tests.
  • No golden changed: every Phase 4 screenshot was already in the suite and green after the merges.
  • I opened follow-up #142 for the voice gaps the spec places in sub-project 2 that are not built: the entrance sound picker, the participant menu's entrance-sound submenu, display settings that no view reads yet, connection volume, and new-device alerts. Those rows say later (2). Charles decides whether they stay in Voice or move to 7.
  • Commits carry the Co-Authored-By line of the model that wrote them (Opus 5.5), not the CLAUDE.md Fable line.

Closes #85

🤖 Generated with Claude Code

Stacked on: voice-19-ui-soundboard, voice-20-ui-participant-menu, voice-21-ui-voice-settings, voice-22-ui-dm-calls (merged into this branch; conflicts in `app.rs`, `message.rs`, `screens/main/mod.rs`, `theme/icons.rs`, `tests/screenshots.rs` and the fluxer-ui README were resolved by keeping both sides: Escape closes the participant menu, then the settings, then the soundboard; `FileDropped` and the push-to-talk `Key` events both stay). ## What this builds - `docs/parity/voice.md`: a feature-level parity table. It covers every item of the facts §7 voice UI inventory (sidebar, connection panel, control bar, call view, DM calls, soundboard, every participant-menu item, stats for nerds) and every voice setting of facts §8. Each row is `done` (with "Partial:" when something is missing), `later (N)`, or `not planned` with a reason. - `docs/parity/settings.toml`: the voice entries that were still open now point at #142, and the keybinds entries for push-to-talk, mute and deafen say what works now and what waits for sub-project 6. - `docs/parity/README.md` (new): what the two parity files are and how they are checked. - `cargo xtask parity-check` now also validates `voice.md` when no `--file` is given. A row fails without a status, with a `later` that names no sub-project, or with a `not planned` that gives no reason. - Screenshot suite: all nine Phase 4 screens (`sidebar_voice`, `voice_panel_connected`, `voice_panel_failed`, `call_view_4`, `call_view_compact`, `soundboard_popout`, `participant_menu`, `settings_voice`, `incoming_call`) run in the one `tests/screenshots.rs` suite. The README table in `docs/screenshots/` now lists the three that were missing, and their reference images were added to `docs/screenshots/`. The new `crates/fluxer-ui/tests/screenshot_suite.rs` reads files only (no GPU) and checks that: - every golden has a test, and every test has a golden; - every voice screen is in the suite; - the README table lists every test; - every voice screen has a reference image. ## Testing - I wrote the tests first and saw them fail: 2 of the 5 suite tests and 2 of the 3 xtask `voice_problems` unit tests (commit 5ce9b77). With the implementation they pass. - `cargo xtask parity-check --fork ~/src/fluxer-soundboard` passes: 126 settings. `extract-parity --dry-run` adds nothing, so the hand-edited notes survive a re-extract. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally, and all 12 screenshot tests pass. ## Deviations - The plan's `Modify: docs/parity/README.md` did not exist, so I created it. - I extended `xtask/src/parity_check.rs` so that "parity-check passes" also covers `voice.md`. This is outside the task's Files list but small, and it comes with unit tests. - No golden changed: every Phase 4 screenshot was already in the suite and green after the merges. - I opened follow-up #142 for the voice gaps the spec places in sub-project 2 that are not built: the entrance sound picker, the participant menu's entrance-sound submenu, display settings that no view reads yet, connection volume, and new-device alerts. Those rows say `later (2)`. Charles decides whether they stay in Voice or move to 7. - Commits carry the `Co-Authored-By` line of the model that wrote them (Opus 5.5), not the CLAUDE.md Fable line. Closes #85 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-core/README.md
The panel above the user area while in voice (VoiceConnectionStatusInner):
"Connecting..." / "In voice chat" / "Connection failed", the channel line,
the signal-strength icon with the original's latency thresholds and its
"Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line
opens the connection details (VoiceDetailsPopout): ping graph of the last
30 round trips, current and average ping, device, duration, participants,
endpoint (click copies). The user area moves to its own module and gains
the microphone and speaker buttons with the original's states and
tooltips (effective mute, moderator mute/deafen and no-speak lock); a
right-click on either opens Settings -> Voice & video.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test(ui): voice panel goldens drawn on lavapipe
All checks were successful
ci / Linux (x86_64) (push) Successful in 13m12s
ci / Windows (x64) (push) Successful in 19m35s
8c37b507c7
voice_panel_connected and voice_panel_failed are new; main-general and
sidebar_voice are redrawn because the user area gained the microphone
and speaker buttons. All drawn on the reference renderer (Ubuntu 22.04
lavapipe, the recipe of docs/screenshots/README.md); the two new frames
are also under docs/screenshots for the PR.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/voice' into voice-17-ui-voice-panel
All checks were successful
ci / Windows (x64) (push) Successful in 8m3s
ci / Linux (x86_64) (push) Successful in 28m17s
80c11ff71c
# Conflicts:
#	crates/fluxer-core/README.md
feat(core): soundboard and entrance sounds
All checks were successful
ci / Linux (x86_64) (push) Successful in 8m43s
ci / Windows (x64) (push) Successful in 8m5s
add3ec139a
Refs #71

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #82

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): call view and control bar
All checks were successful
ci / Windows (x64) (push) Successful in 7m58s
ci / Linux (x86_64) (push) Successful in 9m7s
a7ec434243
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): voice and video settings
All checks were successful
ci / Windows (x64) (push) Successful in 13m18s
ci / Linux (x86_64) (push) Successful in 24m1s
99ffc6f0d9
Refs #82

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #83

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #81

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #80

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(ui): DM calls
All checks were successful
ci / Linux (x86_64) (push) Successful in 9m0s
ci / Windows (x64) (push) Successful in 11m48s
209c55cfc0
Incoming-call prompt over any screen, the DM header's call button, and
the row of call participants (ringing ones dimmed) with the call's
controls above the DM chat.

Refs #83

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UserAction::{ServerMute, ServerDeafen, DisconnectUser, MoveUser} become
ApiRequest::UpdateMemberVoice (guild member PATCH with only its voice
fields). The runtime answers the request with an error until the member
PATCH exists in fluxer-api (#134).

Refs #81

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(ui): voice participant context menu
All checks were successful
ci / Windows (x64) (push) Successful in 7m43s
ci / Linux (x86_64) (push) Successful in 24m30s
f3c1f6932d
Refs #81

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The control bar's soundboard button opens a popout over the call: search,
favourites, a section per guild with three sounds per row, stars, the
original's notices (permission, speak, muted, deafened, cooldown), a
right-click menu with rename and delete when permitted, and an upload
dialog (path typed or dropped; the shell reads the file).

Refs #80

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix: read picked sound files through an injected reader
Some checks failed
ci / Linux (x86_64) (push) Has been cancelled
ci / Windows (x64) (push) Has been cancelled
cfba6fef85
fluxer-ui no longer opens files: the shell hands the path the upload
dialog asks for to an injected files::SoundFileReader, implemented by
fluxer_platform::files::SoundFiles on the runtime's blocking pool (size
checked before reading, read capped one byte past the limit) and passed
in by apps/fluxer, like ImageLoader.

A file read answers only the opening of the dialog that asked for it
(FileRequest::answer), so a late read after Cancel and reopen is ignored.
Escape closes the upload dialog, then the sound menu, then the popout.

Refs #80

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix: add the soundboard_popout golden, drawn on lavapipe
All checks were successful
ci / Windows (x64) (push) Successful in 12m49s
ci / Linux (x86_64) (push) Successful in 22m30s
443a3f1c27
Rendered in the ubuntu:22.04 CI image with WGPU_BACKEND=vulkan and the
lavapipe ICD; all nine screenshot tests (call_view_* included) pass there.

Refs #80

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/src/app.rs
#	crates/fluxer-ui/src/message.rs
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/tests/screenshots.rs
# Conflicts:
#	crates/fluxer-ui/src/app.rs
#	crates/fluxer-ui/src/message.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	crates/fluxer-ui/tests/screenshots.rs
# Conflicts:
#	crates/fluxer-ui/README.md
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	crates/fluxer-ui/tests/screenshots.rs
Refs #85

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(parity): voice
All checks were successful
ci / Linux (x86_64) (push) Successful in 9m23s
ci / Windows (x64) (push) Successful in 12m27s
84dd32738c
Feature-level voice parity table (docs/parity/voice.md) for every item of
facts §7 and every voice setting of facts §8; parity-check validates it.
Voice notes in settings.toml point at the open gaps (#142). The screenshot
README lists every Phase 4 screen; their reference images are in
docs/screenshots; tests/screenshot_suite.rs keeps the suite whole.

Refs #85

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Voice 24 (parity list and screenshot suite)

Reviewed 38116f7..84dd327 cold (2 commits: failing tests, then docs(parity): voice).

Plan step check

  • Every facts §7 UI item (sidebar, connection panel, control bar, call view, DM calls, soundboard, every participant-menu item, stats for nerds) and every facts §8 voice setting has a row in docs/parity/voice.md with done / later (N) / not planned plus reason. I spot-checked the native paths and functions it names (voice_participants::{user_count_badge, collapsed_category}, participant_menu.rs MOVE_MEMBERS gating, the "Show connection IDs" switch in settings/voice_video/soundboard.rs, calls/dm_header.rs, widgets/slider.rs, ...). They all exist.
  • cargo xtask parity-check passes. It now also validates voice.md and has unit tests for every status kind and every gap.
  • All 9 Phase 4 screens are in the one tests/screenshots.rs suite. The new tests/screenshot_suite.rs (no GPU, cfg(not(windows))) checks that goldens and tests match one to one, that the voice screens are present, that the README has a row for each test, and that each screen has a reference image.
  • The commit is titled docs(parity): voice, as the plan says.

Interfaces / invariants: Task 24 has no Interfaces block. No fluxer-core or fluxer-ui source changed: only xtask and a test file. No new dependencies. No secrets or tokens. #142 exists (labels follow-up, parity) and is referenced.

Findings (all minor, none blocking)

  1. minor: xtask/src/parity_check.rs and crates/fluxer-ui/tests/screenshot_suite.rs are outside the task's Files list. The PR body says so. Both are test or check code and fit the task's intent.
  2. minor: docs/screenshots/{incoming-call,participant-menu,soundboard-popout,settings-voice}.png are byte-identical copies of the native goldens. That matches the directory's convention ("what a screen looked like when merged"), but no Electron side-by-side was added.
  3. minor: the connection-panel rows of voice.md do not list the "Disconnected" state from facts §7.
  4. minor: voice_problems splits cells on every |. An escaped \| in a future row would be reported as a wrong column count. Nothing in the file uses one today.
  5. minor: wording differs between the two files. settings.toml has voice-video-voice-channels as done (Partial). voice.md has showVoiceConnectionIdPrefV2 as later (2). Both point at #142, so this is consistent in substance.

CI: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: all steps passed. 12 screenshot tests ok, 4 suite-completeness tests ok, voice parity unit tests ok.

Verdict: APPROVED. No blocking findings and local CI is green.

🤖 Generated with Claude Code

## Independent review: Voice 24 (parity list and screenshot suite) Reviewed `38116f7..84dd327` cold (2 commits: failing tests, then `docs(parity): voice`). **Plan step check** - Every facts §7 UI item (sidebar, connection panel, control bar, call view, DM calls, soundboard, every participant-menu item, stats for nerds) and every facts §8 voice setting has a row in `docs/parity/voice.md` with `done` / `later (N)` / `not planned` plus reason. I spot-checked the native paths and functions it names (`voice_participants::{user_count_badge, collapsed_category}`, `participant_menu.rs` MOVE_MEMBERS gating, the "Show connection IDs" switch in `settings/voice_video/soundboard.rs`, `calls/dm_header.rs`, `widgets/slider.rs`, ...). They all exist. - `cargo xtask parity-check` passes. It now also validates `voice.md` and has unit tests for every status kind and every gap. - All 9 Phase 4 screens are in the one `tests/screenshots.rs` suite. The new `tests/screenshot_suite.rs` (no GPU, `cfg(not(windows))`) checks that goldens and tests match one to one, that the voice screens are present, that the README has a row for each test, and that each screen has a reference image. - The commit is titled `docs(parity): voice`, as the plan says. **Interfaces / invariants:** Task 24 has no Interfaces block. No fluxer-core or fluxer-ui source changed: only xtask and a test file. No new dependencies. No secrets or tokens. #142 exists (labels follow-up, parity) and is referenced. **Findings (all minor, none blocking)** 1. *minor*: `xtask/src/parity_check.rs` and `crates/fluxer-ui/tests/screenshot_suite.rs` are outside the task's Files list. The PR body says so. Both are test or check code and fit the task's intent. 2. *minor*: `docs/screenshots/{incoming-call,participant-menu,soundboard-popout,settings-voice}.png` are byte-identical copies of the native goldens. That matches the directory's convention ("what a screen looked like when merged"), but no Electron side-by-side was added. 3. *minor*: the connection-panel rows of `voice.md` do not list the "Disconnected" state from facts §7. 4. *minor*: `voice_problems` splits cells on every `|`. An escaped `\|` in a future row would be reported as a wrong column count. Nothing in the file uses one today. 5. *minor*: wording differs between the two files. `settings.toml` has `voice-video-voice-channels` as `done` (Partial). `voice.md` has `showVoiceConnectionIdPrefV2` as `later (2)`. Both point at #142, so this is consistent in substance. **CI:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: all steps passed. 12 screenshot tests ok, 4 suite-completeness tests ok, voice parity unit tests ok. **Verdict: APPROVED.** No blocking findings and local CI is green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
charles manually merged commit 09de2137ea into voice 2026-11-11 23:43:32 +00:00
Sign in to join this conversation.
No description provided.