Voice 24: Parity list and screenshot suite for voice (#85) #143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-24-parity-screenshots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: voice-19-ui-soundboard, voice-20-ui-participant-menu, voice-21-ui-voice-settings, voice-22-ui-dm-calls (merged into this branch; conflicts in
app.rs,message.rs,screens/main/mod.rs,theme/icons.rs,tests/screenshots.rsand the fluxer-ui README were resolved by keeping both sides: Escape closes the participant menu, then the settings, then the soundboard;FileDroppedand the push-to-talkKeyevents both stay).What this builds
docs/parity/voice.md: a feature-level parity table. It covers every item of the facts §7 voice UI inventory (sidebar, connection panel, control bar, call view, DM calls, soundboard, every participant-menu item, stats for nerds) and every voice setting of facts §8. Each row isdone(with "Partial:" when something is missing),later (N), ornot plannedwith a reason.docs/parity/settings.toml: the voice entries that were still open now point at #142, and the keybinds entries for push-to-talk, mute and deafen say what works now and what waits for sub-project 6.docs/parity/README.md(new): what the two parity files are and how they are checked.cargo xtask parity-checknow also validatesvoice.mdwhen no--fileis given. A row fails without a status, with alaterthat names no sub-project, or with anot plannedthat gives no reason.sidebar_voice,voice_panel_connected,voice_panel_failed,call_view_4,call_view_compact,soundboard_popout,participant_menu,settings_voice,incoming_call) run in the onetests/screenshots.rssuite. The README table indocs/screenshots/now lists the three that were missing, and their reference images were added todocs/screenshots/. The newcrates/fluxer-ui/tests/screenshot_suite.rsreads files only (no GPU) and checks that:Testing
voice_problemsunit tests (commit5ce9b77). With the implementation they pass.cargo xtask parity-check --fork ~/src/fluxer-soundboardpasses: 126 settings.extract-parity --dry-runadds nothing, so the hand-edited notes survive a re-extract.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally, and all 12 screenshot tests pass.Deviations
Modify: docs/parity/README.mddid not exist, so I created it.xtask/src/parity_check.rsso that "parity-check passes" also coversvoice.md. This is outside the task's Files list but small, and it comes with unit tests.later (2). Charles decides whether they stay in Voice or move to 7.Co-Authored-Byline of the model that wrote them (Opus 5.5), not the CLAUDE.md Fable line.Closes #85
🤖 Generated with Claude Code
The panel above the user area while in voice (VoiceConnectionStatusInner): "Connecting..." / "In voice chat" / "Connection failed", the channel line, the signal-strength icon with the original's latency thresholds and its "Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line opens the connection details (VoiceDetailsPopout): ping graph of the last 30 round trips, current and average ping, device, duration, participants, endpoint (click copies). The user area moves to its own module and gains the microphone and speaker buttons with the original's states and tooltips (effective mute, moderator mute/deafen and no-speak lock); a right-click on either opens Settings -> Voice & video. Refs #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>UserAction::{ServerMute, ServerDeafen, DisconnectUser, MoveUser} become ApiRequest::UpdateMemberVoice (guild member PATCH with only its voice fields). The runtime answers the request with an error until the member PATCH exists in fluxer-api (#134). Refs #81 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Voice 24 (parity list and screenshot suite)
Reviewed
38116f7..84dd327cold (2 commits: failing tests, thendocs(parity): voice).Plan step check
docs/parity/voice.mdwithdone/later (N)/not plannedplus reason. I spot-checked the native paths and functions it names (voice_participants::{user_count_badge, collapsed_category},participant_menu.rsMOVE_MEMBERS gating, the "Show connection IDs" switch insettings/voice_video/soundboard.rs,calls/dm_header.rs,widgets/slider.rs, ...). They all exist.cargo xtask parity-checkpasses. It now also validatesvoice.mdand has unit tests for every status kind and every gap.tests/screenshots.rssuite. The newtests/screenshot_suite.rs(no GPU,cfg(not(windows))) checks that goldens and tests match one to one, that the voice screens are present, that the README has a row for each test, and that each screen has a reference image.docs(parity): voice, as the plan says.Interfaces / invariants: Task 24 has no Interfaces block. No fluxer-core or fluxer-ui source changed: only xtask and a test file. No new dependencies. No secrets or tokens. #142 exists (labels follow-up, parity) and is referenced.
Findings (all minor, none blocking)
xtask/src/parity_check.rsandcrates/fluxer-ui/tests/screenshot_suite.rsare outside the task's Files list. The PR body says so. Both are test or check code and fit the task's intent.docs/screenshots/{incoming-call,participant-menu,soundboard-popout,settings-voice}.pngare byte-identical copies of the native goldens. That matches the directory's convention ("what a screen looked like when merged"), but no Electron side-by-side was added.voice.mddo not list the "Disconnected" state from facts §7.voice_problemssplits cells on every|. An escaped\|in a future row would be reported as a wrong column count. Nothing in the file uses one today.settings.tomlhasvoice-video-voice-channelsasdone(Partial).voice.mdhasshowVoiceConnectionIdPrefV2aslater (2). Both point at #142, so this is consistent in substance.CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed. 12 screenshot tests ok, 4 suite-completeness tests ok, voice parity unit tests ok.Verdict: APPROVED. No blocking findings and local CI is green.
🤖 Generated with Claude Code