Voice 22: DM calls UI (#83) #136

Manually merged
charles merged 0 commits from voice-22-ui-dm-calls into voice 2026-11-11 23:43:30 +00:00
Owner

Stacked on: origin/voice-18-ui-call-view

What

  • screens::main::calls::incoming: the incoming-call prompt (clone of IncomingCallUI.tsx / .module.css: "Incoming call" header, 80 px avatar in a 96 px disc, caller name, "Voice call", Reject (rotated phone, #ff3b30) and Accept (#34c759) circles, drag pill). app::view lays it over whatever screen is open (main, settings), centred in the 320x400 overlay box as the original places it.
  • screens::main::calls::dm_header: the DM header call button (CallButtons.tsx labels: Start / Join / Leave voice call -> StartCall / AcceptCall / EndCall) and the call row above the DM chat (CallParticipantsRow.tsx): self, then who is in the call, then who is rung (dimmed, brightness 0.55); under it the call control bar (disconnect -> EndCall), or Accept/Reject while it rings, or "Join call".
  • main::Message::Calls(calls::Message { Accept, Decline, Start, HangUp, Controls }); new icon phone-incoming-fill (Phosphor, from the fork's node_modules).

Tests

  • tests/calls.rs: incoming_prompt_emits_accept_and_decline (also over the settings screen), dm_header_button_starts_call, ringing_participants_are_dimmed; unit test of the message mapping.
  • Screenshot incoming_call (golden rendered on lavapipe in ubuntu:22.04; all 9 screenshot tests pass there). FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally.
  • Screenshot: fixtures/golden/incoming_call.png on this branch. Reference: fork fluxer_app/src/features/voice/components/IncomingCallUI.module.css (no Electron screenshot in the fork's assets); dimensions are taken from that CSS.

Deviations

  • "Ignore" (silence without answering) is left out on the prompt and the row: the core has no action for it (Task 11 interfaces have Accept/Decline only). Prompt dragging, the avatar pulse animation, the row resize and the participants' context menu are left out.
  • Row avatars use the default 64 px / 12 px gap instead of the original's size-to-fit metrics.
  • Touched outside the Files list (minimal wiring): screens/main/{mod.rs,header.rs}, app.rs, theme/icons.rs, tests/common/mod.rs (call helper), tests/screenshots.rs, README.

Closes #83

🤖 Generated with Claude Code

Stacked on: origin/voice-18-ui-call-view ## What - `screens::main::calls::incoming`: the incoming-call prompt (clone of `IncomingCallUI.tsx` / `.module.css`: "Incoming call" header, 80 px avatar in a 96 px disc, caller name, "Voice call", Reject (rotated phone, #ff3b30) and Accept (#34c759) circles, drag pill). `app::view` lays it over whatever screen is open (main, settings), centred in the 320x400 overlay box as the original places it. - `screens::main::calls::dm_header`: the DM header call button (`CallButtons.tsx` labels: Start / Join / Leave voice call -> `StartCall` / `AcceptCall` / `EndCall`) and the call row above the DM chat (`CallParticipantsRow.tsx`): self, then who is in the call, then who is rung (dimmed, brightness 0.55); under it the call control bar (disconnect -> `EndCall`), or Accept/Reject while it rings, or "Join call". - `main::Message::Calls(calls::Message { Accept, Decline, Start, HangUp, Controls })`; new icon `phone-incoming-fill` (Phosphor, from the fork's node_modules). ## Tests - `tests/calls.rs`: `incoming_prompt_emits_accept_and_decline` (also over the settings screen), `dm_header_button_starts_call`, `ringing_participants_are_dimmed`; unit test of the message mapping. - Screenshot `incoming_call` (golden rendered on lavapipe in ubuntu:22.04; all 9 screenshot tests pass there). `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. - Screenshot: `fixtures/golden/incoming_call.png` on this branch. Reference: fork `fluxer_app/src/features/voice/components/IncomingCallUI.module.css` (no Electron screenshot in the fork's assets); dimensions are taken from that CSS. ## Deviations - "Ignore" (silence without answering) is left out on the prompt and the row: the core has no action for it (Task 11 interfaces have Accept/Decline only). Prompt dragging, the avatar pulse animation, the row resize and the participants' context menu are left out. - Row avatars use the default 64 px / 12 px gap instead of the original's size-to-fit metrics. - Touched outside the Files list (minimal wiring): `screens/main/{mod.rs,header.rs}`, `app.rs`, `theme/icons.rs`, `tests/common/mod.rs` (call helper), `tests/screenshots.rs`, README. Closes #83 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-core/README.md
The panel above the user area while in voice (VoiceConnectionStatusInner):
"Connecting..." / "In voice chat" / "Connection failed", the channel line,
the signal-strength icon with the original's latency thresholds and its
"Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line
opens the connection details (VoiceDetailsPopout): ping graph of the last
30 round trips, current and average ping, device, duration, participants,
endpoint (click copies). The user area moves to its own module and gains
the microphone and speaker buttons with the original's states and
tooltips (effective mute, moderator mute/deafen and no-speak lock); a
right-click on either opens Settings -> Voice & video.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test(ui): voice panel goldens drawn on lavapipe
All checks were successful
ci / Linux (x86_64) (push) Successful in 13m12s
ci / Windows (x64) (push) Successful in 19m35s
8c37b507c7
voice_panel_connected and voice_panel_failed are new; main-general and
sidebar_voice are redrawn because the user area gained the microphone
and speaker buttons. All drawn on the reference renderer (Ubuntu 22.04
lavapipe, the recipe of docs/screenshots/README.md); the two new frames
are also under docs/screenshots for the PR.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/voice' into voice-17-ui-voice-panel
All checks were successful
ci / Windows (x64) (push) Successful in 8m3s
ci / Linux (x86_64) (push) Successful in 28m17s
80c11ff71c
# Conflicts:
#	crates/fluxer-core/README.md
feat(core): soundboard and entrance sounds
All checks were successful
ci / Linux (x86_64) (push) Successful in 8m43s
ci / Windows (x64) (push) Successful in 8m5s
add3ec139a
Refs #71

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): call view and control bar
All checks were successful
ci / Windows (x64) (push) Successful in 7m58s
ci / Linux (x86_64) (push) Successful in 9m7s
a7ec434243
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #83

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(ui): DM calls
All checks were successful
ci / Linux (x86_64) (push) Successful in 9m0s
ci / Windows (x64) (push) Successful in 11m48s
209c55cfc0
Incoming-call prompt over any screen, the DM header's call button, and
the row of call participants (ringing ones dimmed) with the call's
controls above the DM chat.

Refs #83

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Voice 22 (DM calls UI)

Scope: a7ec434..origin/voice-22-ui-dm-calls (bd29093, 209c55c).

Checks

  1. Plan tests: incoming_prompt_emits_accept_and_decline, dm_header_button_starts_call and ringing_participants_are_dimmed are in crates/fluxer-ui/tests/calls.rs and assert what the plan names. The prompt shows "Ada L." with Reject/Accept, emits DeclineCall/AcceptCall, still appears over the settings screen, and goes away on decline. The header button goes Start → StartCall, Join → AcceptCall, Leave → EndCall, with the original's tooltip strings. A rung participant is dimmed (pixel check) and listed after self, and the control bar's disconnect sends EndCall. The incoming_call screenshot test and golden are present. OK.
  2. Interfaces: the incoming prompt is laid over any screen in app::view. The DM header call button sends StartCall. The participant row with its ringing state sits above the DM chat. Hanging up sends EndCall, and core's end_call leaves voice when connected there, which covers LeaveVoice. The semantics match Task 11's reducer (AcceptCall also handles "Join call"). OK.
  3. Invariants: no changes in fluxer-core, and no I/O in fluxer-ui. Nothing in src can panic on server data: unknown channels or users fall back to defaults and no unwrap/expect/indexing was added. No secrets in the code or fixtures. OK.
  4. Review Focus: no item belongs to Task 22.
  5. cargo xtask ci in the review worktree is green. fmt, clippy, deny and all tests passed, including the 3 tests in tests/calls.rs and the unit test messages_map_to_call_actions. The screenshot step was skipped on this host because FLUXER_SCREENSHOT_TESTS was not set. The implementer reports the golden passes on lavapipe/ubuntu:22.04; I did not re-run it.

Findings

  • [minor] calls/incoming.rs uses hard-coded --ic-* colours instead of theme tokens. They are literal values in IncomingCallUI.module.css, not theme tokens, and the code documents this. Acceptable, but worth flagging against the "theme tokens only" rule.
  • [minor] Deviations deferred without follow-up issues: "Ignore" (core has no action for it), prompt dragging, ring pulse, row resize and the participant context menu. CLAUDE.md requires deferred items to become follow-up issues linked from the PR before merge.
  • [minor] The incoming_call screenshot uses the test-local basic_scenario rather than the devserver voice scenario named in the Phase 4 preamble. This matches the other Phase 4 screenshot tests.
  • [note] Commits carry the Claude Opus 5.5 trailer (the model that wrote them), not the Fable 5.2 trailer in CLAUDE.md. This matches who did the work and is not a finding.

Verdict: APPROVED (0 blocking, 3 minor; ci green locally)

## Independent review: Voice 22 (DM calls UI) Scope: `a7ec434..origin/voice-22-ui-dm-calls` (bd29093, 209c55c). **Checks** 1. Plan tests: `incoming_prompt_emits_accept_and_decline`, `dm_header_button_starts_call` and `ringing_participants_are_dimmed` are in `crates/fluxer-ui/tests/calls.rs` and assert what the plan names. The prompt shows "Ada L." with Reject/Accept, emits `DeclineCall`/`AcceptCall`, still appears over the settings screen, and goes away on decline. The header button goes Start → `StartCall`, Join → `AcceptCall`, Leave → `EndCall`, with the original's tooltip strings. A rung participant is dimmed (pixel check) and listed after self, and the control bar's disconnect sends `EndCall`. The `incoming_call` screenshot test and golden are present. OK. 2. Interfaces: the incoming prompt is laid over any screen in `app::view`. The DM header call button sends `StartCall`. The participant row with its ringing state sits above the DM chat. Hanging up sends `EndCall`, and core's `end_call` leaves voice when connected there, which covers `LeaveVoice`. The semantics match Task 11's reducer (`AcceptCall` also handles "Join call"). OK. 3. Invariants: no changes in fluxer-core, and no I/O in fluxer-ui. Nothing in `src` can panic on server data: unknown channels or users fall back to defaults and no `unwrap`/`expect`/indexing was added. No secrets in the code or fixtures. OK. 4. Review Focus: no item belongs to Task 22. 5. `cargo xtask ci` in the review worktree is **green**. fmt, clippy, deny and all tests passed, including the 3 tests in `tests/calls.rs` and the unit test `messages_map_to_call_actions`. The screenshot step was skipped on this host because `FLUXER_SCREENSHOT_TESTS` was not set. The implementer reports the golden passes on lavapipe/ubuntu:22.04; I did not re-run it. **Findings** - [minor] `calls/incoming.rs` uses hard-coded `--ic-*` colours instead of theme tokens. They are literal values in `IncomingCallUI.module.css`, not theme tokens, and the code documents this. Acceptable, but worth flagging against the "theme tokens only" rule. - [minor] Deviations deferred without follow-up issues: "Ignore" (core has no action for it), prompt dragging, ring pulse, row resize and the participant context menu. CLAUDE.md requires deferred items to become `follow-up` issues linked from the PR before merge. - [minor] The `incoming_call` screenshot uses the test-local `basic_scenario` rather than the devserver `voice` scenario named in the Phase 4 preamble. This matches the other Phase 4 screenshot tests. - [note] Commits carry the `Claude Opus 5.5` trailer (the model that wrote them), not the `Fable 5.2` trailer in CLAUDE.md. This matches who did the work and is not a finding. **Verdict: APPROVED** (0 blocking, 3 minor; ci green locally)
charles manually merged commit 09de2137ea into voice 2026-11-11 23:43:30 +00:00
Sign in to join this conversation.
No description provided.