Voice 22: DM calls UI (#83) #136
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-22-ui-dm-calls"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/voice-18-ui-call-view
What
screens::main::calls::incoming: the incoming-call prompt (clone ofIncomingCallUI.tsx/.module.css: "Incoming call" header, 80 px avatar in a 96 px disc, caller name, "Voice call", Reject (rotated phone, #ff3b30) and Accept (#34c759) circles, drag pill).app::viewlays it over whatever screen is open (main, settings), centred in the 320x400 overlay box as the original places it.screens::main::calls::dm_header: the DM header call button (CallButtons.tsxlabels: Start / Join / Leave voice call ->StartCall/AcceptCall/EndCall) and the call row above the DM chat (CallParticipantsRow.tsx): self, then who is in the call, then who is rung (dimmed, brightness 0.55); under it the call control bar (disconnect ->EndCall), or Accept/Reject while it rings, or "Join call".main::Message::Calls(calls::Message { Accept, Decline, Start, HangUp, Controls }); new iconphone-incoming-fill(Phosphor, from the fork's node_modules).Tests
tests/calls.rs:incoming_prompt_emits_accept_and_decline(also over the settings screen),dm_header_button_starts_call,ringing_participants_are_dimmed; unit test of the message mapping.incoming_call(golden rendered on lavapipe in ubuntu:22.04; all 9 screenshot tests pass there).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally.fixtures/golden/incoming_call.pngon this branch. Reference: forkfluxer_app/src/features/voice/components/IncomingCallUI.module.css(no Electron screenshot in the fork's assets); dimensions are taken from that CSS.Deviations
screens/main/{mod.rs,header.rs},app.rs,theme/icons.rs,tests/common/mod.rs(call helper),tests/screenshots.rs, README.Closes #83
🤖 Generated with Claude Code
The panel above the user area while in voice (VoiceConnectionStatusInner): "Connecting..." / "In voice chat" / "Connection failed", the channel line, the signal-strength icon with the original's latency thresholds and its "Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line opens the connection details (VoiceDetailsPopout): ping graph of the last 30 round trips, current and average ping, device, duration, participants, endpoint (click copies). The user area moves to its own module and gains the microphone and speaker buttons with the original's states and tooltips (effective mute, moderator mute/deafen and no-speak lock); a right-click on either opens Settings -> Voice & video. Refs #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Voice 22 (DM calls UI)
Scope:
a7ec434..origin/voice-22-ui-dm-calls(bd29093,209c55c).Checks
incoming_prompt_emits_accept_and_decline,dm_header_button_starts_callandringing_participants_are_dimmedare incrates/fluxer-ui/tests/calls.rsand assert what the plan names. The prompt shows "Ada L." with Reject/Accept, emitsDeclineCall/AcceptCall, still appears over the settings screen, and goes away on decline. The header button goes Start →StartCall, Join →AcceptCall, Leave →EndCall, with the original's tooltip strings. A rung participant is dimmed (pixel check) and listed after self, and the control bar's disconnect sendsEndCall. Theincoming_callscreenshot test and golden are present. OK.app::view. The DM header call button sendsStartCall. The participant row with its ringing state sits above the DM chat. Hanging up sendsEndCall, and core'send_callleaves voice when connected there, which coversLeaveVoice. The semantics match Task 11's reducer (AcceptCallalso handles "Join call"). OK.srccan panic on server data: unknown channels or users fall back to defaults and nounwrap/expect/indexing was added. No secrets in the code or fixtures. OK.cargo xtask ciin the review worktree is green. fmt, clippy, deny and all tests passed, including the 3 tests intests/calls.rsand the unit testmessages_map_to_call_actions. The screenshot step was skipped on this host becauseFLUXER_SCREENSHOT_TESTSwas not set. The implementer reports the golden passes on lavapipe/ubuntu:22.04; I did not re-run it.Findings
calls/incoming.rsuses hard-coded--ic-*colours instead of theme tokens. They are literal values inIncomingCallUI.module.css, not theme tokens, and the code documents this. Acceptable, but worth flagging against the "theme tokens only" rule.follow-upissues linked from the PR before merge.incoming_callscreenshot uses the test-localbasic_scenariorather than the devservervoicescenario named in the Phase 4 preamble. This matches the other Phase 4 screenshot tests.Claude Opus 5.5trailer (the model that wrote them), not theFable 5.2trailer in CLAUDE.md. This matches who did the work and is not a finding.Verdict: APPROVED (0 blocking, 3 minor; ci green locally)