Voice 21: Settings → Voice & Video (#82) #133
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-21-ui-voice-settings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Settings → Voice & video → Audio (
crates/fluxer-ui/src/screens/settings/voice_video/), cloned from the fork'sUserVoiceTab.tsx:571-756, sections in the original's order:SetInputDevice/SetOutputDevicevoice.input_level, brand colour while the gate is open) and play/stop button →StartMicTest/StopMicTest.voiceyet.Video stays a placeholder for sub-project 3.
PTT recorder: a small custom widget. Click it, press a key, and that key is stored as
VoiceSettingChange::PttKey(Some(code)), spelled like the web'sKeyboardEvent.code("KeyF"). Escape or a click cancels. The shell (app.rs) now sendsUserAction::PttKey { down }for that key when the window has focus and no widget took the key. No other code sent it, so push-to-talk could not work without this.Tests
tests/settings_voice.rs:sections_in_original_order,custom_mode_reveals_extra_controls,device_dropdown_lists_devices_and_marks_default,ptt_recorder_captures_key(drives the widget headless with click + key events),mic_test_button_and_level_meter,parity_check_passes. There are also unit tests for the meter's dB mapping and the release-delay snapping.settings_voice(goldenfixtures/golden/settings_voice.png, copy atdocs/screenshots/settings-voice.png): custom profile, PTT on with F, devices listed. The 720 px frame shows the page down to push-to-talk.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally.cargo xtask parity-checkalso passes against the fork checkout.No Electron reference screenshot exists in the fork's assets. Dimensions come from
UserVoiceTab.tsx,MicTestSection.module.cssandKeybindRecorder.tsx.Deviations
xtask parity-checkonly acceptsdone/planned/dropped, and the skeleton test pins audio entries to owner 2. So "partial" is written asdonewith a note starting "Partial:", and "later" asplannedwith a note. I added section entriessection-voice_video-*(as companion-apps did). AGC is nowdone. New-device alerts and connection volume controls stayplannedwith notes.settings::Messageis no longerCopy, because it carriesDeviceId/VoiceSettingChange.section,body_textandborderare now generic over the message type.app.rsandmessage.rs(WindowEvent::Key, PTT key dispatch; Escape is ignored when a widget captured it so the recorder can cancel),theme/icons.rsplusplay-fill/stop-fillSVGs (Phosphor path data written from memory, please check), andsettings_nav.rs(its Voice & video page expectation now that Audio is built).Stacked on: voice-17-ui-voice-panel
Closes #82
🤖 Generated with Claude Code
The panel above the user area while in voice (VoiceConnectionStatusInner): "Connecting..." / "In voice chat" / "Connection failed", the channel line, the signal-strength icon with the original's latency thresholds and its "Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line opens the connection details (VoiceDetailsPopout): ping graph of the last 30 round trips, current and average ping, device, duration, participants, endpoint (click copies). The user area moves to its own module and gains the microphone and speaker buttons with the original's states and tooltips (effective mute, moderator mute/deafen and no-speak lock); a right-click on either opens Settings -> Voice & video. Refs #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Review: Voice 21 (Settings → Voice & video), independent reviewer
Reviewed
80c11ff7..origin/voice-21-ui-voice-settings(2 commits, head99ffc6f).Plan tests: all five named tests exist in
crates/fluxer-ui/tests/settings_voice.rs(sections_in_original_order,custom_mode_reveals_extra_controls,device_dropdown_lists_devices_and_marks_default,ptt_recorder_captures_key,parity_check_passes), plusmic_test_button_and_level_meter. Thesettings_voicegolden is intests/screenshots.rs. The section order matches facts §8 (devices, volume, processing with PTT/AGC, mic test, entrance sound, soundboard, show connection IDs). The custom profile shows the threshold, NS backend, stereo and echo controls. Defaults match the spec: threshold 50, RNNoise, 0–200 % volumes.Interfaces: every control goes through
SetVoiceSetting/SetInputDevice/SetOutputDevice/StartMicTest/StopMicTest. The mic test readsvoice.input_level(level and gate). The PTT recorder takes the key from the focused window. Audio parity entries aredoneorplanned, and each has a note.partialis written asdonewith a "Partial:" note because xtask has no partial status, which is acceptable.Invariants: fluxer-core is untouched, fluxer-ui does no new I/O, and there are no secrets. Losing window focus releases PTT (the core reducer handles
WindowFocus(false)). I checked the play-fill and stop-fill paths against Phosphor and they look right.Review Focus: no item belongs to Task 21.
CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green in the review worktree. All 7 goldens pass, includingsettings_voice_matches_golden, and parity reports 126 settings, all accounted for.Findings
crates/fluxer-ui/src/app.rs,window_event): the Tab arm (FocusNext/FocusPrevious) matches before the new PTT key arm. The recorder accepts Tab, but a Tab push-to-talk key never sendsPttKey. Either reject Tab in the recorder or check the PTT key first.processing::key_name): it uses iced'sCodeDebug name. That matchesKeyboardEvent.codefor letters, digits and Space, but not for some keys, such asSuperLeftagainst the web'sMetaLeft. A key imported from the web Keybind store could fail to match.tests/settings_voice.rs, device test): the comment says "the choice is kept and still listed", but the test asserts neither. The unplugged device is in fact not listed inoptions.settings_voicegolden): the 1280x720 frame shows only the page down to the Push-to-talk switch. The scenario sets up the PTT key, the custom controls and the running mic test meter, but none of them are visible, so the golden does not cover them.Verdict: APPROVE (0 blocking, 4 minor; CI green locally)