Voice 18: Call view and control bar (#79) #132

Manually merged
charles merged 0 commits from voice-18-ui-call-view into voice 2026-11-11 23:43:28 +00:00
Owner

Stacked on: voice-17-ui-voice-panel, voice-10-core-soundboard

What

Selecting a guild voice channel now shows the call view (crates/fluxer-ui/src/screens/main/call/):

  • grid: metrics(count, Size, compact) ports resolveVoiceGridPackedLayoutMetrics from VoiceGridLayoutMetrics.ts (16:9 tiles, gap/padding rules, min tile 220 px or 148 px compact, overflow tiles hidden). view lays the tiles out with responsive.
  • tile: avatar on --voice-surface-2, a 3.5 px speaking border in --status-online plus the avatar's speaking ring, a black name plate with mute/deafen icons, and the soundboard emoji badge from active_effects in the top-right corner.
  • control_bar: soundboard (emits OpenSoundboard), mute, deafen (state and lock from user_area::controls; right-click opens Voice & video settings), camera and screen share disabled with the tooltip "Coming in a later version", and disconnect (LeaveVoice). Colours are the --vc-* literals from VoiceControlBar.module.css.
  • compact: 320 px of avatars plus the bar, shown over the channel's chat when the new header chat button ("Show chat"/"Hide chat") is on.
  • "Join voice" view for a voice channel you're not connected to (JoinVoice).
  • New icons (Phosphor fill): music-notes, camera-slash, monitor-play.

Tests

  • tests/call_view.rs: grid_dimensions_for_1_2_4_9_participants, tile_shows_speaking_and_muted, control_bar_actions_emit_events, not_connected_shows_join (headless, not on Windows), plus unit tests in each module.
  • Screenshots call_view_4 and call_view_compact (goldens in fixtures/golden/, copies in docs/screenshots/). No Electron reference image is available in the fork; dimensions come from VoiceGridLayoutMetrics.ts, VoiceCallView.module.css, VoiceParticipantTile.module.css, VoiceControlBar.module.css, CompactVoiceCallView.module.css and SoundboardEffectEmoji.module.css.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci passes locally.

Deviations

  • app.rs: added Local::call (call::State { chat_open }). It's outside the Files list but needed for the view-local chat toggle.
  • One tile per connection; the original's device grouping, focus and pop-out are left out. Avatars use the default avatar, as elsewhere on the main screen (no image cache yet). A custom-emoji effect shows a music-note icon in place of the emoji image.
  • The join view's "N people are in voice" line is my own wording; the fork has no direct equivalent.
  • The control bar leaves out the input/output setting carets and "more options".

Closes #79

🤖 Generated with Claude Code

Stacked on: voice-17-ui-voice-panel, voice-10-core-soundboard ## What Selecting a guild voice channel now shows the call view (`crates/fluxer-ui/src/screens/main/call/`): - `grid`: `metrics(count, Size, compact)` ports `resolveVoiceGridPackedLayoutMetrics` from `VoiceGridLayoutMetrics.ts` (16:9 tiles, gap/padding rules, min tile 220 px or 148 px compact, overflow tiles hidden). `view` lays the tiles out with `responsive`. - `tile`: avatar on `--voice-surface-2`, a 3.5 px speaking border in `--status-online` plus the avatar's speaking ring, a black name plate with mute/deafen icons, and the soundboard emoji badge from `active_effects` in the top-right corner. - `control_bar`: soundboard (emits `OpenSoundboard`), mute, deafen (state and lock from `user_area::controls`; right-click opens Voice & video settings), camera and screen share disabled with the tooltip "Coming in a later version", and disconnect (`LeaveVoice`). Colours are the `--vc-*` literals from `VoiceControlBar.module.css`. - `compact`: 320 px of avatars plus the bar, shown over the channel's chat when the new header chat button ("Show chat"/"Hide chat") is on. - "Join voice" view for a voice channel you're not connected to (`JoinVoice`). - New icons (Phosphor fill): music-notes, camera-slash, monitor-play. ## Tests - `tests/call_view.rs`: `grid_dimensions_for_1_2_4_9_participants`, `tile_shows_speaking_and_muted`, `control_bar_actions_emit_events`, `not_connected_shows_join` (headless, not on Windows), plus unit tests in each module. - Screenshots `call_view_4` and `call_view_compact` (goldens in `fixtures/golden/`, copies in `docs/screenshots/`). No Electron reference image is available in the fork; dimensions come from `VoiceGridLayoutMetrics.ts`, `VoiceCallView.module.css`, `VoiceParticipantTile.module.css`, `VoiceControlBar.module.css`, `CompactVoiceCallView.module.css` and `SoundboardEffectEmoji.module.css`. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` passes locally. ## Deviations - `app.rs`: added `Local::call` (`call::State { chat_open }`). It's outside the Files list but needed for the view-local chat toggle. - One tile per connection; the original's device grouping, focus and pop-out are left out. Avatars use the default avatar, as elsewhere on the main screen (no image cache yet). A custom-emoji effect shows a music-note icon in place of the emoji image. - The join view's "N people are in voice" line is my own wording; the fork has no direct equivalent. - The control bar leaves out the input/output setting carets and "more options". Closes #79 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-core/README.md
The panel above the user area while in voice (VoiceConnectionStatusInner):
"Connecting..." / "In voice chat" / "Connection failed", the channel line,
the signal-strength icon with the original's latency thresholds and its
"Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line
opens the connection details (VoiceDetailsPopout): ping graph of the last
30 round trips, current and average ping, device, duration, participants,
endpoint (click copies). The user area moves to its own module and gains
the microphone and speaker buttons with the original's states and
tooltips (effective mute, moderator mute/deafen and no-speak lock); a
right-click on either opens Settings -> Voice & video.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test(ui): voice panel goldens drawn on lavapipe
All checks were successful
ci / Linux (x86_64) (push) Successful in 13m12s
ci / Windows (x64) (push) Successful in 19m35s
8c37b507c7
voice_panel_connected and voice_panel_failed are new; main-general and
sidebar_voice are redrawn because the user area gained the microphone
and speaker buttons. All drawn on the reference renderer (Ubuntu 22.04
lavapipe, the recipe of docs/screenshots/README.md); the two new frames
are also under docs/screenshots for the PR.

Refs #78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/voice' into voice-17-ui-voice-panel
All checks were successful
ci / Windows (x64) (push) Successful in 8m3s
ci / Linux (x86_64) (push) Successful in 28m17s
80c11ff71c
# Conflicts:
#	crates/fluxer-core/README.md
feat(core): soundboard and entrance sounds
All checks were successful
ci / Linux (x86_64) (push) Successful in 8m43s
ci / Windows (x64) (push) Successful in 8m5s
add3ec139a
Refs #71

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
feat(ui): call view and control bar
All checks were successful
ci / Windows (x64) (push) Successful in 7m58s
ci / Linux (x86_64) (push) Successful in 9m7s
a7ec434243
Refs #79

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Voice 18 (call view and control bar)

Reviewed git diff cb47ff7..origin/voice-18-ui-call-view (a7ec434) cold.

Plan tests: all four exist in crates/fluxer-ui/tests/call_view.rs and assert what the plan says: grid_dimensions_for_1_2_4_9_participants (1x1, 2x1, 2x2, 3x3 at 1280x720, plus gap 12/10 and min-tile overflow), tile_shows_speaking_and_muted (speaking ring pixel vs muted, struck mic icon), control_bar_actions_emit_events (soundboard/mute/deafen/disconnect only; camera and screen share disabled with "Coming in a later version"; mapped to OpenSoundboard, ToggleSelfMute, ToggleSelfDeaf, LeaveVoice), not_connected_shows_join. Screenshots call_view_4 and call_view_compact have goldens and pass.

Interfaces: the Produces items of Task 18 are present; the soundboard button emits UserAction::OpenSoundboard, which Task 19 consumes. grid::metrics was checked against VoiceGridLayoutMetrics.ts: the constants, gap and padding rules and best-area packing match.

Invariants: no I/O added to fluxer-ui, nothing touched in fluxer-core, no secrets. Server data cannot panic it: NaN/negative sizes are sanitised, visible <= count bounds the slice, and the channel name falls back to empty.

Findings

  • minor: app.rs (outside the Files list) gains Local::call. This is a reasonable deviation and is documented.
  • minor: the call view and control bar use --voice-*/--vc-* CSS literals from the fork modules instead of theme tokens. They are sourced from the fork, not hand-picked, but they should go through gen-theme if those vars are ever tokenised.
  • minor: the tiles are simplified: one per connection, no device grouping, focus or pop-out, and default avatars only. The subtitle wording "N people are in voice" is the implementer's own, not the original's. These can be follow-ups.
  • note (process, not code): the commit carries the Claude Fable 5.2 Co-Authored-By line required by the repo CLAUDE.md, although the implementer reports it ran on Opus 5.5. Charles has said Fable usage is costing a lot, so the integrator should check which model the agents run on and whether the attribution line in CLAUDE.md is still right.

CI: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: all steps passed, including the screenshot goldens.

Verdict: APPROVE (0 blocking findings, ci green)

🤖 Generated with Claude Code

## Independent review: Voice 18 (call view and control bar) Reviewed `git diff cb47ff7..origin/voice-18-ui-call-view` (a7ec434) cold. **Plan tests:** all four exist in `crates/fluxer-ui/tests/call_view.rs` and assert what the plan says: `grid_dimensions_for_1_2_4_9_participants` (1x1, 2x1, 2x2, 3x3 at 1280x720, plus gap 12/10 and min-tile overflow), `tile_shows_speaking_and_muted` (speaking ring pixel vs muted, struck mic icon), `control_bar_actions_emit_events` (soundboard/mute/deafen/disconnect only; camera and screen share disabled with "Coming in a later version"; mapped to `OpenSoundboard`, `ToggleSelfMute`, `ToggleSelfDeaf`, `LeaveVoice`), `not_connected_shows_join`. Screenshots `call_view_4` and `call_view_compact` have goldens and pass. **Interfaces:** the Produces items of Task 18 are present; the soundboard button emits `UserAction::OpenSoundboard`, which Task 19 consumes. `grid::metrics` was checked against `VoiceGridLayoutMetrics.ts`: the constants, gap and padding rules and best-area packing match. **Invariants:** no I/O added to fluxer-ui, nothing touched in fluxer-core, no secrets. Server data cannot panic it: NaN/negative sizes are sanitised, `visible <= count` bounds the slice, and the channel name falls back to empty. **Findings** - minor: `app.rs` (outside the Files list) gains `Local::call`. This is a reasonable deviation and is documented. - minor: the call view and control bar use `--voice-*`/`--vc-*` CSS literals from the fork modules instead of theme tokens. They are sourced from the fork, not hand-picked, but they should go through gen-theme if those vars are ever tokenised. - minor: the tiles are simplified: one per connection, no device grouping, focus or pop-out, and default avatars only. The subtitle wording "N people are in voice" is the implementer's own, not the original's. These can be follow-ups. - note (process, not code): the commit carries the `Claude Fable 5.2` Co-Authored-By line required by the repo CLAUDE.md, although the implementer reports it ran on Opus 5.5. Charles has said Fable usage is costing a lot, so the integrator should check which model the agents run on and whether the attribution line in CLAUDE.md is still right. **CI:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: all steps passed, including the screenshot goldens. **Verdict: APPROVE** (0 blocking findings, ci green) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
charles manually merged commit 09de2137ea into voice 2026-11-11 23:43:28 +00:00
Sign in to join this conversation.
No description provided.