Voice 18: Call view and control bar (#79) #132
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-18-ui-call-view"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: voice-17-ui-voice-panel, voice-10-core-soundboard
What
Selecting a guild voice channel now shows the call view (
crates/fluxer-ui/src/screens/main/call/):grid:metrics(count, Size, compact)portsresolveVoiceGridPackedLayoutMetricsfromVoiceGridLayoutMetrics.ts(16:9 tiles, gap/padding rules, min tile 220 px or 148 px compact, overflow tiles hidden).viewlays the tiles out withresponsive.tile: avatar on--voice-surface-2, a 3.5 px speaking border in--status-onlineplus the avatar's speaking ring, a black name plate with mute/deafen icons, and the soundboard emoji badge fromactive_effectsin the top-right corner.control_bar: soundboard (emitsOpenSoundboard), mute, deafen (state and lock fromuser_area::controls; right-click opens Voice & video settings), camera and screen share disabled with the tooltip "Coming in a later version", and disconnect (LeaveVoice). Colours are the--vc-*literals fromVoiceControlBar.module.css.compact: 320 px of avatars plus the bar, shown over the channel's chat when the new header chat button ("Show chat"/"Hide chat") is on.JoinVoice).Tests
tests/call_view.rs:grid_dimensions_for_1_2_4_9_participants,tile_shows_speaking_and_muted,control_bar_actions_emit_events,not_connected_shows_join(headless, not on Windows), plus unit tests in each module.call_view_4andcall_view_compact(goldens infixtures/golden/, copies indocs/screenshots/). No Electron reference image is available in the fork; dimensions come fromVoiceGridLayoutMetrics.ts,VoiceCallView.module.css,VoiceParticipantTile.module.css,VoiceControlBar.module.css,CompactVoiceCallView.module.cssandSoundboardEffectEmoji.module.css.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses locally.Deviations
app.rs: addedLocal::call(call::State { chat_open }). It's outside the Files list but needed for the view-local chat toggle.Closes #79
🤖 Generated with Claude Code
The panel above the user area while in voice (VoiceConnectionStatusInner): "Connecting..." / "In voice chat" / "Connection failed", the channel line, the signal-strength icon with the original's latency thresholds and its "Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line opens the connection details (VoiceDetailsPopout): ping graph of the last 30 round trips, current and average ping, device, duration, participants, endpoint (click copies). The user area moves to its own module and gains the microphone and speaker buttons with the original's states and tooltips (effective mute, moderator mute/deafen and no-speak lock); a right-click on either opens Settings -> Voice & video. Refs #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Voice 18 (call view and control bar)
Reviewed
git diff cb47ff7..origin/voice-18-ui-call-view(a7ec434) cold.Plan tests: all four exist in
crates/fluxer-ui/tests/call_view.rsand assert what the plan says:grid_dimensions_for_1_2_4_9_participants(1x1, 2x1, 2x2, 3x3 at 1280x720, plus gap 12/10 and min-tile overflow),tile_shows_speaking_and_muted(speaking ring pixel vs muted, struck mic icon),control_bar_actions_emit_events(soundboard/mute/deafen/disconnect only; camera and screen share disabled with "Coming in a later version"; mapped toOpenSoundboard,ToggleSelfMute,ToggleSelfDeaf,LeaveVoice),not_connected_shows_join. Screenshotscall_view_4andcall_view_compacthave goldens and pass.Interfaces: the Produces items of Task 18 are present; the soundboard button emits
UserAction::OpenSoundboard, which Task 19 consumes.grid::metricswas checked againstVoiceGridLayoutMetrics.ts: the constants, gap and padding rules and best-area packing match.Invariants: no I/O added to fluxer-ui, nothing touched in fluxer-core, no secrets. Server data cannot panic it: NaN/negative sizes are sanitised,
visible <= countbounds the slice, and the channel name falls back to empty.Findings
app.rs(outside the Files list) gainsLocal::call. This is a reasonable deviation and is documented.--voice-*/--vc-*CSS literals from the fork modules instead of theme tokens. They are sourced from the fork, not hand-picked, but they should go through gen-theme if those vars are ever tokenised.Claude Fable 5.2Co-Authored-By line required by the repo CLAUDE.md, although the implementer reports it ran on Opus 5.5. Charles has said Fable usage is costing a lot, so the integrator should check which model the agents run on and whether the attribution line in CLAUDE.md is still right.CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: all steps passed, including the screenshot goldens.Verdict: APPROVE (0 blocking findings, ci green)
🤖 Generated with Claude Code