Voice 17: Voice connection panel and user-area controls (#78) #124
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-17-ui-voice-panel"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/voice-8-core-live-room-volumes
What
screens::main::voice_panel: the connection panel above the user area (VoiceConnectionStatusInner.tsx). States with the original strings: "Connecting..." (awaiting server, connecting, and reconnecting, as the original), "In voice chat", "Connection failed" with Try again (RetryVoice) and Dismiss (DismissVoiceError); channel line "Hangout / Forked"; disconnect button (LeaveVoice); signal-strength icon ported fromSignalStrengthIcon/getLatencySignalState(median of last 30, thresholds 70/160/300 ms, colours from status tokens) with "Ping: {n}ms" / "Measuring latency..." tooltip.screens::main::voice_details: details popout (VoiceDetailsPopout.tsx) opened by the status line: ping graph (last 30 RTTs, same chart geometry), Device, Current/Average ping, Duration, Participants, Endpoint (click copies via the shell clipboard).screens::main::user_area: user area moved out ofsidebar.rs, now with microphone and speaker buttons (UserArea.tsx,selectUserAreaMicrophoneState): effective mute, moderator mute/deafen and suppress lock the button with the original tooltips. Right-click on either button givesOpenSettings(Some(VoiceVideo)). The gear is unchanged (OpenSettings(None), "User Settings").Tests
tests/voice_panel.rs:each_connection_state_renders_its_line,failed_state_offers_retry_and_dismiss,mute_button_reflects_effective_mute_and_server_mute, plusdetails_popout_shows_ping_history_and_participants. These are headless widget tests on tiny-skia, not run on Windows (#93). Unit tests cover the signal thresholds, the median, the SVG, duration formatting, endpoint stripping and the graph scale.voice_panel_connected(details open) andvoice_panel_failed, drawn on Ubuntu 22.04 lavapipe.main-generalandsidebar_voicewere redrawn because the user area has new buttons. The frames are indocs/screenshots/voice-panel-*.png. No Electron capture: the dimensions come fromVoiceConnectionStatus.module.cssandUserArea.module.css.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally.Deviations
Connecting, because core drops it onConnected(follow-up #122). Duration is hidden untilsinceis known (#109). The original "Advanced" stats are omitted because the room does not report them yet.sidebar.rs(the user area moved out, and it now stacks the popout),app.rs(clipboard for CopyEndpoint),theme/icons.rsand assets, the READMEs, andtests/voice_sidebar.rs(its probe ignores the new right-clickOpenVoiceSettings). The headless harness was copied intotests/headless/mod.rsfor reuse.Closes #78
🤖 Generated with Claude Code
The panel above the user area while in voice (VoiceConnectionStatusInner): "Connecting..." / "In voice chat" / "Connection failed", the channel line, the signal-strength icon with the original's latency thresholds and its "Ping: {n}ms" tooltip, disconnect, Try again and Dismiss. The status line opens the connection details (VoiceDetailsPopout): ping graph of the last 30 round trips, current and average ping, device, duration, participants, endpoint (click copies). The user area moves to its own module and gains the microphone and speaker buttons with the original's states and tooltips (effective mute, moderator mute/deafen and no-speak lock); a right-click on either opens Settings -> Voice & video. Refs #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Voice 17 (ui-voice-panel)
Reviewed
da8f356..8c37b50(three commits) in a clean worktree.Verdict: APPROVE. No blocking findings; local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green.What I checked
crates/fluxer-ui/tests/voice_panel.rsand pass, plusdetails_popout_shows_ping_history_and_participants.each_connection_state_renders_its_lineasserts the literal strings "Connecting...", "In voice chat", "Connection failed", "Measuring latency..." and "Ping: 42ms", and the signal icon at 4 arcs green and 1 arc red.failed_state_offers_retry_and_dismissclicks through the real widget tree and checks Retry ->RetryVoice, Dismiss ->DismissVoiceError, Disconnect ->LeaveVoice.mute_button_reflects_effective_mute_and_server_mutecovers self-mute, deafen-implies-mute, server mute, suppress and server deaf, including that a locked button emits nothing.voice_panel_connectedandvoice_panel_failedran against their goldens and passed.VoiceConnectionStatusInner.tsxandVoiceMessageDescriptors.ts. The thresholds[70, 160, 300], the 30-sample baseline, the median rounding and the skipping of samples <= 0 matchVoiceLatencySignal.ts.LeaveVoice,RetryVoice,ToggleSelfMute,ToggleSelfDeafandOpenSettings(Some(VoiceVideo))are all emitted; see minor 1 for where the last one comes from.fluxer-core, and the core-isolation step passes.fluxer-uigains no I/O. The clipboard write is an iced task inapp.rs, the same way Settings already copies text.urlwas already a workspace dependency offluxer-ui) and no new fixtures or secrets.u32, and an unparsable endpoint is shown as it is.#![cfg(not(windows))]and the renderer-free rules are unit tests.Findings
OpenSettings(Some(VoiceVideo)). Here the gear keepsOpenSettings(None)and a right-click on the mic or speaker button emitsOpenVoiceSettings. The gear matches the original (openUserSettingsModal). The right-click is an approximation: the original opens aVoiceAudioSettingsMenuthere. No other task's interface breaks, but Voice 21 should know this is the entry point.Co-Authored-By: Claude Opus 5.5; CLAUDE.md requiresClaude Fable 5.2. I cannot verify which model ran, and fixing it means rewriting history, which is denied (no force push). Charles to decide.getStatusText. The spec text should be corrected.CopyEndpoint) only shows inConnecting, because core drops the endpoint afterwards (#122).sinceis alwaysNone(#109).sidebar::State::voice_detailsis not reset when the connection ends, so the popout reappears on the next call.voice_details::modelcomputesnow - since.unix_millis()unchecked. It cannot fire today (sinceis never set), butsaturating_subwould be safer once #109 lands.The implementer's question about the connected golden (only ada listed under Hangout, Participants says 2) is most likely not a bug. The popout floats over the bottom of the channel list from y=280, and the row after ada would start at about y=291, so the second row is probably hidden behind it. I did not render the frame without the popout to confirm.