deny: reasoned ignores for new chrono and zip 8 advisories (#773) #775

Closed
charles wants to merge 0 commits from fix-773-cargo-deny-advisories into textchat
Owner

Closes #773

cargo deny check (a step of cargo xtask ci and CI) failed on every branch because RustSec published five new advisories. The code did not change. No patched version can be reached for any of them, so each one gets an ignore in deny.toml with a concrete reason. Cargo.lock is unchanged: no version moved.

Advisory Crate What I did Why
RUSTSEC-2026-0543 (unmaintained) chrono 0.4.45 ignore No patched version exists. pbjson-types 0.9.0 (its latest release, used through livekit-protocol/livekit-api) and the vendored livekit both depend on chrono. Dropping fluxer-platform's one direct use (settings::local_utc_offset_minutes) would not take chrono out of the graph.
RUSTSEC-2026-0545 (AES HMAC not checked on truncated entries) zip 8.6.0 (velopack 1.2.161) ignore, #466 Fixed only in zip >= 9. The bug needs the aes-crypto feature, and velopack builds zip with default-features = false, features = ["deflate"], so that code is not compiled.
RUSTSEC-2026-0546 (ZipArchive::extract symlink escape) zip 8.6.0 ignore, #466 Fixed only in zip >= 9. velopack 1.2.161 never calls extract or extract_unwrapped_root_dir: it opens packages with ZipArchive::new and by_index (src/bundle.rs). The packages come from our feed after a size and SHA-256 check.
RUSTSEC-2026-0547 (Shrink/Reduce/Implode preallocation) zip 8.6.0 ignore, #466 Fixed only in zip >= 9. The bug needs the legacy-zip feature, which is not enabled.
RUSTSEC-2026-0548 (ZipStreamReader local-header names) zip 8.6.0 ignore, #466 Fixed only in zip >= 9.0.5. velopack 1.2.161 never uses ZipStreamReader or read_zipfile_from_stream.

Why velopack was not bumped: the only velopack release on zip 9 is 1.3.39-g8d2844f (zip ^9.0.3, and it also drops derivative). It is marked as a pre-release on both GitHub and NuGet (vpk). Comparing its source with 1.2.161 shows behaviour changes, not just the zip API port:

  • packages are now stored under a sanitised file name (local_package_path);
  • delta-download progress is scaled per delta on a new thread;
  • a .nuspec write error is no longer reported as an invalid package;
  • new release-notes getters were added.

That breaks the "no behaviour change" rule. The updater also cannot be compiled or run here (the files that use it are cfg(windows)). Details are on #466.

Verification

  • cargo deny check → advisories ok, bans ok, licenses ok, sources ok
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci → ==> xtask ci: all steps passed. livekit-interop was skipped as usual (FLUXER_LIVEKIT_TESTS is not 1).

🤖 Generated with Claude Code

Closes #773 `cargo deny check` (a step of `cargo xtask ci` and CI) failed on every branch because RustSec published five new advisories. The code did not change. No patched version can be reached for any of them, so each one gets an `ignore` in `deny.toml` with a concrete reason. **Cargo.lock is unchanged: no version moved.** | Advisory | Crate | What I did | Why | |---|---|---|---| | RUSTSEC-2026-0543 (unmaintained) | chrono 0.4.45 | ignore | No patched version exists. `pbjson-types` 0.9.0 (its latest release, used through livekit-protocol/livekit-api) and the vendored livekit both depend on chrono. Dropping fluxer-platform's one direct use (`settings::local_utc_offset_minutes`) would not take chrono out of the graph. | | RUSTSEC-2026-0545 (AES HMAC not checked on truncated entries) | zip 8.6.0 (velopack 1.2.161) | ignore, #466 | Fixed only in zip >= 9. The bug needs the `aes-crypto` feature, and velopack builds zip with `default-features = false, features = ["deflate"]`, so that code is not compiled. | | RUSTSEC-2026-0546 (`ZipArchive::extract` symlink escape) | zip 8.6.0 | ignore, #466 | Fixed only in zip >= 9. velopack 1.2.161 never calls `extract` or `extract_unwrapped_root_dir`: it opens packages with `ZipArchive::new` and `by_index` (src/bundle.rs). The packages come from our feed after a size and SHA-256 check. | | RUSTSEC-2026-0547 (Shrink/Reduce/Implode preallocation) | zip 8.6.0 | ignore, #466 | Fixed only in zip >= 9. The bug needs the `legacy-zip` feature, which is not enabled. | | RUSTSEC-2026-0548 (`ZipStreamReader` local-header names) | zip 8.6.0 | ignore, #466 | Fixed only in zip >= 9.0.5. velopack 1.2.161 never uses `ZipStreamReader` or `read_zipfile_from_stream`. | **Why velopack was not bumped:** the only velopack release on zip 9 is `1.3.39-g8d2844f` (zip ^9.0.3, and it also drops `derivative`). It is marked as a pre-release on both GitHub and NuGet (vpk). Comparing its source with 1.2.161 shows behaviour changes, not just the zip API port: - packages are now stored under a sanitised file name (`local_package_path`); - delta-download progress is scaled per delta on a new thread; - a `.nuspec` write error is no longer reported as an invalid package; - new release-notes getters were added. That breaks the "no behaviour change" rule. The updater also cannot be compiled or run here (the files that use it are `cfg(windows)`). Details are on #466. **Verification** - `cargo deny check` → `advisories ok, bans ok, licenses ok, sources ok` - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` → `==> xtask ci: all steps passed`. livekit-interop was skipped as usual (`FLUXER_LIVEKIT_TESTS` is not 1). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
cargo deny check failed on every branch after RustSec published
RUSTSEC-2026-0543 (chrono unmaintained) and RUSTSEC-2026-0545..0548
(zip 8.6.0, via velopack 1.2.161). No patched version is reachable:

- zip: fixed only in zip 9 (>= 9.0.5 for 0548); no 8.x patch release.
  The only velopack on zip 9 is the pre-release 1.3.39-g8d2844f, which
  also changes download paths and progress reporting and needs a
  Windows run (#466). velopack 1.2.161 builds zip with
  default-features = false, features = ["deflate"] (no aes-crypto, no
  legacy-zip) and reads packages with ZipArchive::by_index only (never
  extract or ZipStreamReader), so none of the four code paths is
  reachable.
- chrono: no patched version; pbjson-types 0.9 (latest, via
  livekit-protocol/livekit-api) and the vendored livekit depend on it,
  so dropping fluxer-platform's direct use would not remove it.

Cargo.lock unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Merged into textchat by hand (the merge API returns 405), and textchat into serveradmin.

Merged into `textchat` by hand (the merge API returns 405), and textchat into `serveradmin`.
charles closed this pull request 2026-11-17 19:13:33 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.