Embed spoilers: own reveal state and clickable spoilers in embed Markdown #381

Open
opened 2026-11-13 00:35:44 +00:00 by charles · 0 comments
Owner

Found in the review of PR #320 (Text chat 23, finding 2).

Embed descriptions are drawn with the message's RenderCtx, so they share revealed_spoilers with the message text: revealing spoiler N of the message text also uncovers spoiler N of an embed description. Clicks on spoilers inside embed text do nothing (Embed::Spoiler(_) => Vec::new() in screens/main/messages.rs).

Expected (as in the Electron client): each embed's spoilers have their own reveal state and reveal on click. Also covers ||url|| spoilered embed URLs.

Seen on branch textchat-23-ui-embeds (commit 8127468).

Refs #273

Found in the review of PR #320 (Text chat 23, finding 2). Embed descriptions are drawn with the message's `RenderCtx`, so they share `revealed_spoilers` with the message text: revealing spoiler N of the message text also uncovers spoiler N of an embed description. Clicks on spoilers inside embed text do nothing (`Embed::Spoiler(_) => Vec::new()` in `screens/main/messages.rs`). Expected (as in the Electron client): each embed's spoilers have their own reveal state and reveal on click. Also covers `||url||` spoilered embed URLs. Seen on branch `textchat-23-ui-embeds` (commit 8127468). Refs #273
charles added this to the Text chat milestone 2026-11-13 00:35:44 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#381
No description provided.