Text chat 23: Embeds (#273) #320

Manually merged
charles merged 0 commits from textchat-23-ui-embeds into textchat 2026-11-13 02:14:24 +00:00
Owner

What this builds

Embeds under a message (spec §3.5, §9.3), cloned from fluxer_app/src/features/channel/components/embeds/ (ChannelEmbed.tsx, channel_embed/RichEmbed.tsx, BlueskyEmbed.tsx, EmbedParts.tsx, ChannelEmbedShared.ts, EmbedRenderUtils.ts, media/EmbedYouTube.tsx); dimensions from ChannelEmbed.module.css, EmbedYouTube.module.css and MediaDimensionConfig.ts.

  • widgets/message_content/embed.rs: models(&embeds, &Display) is the pure model. It drops duplicates by normalized URL, splits media-only embeds from cards (hasRichEmbedContent), and builds the rich card: bar colour (else --brand-primary-foreground), provider, author with its 24 px icon, title link, and a description that is Markdown only for rich and Bluesky embeds. It also lays out the field grid (field_rows: 12 columns, at most 3 inline fields per row), the 80 px thumbnail (promoted to large media for article/image), large media, a gallery of up to 10 images sharing a URL, and the footer with its 20 px icon and "Today at …". Cards are 432 px wide with large media, 516 px otherwise. Bluesky gets its own width rule, the engagement row as text and the quoted post. Unknown types render as a plain (non-Markdown) card.
  • embed_media.rs: image, GIF, GIFV (the proxy's animated variant of the thumbnail), video poster with play, and the audio card. fit is fitMediaWithinBounds (400 x 300, tall videos 400 x 450). Thumbhash placeholders show until the image loads. youtube.rs: the poster with "Play video" and "Open in new tab".
  • The suppress X shows for the author, or for MANAGE_MESSAGES outside DMs, while the row is hovered and "Show suppress embeds button" is on. It emits UserAction::SuppressEmbeds { confirmed: false }, and the confirm is Text chat 15's.
  • Settings: render_embeds and the message's SUPPRESS_EMBEDS flag hide embeds. With inline_embed_media off, media-only embeds become their link and cards lose large media. A message that is only the link of its media-only embeds hides its text (shouldHideContent).
  • Links (title, provider, author, Markdown links, video and YouTube buttons) go out as UserAction::OpenUrl. A string that does not parse as a URL is dropped. Only http(s) URLs leave the store (existing open_url). Images are requested through media::wanted (the proxy at 2x the layout size).
  • Icon added: ArrowSquareOut (arrow-square-out-fill.svg from @phosphor-icons/react 2.1.10).

Tests

  • crates/fluxer-ui/tests/embeds.rs: field_grid_rows, width_432_with_media_else_516, thumbnail_promoted_for_article_and_image, duplicate_embeds_dropped (with the 10-image gallery), markdown_only_in_rich, unknown_type_renders_as_link_card, a table test malformed_embeds_never_panic (28 hostile embeds × 5 clocks; models, footer times and built views), suppress_x_only_for_author_or_mod (pure table and through the store), plus fixture_embeds_take_the_original_paths (every embed of fixtures/rest/message_embeds.json), display_settings_apply, footer_time_is_relative, media_fits_the_original_bounds and embed_clicks_become_user_actions.
  • Screenshots embed_rich_fields, embed_article, embed_youtube, embed_gifv (in tests/screenshots.rs, README table updated). They show #general of the basic scenario plus one message carrying the corresponding embed of message_embeds.json. The external pictures are gradients. No Electron reference capture: dimensions come from the fork component and CSS files named above.
  • Local gate: cargo xtask ci green on the host (Arch, NVIDIA). The --ignored step was run in two halves. The fluxer-ui screenshots (all 36 goldens) ran on lavapipe in the Ubuntu 22.04 CI image (fluxer-native-shots:u2204, offline with the host's cargo cache); the goldens were written there with UPDATE_GOLDEN=1. The other ignored workspace tests ran on the host. The whole workspace could not run in that container because webrtc-sys needs the network.
  • No desktop-only (FLUXER_DESKTOP_TESTS) tests in this task.

Deviations from the plan

  • Files outside the task's list, all minimal: theme/icons.rs and the svg (the new icon, as every UI task does); screens/main/messages.rs (one Message::Embed variant and its mapping to OpenUrl / SuppressEmbeds); screens/main/media.rs (the embeds' image URLs in wanted); widgets/mod.rs; READMEs. message_content/mod.rs is created here with only the embed modules. Text chat 22 creates the same file and also edits message_row.rs, so whichever merges second has a mechanical conflict.
  • Text chat 22 (attachments, mosaic, lightbox) is not on textchat. Until it lands, an embed gallery is a grid of square tiles and a click on an embed image does nothing: follow-up #319.
  • Audio: a media-only audio embed is a card that opens the clip in the browser (not Text chat 22's player). An audio embed with a title is a card of its title, as in the original (its EmbedMediaRenderer draws no audio).
  • Trusted-domain check / "Leaving Fluxer" (spec §14): embeds emit UserAction::OpenUrl like message links do. The check belongs in the store's OpenUrl path, which does not have it yet; nothing here bypasses it.
  • Spoilered embed URLs (||url|| covering the embed) and Markdown spoilers inside embed text are not interactive yet: spoilers in embed text stay covered.
  • Embed Markdown uses the description flags minus headings, lists and alerts, which the renderer has no layout for (as in message content). Field names and titles are plain text. The footer date beyond yesterday is M/D/YYYY, HH:MM (24-hour like the rest of the client).
  • Guild disabled_operations (SEND_MESSAGE) is not checked for the suppress X; the store has no such field yet.
  • Review follow-ups: #381 (embed spoilers: own reveal state, clickable) and #382 (spoiler cover for NSFW-flagged embed media).

Closes #273

🤖 Generated with Claude Code

## What this builds Embeds under a message (spec §3.5, §9.3), cloned from `fluxer_app/src/features/channel/components/embeds/` (`ChannelEmbed.tsx`, `channel_embed/RichEmbed.tsx`, `BlueskyEmbed.tsx`, `EmbedParts.tsx`, `ChannelEmbedShared.ts`, `EmbedRenderUtils.ts`, `media/EmbedYouTube.tsx`); dimensions from `ChannelEmbed.module.css`, `EmbedYouTube.module.css` and `MediaDimensionConfig.ts`. - `widgets/message_content/embed.rs`: `models(&embeds, &Display)` is the pure model. It drops duplicates by normalized URL, splits media-only embeds from cards (`hasRichEmbedContent`), and builds the rich card: bar colour (else `--brand-primary-foreground`), provider, author with its 24 px icon, title link, and a description that is Markdown only for rich and Bluesky embeds. It also lays out the field grid (`field_rows`: 12 columns, at most 3 inline fields per row), the 80 px thumbnail (promoted to large media for article/image), large media, a gallery of up to 10 images sharing a URL, and the footer with its 20 px icon and "Today at …". Cards are 432 px wide with large media, 516 px otherwise. Bluesky gets its own width rule, the engagement row as text and the quoted post. Unknown types render as a plain (non-Markdown) card. - `embed_media.rs`: image, GIF, GIFV (the proxy's animated variant of the thumbnail), video poster with play, and the audio card. `fit` is `fitMediaWithinBounds` (400 x 300, tall videos 400 x 450). Thumbhash placeholders show until the image loads. `youtube.rs`: the poster with "Play video" and "Open in new tab". - The suppress X shows for the author, or for `MANAGE_MESSAGES` outside DMs, while the row is hovered and "Show suppress embeds button" is on. It emits `UserAction::SuppressEmbeds { confirmed: false }`, and the confirm is Text chat 15's. - Settings: `render_embeds` and the message's `SUPPRESS_EMBEDS` flag hide embeds. With `inline_embed_media` off, media-only embeds become their link and cards lose large media. A message that is only the link of its media-only embeds hides its text (`shouldHideContent`). - Links (title, provider, author, Markdown links, video and YouTube buttons) go out as `UserAction::OpenUrl`. A string that does not parse as a URL is dropped. Only http(s) URLs leave the store (existing `open_url`). Images are requested through `media::wanted` (the proxy at 2x the layout size). - Icon added: `ArrowSquareOut` (`arrow-square-out-fill.svg` from @phosphor-icons/react 2.1.10). ## Tests - `crates/fluxer-ui/tests/embeds.rs`: `field_grid_rows`, `width_432_with_media_else_516`, `thumbnail_promoted_for_article_and_image`, `duplicate_embeds_dropped` (with the 10-image gallery), `markdown_only_in_rich`, `unknown_type_renders_as_link_card`, a table test `malformed_embeds_never_panic` (28 hostile embeds × 5 clocks; models, footer times and built views), `suppress_x_only_for_author_or_mod` (pure table and through the store), plus `fixture_embeds_take_the_original_paths` (every embed of `fixtures/rest/message_embeds.json`), `display_settings_apply`, `footer_time_is_relative`, `media_fits_the_original_bounds` and `embed_clicks_become_user_actions`. - Screenshots `embed_rich_fields`, `embed_article`, `embed_youtube`, `embed_gifv` (in `tests/screenshots.rs`, README table updated). They show #general of the basic scenario plus one message carrying the corresponding embed of `message_embeds.json`. The external pictures are gradients. No Electron reference capture: dimensions come from the fork component and CSS files named above. - Local gate: `cargo xtask ci` green on the host (Arch, NVIDIA). The `--ignored` step was run in two halves. The fluxer-ui screenshots (all 36 goldens) ran on lavapipe in the Ubuntu 22.04 CI image (`fluxer-native-shots:u2204`, offline with the host's cargo cache); the goldens were written there with `UPDATE_GOLDEN=1`. The other ignored workspace tests ran on the host. The whole workspace could not run in that container because webrtc-sys needs the network. - No desktop-only (`FLUXER_DESKTOP_TESTS`) tests in this task. ## Deviations from the plan - Files outside the task's list, all minimal: `theme/icons.rs` and the svg (the new icon, as every UI task does); `screens/main/messages.rs` (one `Message::Embed` variant and its mapping to `OpenUrl` / `SuppressEmbeds`); `screens/main/media.rs` (the embeds' image URLs in `wanted`); `widgets/mod.rs`; READMEs. `message_content/mod.rs` is created here with only the embed modules. Text chat 22 creates the same file and also edits `message_row.rs`, so whichever merges second has a mechanical conflict. - Text chat 22 (attachments, mosaic, lightbox) is not on `textchat`. Until it lands, an embed gallery is a grid of square tiles and a click on an embed image does nothing: follow-up #319. - Audio: a media-only audio embed is a card that opens the clip in the browser (not Text chat 22's player). An audio embed with a title is a card of its title, as in the original (its `EmbedMediaRenderer` draws no audio). - Trusted-domain check / "Leaving Fluxer" (spec §14): embeds emit `UserAction::OpenUrl` like message links do. The check belongs in the store's `OpenUrl` path, which does not have it yet; nothing here bypasses it. - Spoilered embed URLs (`||url||` covering the embed) and Markdown spoilers inside embed text are not interactive yet: spoilers in embed text stay covered. - Embed Markdown uses the description flags minus headings, lists and alerts, which the renderer has no layout for (as in message content). Field names and titles are plain text. The footer date beyond yesterday is `M/D/YYYY, HH:MM` (24-hour like the rest of the client). - Guild `disabled_operations` (SEND_MESSAGE) is not checked for the suppress X; the store has no such field yet. - Review follow-ups: #381 (embed spoilers: own reveal state, clickable) and #382 (spoiler cover for NSFW-flagged embed media). Closes #273 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-proto/README.md
#	crates/fluxer-proto/src/gateway/events.rs
#	crates/fluxer-proto/src/models/channel.rs
#	crates/fluxer-proto/src/models/mod.rs
#	crates/fluxer-proto/src/models/settings.rs
#	crates/fluxer-proto/tests/models_roundtrip.rs
# Conflicts:
#	crates/fluxer-proto/tests/models_roundtrip.rs
Embeds under a message, cloned from the fork's ChannelEmbed, RichEmbed,
BlueskyEmbed and EmbedYouTube: deduplication by normalized URL, media-only
embeds vs cards (hasRichEmbedContent), the field grid, 80 px thumbnail,
432/516 px widths, galleries, relative footer time, Bluesky engagement
row and quoted post, YouTube poster, the suppress X (SuppressEmbeds),
render_embeds / inline_embed_media / SUPPRESS_EMBEDS. Screenshot goldens
drawn on lavapipe (Ubuntu 22.04 CI image).

Refs #273

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Text chat 23 (Embeds), head bcb0132

Scope: git diff 9fcc13d..origin/textchat-23-ui-embeds (fluxer-ui only: widgets/message_content/{mod,embed,embed_media,youtube}.rs, message_row.rs, screens/main/{messages,media}.rs, theme/icons.rs and its svg, tests/{embeds,screenshots}.rs, 4 goldens, READMEs).

Plan tests (1): all 8 exist and assert the spec's values. field_grid_rows (≤3 inline per row, 12-column spans 4/6/12), width_432_with_media_else_516, thumbnail_promoted_for_article_and_image (400x300), duplicate_embeds_dropped (normalized URL, unparsable URLs never merged, gallery ≤10), markdown_only_in_rich (rich and bluesky only), unknown_type_renders_as_link_card, the malformed_embeds_never_panic table (28 hostile embeds x 5 extreme clocks, models plus a headless view build), suppress_x_only_for_author_or_mod (pure and through the store). The 4 screenshots exist and are listed in docs/screenshots/README.md.
Interfaces (2): everything in the Interfaces block is present. The suppress X emits UserAction::SuppressEmbeds { confirmed: false }. render_embeds, SUPPRESS_EMBEDS and inline_embed_media are honoured. The embed::Message::OpenUrl link path is the one Task 43 switches over (see finding 1).
Invariants (3): no new dependency and no fluxer-core change. The UI does no new I/O: images go only through Images/embed::wanted, and the thumbhash decode is pure. No fixture was added (the tests reuse fixtures/rest/message_embeds.json). No URL, secret or path is logged. I checked the panic paths and found none: fit clamps zero and huge sizes, the slicing in engagement is guarded by ASCII checks, rgb drops high bits, Bluesky nesting is bounded at depth 1, and footer_time handles out-of-range clocks.
Review Focus 7 (4): covered by the fuzz-style table above.
Local gate (5): FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a clean review worktree exited 0. All 4 embed goldens passed on this host.

Findings

  1. minor: Embed links reach the store as UserAction::OpenUrl, which only checks the http/https scheme. Nothing checks trusted domains yet. Spec §18.2.3 explicitly moves embed links to the warning modal in Task 43, so this is deferred and does not block.
  2. minor: Embed Markdown is drawn with the message's RenderCtx, so it shares revealed_spoilers. Revealing spoiler N of the message text also uncovers spoiler N of an embed description, and clicks on embed spoilers do nothing (Embed::Spoiler(_) => Vec::new()). This is cosmetic and needs a follow-up issue.
  3. minor: is_mature (CONTAINS_EXPLICIT_MEDIA) is defined but never used. Spec §15 says NSFW-flagged media gets the spoiler cover, and embed media is currently drawn uncovered. It can wait for the spoiler-cover work of Text chat 22. It needs a follow-up issue linked from the PR.
  4. minor: When inline_embed_media is off, hides_content keeps the message text, and the media-only embed also becomes EmbedModel::Link. A link-only message therefore shows the same URL twice. The original hides the content whatever inline_embed_media is set to.
  5. minor: screens/main/media.rs::wanted rebuilds embed models for every stored message of the open channel on each call, not only the visible rows. This only costs performance.
  6. note: The declared deviations are fine for now: audio opens externally, disabled_operations is not checked, and the gallery is a square grid until the mosaic lands. The mechanical conflict with Text chat 22 over message_content/mod.rs and message_row.rs is expected.

Verdict: approve. There are no blocking findings and the local CI is green. Findings 2 and 3 should become follow-up issues before merge.

## Independent review: Text chat 23 (Embeds), head bcb0132 Scope: `git diff 9fcc13d..origin/textchat-23-ui-embeds` (fluxer-ui only: `widgets/message_content/{mod,embed,embed_media,youtube}.rs`, `message_row.rs`, `screens/main/{messages,media}.rs`, `theme/icons.rs` and its svg, `tests/{embeds,screenshots}.rs`, 4 goldens, READMEs). **Plan tests (1)**: all 8 exist and assert the spec's values. `field_grid_rows` (≤3 inline per row, 12-column spans 4/6/12), `width_432_with_media_else_516`, `thumbnail_promoted_for_article_and_image` (400x300), `duplicate_embeds_dropped` (normalized URL, unparsable URLs never merged, gallery ≤10), `markdown_only_in_rich` (rich and bluesky only), `unknown_type_renders_as_link_card`, the `malformed_embeds_never_panic` table (28 hostile embeds x 5 extreme clocks, models plus a headless view build), `suppress_x_only_for_author_or_mod` (pure and through the store). The 4 screenshots exist and are listed in docs/screenshots/README.md. **Interfaces (2)**: everything in the Interfaces block is present. The suppress X emits `UserAction::SuppressEmbeds { confirmed: false }`. `render_embeds`, `SUPPRESS_EMBEDS` and `inline_embed_media` are honoured. The `embed::Message::OpenUrl` link path is the one Task 43 switches over (see finding 1). **Invariants (3)**: no new dependency and no fluxer-core change. The UI does no new I/O: images go only through `Images`/`embed::wanted`, and the thumbhash decode is pure. No fixture was added (the tests reuse `fixtures/rest/message_embeds.json`). No URL, secret or path is logged. I checked the panic paths and found none: `fit` clamps zero and huge sizes, the slicing in `engagement` is guarded by ASCII checks, `rgb` drops high bits, Bluesky nesting is bounded at depth 1, and `footer_time` handles out-of-range clocks. **Review Focus 7 (4)**: covered by the fuzz-style table above. **Local gate (5)**: `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a clean review worktree exited 0. All 4 embed goldens passed on this host. ### Findings 1. **minor**: Embed links reach the store as `UserAction::OpenUrl`, which only checks the http/https scheme. Nothing checks trusted domains yet. Spec §18.2.3 explicitly moves embed links to the warning modal in Task 43, so this is deferred and does not block. 2. **minor**: Embed Markdown is drawn with the message's `RenderCtx`, so it shares `revealed_spoilers`. Revealing spoiler N of the message text also uncovers spoiler N of an embed description, and clicks on embed spoilers do nothing (`Embed::Spoiler(_) => Vec::new()`). This is cosmetic and needs a follow-up issue. 3. **minor**: `is_mature` (`CONTAINS_EXPLICIT_MEDIA`) is defined but never used. Spec §15 says NSFW-flagged media gets the spoiler cover, and embed media is currently drawn uncovered. It can wait for the spoiler-cover work of Text chat 22. It needs a follow-up issue linked from the PR. 4. **minor**: When `inline_embed_media` is off, `hides_content` keeps the message text, and the media-only embed also becomes `EmbedModel::Link`. A link-only message therefore shows the same URL twice. The original hides the content whatever `inline_embed_media` is set to. 5. **minor**: `screens/main/media.rs::wanted` rebuilds embed models for every stored message of the open channel on each call, not only the visible rows. This only costs performance. 6. **note**: The declared deviations are fine for now: audio opens externally, `disabled_operations` is not checked, and the gallery is a square grid until the mosaic lands. The mechanical conflict with Text chat 22 over `message_content/mod.rs` and `message_row.rs` is expected. **Verdict: approve.** There are no blocking findings and the local CI is green. Findings 2 and 3 should become `follow-up` issues before merge.
Author
Owner

Independent review: Text chat 23 (Embeds), at 5560034 (diff 188f780..origin/textchat-23-ui-embeds)

Checked

  1. Plan tests: field_grid_rows, width_432_with_media_else_516, thumbnail_promoted_for_article_and_image, duplicate_embeds_dropped, markdown_only_in_rich, unknown_type_renders_as_link_card, table malformed_embeds_never_panic (28 hostile embeds × 5 extreme clocks, model + footer time + view build) and suppress_x_only_for_author_or_mod all exist in crates/fluxer-ui/tests/embeds.rs. They assert the spec §3.5 values: 432/516 widths, 12-column grid with at most 3 inline fields per row, 80 px thumbnail, gallery of 10 or fewer, 400×300 media and 400×450 tall media. The four screenshots embed_rich_fields, embed_article, embed_youtube and embed_gifv have goldens and pass. I compared hasRichEmbedContent, embedAllowsMarkdown, the www.youtube.com host check and MAX_INLINE_PER_ROW with the fork's EmbedRenderUtils.ts, EmbedParts.tsx and ChannelEmbed.tsx, and they match.
  2. Interfaces (spec §9.3 embeds): dedupe, media-only vs rich, the card, the media kinds, the YouTube poster, the Bluesky card, the suppress X → UserAction::SuppressEmbeds { confirmed: false }, and render_embeds/inline_embed_media are all present. No existing public interface is changed.
  3. Invariants: fluxer-core is untouched and no dependency is added. fluxer-ui gains no I/O path: images go through the existing media::wanted/ImageLoader, and the thumbhash cache is in memory only. No new fixtures (it uses the existing message_embeds.json). No secrets, URLs or paths are logged. Server data: I found no panic path, because slicing in engagement is guarded by ASCII checks, fit clamps, and card/is_duplicate index only after get.
  4. Review Focus 7 (malformed embeds, zero-size media, unknown types): covered by the table test and by unknown_type_renders_as_link_card.
  5. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: exit 0, no failures.

Findings

  • minor: message_row::estimate_height builds the embed models with render_embeds: true, inline_media: true no matter what the user's settings or the message's SUPPRESS_EMBEDS flag say. So suppressed or disabled embeds still add estimated height until the row is laid out. This only affects the estimate, not what is drawn.
  • minor: embed links (title, author, provider, video and YouTube buttons) go through the same UserAction::OpenUrl → open_url path as Markdown links. That path filters to http(s) only and has no trusted-domain / "Leaving Fluxer" step yet. This is consistent with the base, and spec §18.2.3 assigns the switch to Text chat 43. Noting it only so that task covers embeds too.
  • minor (carried over, already tracked): the spoiler state of embeds (#381) and the NSFW spoiler cover from spec §15 (#382) are follow-ups linked from the PR.
  • minor (carried over, not tracked): the earlier review's finding 4 (the URL shows twice when inline_embed_media is off) and finding 5 (media::wanted builds embed models for every message in the open channel each time it runs) still have no issue. I suggest opening follow-up issues for both, but neither blocks.

Verdict: approve. No blocking findings, and local CI is green.

## Independent review: Text chat 23 (Embeds), at 5560034 (diff 188f780..origin/textchat-23-ui-embeds) **Checked** 1. Plan tests: `field_grid_rows`, `width_432_with_media_else_516`, `thumbnail_promoted_for_article_and_image`, `duplicate_embeds_dropped`, `markdown_only_in_rich`, `unknown_type_renders_as_link_card`, table `malformed_embeds_never_panic` (28 hostile embeds × 5 extreme clocks, model + footer time + view build) and `suppress_x_only_for_author_or_mod` all exist in `crates/fluxer-ui/tests/embeds.rs`. They assert the spec §3.5 values: 432/516 widths, 12-column grid with at most 3 inline fields per row, 80 px thumbnail, gallery of 10 or fewer, 400×300 media and 400×450 tall media. The four screenshots `embed_rich_fields`, `embed_article`, `embed_youtube` and `embed_gifv` have goldens and pass. I compared `hasRichEmbedContent`, `embedAllowsMarkdown`, the `www.youtube.com` host check and `MAX_INLINE_PER_ROW` with the fork's `EmbedRenderUtils.ts`, `EmbedParts.tsx` and `ChannelEmbed.tsx`, and they match. 2. Interfaces (spec §9.3 embeds): dedupe, media-only vs rich, the card, the media kinds, the YouTube poster, the Bluesky card, the suppress X → `UserAction::SuppressEmbeds { confirmed: false }`, and `render_embeds`/`inline_embed_media` are all present. No existing public interface is changed. 3. Invariants: `fluxer-core` is untouched and no dependency is added. `fluxer-ui` gains no I/O path: images go through the existing `media::wanted`/`ImageLoader`, and the thumbhash cache is in memory only. No new fixtures (it uses the existing `message_embeds.json`). No secrets, URLs or paths are logged. Server data: I found no panic path, because slicing in `engagement` is guarded by ASCII checks, `fit` clamps, and `card`/`is_duplicate` index only after `get`. 4. Review Focus 7 (malformed embeds, zero-size media, unknown types): covered by the table test and by `unknown_type_renders_as_link_card`. 5. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: **exit 0**, no failures. **Findings** - **minor**: `message_row::estimate_height` builds the embed models with `render_embeds: true, inline_media: true` no matter what the user's settings or the message's `SUPPRESS_EMBEDS` flag say. So suppressed or disabled embeds still add estimated height until the row is laid out. This only affects the estimate, not what is drawn. - **minor**: embed links (title, author, provider, video and YouTube buttons) go through the same `UserAction::OpenUrl` → `open_url` path as Markdown links. That path filters to http(s) only and has no trusted-domain / "Leaving Fluxer" step yet. This is consistent with the base, and spec §18.2.3 assigns the switch to Text chat 43. Noting it only so that task covers embeds too. - **minor** (carried over, already tracked): the spoiler state of embeds (#381) and the NSFW spoiler cover from spec §15 (#382) are follow-ups linked from the PR. - **minor** (carried over, not tracked): the earlier review's finding 4 (the URL shows twice when `inline_embed_media` is off) and finding 5 (`media::wanted` builds embed models for every message in the open channel each time it runs) still have no issue. I suggest opening `follow-up` issues for both, but neither blocks. **Verdict: approve.** No blocking findings, and local CI is green.
charles manually merged commit a8c9c3f4fd into textchat 2026-11-13 02:14:24 +00:00
Sign in to join this conversation.
No description provided.