Reactions: tooltip names for history-loaded messages; bound ReactionOps::known #337

Open
opened 2026-11-12 18:28:31 +00:00 by charles · 0 comments
Owner

From the review of PR #310 (Text chat 13).

  1. Finding 2: selectors::reactions tooltip names come only from reactor pages and live gateway events. A message loaded from history shows no names until its reactors modal is opened, and no core action fetches reactors for a tooltip (the Electron app fetches on hover). Text chat 24 (#274, reactions row) will need a hover action, e.g. a small reactors fetch keyed by (message, emoji).
  2. Finding 1: ReactionOps::known records users for every reaction event in the session, including messages never loaded; only READY clears it. Record only for loaded messages, or bound it.

Seen on textchat-13-core-reactions @ a78a9c6.

From the review of PR #310 (Text chat 13). 1. Finding 2: `selectors::reactions` tooltip names come only from reactor pages and live gateway events. A message loaded from history shows no names until its reactors modal is opened, and no core action fetches reactors for a tooltip (the Electron app fetches on hover). Text chat 24 (#274, reactions row) will need a hover action, e.g. a small reactors fetch keyed by (message, emoji). 2. Finding 1: `ReactionOps::known` records users for every reaction event in the session, including messages never loaded; only READY clears it. Record only for loaded messages, or bound it. Seen on textchat-13-core-reactions @ a78a9c6.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#337
No description provided.