Text chat 13: core-reactions (#263) #310

Manually merged
charles merged 5 commits from textchat-13-core-reactions into textchat 2026-11-12 21:47:57 +00:00
Owner

What this builds

fluxer-core::chat::reactions (Text chat spec §6.2 "Reactions"), plus reaction events applied to message records in messages.rs.

  • Convergence model. A record's reactions change only with server answers and gateway events (MESSAGE_REACTION_ADD, _ADD_MANY, _REMOVE, _REMOVE_EMOJI, _REMOVE_ALL); this user's own reaction is idempotent through me, so an echo of something the record already shows changes nothing. A click records the wanted state in a ReactionOp; selectors::reactions lays it over the record (count without the server's me, plus one if wanted). An op is dropped once nothing is in flight and the record agrees, and dropping it on failure is the revert. Requests go out one per message at a time, because ApiResult::ReactionDone names the message, not the emoji. After a successful request the op waits up to ECHO_GRACE (5 s) for its echo, since the gateway drops an add/remove pair that meets inside its 650 ms buffer (gw/session/session_dispatch_voice.erl:42-101).
  • Retries. A 429 is retried after max(2^n s, retry_after) (Effect::Schedule), up to 3 times, then reverted. A 400 MAX_REACTIONS becomes ReactionRefusal::TooMany.
  • Checks. A new emoji needs ADD_REACTIONS, and an emoji from another guild also needs USE_EXTERNAL_EMOJIS. An emoji already on the message needs neither. The cap is max_reactions_per_message from the instance limits (default 30). Refusals go to app.chat.reactions.refusal.
  • Moderator removals. RemoveReaction of another user, RemoveAllReactions by emoji or for all: these need MANAGE_MESSAGES in guilds, are not optimistic (the events clear the row) and use the same retry rule.
  • Reactors modal. OpenReactors / LoadMoreReactors fetch pages of 100 through the next_after cursor; stale pages are dropped and duplicates removed. Tooltip names (up to 3) come from reactor pages and gateway events, using nick, then global name, then username.
  • selectors::quick_reactions(&App, n). Frecency first (custom emoji only when a known guild has them), then thumbsup, ok_hand, tada, heart, with the user's skin tone.

How it was tested

crates/fluxer-core/tests/chat_reactions.rs has every test the plan names. Before the implementation they failed to compile against the Task 10 stub; with it, they pass:
toggle_adds_optimistically_and_sends_put, own_echo_not_double_counted (single and ADD_MANY), others_add_many_applies_each (Text chat 2 fixtures), remove_emoji_and_remove_all, failure_reverts, retry_429_backoff_then_revert, new_emoji_needs_add_reactions, existing_emoji_does_not, thirty_emoji_cap, reactors_paging, quick_reactions_defaults_and_frecency, and the proptest any_interleaving_converges_to_server_counts. The proptest runs 512 cases over a model of the server, the gateway's 650 ms add buffer (an add and its remove cancel inside it), the network, and other users' and moderators' actions. It checks that no pill is ever zero or duplicated, and that after settling the row equals the server's state with no op left. Its regression seeds are committed.

FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci passes locally. No desktop-only tests apply.

Deviations from the plan

  • tests/chat_ports.rs::stubs_emit_nothing (Text chat 10) now skips the reaction actions, because they have behaviour now. Text chat 11 changes the same test in the same way for the composer, so a merge conflict there is mechanical.
  • chat/mod.rs and selectors/mod.rs only gain re-exports. They are not in the Files list.
  • ReactionOps gains moderation, refusal and known. ReactionOp gains sending, echoed, confirmed, retry and grace. Reactors gains next_after. All of these are additive to the Task 10 types.
  • External custom emoji: the server also needs premium, but UserPrivate has no traits yet (as noted in chat::limits), so only USE_EXTERNAL_EMOJIS is checked, and the server's 4xx reverts the rest.
  • The proptest model flushes the gateway buffer before a moderator clear. The real gateway can deliver a buffered add after a REMOVE_EMOJI/REMOVE_ALL, which affects every client, the original included.
  • +:name: reacting to the last message is in Text chat 11 (plus_react_shorthand_reacts_to_last).

Closes #263

🤖 Generated with Claude Code

## What this builds `fluxer-core::chat::reactions` (Text chat spec §6.2 "Reactions"), plus reaction events applied to message records in `messages.rs`. - **Convergence model.** A record's `reactions` change only with server answers and gateway events (`MESSAGE_REACTION_ADD`, `_ADD_MANY`, `_REMOVE`, `_REMOVE_EMOJI`, `_REMOVE_ALL`); this user's own reaction is idempotent through `me`, so an echo of something the record already shows changes nothing. A click records the wanted state in a `ReactionOp`; `selectors::reactions` lays it over the record (count without the server's `me`, plus one if wanted). An op is dropped once nothing is in flight and the record agrees, and dropping it on failure is the revert. Requests go out one per message at a time, because `ApiResult::ReactionDone` names the message, not the emoji. After a successful request the op waits up to `ECHO_GRACE` (5 s) for its echo, since the gateway drops an add/remove pair that meets inside its 650 ms buffer (`gw/session/session_dispatch_voice.erl:42-101`). - **Retries.** A 429 is retried after `max(2^n s, retry_after)` (`Effect::Schedule`), up to 3 times, then reverted. A 400 `MAX_REACTIONS` becomes `ReactionRefusal::TooMany`. - **Checks.** A new emoji needs ADD_REACTIONS, and an emoji from another guild also needs USE_EXTERNAL_EMOJIS. An emoji already on the message needs neither. The cap is `max_reactions_per_message` from the instance limits (default 30). Refusals go to `app.chat.reactions.refusal`. - **Moderator removals.** `RemoveReaction` of another user, `RemoveAllReactions` by emoji or for all: these need MANAGE_MESSAGES in guilds, are not optimistic (the events clear the row) and use the same retry rule. - **Reactors modal.** `OpenReactors` / `LoadMoreReactors` fetch pages of 100 through the `next_after` cursor; stale pages are dropped and duplicates removed. Tooltip names (up to 3) come from reactor pages and gateway events, using nick, then global name, then username. - **`selectors::quick_reactions(&App, n)`.** Frecency first (custom emoji only when a known guild has them), then thumbsup, ok_hand, tada, heart, with the user's skin tone. ## How it was tested `crates/fluxer-core/tests/chat_reactions.rs` has every test the plan names. Before the implementation they failed to compile against the Task 10 stub; with it, they pass: `toggle_adds_optimistically_and_sends_put`, `own_echo_not_double_counted` (single and `ADD_MANY`), `others_add_many_applies_each` (Text chat 2 fixtures), `remove_emoji_and_remove_all`, `failure_reverts`, `retry_429_backoff_then_revert`, `new_emoji_needs_add_reactions`, `existing_emoji_does_not`, `thirty_emoji_cap`, `reactors_paging`, `quick_reactions_defaults_and_frecency`, and the proptest `any_interleaving_converges_to_server_counts`. The proptest runs 512 cases over a model of the server, the gateway's 650 ms add buffer (an add and its remove cancel inside it), the network, and other users' and moderators' actions. It checks that no pill is ever zero or duplicated, and that after settling the row equals the server's state with no op left. Its regression seeds are committed. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` passes locally. No desktop-only tests apply. ## Deviations from the plan - `tests/chat_ports.rs::stubs_emit_nothing` (Text chat 10) now skips the reaction actions, because they have behaviour now. Text chat 11 changes the same test in the same way for the composer, so a merge conflict there is mechanical. - `chat/mod.rs` and `selectors/mod.rs` only gain re-exports. They are not in the Files list. - `ReactionOps` gains `moderation`, `refusal` and `known`. `ReactionOp` gains `sending`, `echoed`, `confirmed`, `retry` and `grace`. `Reactors` gains `next_after`. All of these are additive to the Task 10 types. - External custom emoji: the server also needs premium, but `UserPrivate` has no traits yet (as noted in `chat::limits`), so only USE_EXTERNAL_EMOJIS is checked, and the server's 4xx reverts the rest. - The proptest model flushes the gateway buffer before a moderator clear. The real gateway can deliver a buffered add after a `REMOVE_EMOJI`/`REMOVE_ALL`, which affects every client, the original included. - `+:name:` reacting to the last message is in Text chat 11 (`plus_react_shorthand_reacts_to_last`). Closes #263 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-proto/README.md
#	crates/fluxer-proto/src/gateway/events.rs
#	crates/fluxer-proto/src/models/channel.rs
#	crates/fluxer-proto/src/models/mod.rs
#	crates/fluxer-proto/src/models/settings.rs
#	crates/fluxer-proto/tests/models_roundtrip.rs
Optimistic toggles laid over the server's record (never double-counted
against single or MESSAGE_REACTION_ADD_MANY echoes), revert on failure,
429 retry with max(2^n s, retry_after) up to 3 times, ADD_REACTIONS /
USE_EXTERNAL_EMOJIS checks for a new emoji, the 30-emoji cap, moderator
removals, reactors paging, the reactions and quick_reactions selectors,
and a property test that any interleaving converges to the server's counts.

Refs #263

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Text chat 13 (reactions)

Reviewed git diff 53fbd6f..a78a9c6 cold: chat/reactions.rs, messages.rs, tests/chat_reactions.rs, tests/chat_ports.rs, re-exports, README.

Plan tests: all 12 named tests exist and assert what the plan says. Spec values hold: 429 backoff max(2^n s, retry_after) for n = 0, 1, 2 (three retries, then revert); 30-emoji cap; reactor pages of 100; quick reactions frecency first, then thumbsup, ok_hand, tada, heart. The proptest runs 512 cases, and its regressions file is committed.
Interfaces: selectors::reactions(&App, channel, message) -> Vec<ReactionModel { emoji: EmojiRef, count, me, tooltip_names }> and selectors::quick_reactions(&App, n) -> Vec<EmojiRef> match the plan exactly. OpenReactors, LoadMoreReactors, ADD_REACTIONS for a new emoji only, USE_EXTERNAL_EMOJIS, the 30-emoji cap, and the 429 retry through Effect::Schedule are all present. Reactors gains next_after, and nothing outside the module builds it.
Invariants: no new dependency, no I/O, no new fixture (the tests use Text chat 2's gateway and REST fixtures). Server data cannot panic the client: counts saturate, removals never go below the user's own reaction, and the shift is clamped.
Review Focus 1: verified. The record holds only the server's state, and the user's own reaction is idempotent through me. The optimistic wish is shown over the record and never written into it. chat::reduce runs after messages.reduce (app.rs), so settle sees the record with the echo already applied. Requests go out one per message at a time, which is sound because ReactionDone carries no emoji. The ECHO_GRACE design also holds: a stale grace timer cannot clear a newer confirmed, because the timer ids must match.

Findings

  1. minor: ReactionOps::known gets an entry for every reaction event in the session, including messages that were never loaded. Only READY clears it (MESSAGE_DELETE removes one message). Memory grows without bound over a long session. Consider recording users only for loaded messages.
  2. minor: tooltip names come only from reactor pages and live events. A message loaded from history shows no names until its modal is opened, and no action fetches reactors for a tooltip (the original fetches on hover). Text chat 24 will need one. Suggest a follow-up issue.
  3. minor: the server's MAX_REACTIONS answer sets TooMany { max: DEFAULT_MAX_REACTIONS } instead of the resolved max_reactions(ctx, channel). The modal shows 30 on an instance with a different limit.
  4. minor (acknowledged by the implementer): the premium check for external emoji is skipped (UserPrivate has no traits yet), and custom emoji in DMs are not checked at all. The server's 4xx reverts the reaction, so no data is lost.
  5. minor (unrelated to this PR): the first local FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci failed. The apps/fluxer lib tests passed all 53 tests, then aborted at exit with The futex facility returned an unexpected error code (SIGABRT). Three direct reruns of that binary and a second full CI run were green, so this looks like an intermittent abort at teardown in the app crate. This PR touches only fluxer-core. A bug issue should be opened (I could not open one from here).

Local CI: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green on rerun (all steps passed). The first run hit the flaky abort in finding 5.

Verdict: approve. No blocking findings.

## Independent review: Text chat 13 (reactions) Reviewed `git diff 53fbd6f..a78a9c6` cold: `chat/reactions.rs`, `messages.rs`, `tests/chat_reactions.rs`, `tests/chat_ports.rs`, re-exports, README. **Plan tests**: all 12 named tests exist and assert what the plan says. Spec values hold: 429 backoff `max(2^n s, retry_after)` for n = 0, 1, 2 (three retries, then revert); 30-emoji cap; reactor pages of 100; quick reactions frecency first, then thumbsup, ok_hand, tada, heart. The proptest runs 512 cases, and its regressions file is committed. **Interfaces**: `selectors::reactions(&App, channel, message) -> Vec<ReactionModel { emoji: EmojiRef, count, me, tooltip_names }>` and `selectors::quick_reactions(&App, n) -> Vec<EmojiRef>` match the plan exactly. `OpenReactors`, `LoadMoreReactors`, ADD_REACTIONS for a new emoji only, USE_EXTERNAL_EMOJIS, the 30-emoji cap, and the 429 retry through `Effect::Schedule` are all present. `Reactors` gains `next_after`, and nothing outside the module builds it. **Invariants**: no new dependency, no I/O, no new fixture (the tests use Text chat 2's gateway and REST fixtures). Server data cannot panic the client: counts saturate, removals never go below the user's own reaction, and the shift is clamped. **Review Focus 1**: verified. The record holds only the server's state, and the user's own reaction is idempotent through `me`. The optimistic wish is shown over the record and never written into it. `chat::reduce` runs after `messages.reduce` (app.rs), so `settle` sees the record with the echo already applied. Requests go out one per message at a time, which is sound because `ReactionDone` carries no emoji. The `ECHO_GRACE` design also holds: a stale grace timer cannot clear a newer `confirmed`, because the timer ids must match. ### Findings 1. **minor**: `ReactionOps::known` gets an entry for every reaction event in the session, including messages that were never loaded. Only READY clears it (MESSAGE_DELETE removes one message). Memory grows without bound over a long session. Consider recording users only for loaded messages. 2. **minor**: tooltip names come only from reactor pages and live events. A message loaded from history shows no names until its modal is opened, and no action fetches reactors for a tooltip (the original fetches on hover). Text chat 24 will need one. Suggest a `follow-up` issue. 3. **minor**: the server's `MAX_REACTIONS` answer sets `TooMany { max: DEFAULT_MAX_REACTIONS }` instead of the resolved `max_reactions(ctx, channel)`. The modal shows 30 on an instance with a different limit. 4. **minor (acknowledged by the implementer)**: the premium check for external emoji is skipped (`UserPrivate` has no traits yet), and custom emoji in DMs are not checked at all. The server's 4xx reverts the reaction, so no data is lost. 5. **minor (unrelated to this PR)**: the first local `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` failed. The `apps/fluxer` lib tests passed all 53 tests, then aborted at exit with `The futex facility returned an unexpected error code` (SIGABRT). Three direct reruns of that binary and a second full CI run were green, so this looks like an intermittent abort at teardown in the app crate. This PR touches only `fluxer-core`. A `bug` issue should be opened (I could not open one from here). **Local CI**: `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green on rerun (all steps passed). The first run hit the flaky abort in finding 5. **Verdict: approve.** No blocking findings.
Author
Owner

Independent review (second pass): Text chat 13 (reactions), head 901849c

I reviewed git diff 9fcc13d..901849c cold in a fresh worktree. It covers chat/reactions.rs, messages.rs, tests/chat_reactions.rs (with the proptest regressions file), tests/chat_ports.rs, the re-exports in chat/mod.rs and selectors/mod.rs, and the README.

(1) Plan tests. All 12 named tests exist and check what the plan says:

  • toggle_adds_optimistically_and_sends_put
  • own_echo_not_double_counted: single echo before the 204, ADD_MANY after it, and a removal echo
  • others_add_many_applies_each, which uses Text chat 2's message_reaction_add_many.json
  • remove_emoji_and_remove_all
  • failure_reverts
  • retry_429_backoff_then_revert
  • new_emoji_needs_add_reactions
  • existing_emoji_does_not
  • thirty_emoji_cap
  • reactors_paging
  • quick_reactions_defaults_and_frecency
  • the proptest any_interleaving_converges_to_server_counts: 512 cases, regressions file committed

The spec values hold, and I checked the backoff against the original. The 429 wait is max(2^n s, retry_after) for n = 0..2, which matches ReactionCommands.tsx:249-250 (MAX_RETRIES = 3), and the request is reverted after that. The other values: a cap of 30 distinct emoji, reactor pages of 100, and quick reactions frecency first, then thumbsup, ok_hand, tada, heart.

(2) Interfaces. These match the plan exactly:

  • selectors::reactions(&App, channel, message) -> Vec<ReactionModel { emoji: EmojiRef, count, me, tooltip_names: Vec<String> }>
  • selectors::quick_reactions(&App, n) -> Vec<EmojiRef>
  • the reactors state, driven by OpenReactors and LoadMoreReactors
  • the permission checks and the 30-emoji cap
  • the 429 retry through Effect::Schedule

The changes to the Task 10 types only add fields, and nothing outside the module builds those types.

(3) Invariants.

  • No Cargo.toml changes and no new dependency.
  • No I/O, and no new fixture: the tests use Text chat 2's gateway and REST fixtures.
  • No secrets, URLs or paths.
  • Server data cannot panic the client: counts saturate, the shift is clamped with min(6), a removal never takes the count below the user's own reaction, and a server count of 0 shows as max(me).

(4) Review Focus 1. Verified. The record holds only the server's state. The user's own reaction is idempotent through me, which the server computes per viewer (fluxer_messages/src/shard_impl.rs:2964). The user's wish is laid over the record and never written into it. chat::reduce runs after messages.reduce (app.rs). Requests go one per message at a time, which is sound because ReactionDone carries no emoji. I traced these cases by hand and they converge:

  • the echo arrives before the 204
  • the echo arrives after the 204
  • the user toggles again while the request is in flight, with and without an echo
  • the gateway cancels an add and its remove inside the 650 ms buffer, so ECHO_GRACE expires

(5) CI. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: green (all steps passed) on the second run. The first run failed at the test step: apps/fluxer --lib passed all 53 tests, then the process died at exit with SIGSEGV. I reran cargo test -p fluxer --lib three times and it passed each time. This diff does not touch apps/fluxer, so this is the known exit-time crash tracked in #338 (filed there as a futex SIGABRT; this time it was SIGSEGV).

Findings

  1. minor (still open from the first review; no issue yet): when the server answers 400 MAX_REACTIONS, on_failed sets TooMany { max: DEFAULT_MAX_REACTIONS } instead of max_reactions(ctx, channel_id). On an instance with a different limit, the modal shows 30. ctx is already in scope in reduce. This needs a follow-up issue before merge (CLAUDE.md: anything deferred gets its own issue).
  2. minor (hardening): re-sending after ECHO_GRACE expires has no bound. Suppose the record says me = false while the server already has this user's reaction. A click sends PUT. The server returns 204 with no event (MessageReactionService.ts around line 212: if (userReactionExists) return;). Grace expires, needs_request is true again, and the client sends another PUT every 5 s for as long as the message is loaded. Meanwhile the pill shows count + 1. READY reloads the records and a resume replays missed events, so I could not produce this state with the current server, which is why this is not blocking. A cap on grace-expiry re-sends (say, one) would close it. Suggest folding it into the same follow-up as finding 1.
  3. minor (acknowledged in the PR body): the premium check for external emoji is skipped because UserPrivate has no traits yet, and custom emoji in DMs are not checked at all. The server's 4xx reverts the reaction, so no data is lost.
  4. minor: on MESSAGE_REACTION_ADD, on_gateway looks the reactor up in ctx.users, but users.reduce runs after chat::reduce. A user who first appears in that event, without a member, is not remembered for the tooltip. Cosmetic; it belongs with #337 (tooltip names).

#337 and #338 already cover the first review's other minor findings.

Verdict: APPROVE. No blocking findings. Local CI is green (one flaky run from #338 before that).

## Independent review (second pass): Text chat 13 (reactions), head 901849c I reviewed `git diff 9fcc13d..901849c` cold in a fresh worktree. It covers `chat/reactions.rs`, `messages.rs`, `tests/chat_reactions.rs` (with the proptest regressions file), `tests/chat_ports.rs`, the re-exports in `chat/mod.rs` and `selectors/mod.rs`, and the README. **(1) Plan tests.** All 12 named tests exist and check what the plan says: - `toggle_adds_optimistically_and_sends_put` - `own_echo_not_double_counted`: single echo before the 204, `ADD_MANY` after it, and a removal echo - `others_add_many_applies_each`, which uses Text chat 2's `message_reaction_add_many.json` - `remove_emoji_and_remove_all` - `failure_reverts` - `retry_429_backoff_then_revert` - `new_emoji_needs_add_reactions` - `existing_emoji_does_not` - `thirty_emoji_cap` - `reactors_paging` - `quick_reactions_defaults_and_frecency` - the proptest `any_interleaving_converges_to_server_counts`: 512 cases, regressions file committed The spec values hold, and I checked the backoff against the original. The 429 wait is `max(2^n s, retry_after)` for n = 0..2, which matches `ReactionCommands.tsx:249-250` (`MAX_RETRIES = 3`), and the request is reverted after that. The other values: a cap of 30 distinct emoji, reactor pages of 100, and quick reactions frecency first, then thumbsup, ok_hand, tada, heart. **(2) Interfaces.** These match the plan exactly: - `selectors::reactions(&App, channel, message) -> Vec<ReactionModel { emoji: EmojiRef, count, me, tooltip_names: Vec<String> }>` - `selectors::quick_reactions(&App, n) -> Vec<EmojiRef>` - the reactors state, driven by `OpenReactors` and `LoadMoreReactors` - the permission checks and the 30-emoji cap - the 429 retry through `Effect::Schedule` The changes to the Task 10 types only add fields, and nothing outside the module builds those types. **(3) Invariants.** - No Cargo.toml changes and no new dependency. - No I/O, and no new fixture: the tests use Text chat 2's gateway and REST fixtures. - No secrets, URLs or paths. - Server data cannot panic the client: counts saturate, the shift is clamped with `min(6)`, a removal never takes the count below the user's own reaction, and a server count of 0 shows as `max(me)`. **(4) Review Focus 1.** Verified. The record holds only the server's state. The user's own reaction is idempotent through `me`, which the server computes per viewer (`fluxer_messages/src/shard_impl.rs:2964`). The user's wish is laid over the record and never written into it. `chat::reduce` runs after `messages.reduce` (`app.rs`). Requests go one per message at a time, which is sound because `ReactionDone` carries no emoji. I traced these cases by hand and they converge: - the echo arrives before the 204 - the echo arrives after the 204 - the user toggles again while the request is in flight, with and without an echo - the gateway cancels an add and its remove inside the 650 ms buffer, so `ECHO_GRACE` expires **(5) CI.** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: **green** (`all steps passed`) on the second run. The first run failed at the `test` step: `apps/fluxer --lib` passed all 53 tests, then the process died at exit with SIGSEGV. I reran `cargo test -p fluxer --lib` three times and it passed each time. This diff does not touch `apps/fluxer`, so this is the known exit-time crash tracked in #338 (filed there as a futex SIGABRT; this time it was SIGSEGV). ### Findings 1. **minor** (still open from the first review; no issue yet): when the server answers `400 MAX_REACTIONS`, `on_failed` sets `TooMany { max: DEFAULT_MAX_REACTIONS }` instead of `max_reactions(ctx, channel_id)`. On an instance with a different limit, the modal shows 30. `ctx` is already in scope in `reduce`. This needs a `follow-up` issue before merge (CLAUDE.md: anything deferred gets its own issue). 2. **minor** (hardening): re-sending after `ECHO_GRACE` expires has no bound. Suppose the record says `me = false` while the server already has this user's reaction. A click sends `PUT`. The server returns 204 with no event (`MessageReactionService.ts` around line 212: `if (userReactionExists) return;`). Grace expires, `needs_request` is true again, and the client sends another `PUT` every 5 s for as long as the message is loaded. Meanwhile the pill shows count + 1. READY reloads the records and a resume replays missed events, so I could not produce this state with the current server, which is why this is not blocking. A cap on grace-expiry re-sends (say, one) would close it. Suggest folding it into the same follow-up as finding 1. 3. **minor** (acknowledged in the PR body): the premium check for external emoji is skipped because `UserPrivate` has no traits yet, and custom emoji in DMs are not checked at all. The server's 4xx reverts the reaction, so no data is lost. 4. **minor**: on `MESSAGE_REACTION_ADD`, `on_gateway` looks the reactor up in `ctx.users`, but `users.reduce` runs after `chat::reduce`. A user who first appears in that event, without a `member`, is not remembered for the tooltip. Cosmetic; it belongs with #337 (tooltip names). #337 and #338 already cover the first review's other minor findings. **Verdict: APPROVE.** No blocking findings. Local CI is green (one flaky run from #338 before that).
charles manually merged commit 2e0ae03bcf into textchat 2026-11-12 21:47:57 +00:00
Sign in to join this conversation.
No description provided.