Ask EmuMovies for a clone video under its parent name #74
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/video-snaps-for-clones"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
47 of 191 installed games showed a static snap; 36 were clones. EmuMovies files a clone artwork under the parent, so asking for the clone name returned nothing and looked identical to the source not having it.
Probed against the real server: 1943ua absent / 1943 present, punisheru absent / punisher present, crimfghtu absent / crimfght present.
Parentage reaches the shell fetcher the way titles already do, a tsv written from the index.
Also guards both list writers against a null index, which never reached their catch and would have thrown.
47 of 191 installed games were showing a static snap. 36 of those were clones, and EmuMovies files a clone's artwork under the parent. Probed against the real server: absent 1943ua.mp4 present 1943.mp4 absent punisheru.mp4 present punisher.mp4 absent crimfghtu.mp4 present crimfght.mp4 So "no video for this game" was mostly "asked under the wrong name", and it looked identical to the source not having it. Parentage reaches the shell fetcher the way titles already do -- a tsv written beside them from the index -- because the fetcher has no way to ask the index itself. Same fix as the mirror's clone fallback, a different source needing it. Both list writers now handle a missing index. loadIndexRows answers null for "not built yet", which is not an exception, so it never reached the catch and the loop below would have thrown -- in a function whose whole purpose is to degrade quietly when there is no index. writeTitleList had it too; it is where this was copied from. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nz3es8PajUzXmqJJiK6yRBView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.