A late publication of an ended share can be taken by the next share; flaky window_input_updates_last_input #923

Closed
opened 2026-11-19 00:26:49 +00:00 by charles · 1 comment
Owner

Found while investigating #921 (PR #922); not fixed there.

  1. A late publication of an ended share can be taken by the next share. Sequence: stop a screen share while it is still publishing, then start a new one so that the new capture reports Started before the old publication lands. on_video_published (fluxer-core go-live) accepts any sid while video_sid is None, so the new share can announce self_stream early under the OLD track's sid; the old sid's LocalTrackUnpublished then does not clear video_sid. Possible effects: viewers told the stream is live under a track that is about to be unpublished; the new share's real publication ignored or mismatched. Wanted: tie each publication to the share that asked for it (the start's own id / generation) and ignore publications of an earlier share; tests for the sequence at core level and with the fake room's hold_screen_publish.
  2. Flaky test crates/fluxer-ui/tests/app.rs window_input_updates_last_input: assertion failed: last_input() <= Instant::now() (microsecond rounding in last_input). Make the comparison sound (round the same way on both sides, or compare with a tolerance and say why).
Found while investigating #921 (PR #922); not fixed there. 1. **A late publication of an ended share can be taken by the next share.** Sequence: stop a screen share while it is still publishing, then start a new one so that the new capture reports `Started` before the old publication lands. `on_video_published` (fluxer-core go-live) accepts any sid while `video_sid` is `None`, so the new share can announce `self_stream` early under the OLD track's sid; the old sid's `LocalTrackUnpublished` then does not clear `video_sid`. Possible effects: viewers told the stream is live under a track that is about to be unpublished; the new share's real publication ignored or mismatched. Wanted: tie each publication to the share that asked for it (the start's own id / generation) and ignore publications of an earlier share; tests for the sequence at core level and with the fake room's `hold_screen_publish`. 2. **Flaky test** `crates/fluxer-ui/tests/app.rs` `window_input_updates_last_input`: `assertion failed: last_input() <= Instant::now()` (microsecond rounding in `last_input`). Make the comparison sound (round the same way on both sides, or compare with a tolerance and say why).
Author
Owner

Fixed by #924, published in nightly 2026.1119.395.

Fixed by #924, published in nightly 2026.1119.395.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#923
No description provided.