Key codes and typed text still printable through Debug in older types #919

Open
opened 2026-11-18 22:59:08 +00:00 by charles · 0 comments
Owner

Found while fixing Task 35's review (PR #898). The desktop shell spec (§12, Global Constraints) says no key code, key name or typed text may appear in logs or in Debug output. Task 35's own types now comply, but these older types still derive Debug with key material:

  • fluxer-ui: WindowEvent::Key, Chord, ChordIn, and keybinds::Chord (from Text chat / Daily use 35) print the key code and the text;
  • fluxer-core: VoiceSettings and VoiceSettingChange::PttKey print the push-to-talk key name.

Wanted. Hand-written Debug for each (as Matcher and VoiceKeys have), a test per type that its {:?} and that of the structs holding it (Local, App, messages, actions) contain no key code, name or text, and a sweep for any tracing field or Display that prints one. Consider one shared helper or a lint-style test that walks the public message/action enums, so a new variant cannot reintroduce it.

Found while fixing Task 35's review (PR #898). The desktop shell spec (§12, Global Constraints) says no key code, key name or typed text may appear in logs or in `Debug` output. Task 35's own types now comply, but these older types still derive `Debug` with key material: - fluxer-ui: `WindowEvent::Key`, `Chord`, `ChordIn`, and `keybinds::Chord` (from Text chat / Daily use 35) print the key code and the text; - fluxer-core: `VoiceSettings` and `VoiceSettingChange::PttKey` print the push-to-talk key name. **Wanted.** Hand-written `Debug` for each (as `Matcher` and `VoiceKeys` have), a test per type that its `{:?}` and that of the structs holding it (`Local`, `App`, messages, actions) contain no key code, name or text, and a sweep for any `tracing` field or `Display` that prints one. Consider one shared helper or a lint-style test that walks the public message/action enums, so a new variant cannot reintroduce it.
charles added this to the Desktop shell milestone 2026-11-18 22:59:08 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#919
No description provided.