Pin cards and the thread panel: context menu, lightbox and spoilers that don't answer (follow-up of #848) #849

Closed
opened 2026-11-18 02:05:03 +00:00 by charles · 1 comment
Owner

Found while fixing #848, on textchat at ac54f542. They are left out of that PR because each needs more than the click routing #848 adds.

  1. A pin whose message is outside the loaded history: no context menu, and its pictures don't open. The message menu (message_actions::menu::model → chat::actions::record) and the lightbox (chat::media::open) look the message up among the channel's loaded messages only. A pin card of an older message therefore gets no menu on a right click, and a click on its picture does nothing. In the original both work from the pins popout. Steps: open #general in the dev server, pin a message older than the first page (e.g. via the API), open the pins popout, then right-click the pin and click a picture of it. Probably needs the store to also look the message up in chat.pins (and in the search and inbox results).
  2. Spoilers in pin cards can't be revealed. search::results::message_preview draws them with an empty revealed_spoilers set. The click reaches the channel's view state, but the card does not read it.
  3. Search result and bookmark/mention cards are still read-only. They pass |_| Row to message_preview: links, the author, pictures and the context menu do nothing. The original renders them with MessagePreviewContext.LIST_POPOUT, like the pins. #848 gave the pins the routing (pins::Message::Row/Menu → main::update); the same routing would serve search::Message::Row and inbox::Message::Row.
  4. Right click on a message in the thread side panel opens a menu that is never drawn. threads::panel::update → messages::update_in sets local.threads.panel.chat.actions.menu, but main::message_actions_over draws only local.messages.actions.menu. Steps: open a thread in the side panel and right-click one of its messages. Nothing shows (seen headlessly: the panel's actions.menu is Some, and no menu text is drawn).
Found while fixing #848, on `textchat` at ac54f542. They are left out of that PR because each needs more than the click routing #848 adds. 1. **A pin whose message is outside the loaded history: no context menu, and its pictures don't open.** The message menu (`message_actions::menu::model` → `chat::actions::record`) and the lightbox (`chat::media::open`) look the message up among the channel's loaded messages only. A pin card of an older message therefore gets no menu on a right click, and a click on its picture does nothing. In the original both work from the pins popout. Steps: open #general in the dev server, pin a message older than the first page (e.g. via the API), open the pins popout, then right-click the pin and click a picture of it. Probably needs the store to also look the message up in `chat.pins` (and in the search and inbox results). 2. **Spoilers in pin cards can't be revealed.** `search::results::message_preview` draws them with an empty `revealed_spoilers` set. The click reaches the channel's view state, but the card does not read it. 3. **Search result and bookmark/mention cards are still read-only.** They pass `|_| Row` to `message_preview`: links, the author, pictures and the context menu do nothing. The original renders them with `MessagePreviewContext.LIST_POPOUT`, like the pins. #848 gave the pins the routing (`pins::Message::Row`/`Menu` → `main::update`); the same routing would serve `search::Message::Row` and `inbox::Message::Row`. 4. **Right click on a message in the thread side panel opens a menu that is never drawn.** `threads::panel::update` → `messages::update_in` sets `local.threads.panel.chat.actions.menu`, but `main::message_actions_over` draws only `local.messages.actions.menu`. Steps: open a thread in the side panel and right-click one of its messages. Nothing shows (seen headlessly: the panel's `actions.menu` is `Some`, and no menu text is drawn).
Author
Owner

Fixed in nightly 2026.1118.373 (PR #862). Leftover: #863.

Fixed in nightly 2026.1118.373 (PR #862). Leftover: #863.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#849
No description provided.