Shell 3: Spike — Wayland global shortcuts through the portal (#795) #840
Closed
charles
wants to merge 0 commits from
shell-3-spike-wayland-global-shortcuts into shell
pull from: shell-3-spike-wayland-global-shortcuts
merge into: charles:shell
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!840
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "shell-3-spike-wayland-global-shortcuts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What this is
Spike for Desktop shell Task 3: system-wide shortcuts on Wayland through the XDG portal's
GlobalShortcutsinterface, withashpd0.14 over the zbus 6 we already have. Nothing new in the library. The client code is in the example (spikemodule), and the private-bus test runs that same module, so the tests cover exactly what the example runs on a real desktop.Cargo.toml:ashpd = { version = "0.14", default-features = false, features = ["async-io", "global_shortcuts"] }.async-iois zbus's own runtime, not tokio. Thetracingfeature is off because it logs whole signal bodies, andShortcutsChangedcarries the triggers (spec §12).fluxer-platformdepends on it on Linux only. The test is also Linux-only and addszbuswithserviceas a dev-dependency for the fake's#[interface].cargo denyis green.examples/portal_shortcuts.rsregistersflaxative, opens a session, lists what is assigned and bindsvoice_toggle_mute("Toggle mute", preferredCTRL+SHIFT+m) andvoice_push_to_talk("Push to talk", no default as in the original;--ptt-triggertakes an XDG trigger).--configureopensConfigureShortcutson v2. It then printspress <id>/release <id>with timestamps. It prints ids only, never keys or triggers.tests/portal_shortcuts_bus.rsis a fakeorg.freedesktop.portal.Desktopon a privatedbus-daemon(it activates nothing). It servesGlobalShortcutsv1/v2,Request.Response, session objects andhost.portal.Registry. This is the harness Task 28 extends.What was proven
Tests (in
cargo xtask ci):registers_before_first_callregister_without_desktop_entry_is_refused_and_the_session_still_opensregister_errors_are_classifiedregister_on_a_bus_without_portal_reports_no_portalbind_then_activated_and_deactivated(another session's signals are ignored)bind_without_trigger_for_push_to_talk_sends_noneempty_bind_answer_is_deniedempty_bind_answer_with_stored_shortcuts_is_boundcancelled_bind_is_cancelledshortcuts_changed_reported(Debugnever shows a trigger)configure_only_on_v2(ashpd refuses on v1 without calling)portal_restart_detected(NameOwnerChangedlost/appeared; the session does not survive; the same connection can register and open a new session)Measured on this machine, without touching the live desktop session (KDE Plasma 6.8.2 Wayland, xdg-desktop-portal 1.22.1, -kde 6.8.2):
GlobalShortcuts.versionis 2. This was a single property read./usr/lib/xdg-desktop-portalon a private bus, with private XDG data dirs and no backends activatable. Its answers toRegister:flaxative.desktoppresent,Register("flaxative")succeeds. A one-element id is accepted.org.freedesktop.portal.Error.Failed"Could not register app ID: App info not found for 'flaxative'".org.kde.konsole).Findings for Task 28 (deviations from the plan's Interfaces)
ashpd::AppIDrejectsflaxative. It requires reverse-DNS with at least two elements. The spike therefore callsRegistry.Registerdirectly on the connection instead ofashpd::register_host_app.ashpd0.14'sCreateSessionOptionshas no setters, so every session gets a random token. The plan's "session with a fixed handle token" needsCreateSessionwritten by hand, or accepting a random token.receive_closed.ashpdkeeps the session path private, sospike::session_pathreads it from the serialised form.Session::receive_closedborrows the session, so the spike watchesClosedwith azbus::Proxyof its own.BindShortcutswaits for its Response without a time limit, which the user's dialog needs.Spike verdict: the ashpd/portal path works at protocol level, so Task 28 goes ahead (the Task 3 fallback is not needed). The hold behaviour below is not measured yet.
Not measured: Charles, by hand (for Task 44's list)
Run
cargo run -p fluxer-platform --example portal_shortcuts -- --ptt-trigger F9on KDE Plasma 6 Wayland, and again with--configureand with--rebind. Record:releasearrive on key release?release/presswith a few ms between them? That gap is what sizes Task 28's 60 ms debounce.CTRL+ALT+t): press/release while holding.GNOME 48+, Hyprland (
hyprctl globalshortcuts), Sway and COSMIC are from documentation only (spec §4, §16).Tests run
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally, with origin/shell9012f380merged in.FLUXER_DESKTOP_TESTStest and did not run the example on the live session, because it would show the desktop's dialog. Windows: the example compiles to a stubmain, the test file is#![cfg(target_os = "linux")], andashpdis a Linux-only dependency.Closes #795
🤖 Generated with Claude Code
https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Independent review: Shell 3 (spike, Wayland global shortcuts through the portal)
Scope:
git diff 106ff769..origin/shell-3-spike-wayland-global-shortcuts. Theci.yamlhunk comes from origin/shell9012f380(merged in), not from this task. The task's own diff against origin/shell is 6 files: workspace and crateCargo.toml,Cargo.lock, README,examples/portal_shortcuts.rsandtests/portal_shortcuts_bus.rs.Checks
registers_before_first_call,bind_then_activated_and_deactivated,empty_bind_answer_is_denied,shortcuts_changed_reported,configure_only_on_v2andportal_restart_detected. Six extra tests cover register classification, a missing desktop entry, no portal, cancel, an empty answer with stored shortcuts, and a push-to-talk bind without a trigger. The ids arevoice_toggle_muteandvoice_push_to_talk, the app id isflaxative(fluxer_platform::APP_ID), and the fake serves GlobalShortcuts v1 and v2 plushost.portal.Registry.AppIDrejectsflaxative, private session path) are documented in the README and the PR.ashpd0.14 is Linux-only and usesdefault-features = falsewithasync-ioandglobal_shortcuts. Itstracingfeature is off, and no other crate enables it. Notracing::calls are added. Output prints ids only.DebugofDefinitionandAssignedprints…for triggers, and a test asserts it. The private bus activates nothing, so the live session is not touched. Windows: the example falls back to a stubmain, the test file is#![cfg(target_os = "linux")]and the deps are target-gated.cargo denyis green. No secrets or paths.GlobalShortcutActions.ts:26-30.is_xdg_triggermatchesXDG_TRIGGER_PATTERN(GlobalShortcutsEngine.ts:116, the trigger is dropped when it does not match,:191).minCTRL+SHIFT+mmatchesxdgKeysymForCombo/comboToXdgTrigger(GlobalShortcutKeys.ts:688-719).bind_step/listed_outcome(global_shortcuts.rs:251-269).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green in the review worktree ate26ac42b("all steps passed"; portal_shortcuts_bus: 12 passed).Findings
examples/portal_shortcuts.rs:339): a bind Response code 2 (ashpdResponseError::Other) becomesBindOutcome::Failed. The original'sbind_stepmaps code 2 toDenied(global_shortcuts.rs:258). This is harmless in a spike, but Task 28 must map it to denied (consentdeclined), not to a failure.examples/portal_shortcuts.rs:183):classify_register_errordeparts from the original. The original treatsFailed(other than "already associated") asRetryand unknown names asUnregistered. The spike reportsNoDesktopEntry/Refused/NoRegistryinstead. The finer split is useful, but Task 28 should keep the original's retry for "App info not found" (the desktop entry can appear later, Task 18).CLAUDE.md'sCo-Authored-By: Claude Fable 5.2line. This affects history metadata only.Verdict: approve. There are no blocking findings, and the local gate is green.
Merged into
shellby hand (the merge API returns 405); the commits are in the branch.Independent review (second pass): Shell 3, spike, Wayland global shortcuts through the portal
Scope. The range I was given,
f2e3f17d..origin/shell-3-spike-wayland-global-shortcuts, is a reverse diff: the branch tip44a04b1bis already an ancestor ofshell(the PR was merged as900b258a). So I reviewed the task's own commits instead:7d2735a0(the example,ashpddependency lines) andf157ae53(tests/portal_shortcuts_bus.rs, README).Checks
registers_before_first_call,bind_then_activated_and_deactivated,empty_bind_answer_is_denied,shortcuts_changed_reported,configure_only_on_v2andportal_restart_detected. There are also six extra tests: register classification, no portal, no desktop entry, cancel, an empty answer with stored shortcuts, and a push-to-talk bind with no trigger. The ids arevoice_toggle_muteandvoice_push_to_talk, and the preferred trigger isCTRL+SHIFT+m.press <id>/release <id>. The fake portal servesGlobalShortcutsv1/v2, the sessions andhost.portal.Registryon a privatedbus-daemonwith no service activation. That gives Task 28 its harness.ashpd0.14 is a Linux-only dependency withdefault-features = falseand onlyasync-ioandglobal_shortcuts.tracingis off, and the reason is given.#![cfg(target_os = "linux")], and the example has a non-Linuxmain, so the Windows build is clean.Debug:DefinitionandAssignedredact the trigger, and a test asserts this./home/cdaoust/src/fluxer-soundboard:GLOBAL_SHORTCUT_DEFAULT_DESCRIPTIONSinfluxer_desktop/src/common/GlobalShortcutActions.ts.is_xdg_triggermatchesXDG_TRIGGER_PATTERNinGlobalShortcutsEngine.ts:116.InputKeybind.ts:683.ListShortcuts, where an empty list means a denial, matchesbind_step/listed_outcomeinlinux-portals/src/global_shortcuts.rs:251-269. Two differences are listed below.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cion44a04b1b: all steps passed, andportal_shortcuts_buspassed 12 of 12.Findings
Portal::bindmaps response code 2 (ResponseError::Other) toBindOutcome::Failed. The original'sbind_step(global_shortcuts.rs:255-259) maps code 2 toDeniedand only codes 3 and above toFailed. This is spike-only code, but Task 28 should follow the original here.classify_register_errordiverges from the original (global_shortcuts.rs:350-358):UnknownMethod/UnknownInterfacegiveNoRegistry, where the original givesUnregistered.Error.FailedgivesNoDesktopEntryorRefused, where the original retries.The README documents the finer split, but Task 28 must keep the original's retry and back-off.
Deactivatedon release, KDE bug 484525, modifier triggers and a mouse-button trigger. The workflow forbids key grabs on the live session, so this is correctly listed in the README as needing a person at the desktop:cargo run -p fluxer-platform --example portal_shortcuts. Charles should run it on Plasma 6.8.Verdict: approved. There are no blocking findings, and the local gate is green.
Review round 1 (Task 3, #795): the one finding was minor and needed no code change. It said there was nothing to review: origin/shell-3-spike-wayland-global-shortcuts is at
f2e3f17db, the same commit as the review base, and the spike already landed in shell as900b258a7. I checked this.900b258a7is in origin/shell and the branch has no commits beyond shell, so I made no commit, no push and no follow-up issue.Pull request closed