Server admin 8: Form widgets: colour field, tri-state permission buttons, stop slider, multi-line field (#674) #714
Closed
charles
wants to merge 0 commits from
serveradmin-8-form-widgets into serveradmin
pull from: serveradmin-8-form-widgets
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!714
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-8-form-widgets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What this builds
The form widgets for the administration screens (Server administration plan, Task 8; spec §8):
widgets::color_field::view(value, on_change)(.label(),.description(),.disabled()): the original'sColorPickerField(feat/ui/components/form/ColorPickerField.{tsx,module.css}). It has a 44 px field with a monospace hex input, the swatch with the eyedropper, the description and the error. The text is committed on Enter or on a press elsewhere (the original commits on blur).parsereads#rgb/#rgba/#rrggbb/#rrggbbaa,rgb()/rgba()(numbers or %, comma or space separated),hsl()/hsla()(deg/rad/grad/turn) and the 148 CSS names plustransparent, and drops alpha. An invalid entry keeps the value, puts its hex back and shows the error (commit). A value of 0 means "no colour": the swatch then shows--text-chat. The swatch opens the original'sColorPickerPopover: the saturation/brightness area, the hue slider and "Reset" (to 0, disabled on#4641D9), 8 px under the field.widgets::tri_state::view(TriState::{Deny, Neutral, Allow}, disabled: Option<&str>, on_change):PermissionStateButtons(DLG/shared/PermissionComponents.{tsx,module.css}). Three 32 px buttons with the active colours: danger 88 %, settings-selected, online 88 %. When disabled they are drawn at half opacity, and a non-empty reason shows as the tooltip.TriState::ofisgetPermissionState.widgets::slider::stops(value, &stops, format, on_change): evenly spaced stops (slowmode's 14 fromSlowmodeControl.tsx, or any range), with the formatted value on the right.nearest_stopgives the stop closest to a value.widgets::text_input::multiline(value, max, on_change)(.label(),.placeholder()): the formTextarea, 2 to 10 rows, with then/maxcounter right of the label. Typing or pasting pastmaxis cut.widgets::form::{section, body_text, labelled, switch_row, radio_group, Choice, dropdown, select, filter}: the user settings' rows, moved out ofscreens/settings/mod.rs, which re-exports them under their old names, so no settings panel changed.select(choices, selected, on_pick)is a new searchable dropdown: its list floats under the field, typing filters it, and Escape or a click elsewhere closes it.widgets::stateful::Stateful(new file, see the deviations below): a widget that keeps its own state in the widget tree. The fields use it to hold the text being typed, the query, whether the list is open, and the editor's cursor, so callers keep only the value, as the Interfaces block asks (view(value, on_change)). A content that owns its data is kept between update and draw, because iced 0.14 widgets read their hover/disabled status from the widget instance.MinusBoldandEyedropper(Phosphor 2.1.10 path data).Strings, copied from the fork: "Role color", "Type a color (hex, rgb(), hsl(), or name) or use the picker.", "That doesn't look like a valid color. Try hex, rgb(), hsl(), or a CSS color name.", placeholder "#000000, rgb(...), red", "Reset", "Deny", "Neutral (inherit)", "Allow".
How it was tested
tests/form_widgets.rs(headless, iced widget protocol):hex_and_css_colour_parsing_tableinvalid_colour_keeps_last_value: typing nonsense and pressing Enter sends nothing and shows the error; then#00ff00is sent.tri_state_click_cycles_to_the_clicked_statedisabled_tri_state_emits_nothing_and_has_tooltipstop_slider_snapsmultiline_counter_and_maxselect_filters_by_query: a click opens the list, typing filters it, a click picks and closes it.user_settings_rows_unchanged: every text and its bounds on the Chat, Advanced, Notifications, Appearance and Account settings tabs, recorded before the move intests/form_widgets_settings_rows.txt, are identical after it.color_fieldandtri_state.color_field,tri_state_buttons,stop_slider,form_rows. They were rendered on lavapipe influxer-native-shots:u2204, with references indocs/screenshots/and rows in its README. A full lavapipe run of the suite passed: 182 passed, so no existing golden (including the settings ones) changed.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed.FLUXER_DESKTOP_TESTS=1tests were run (none were added). No side-by-side capture with the Electron app: it is not runnable here.Deviations from the plan
ColorPickerFieldand itsColorPickerPopoverhave none: the popover is a saturation/brightness area, a hue slider and "Reset". This field clones that popover instead of inventing presets.widgets/stateful.rs, outside the Files list. The fields need state between frames to keep theview(value, on_change)signatures, and iced 0.14'sComponentis deprecated and behind a feature that pulls in a new dependency.screens/settings/mod.rsmodified, outside the Files list. The moved rows are re-exported there, and no other screen file changed.tests/headless/mod.rs: addedHarness::overlay_event(it sends an event to the floating list).n/maxas in the original (FormInput.tsx), notn / max.Closes #674
🤖 Generated with Claude Code
Independent review: Server admin 8 (form widgets)
Reviewed
git diff 8c58a73f..origin/serveradmin-8-form-widgets(head091d6b4e) cold.Checked and fine
#rgb/#rgba/#rrggbb/#rrggbbaa,rgb(),hsl()and names. The slowmode stops are the spec's 14 values.color_field::view(u32, on_change),tri_state::view(TriState, Option<&str>, on_change),slider::stops(value, &[u32], format, on_change),text_input::multiline(value, max, on_change),form::{section, labelled, switch_row, radio_group, select}.screens/settingsre-exports the old names.parseColor(hex expand, then alpha cut) matches;transparentmaps to 0.getPermissionStatematches (deny wins, all bits must be set).PermissionComponents.module.cssmatches: 32 px buttons, 8 px radius, 88 % colour-mix, 0.5 opacity when disabled.ColorPickerPopoverReset is disabled on#4641D9. The original has no preset swatches, so leaving them out is right.UserInterface::{update,draw}. In draw the base content is drawn beforeoverlay()drops the cache. On the next RedrawRequested,overlay()runs first, then the baseupdaterebuilds the content and sets the statuses before draw.overlay()returns early, keeping the cache, while no overlay is open.Findings
[blocking] The overlay content loses its widget statuses: the picker's Reset always looks disabled, and the select list never shows hover.
Stateful::overlaybuilds a new overlayElementon every call.UserInterface::drawcallsroot.overlay()again just before drawing it (iced_runtime 0.14user_interface.rs~l.520), so the overlay drawn is a fresh element. Its buttons never receivedRedrawRequested, and iced_widget 0.14button.rs:376drawsself.status.unwrap_or(Status::Disabled). In the running app:--background-modifier-hoverhighlight (Hoveredis never seen).The goldens don't catch it:
color_field.pngdrawspicker()directly, not through the overlay, and no golden shows an open select. Tasks 25, 29, 30 and 31 use these widgets. Fix suggestion: keep the overlay element across calls like the base content (rebuild it only when the state changed /stale). Or add a golden or headless test that opens the overlay throughStateful, sends RedrawRequested with the cursor over a row, then draws.[minor] The select's empty-list text "No options" is not the original's.
FormCombobox.tsxshowsNO_RESULTS_FOUND_DESCRIPTOR= "No results found" (Global Constraint: strings are the original's). It also shows "Select…" (SELECT_DESCRIPTOR) as the placeholder when nothing is chosen; the native field shows an empty one.[minor] The character counter is unformatted. The original prints
numberFormat.format(n)/numberFormat.format(max), i.e.34/1,024for the topic. The native one prints34/1024(seeform_rows.png).[minor] The slider snaps, but the original does not. The original
SlowmodeControluses<Slider equidistant step={1} markers=…>withoutstickToMarkers: values between the markers are reachable, the value appears in a tooltip, and the markers 0/60/3600/21600 are labelled ("Off", "1 minute", …).[minor] The colour field commits on a press outside it, but a click on its own swatch does not commit the draft. The original commits on blur, which a swatch click causes. This is part of the documented blur approximation; noting it for completeness.
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen in the review worktree (exit 0, 0 failures, screenshot goldens incl. the four new ones and the existing settings goldens pass).Verdict: changes requested — 1 blocking (overlay statuses), 4 minor.
Review round 1 addressed in
116c7e52:stateful.rsoverlay rebuilt on every call:Statefulnow keeps the overlay element (with the anchor it was built for) as it keeps the owned content, and drops both only when the state goes stale or the anchor moves. The overlay that is drawn is the one that sawRedrawRequested, so the picker's enabled Reset no longer draws as disabled and the select rows show hover.overlay()also no longer drops the base content's cache on every call. New testselect_list_hover_survives_the_runtime_redrawopens a select throughStatefuland runs the overlay asUserInterfacedoes (update with CursorMoved + RedrawRequested, ask for the overlay again, draw), using a new harness helperHarness::overlay_frame. It failed on the old code (identical pixels for the hovered and plain rows) and passes now.form.rsselect texts: the empty list now says "No results found" (form::NO_RESULTS, fromNO_RESULTS_FOUND_DESCRIPTOR), and the field shows the placeholder "Select…" (form::SELECT_PLACEHOLDER) in the muted placeholder colour when nothing is chosen. Test:select_placeholder_and_empty_list.text_input.rscounter: both numbers are grouped as en-USnumberFormatgroups them (1,234/2,000). Covered inmultiline_counter_and_max.slider.rssnapping: the label now shows the value it was given rather than the nearest stop, so a server value of 45 s reads45s(stop_slider_snapsupdated). Making the slider move between equidistant markers without snapping, as the original does, is follow-up #716 for Task 29 or the parity doc.color_field.rsswatch click: a click on the swatch commits the typed text before it toggles the picker, as the original's blur would. Test:swatch_click_commits_the_typed_text.Local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses. All goldens are unchanged.Independent review: Server admin 8 (form widgets), head
116c7e52Scope:
git diff 8c58a73f..116c7e52.Tests named by the plan: all present. These are
hex_and_css_colour_parsing_table,invalid_colour_keeps_last_value,tri_state_click_cycles_to_the_clicked_state,disabled_tri_state_emits_nothing_and_has_tooltip,stop_slider_snaps(uses the original's 14SLOWMODE_STOP_SECONDS),multiline_counter_and_max,select_filters_by_queryanduser_settings_rows_unchanged. The four goldens are also present:color_field,tri_state_buttons,stop_sliderandform_rows. There are extra tests for the overlay redraw, the select placeholder and empty list, and the swatch commit.Interfaces: these exist as written:
color_field::view(u32, on_change),tri_state::view(TriState, Option<&str>, on_change),slider::stops(value, &[u32], format, on_change),text_input::multiline(value, max, on_change)andform::{section, labelled, switch_row, radio_group, select}. The user settings re-export the moved rows under their old names.Invariants: I found no new I/O path in fluxer-ui. The only
std::fsis in the test that writes the settings-rows file. There are no panicking unwraps on data.selectpicks by index into the full list and ignores disabled entries. The stops slider takes empty stops. Colour parsing rejects non-finite numbers and clamps the channels. There are no secrets.Parity, spot-checked against the fork:
parseColor:#rgband#rgbaare expanded and#rrggbbaais cut to six digits. The placeholder#000000, rgb(...), red,maxLength=64, the description and the error text are the same asColorPickerField.tsx.PermissionStateButtons: the Deny, Neutral and Allow labels are the same. A click sends the clicked state even when it is already active. Disabled buttons use opacity 0.5. The tooltip isdisabled && disabledReason. The 2rem buttons and 0.5rem radius match.FormCombobox"No results found" and "Select…" match. TheFormInputcounternumberFormat(n)/numberFormat(max)matches.Review Focus: no item applies to Task 8.
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green. All steps passed and the goldens match.Findings
color_field. The original'sColorPickerFieldandColorPickerPopoverhave none, and I checked this. The module doc says so, and following the original is correct. This is noted only so that later tasks do not look for presets.value.lengthcounts UTF-16 units, so text with astral-plane characters (such as emoji) can differ by one unit per character. This does not affect correctness of anything sent: the server validates.Verdict: APPROVED. There are no blocking findings and local CI is green.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed