Server admin 3: fluxer-proto members, bans, member search, invite events, error codes #669

Closed
opened 2026-11-15 19:01:08 +00:00 by charles · 0 comments
Owner

Task 3 of the Server administration plan (docs/superpowers/plans/2026-11-15-serveradmin.md, section "### Task 3:"). The plan on the serveradmin branch is the source of truth; this copy is for reading.

Closes: —
Depends on: —

Files:

  • Create: crates/fluxer-proto/src/models/moderation.rs, fixtures fixtures/rest/{member_update_nick.json,member_update_timeout.json,ban_create.json,bans.json,member_search_request.json,member_search_response.json,member_search_indexing.json,error_sudo_required.json,error_sudo_invalid.json}, fixtures/gateway/{guild_ban_add.json,guild_ban_remove.json,invite_create.json,invite_delete.json}
  • Modify: crates/fluxer-proto/src/models/mod.rs, crates/fluxer-proto/src/gateway/events.rs, crates/fluxer-proto/src/errors.rs, crates/fluxer-proto/tests/spec_contract.rs, README
  • Test: crates/fluxer-proto/tests/moderation.rs

Interfaces:

  • Produces: MemberUpdateRequest { nick: Option<Option<String>>, roles: Option<Vec<Snowflake>>, communication_disabled_until: Option<Option<Timestamp>>, timeout_reason: Option<String> } (the voice fields stay in MemberVoicePatch; S/guild/GuildRequestSchemas.ts); BanCreateRequest { delete_message_seconds: u32, reason: Option<String>, ban_duration_seconds: u64 }; GuildBan { user: UserPartial, reason: Option<String>, moderator_id: Snowflake, banned_at: Timestamp, expires_at: Option<Timestamp> }; MemberSearchRequest { query, limit, offset, role_ids, joined_at_gte, joined_at_lte, sort_by: MemberSort, sort_order: SortOrder } (only set fields), MemberSearchResponse { guild_id, members: Vec<MemberSearchResult>, page_result_count, total_result_count, indexing }, MemberSearchResult (as S/guild/GuildMemberSearchSchemas.ts: the member, the user's creation, the join source and invite code when present; unknown join sources kept); GatewayEvent::{GuildBanAdd { guild_id, user }, GuildBanRemove { guild_id, user }, InviteCreate(InviteMetadata), InviteDelete { code, channel_id, guild_id }} (api/guild/services/GuildModerationService.ts, api/invite/InviteService.ts).

  • Error codes as typed constants (C/ApiErrorCodes.ts, C/ValidationErrorCodes.ts): SUDO_SECOND_FACTOR_REQUIRED, TWO_FACTOR_REQUIRED, MISSING_PERMISSIONS, RESOURCE_LOCKED, MAX_GUILD_ROLES, MAX_GUILD_CHANNELS, MAX_CATEGORY_CHANNELS, USER_IS_NOT_BANNED, GUILD_FEATURE_NOT_TOGGLEABLE, CANNOT_REORDER_EVERYONE_ROLE, TIMEOUT_CANNOT_EXCEED_365_DAYS, MUST_ENABLE_2FA_BEFORE_REQUIRING_FOR_MODS, UNKNOWN_ROLE, UNKNOWN_MEMBER, INVALID_FORM_BODY with ApiError::field_errors() -> Vec<(path, message)> if not already there (the identity check reads the error path, feat/platform/transport/RestTransport.ts isSudoVerificationFailure).

  • Step 1: Write failing tests: member_update_nick_null_clears, timeout_and_remove_timeout_bodies, ban_body_as_the_original, bans_parse_with_and_without_expiry, member_search_request_only_set_fields, member_search_response_and_indexing, unknown_join_source_kept, ban_and_invite_events_parse, error_codes_match_server, invalid_form_body_field_paths, proptests arbitrary_ban_json_never_panics, arbitrary_member_search_json_never_panics, spec_contract_moderation_types.

  • Step 2–5: FAIL → implement → PASS → commit feat(proto): members, bans, member search, invite events.

Task 3 of the Server administration plan (`docs/superpowers/plans/2026-11-15-serveradmin.md`, section "### Task 3:"). The plan on the `serveradmin` branch is the source of truth; this copy is for reading. **Closes:** — **Depends on:** — **Files:** - Create: `crates/fluxer-proto/src/models/moderation.rs`, fixtures `fixtures/rest/{member_update_nick.json,member_update_timeout.json,ban_create.json,bans.json,member_search_request.json,member_search_response.json,member_search_indexing.json,error_sudo_required.json,error_sudo_invalid.json}`, `fixtures/gateway/{guild_ban_add.json,guild_ban_remove.json,invite_create.json,invite_delete.json}` - Modify: `crates/fluxer-proto/src/models/mod.rs`, `crates/fluxer-proto/src/gateway/events.rs`, `crates/fluxer-proto/src/errors.rs`, `crates/fluxer-proto/tests/spec_contract.rs`, README - Test: `crates/fluxer-proto/tests/moderation.rs` **Interfaces:** - Produces: `MemberUpdateRequest { nick: Option<Option<String>>, roles: Option<Vec<Snowflake>>, communication_disabled_until: Option<Option<Timestamp>>, timeout_reason: Option<String> }` (the voice fields stay in `MemberVoicePatch`; `S/guild/GuildRequestSchemas.ts`); `BanCreateRequest { delete_message_seconds: u32, reason: Option<String>, ban_duration_seconds: u64 }`; `GuildBan { user: UserPartial, reason: Option<String>, moderator_id: Snowflake, banned_at: Timestamp, expires_at: Option<Timestamp> }`; `MemberSearchRequest { query, limit, offset, role_ids, joined_at_gte, joined_at_lte, sort_by: MemberSort, sort_order: SortOrder }` (only set fields), `MemberSearchResponse { guild_id, members: Vec<MemberSearchResult>, page_result_count, total_result_count, indexing }`, `MemberSearchResult` (as `S/guild/GuildMemberSearchSchemas.ts`: the member, the user's creation, the join source and invite code when present; unknown join sources kept); `GatewayEvent::{GuildBanAdd { guild_id, user }, GuildBanRemove { guild_id, user }, InviteCreate(InviteMetadata), InviteDelete { code, channel_id, guild_id }}` (`api/guild/services/GuildModerationService.ts`, `api/invite/InviteService.ts`). - Error codes as typed constants (`C/ApiErrorCodes.ts`, `C/ValidationErrorCodes.ts`): `SUDO_SECOND_FACTOR_REQUIRED`, `TWO_FACTOR_REQUIRED`, `MISSING_PERMISSIONS`, `RESOURCE_LOCKED`, `MAX_GUILD_ROLES`, `MAX_GUILD_CHANNELS`, `MAX_CATEGORY_CHANNELS`, `USER_IS_NOT_BANNED`, `GUILD_FEATURE_NOT_TOGGLEABLE`, `CANNOT_REORDER_EVERYONE_ROLE`, `TIMEOUT_CANNOT_EXCEED_365_DAYS`, `MUST_ENABLE_2FA_BEFORE_REQUIRING_FOR_MODS`, `UNKNOWN_ROLE`, `UNKNOWN_MEMBER`, `INVALID_FORM_BODY` with `ApiError::field_errors() -> Vec<(path, message)>` if not already there (the identity check reads the error path, `feat/platform/transport/RestTransport.ts` `isSudoVerificationFailure`). - [ ] **Step 1: Write failing tests**: `member_update_nick_null_clears`, `timeout_and_remove_timeout_bodies`, `ban_body_as_the_original`, `bans_parse_with_and_without_expiry`, `member_search_request_only_set_fields`, `member_search_response_and_indexing`, `unknown_join_source_kept`, `ban_and_invite_events_parse`, `error_codes_match_server`, `invalid_form_body_field_paths`, proptests `arbitrary_ban_json_never_panics`, `arbitrary_member_search_json_never_panics`, `spec_contract_moderation_types`. - [ ] **Step 2–5:** FAIL → implement → PASS → commit `feat(proto): members, bans, member search, invite events`.
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#669
No description provided.