Show the install location in Settings → Updates; vpk --aumid (#614) #651

Closed
charles wants to merge 0 commits from fix-614-install-location into textchat
Owner

Refs #614
Refs #544

A Windows user couldn't find where the updated app lives. The exe they downloaded is only the Velopack Setup.exe. The installer puts the app in %LocalAppData%\Flaxative\current, and nothing in the client said so. The original client has no About tab. The only place this client shows its version is Settings → Advanced → Updates ("Current version …"), so that section gets the new row.

What changed

1. Install location in Advanced → Updates (built and tested on Linux)

  • fluxer-platform: update::install_location(&InstallTarget, current_exe) returns:
    • for an AppImage, the folder of the $APPIMAGE file. current_exe would be the read-only /tmp/.mount_*/usr/bin that the image runs from, which is the wrong answer.
    • otherwise, the folder of the running executable. For a Velopack install that is %LocalAppData%\Flaxative\current. For cargo run it is the target folder.
  • fluxer-core: UpdateEvent::Started now carries install_location: Option<String> (a display string; the runtime keeps the path). Also added: UpdateSettingsModel::install_location and UpdateAction/UpdateCommand::OpenInstallLocation. "Open folder" works in a development build too, and does nothing when there is no location.
  • fluxer-ui: under the version line (or under the development-build notice), the section shows "Install location", the folder, and an "Open folder" button.
  • apps/fluxer update_rt: sends the location with Started and opens the folder with explorer, open or xdg-open. The path goes in as a single argument with no shell, and the child process is reaped on its own thread.

2. Packaging: vpk pack --aumid Forked.Flaxative (#544)
Up to now vpk_pack_args passed no AUMID. The shortcut and Velopack's process AUMID therefore defaulted to velopack.Flaxative, while the client and its toasts use fluxer_platform::WINDOWS_APP_USER_MODEL_ID = Forked.Flaxative. vpk 1.2.161 (the pinned version) documents --aumid <AUMID> ("Override the Application User Model ID (AUMID) for shortcuts", see vpk [win] pack -H). I packed a stub app with it on Linux using the [win] directive. The resulting .nuspec contains <shortcutAumid>Forked.Flaxative</shortcutAumid>, which is the field the velopack crate reads (locator.rs get_app_user_model_id). A new xtask test checks that the constant equals the one in fluxer-platform.

What I found about the Windows package (no change made)

  • cargo xtask package --target windows → vpk --yes pack --packId Flaxative … --mainExe flaxative.exe --packTitle Flaxative --packAuthors "Charles Daoust" --shortcuts StartMenu --runtime win-x64 --channel nightly --delta None. The release workflow's windows job runs it, then smoke-tests a silent install.
  • --shortcuts StartMenu creates one shortcut, inside an author folder: Start Menu\Programs\Charles Daoust\Flaxative.lnk. Velopack's default would be Desktop,StartMenuRoot. According to Velopack's shortcuts.rs (develop branch), the shortcut points at current\flaxative.exe with current\ as its working directory.
  • No desktop shortcut is created. The auto-update spec §5.3 chose "a Start-menu shortcut", so whether to add Desktop, or move to StartMenuRoot, is a product decision. I left it as it is.

Tests

  • core: install_location_reaches_the_settings_model, open_install_location_asks_the_runtime_even_in_a_development_build, open_install_location_without_a_location_does_nothing
  • platform: install_location_of_an_appimage_is_the_image_folder, install_location_of_an_executable_is_its_folder, install_location_of_a_velopack_install_is_current (cfg(windows); runs only on the Windows runner)
  • app: the_install_folder_is_one_argument_of_the_file_manager; devserver_update_flows_from_check_to_ready now checks the location that Started sends
  • ui: install_location_is_in_the_updates_section_and_opens_the_folder; headless install_location_row_is_drawn_and_its_button_clicks
  • xtask: shortcut_aumid_is_the_clients_app_user_model_id; vpk_args_are_per_user_start_menu_no_delta now checks --aumid
  • golden settings_updates_section re-rendered on lavapipe (docker fluxer-native-shots:u2204). It shows a Velopack-style path with "Open folder".
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed locally.

Untested on Windows

  • "Open folder" through explorer <dir> on a real Velopack install, and whether the path shown there is really …\Flaxative\current.
  • --aumid: that the installed shortcut carries Forked.Flaxative, that toasts appear and a click raises the window (spec §14), and whether Velopack rewrites the AUMID of an existing shortcut on update or only on a fresh install. I checked only the manifest written by vpk 1.2.161 on Linux.

🤖 Generated with Claude Code

Refs #614 Refs #544 A Windows user couldn't find where the updated app lives. The exe they downloaded is only the Velopack Setup.exe. The installer puts the app in `%LocalAppData%\Flaxative\current`, and nothing in the client said so. The original client has no About tab. The only place this client shows its version is Settings → Advanced → Updates ("Current version …"), so that section gets the new row. ## What changed **1. Install location in Advanced → Updates (built and tested on Linux)** - `fluxer-platform`: `update::install_location(&InstallTarget, current_exe)` returns: - for an AppImage, the folder of the `$APPIMAGE` file. `current_exe` would be the read-only `/tmp/.mount_*/usr/bin` that the image runs from, which is the wrong answer. - otherwise, the folder of the running executable. For a Velopack install that is `%LocalAppData%\Flaxative\current`. For `cargo run` it is the target folder. - `fluxer-core`: `UpdateEvent::Started` now carries `install_location: Option<String>` (a display string; the runtime keeps the path). Also added: `UpdateSettingsModel::install_location` and `UpdateAction`/`UpdateCommand::OpenInstallLocation`. "Open folder" works in a development build too, and does nothing when there is no location. - `fluxer-ui`: under the version line (or under the development-build notice), the section shows "Install location", the folder, and an "Open folder" button. - `apps/fluxer` `update_rt`: sends the location with `Started` and opens the folder with `explorer`, `open` or `xdg-open`. The path goes in as a single argument with no shell, and the child process is reaped on its own thread. **2. Packaging: `vpk pack --aumid Forked.Flaxative` (#544)** Up to now `vpk_pack_args` passed no AUMID. The shortcut and Velopack's process AUMID therefore defaulted to `velopack.Flaxative`, while the client and its toasts use `fluxer_platform::WINDOWS_APP_USER_MODEL_ID` = `Forked.Flaxative`. `vpk` 1.2.161 (the pinned version) documents `--aumid <AUMID>` ("Override the Application User Model ID (AUMID) for shortcuts", see `vpk [win] pack -H`). I packed a stub app with it on Linux using the `[win]` directive. The resulting `.nuspec` contains `<shortcutAumid>Forked.Flaxative</shortcutAumid>`, which is the field the `velopack` crate reads (`locator.rs` `get_app_user_model_id`). A new xtask test checks that the constant equals the one in `fluxer-platform`. ## What I found about the Windows package (no change made) - `cargo xtask package --target windows` → `vpk --yes pack --packId Flaxative … --mainExe flaxative.exe --packTitle Flaxative --packAuthors "Charles Daoust" --shortcuts StartMenu --runtime win-x64 --channel nightly --delta None`. The release workflow's `windows` job runs it, then smoke-tests a silent install. - `--shortcuts StartMenu` creates one shortcut, inside an author folder: Start Menu\Programs\Charles Daoust\Flaxative.lnk. Velopack's default would be `Desktop,StartMenuRoot`. According to Velopack's `shortcuts.rs` (develop branch), the shortcut points at `current\flaxative.exe` with `current\` as its working directory. - No desktop shortcut is created. The auto-update spec §5.3 chose "a Start-menu shortcut", so whether to add `Desktop`, or move to `StartMenuRoot`, is a product decision. I left it as it is. ## Tests - core: `install_location_reaches_the_settings_model`, `open_install_location_asks_the_runtime_even_in_a_development_build`, `open_install_location_without_a_location_does_nothing` - platform: `install_location_of_an_appimage_is_the_image_folder`, `install_location_of_an_executable_is_its_folder`, `install_location_of_a_velopack_install_is_current` (cfg(windows); runs only on the Windows runner) - app: `the_install_folder_is_one_argument_of_the_file_manager`; `devserver_update_flows_from_check_to_ready` now checks the location that `Started` sends - ui: `install_location_is_in_the_updates_section_and_opens_the_folder`; headless `install_location_row_is_drawn_and_its_button_clicks` - xtask: `shortcut_aumid_is_the_clients_app_user_model_id`; `vpk_args_are_per_user_start_menu_no_delta` now checks `--aumid` - golden `settings_updates_section` re-rendered on lavapipe (docker `fluxer-native-shots:u2204`). It shows a Velopack-style path with "Open folder". - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`: all steps passed locally. ## Untested on Windows - "Open folder" through `explorer <dir>` on a real Velopack install, and whether the path shown there is really `…\Flaxative\current`. - `--aumid`: that the installed shortcut carries `Forked.Flaxative`, that toasts appear and a click raises the window (spec §14), and whether Velopack rewrites the AUMID of an existing shortcut on update or only on a fresh install. I checked only the manifest written by `vpk` 1.2.161 on Linux. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
#614: a Windows user could not find the updated app: the downloaded exe is
the Velopack Setup.exe, which installs into %LocalAppData%\Flaxative\current,
and nothing in the client said so.

- fluxer-platform: update::install_location(target, current_exe): the
  AppImage file's folder (not the read-only /tmp/.mount_* the binary runs
  from), else the running executable's folder (Velopack's current\).
- fluxer-core: UpdateEvent::Started carries install_location (display
  string); UpdateSettingsModel::install_location; UpdateAction /
  UpdateCommand::OpenInstallLocation, also in a development build.
- fluxer-ui: Advanced → Updates shows "Install location", the folder and
  "Open folder" under the version line (or the dev-build notice).
- apps/fluxer: update_rt sends the location and opens it with explorer /
  open / xdg-open (one argument, reaped off the async threads).
- xtask: vpk pack --aumid Forked.Flaxative, so the Start-menu shortcut and
  Velopack's process AUMID match fluxer_platform::WINDOWS_APP_USER_MODEL_ID
  (#544). Checked with vpk 1.2.161 on Linux ([win] directive): the nuspec
  gets <shortcutAumid>Forked.Flaxative</shortcutAumid>. Untested on Windows.

Golden settings_updates_section re-rendered on lavapipe.

Refs #614
Refs #544

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Merged into textchat by hand (the merge API returned 405); the commits are in the branch.

Merged into `textchat` by hand (the merge API returned 405); the commits are in the branch.
charles closed this pull request 2026-11-15 15:41:13 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.