Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/voice-view"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #612, #613
#612: the control bar covers the participants' tiles
Cause. The reporter's screenshot shows the focus layout: a stream is focused and the participants are shown in the mini grid under it. In the window, the stream kept the height rule of the layout without participants (
min(76 % of the window, area − 3 rem),focus::main_size). So the mini grid started below the control bar's top edge, and its tiles (avatars, name plates) were cut off behind the bar unless the user scrolled (crates/fluxer-ui/src/screens/main/call/focus.rs,layout, non-fullscreen branch). The goldenstream_focus.pngshowed it too.Fix. With the participants shown, the original uses
resolveFocusExpandedMainMetrics(VoiceFocusLayoutMetrics.ts,.focusExpandedScrollBody). The stream gives up the toggle's 44 px, 40 px of gaps and one row of the mini grid. It stays at least 180 px high and at most 95 rem wide. Newfocus::expanded_main_sizedoes the same, andlayoutuses it whenever the mini grid is shown. Further rows scroll, as in the original. The layout without participants and the fullscreen layout are unchanged.#428. I could not reproduce it on
textchat. The plain grid (no focused stream) already packs its tiles into the height above the bar, and a single tile is centred there. The new test checks this at 1500×1240 and 1160×1303. #428 is not explained by the #612 rule, so it is left open.#613: "Watch stream" from the hover card does not switch the view
Cause.
stream_hover::update(Message::Watch, and the double click throughMessage::Pressedand the profile-backdrop press inmain::update) only sentUserAction::WatchStream. The store watched the stream and joined or moved the connection, so its sound played, but nothing selected the stream's channel.Fix. The new
stream_hover::watch_actions(key)returnsWatchStream, thenSelectGuild(key.guild_id())andSelectChannel(channel), as the original'sopenAndWatchStream→applyStreamWatchFocus→selectStreamChanneldoes. The call view'sState::syncalready pins a newly watched stream, so the call view opens on the focused stream. One difference from the original: it navigates right away instead of waiting for the voice connection, and the call view shows the connecting call in the meantime.Tests
tests/stream_focus.rs::control_bar_leaves_room_for_the_tiles(new; fails without the fix, at the reporter-like 1861×700). Call view sizes 1861×700, 1280×720, 1000×640, 624×664 and 1500×1240, with 1, 2, 4 and 9 participants. In the grid, no tile's name plate reaches the bar's room. In the focus layout, the first mini-grid row's plates are above the bar. The test also covers the grid in short views (1280×400, 900×360) and the #428 single-tile centring.tests/stream_focus.rs::fullscreen_moves_members_to_bottom_row: the windowed expectation is updated to the expanded rule, plus the 180 px floor and the unchanged rule without participants.tests/stream_sidebar.rs::hover_card_watch_opens_the_call_view_on_the_stream(new; fails without the fix). The test hovers ada's row, clicks the card's Watch stream and runsmain::updateandcall::State::sync. It then checks that the stream is watched,#Hangoutis selected, and the call view focuses ada's stream, both when not in voice and when already in the call while viewing #general.double_click_watchesnow also asserts the navigation. Thestream_hoverunit test asserts the three actions.stream_focus.pngregenerated (looked at first): the stream is smaller and the first row of tiles sits fully above the bar.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed locally (Linux).Not verified on Windows; the headless widget tests do not run on the Windows runner (#93).
🤖 Generated with Claude Code
Updated to
textchate932e06c(head now052a1696).00204001): the only conflict wasfixtures/golden/stream_focus.png, which both sides had redrawn. The code merged cleanly. Sincec8faabf4, textchat changedcall/grid.rs(a single tile has no minimum size) andcall/pip.rs(new menu-row fields), but notcall/focus.rs,stream_hover.rsor this branch'smain/mod.rshunk. Sofocus::expanded_main_size,stream_hover::watch_actions(WatchStream → SelectGuild → SelectChannel) and task 36's voice badge/refusal UI are all as their authors left them.052a1696):stream_focus.pngredrawn on the reference renderer (lavapipe,fluxer-native-shots:u2204). With textchat's golden, the test differed by 17.3 %. The new frame differs from this branch's previous golden by 0.2 %, only around the member list (ada's "heads down" status line from textchat). It shows the smaller stream with the first row of tiles fully above the control bar. All 162 screenshot tests pass on lavapipe. No other golden changed.Tests:
stream_focus::control_bar_leaves_room_for_the_tiles,stream_sidebar::hover_card_watch_opens_the_call_view_on_the_streamanddouble_click_watchespass.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed (screenshots on the host GPU).🤖 Generated with Claude Code