Thread side panel: pasting an image from the clipboard does nothing #621

Closed
opened 2026-11-15 09:12:08 +00:00 by charles · 3 comments
Owner

Reported by wickedsun (Charles) in #flaxative-bug-reports (https://fluxer.forked.io/channels/1554245914976059392/1571452264357298176).

Report. "trying to paste another image in a side opened doesn't paste." Correction: "side panel does not allow for image pasting from clipboard -- nothing happens".

Steps. Open a thread or forum post in the side panel. Copy an image to the clipboard and press Ctrl+V in the side panel's composer. Nothing happens; in the main channel composer the same paste attaches the image.

Notes. Not investigated. Likely the clipboard-image paste is wired only to the main composer (the paste handler targets the channel composer's attachment list), not to the thread panel / forum composer. Related: #602 (thread panel and forum composer should build their options from the shared composer context). Check drag-and-drop and the attach button in the side panel at the same time.

**Reported by** wickedsun (Charles) in #flaxative-bug-reports (https://fluxer.forked.io/channels/1554245914976059392/1571452264357298176). **Report.** "trying to paste another image in a side opened doesn't paste." Correction: "side panel does not allow for image pasting from clipboard -- nothing happens". **Steps.** Open a thread or forum post in the side panel. Copy an image to the clipboard and press Ctrl+V in the side panel's composer. Nothing happens; in the main channel composer the same paste attaches the image. **Notes.** Not investigated. Likely the clipboard-image paste is wired only to the main composer (the paste handler targets the channel composer's attachment list), not to the thread panel / forum composer. Related: #602 (thread panel and forum composer should build their options from the shared composer context). Check drag-and-drop and the attach button in the side panel at the same time.
Author
Owner

Probably the same root cause as #616 (fixed in PR #624): actions sent from the thread side panel are resolved against the selected channel (the forum or parent channel), not the panel's thread. PR #624 fixed this for the four edit actions by carrying the channel in the action. Still using the selected channel, from reading the code (not yet tested): StartReply, ToggleReplyMention, CancelReply, the emoji picker's insert into the composer — and very likely the clipboard image paste reported here. Fix them the same way (the action carries the channel of the list/composer that sent it), with a test per action in the side panel.

Probably the same root cause as #616 (fixed in PR #624): actions sent from the thread side panel are resolved against the *selected* channel (the forum or parent channel), not the panel's thread. PR #624 fixed this for the four edit actions by carrying the channel in the action. Still using the selected channel, from reading the code (not yet tested): `StartReply`, `ToggleReplyMention`, `CancelReply`, the emoji picker's insert into the composer — and very likely the clipboard image paste reported here. Fix them the same way (the action carries the channel of the list/composer that sent it), with a test per action in the side panel.
Author
Owner

Fixed in PR #628 (not merged). It was the same cause as #616. In the shell, Ctrl+V only checked whether the channel composer had asked for the clipboard (app.rs) and always sent the clipboard back to that composer, so a paste in the side panel did nothing. Now the shell asks which composer pressed Ctrl+V (main::take_paste_request) and sends the clipboard back to it.

Fixed in the same PR, each with a test for a thread and for a forum post:

  • Drops now go to the composer in use: the panel's once its thread opens or you type in it, the channel's again once you type there.
  • Reply, "@ On" and the reply bar's "x" now carry the panel's channel: StartReply { channel_id, .. }, ToggleReplyMention(ch), CancelReply(ch).
  • The panel composer's GIF/Sticker/Emoji buttons now open the picker on the thread (PickTarget::Composer { channel_id }).
  • "Edit attachment" from the panel's tray now opens its modal.
  • Ctrl+E/G/S, a key typed while no composer is focused, and Escape on the panel's "+" menu now act on the panel.

The attach button already sent the thread's id.

Fixed in PR #628 (not merged). It was the same cause as #616. In the shell, Ctrl+V only checked whether the channel composer had asked for the clipboard (`app.rs`) and always sent the clipboard back to that composer, so a paste in the side panel did nothing. Now the shell asks which composer pressed Ctrl+V (`main::take_paste_request`) and sends the clipboard back to it. Fixed in the same PR, each with a test for a thread and for a forum post: - Drops now go to the composer in use: the panel's once its thread opens or you type in it, the channel's again once you type there. - Reply, "@ On" and the reply bar's "x" now carry the panel's channel: `StartReply { channel_id, .. }`, `ToggleReplyMention(ch)`, `CancelReply(ch)`. - The panel composer's GIF/Sticker/Emoji buttons now open the picker on the thread (`PickTarget::Composer { channel_id }`). - "Edit attachment" from the panel's tray now opens its modal. - Ctrl+E/G/S, a key typed while no composer is focused, and Escape on the panel's "+" menu now act on the panel. The attach button already sent the thread's id.
Author
Owner

Fixed in nightly 2026.1115.318.

Fixed in nightly 2026.1115.318.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#621
No description provided.