Daily use 34b: "Create or join a community" and the invite modal (#524) #596

Closed
charles wants to merge 0 commits from dailyuse-34b-ui-add-guild-invite-modal into dailyuse
Owner

Stacked on: dailyuse-16b-core-create-invites-guilds, dailyuse-30-ui-notification-settings-modal, dailyuse-33-ui-confirm-friends-page

What this builds (Daily use 34b, spec §3.6)

  • Rail add button (AddGuildButton.tsx, GuildListActionButton.tsx, GuildsLayout.module.css .createGuildButtonIcon): after the guilds, a 44 px circle with a dashed --background-modifier-accent ring and the bold plus (ring --text-primary with 30 % corners on hover; the dashes are an SVG since iced borders have no dash). Tooltip "Create or join a community". A click opens the modal on its landing view. A right press opens its menu ("Create community" with House, "Join community" with Link). The menu is a MenuModel (add_guild::menu()) drawn through menus::items/context_menu. Escape and an outside click close it.
  • modals/add_guild.rs draws fluxer_core::invites::add_guild:
    • landing ("Add a community", the two tiles, no template tile);
    • create (description, "Community icon" with an 80 px round, cover-cropped preview or the acronym placeholder, "Upload icon"/"Change icon", "Remove icon", "Community name", Back / "Create community");
    • join ("Invite link" with the {endpoints.invite}/… placeholder, Back / "Join community").
    • "Upload icon" asks the shell to open the injected Dialogs. The picked path is named by LocalFiles and goes to the store as AddGuildAction::SetIcon(Some(FileRef)), and the store checks the file is static and within the size limit. The file is read once with SoundFileReader for the preview, as the group icon preview (#383) does.
  • modals/invite.rs draws fluxer_core::invites::invite_modal:
    • "Invite friends to {guild}", "Recipients will be taken to" with the channel icon and name, and the invites-paused warning;
    • "Search friends", and the RecipientList rows (avatar or group picture, "Direct message"/"Group DM"/username, Invite → disabled Sent, spinner while sending);
    • "Or send an invite link to a friend:", the link with Copy → "Copied", and the expiry text with "Edit invite link";
    • "Invite link settings": "Expire after" and "Max number of uses" lists with the "Custom…" inputs, clamped as clampNumber; "Temporary membership"; Cancel / "Create new link" → InviteAction::Configure. The unavailable variant is drawn too.
    • Opening it from a menu starts the view state afresh.
  • Leave community goes through Daily use 33's modals/leave.rs. This PR adds a test for that path and no new code.

Tests

  • crates/fluxer-ui/tests/add_guild.rs: add_guild_views, invite_settings_lists, copy_link_emits, leave_community_uses_shared_modal. I wrote these tests first and committed them separately. I wrote the modules alongside them, so the first run already had the implementation; add_guild_views failed on it and is fixed in this PR.
  • Goldens (lavapipe): add_guild_landing, add_guild_create, invite_modal, invite_settings. They have references in docs/screenshots/ and rows in its README. There is no Electron reference capture; the dimensions come from the fork CSS files named in each test's doc comment.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally. I ran no FLUXER_DESKTOP_TESTS tests (none apply).

Deviations and things to look at

  • Goldens: the add button shows on every main-screen golden. On the existing goldens it changes about 300 pixels, under the 0.5 % threshold, except gif_picker_results and gif_picker_categories, which crossed it (0.52 %) and are redrawn. I left the other goldens as they were to avoid binary conflicts with the UI tasks running in parallel. They can be redrawn in Task 40.
  • Files outside the task's Files list:
    • app.rs: the Local fields, the dialog/LocalFiles pick, the preview read, and Escape for the add-button menu;
    • screens/main/{mod.rs,media.rs}: routing, overlays, and the avatars the invite modal wants;
    • menus/mod.rs: two icon arms for the menu ids;
    • crates/fluxer-ui/README.md.
  • Left out on purpose:
    • the crop step: the whole picture is sent, as the original's "Skip" does;
    • the guidelines note: the instance's guidelines_url is not in the discovery the client reads;
    • the "Copied" → "Copy" 3 s timer: here "Copied" stays until the link changes or the modal closes;
    • the icon refusal is shown inline (.iconError) instead of the original's error modal, because the store has no action to dismiss it without clearing the icon.
  • The Ctrl+Shift+N hint in the tooltip is Task 35's.

Closes #524

🤖 Generated with Claude Code

Stacked on: dailyuse-16b-core-create-invites-guilds, dailyuse-30-ui-notification-settings-modal, dailyuse-33-ui-confirm-friends-page ## What this builds (Daily use 34b, spec §3.6) - **Rail add button** (`AddGuildButton.tsx`, `GuildListActionButton.tsx`, `GuildsLayout.module.css` `.createGuildButtonIcon`): after the guilds, a 44 px circle with a dashed `--background-modifier-accent` ring and the bold plus (ring `--text-primary` with 30 % corners on hover; the dashes are an SVG since iced borders have no dash). Tooltip "Create or join a community". A click opens the modal on its landing view. A right press opens its menu ("Create community" with House, "Join community" with Link). The menu is a `MenuModel` (`add_guild::menu()`) drawn through `menus::items`/`context_menu`. Escape and an outside click close it. - **`modals/add_guild.rs`** draws `fluxer_core::invites::add_guild`: - landing ("Add a community", the two tiles, no template tile); - create (description, "Community icon" with an 80 px round, cover-cropped preview or the acronym placeholder, "Upload icon"/"Change icon", "Remove icon", "Community name", Back / "Create community"); - join ("Invite link" with the `{endpoints.invite}/…` placeholder, Back / "Join community"). - "Upload icon" asks the shell to open the injected `Dialogs`. The picked path is named by `LocalFiles` and goes to the store as `AddGuildAction::SetIcon(Some(FileRef))`, and the store checks the file is static and within the size limit. The file is read once with `SoundFileReader` for the preview, as the group icon preview (#383) does. - **`modals/invite.rs`** draws `fluxer_core::invites::invite_modal`: - "Invite friends to {guild}", "Recipients will be taken to" with the channel icon and name, and the invites-paused warning; - "Search friends", and the `RecipientList` rows (avatar or group picture, "Direct message"/"Group DM"/username, Invite → disabled Sent, spinner while sending); - "Or send an invite link to a friend:", the link with Copy → "Copied", and the expiry text with "Edit invite link"; - "Invite link settings": "Expire after" and "Max number of uses" lists with the "Custom…" inputs, clamped as `clampNumber`; "Temporary membership"; Cancel / "Create new link" → `InviteAction::Configure`. The unavailable variant is drawn too. - Opening it from a menu starts the view state afresh. - **Leave community** goes through Daily use 33's `modals/leave.rs`. This PR adds a test for that path and no new code. ## Tests - `crates/fluxer-ui/tests/add_guild.rs`: `add_guild_views`, `invite_settings_lists`, `copy_link_emits`, `leave_community_uses_shared_modal`. I wrote these tests first and committed them separately. I wrote the modules alongside them, so the first run already had the implementation; `add_guild_views` failed on it and is fixed in this PR. - Goldens (lavapipe): `add_guild_landing`, `add_guild_create`, `invite_modal`, `invite_settings`. They have references in `docs/screenshots/` and rows in its README. There is no Electron reference capture; the dimensions come from the fork CSS files named in each test's doc comment. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally. I ran no `FLUXER_DESKTOP_TESTS` tests (none apply). ## Deviations and things to look at - **Goldens:** the add button shows on every main-screen golden. On the existing goldens it changes about 300 pixels, under the 0.5 % threshold, except `gif_picker_results` and `gif_picker_categories`, which crossed it (0.52 %) and are redrawn. I left the other goldens as they were to avoid binary conflicts with the UI tasks running in parallel. They can be redrawn in Task 40. - **Files outside the task's Files list:** - `app.rs`: the `Local` fields, the dialog/`LocalFiles` pick, the preview read, and Escape for the add-button menu; - `screens/main/{mod.rs,media.rs}`: routing, overlays, and the avatars the invite modal wants; - `menus/mod.rs`: two icon arms for the menu ids; - `crates/fluxer-ui/README.md`. - **Left out on purpose:** - the crop step: the whole picture is sent, as the original's "Skip" does; - the guidelines note: the instance's `guidelines_url` is not in the discovery the client reads; - the "Copied" → "Copy" 3 s timer: here "Copied" stays until the link changes or the modal closes; - the icon refusal is shown inline (`.iconError`) instead of the original's error modal, because the store has no action to dismiss it without clearing the icon. - The Ctrl+Shift+N hint in the tooltip is Task 35's. Closes #524 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Own presence from the user settings; SetStatus / SetCustomStatus write only
their fields (optimistic, reverted on failure); reset timer; idle and afk
from CoreEvent::Idle; op 3 whenever the computed presence changes; status
popout, custom status modal and custom status selectors.

Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed reset PATCH was re-sent at once by the same refresh, with no
limit (a request storm while offline or on 4xx/429). Remember the reset
whose write failed and skip it until READY, USER_SETTINGS_UPDATE or a
patch answer brings new settings, as StatusExpiry.handleExpiry does not
retry. The custom status test now asserts the profile popout exists.

Refs #499

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Relationship fixtures are shaped like RelationshipResponse
(packages/schema/src/domains/user/UserResponseSchemas.ts:492 of the
fork): id, type, user, nickname (nullable, always sent),
share_voice_activity, friend_shares_voice_activity.

Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generic confirm draws every daily-use confirm of the store; the
leave confirm (group with "Leave silently", community without); the
friends page with its tabs, search, rows, More menu, empty states and
Add friend form; Settings -> Blocked users; the DM welcome's friend
buttons; the DM list's Friends entry; the group X asks Leave group; the
group settings preview the picked icon (#383).

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six new goldens from the dailyuse scenario's READY
(fixtures/gateway/dailyuse_ready.json): friends_online, friends_pending,
friends_add, friends_empty, blocked_users and leave_group_confirm, with
their reference images and README rows. dm_list, friend_picker,
group_dm_welcome, group_settings and personal_notes_welcome are redrawn:
the DM list now starts with the Friends entry. Rendered on lavapipe in
the fluxer-native-shots:u2204 (Ubuntu 22.04) image like the Linux
runner; the whole suite (129 tests) passes there.

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #519

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guild's "Notification settings" modal (GuildNotificationSettingsModal.tsx),
opened by the guild and channel menus; channels and categories muted by their
own override at half opacity (ChannelItem.module.css:272); the guild tooltip's
filled BellSlash and "Muted" / "Muted until {datetime}"
(GuildListItemTooltip.tsx:216-229).

Refs #519

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #519

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/tests/dailyuse_ports.rs
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/src/screens/main/modals/mod.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	crates/fluxer-ui/tests/screenshots.rs
Refs #524

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guild rail's add button with its menu, "Create or join a community"
(landing, create with the icon through Dialogs and a round preview, join),
the invite modal with its friends, link and "Invite link settings".

Refs #524

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #524

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The add button after the guilds pushes these two over the 0.5 % threshold; the
other goldens show it under the threshold and are left as they are.

Refs #524

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Daily use 34b

Scope: git diff 769e2ca..origin/dailyuse-34b-ui-add-guild-invite-modal (4 commits).

Tests (1): add_guild_views, invite_settings_lists, copy_link_emits and leave_community_uses_shared_modal all exist in crates/fluxer-ui/tests/add_guild.rs. They check the spec's exact strings: the tooltip, both menu rows, all three views' titles and texts, the expire list Never…7 days/Custom… with 7 days as the default, the uses list No limit…100 uses/Custom…, the clamps 999999→604800 and 250→100, and Configure{86400,100,true}. The goldens add_guild_landing, add_guild_create, invite_modal and invite_settings are in screenshots.rs, with references and README rows.
Interfaces (2): all present. The add button sits at the end of the rail with its tooltip and right-click menu. The modal has the landing view (no template tile), the create view (icon via the injected Dialogs → LocalFiles → SoundFileReader, round cover-cropped preview) and the join view. The invite modal has the friends list, the link with Copy, the expiry text and "Edit invite link" → "Invite link settings". Leave goes through Task 33's modals/leave.rs.
Invariants (3): no new I/O path in fluxer-ui (only the sanctioned injected traits through Task::perform), and nothing touches fluxer-core. No unwrap or indexing on server data, and no secrets. The copy goes through the core Effect::Clipboard, which desktop_rt executes.
Parity (4), checked against the fork: AddGuildButton.tsx (strings, House/Link icons, bold plus), GuildsLayout.module.css .createGuildButtonIcon (2 px dashed --background-modifier-accent, 44 px), AddGuildModal.module.css (.actionButton 1.5rem/1rem padding, 0.5rem radius; .iconImage 5rem, cover) and GuildCreateShared.tsx (Upload/Change/Remove icon, inline .iconError exists in the original too). All match except the minor items below.
Review Focus (5): item 5 (confirms): "Leave community" uses the shared confirm without a Shift bypass or switch. Covered by the test.

Findings

  • minor: add_guild.rs ring_svg rounds the ring to 30 % on hover. In the original, .createGuildButtonIcon stays --radius-full; only border-color changes to --text-primary, since the 30 % rule targets .guildIcon, not this element. The original also keeps the hover look while the menu is open (.contextMenuHover); here it does not.
  • minor: the spec's §3.6 "crop" step (AssetCropModal), the guidelines note and the 3 s "Copied" reset are left out. They are disclosed in the PR body but have no follow-up issue linked yet (CLAUDE.md requires one before merge).
  • minor: the PR edits app.rs, which the plan gives to Task 35, and Task 35 does not depend on this task (nor this task on it). The plan says to stop and ask the orchestrator in that case. The edits are small and additive (Local fields, a pick and read task, an Escape arm), so expect a mechanical rebase. The orchestrator should order the merges.
  • minor: the custom expiry and uses inputs are drawn from the clamped number, so clearing the field shows "0". It works, but it is not a free text field as in the original.
  • minor: only two existing goldens were redrawn. The others now differ by about 300 px under the threshold, so the margin left for later UI tasks is smaller. Task 40 should redraw them.

CI (6)

FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci was started in the review worktree but had not finished (still compiling) when this review had to be returned. I could not confirm it locally.

Verdict: no blocking findings in the code. Not approved by this review because local CI was not confirmed green. Re-run the gate before ready-to-merge.

## Independent review: Daily use 34b Scope: `git diff 769e2ca..origin/dailyuse-34b-ui-add-guild-invite-modal` (4 commits). **Tests (1):** `add_guild_views`, `invite_settings_lists`, `copy_link_emits` and `leave_community_uses_shared_modal` all exist in `crates/fluxer-ui/tests/add_guild.rs`. They check the spec's exact strings: the tooltip, both menu rows, all three views' titles and texts, the expire list Never…7 days/Custom… with 7 days as the default, the uses list No limit…100 uses/Custom…, the clamps 999999→604800 and 250→100, and `Configure{86400,100,true}`. The goldens `add_guild_landing`, `add_guild_create`, `invite_modal` and `invite_settings` are in `screenshots.rs`, with references and README rows. **Interfaces (2):** all present. The add button sits at the end of the rail with its tooltip and right-click menu. The modal has the landing view (no template tile), the create view (icon via the injected `Dialogs` → `LocalFiles` → `SoundFileReader`, round cover-cropped preview) and the join view. The invite modal has the friends list, the link with Copy, the expiry text and "Edit invite link" → "Invite link settings". Leave goes through Task 33's `modals/leave.rs`. **Invariants (3):** no new I/O path in fluxer-ui (only the sanctioned injected traits through `Task::perform`), and nothing touches fluxer-core. No unwrap or indexing on server data, and no secrets. The copy goes through the core `Effect::Clipboard`, which `desktop_rt` executes. **Parity (4)**, checked against the fork: `AddGuildButton.tsx` (strings, House/Link icons, bold plus), `GuildsLayout.module.css .createGuildButtonIcon` (2 px dashed `--background-modifier-accent`, 44 px), `AddGuildModal.module.css` (`.actionButton` 1.5rem/1rem padding, 0.5rem radius; `.iconImage` 5rem, cover) and `GuildCreateShared.tsx` (Upload/Change/Remove icon, inline `.iconError` exists in the original too). All match except the minor items below. **Review Focus (5):** item 5 (confirms): "Leave community" uses the shared confirm without a Shift bypass or switch. Covered by the test. ### Findings - **minor**: `add_guild.rs` `ring_svg` rounds the ring to 30 % on hover. In the original, `.createGuildButtonIcon` stays `--radius-full`; only `border-color` changes to `--text-primary`, since the 30 % rule targets `.guildIcon`, not this element. The original also keeps the hover look while the menu is open (`.contextMenuHover`); here it does not. - **minor**: the spec's §3.6 "crop" step (`AssetCropModal`), the guidelines note and the 3 s "Copied" reset are left out. They are disclosed in the PR body but have no `follow-up` issue linked yet (CLAUDE.md requires one before merge). - **minor**: the PR edits `app.rs`, which the plan gives to Task 35, and Task 35 does not depend on this task (nor this task on it). The plan says to stop and ask the orchestrator in that case. The edits are small and additive (`Local` fields, a pick and read task, an Escape arm), so expect a mechanical rebase. The orchestrator should order the merges. - **minor**: the custom expiry and uses inputs are drawn from the clamped number, so clearing the field shows "0". It works, but it is not a free text field as in the original. - **minor**: only two existing goldens were redrawn. The others now differ by about 300 px under the threshold, so the margin left for later UI tasks is smaller. Task 40 should redraw them. ### CI (6) `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` was started in the review worktree but **had not finished** (still compiling) when this review had to be returned. I could not confirm it locally. **Verdict:** no blocking findings in the code. Not approved by this review because local CI was not confirmed green. Re-run the gate before `ready-to-merge`.
`.createGuildButtonIcon` only changes the ring's border colour on hover, and
`.contextMenuHover` keeps that look while the menu is open. Refs #524

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Review round 1, what changed per finding (commit 51c070b; FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally):

  1. Ring corners on hover / .contextMenuHover: fixed. add_guild::ring_svg(size) always draws the fully round ring, so hovering now only changes its colour to --text-primary. rail_button(open, menu_open) keeps that hover colour while the add button's menu is open: guild_rail::view gets local.add_guild.menu.is_some(). New test add_button_ring_round_and_lit_with_menu. The resting look did not change, so no golden moved.
  2. Crop step, guidelines note, 3 s "Copied" reset: not fixed here. They are now follow-up #604, linked from this PR.
  3. app.rs overlaps with Task 35: no code change. The edits to app.rs are additions only (Local fields, the icon pick and read tasks, an Escape arm). The orchestrator needs to set the merge order of 34b and 35, and the later branch rebases mechanically.
  4. Custom expiry/max-uses inputs show the clamped number: no change, because this matches the original. InviteModal.tsx binds value={maxAge} / value={maxUses} to state that clampNumber sets, and clampNumber('') returns '0' (lines 248-253 and 448-449, 476-477). Clearing the field shows "0" in the Electron app too.
  5. Main-screen goldens differ by about 300 px: not changed here. Follow-up #605 tracks redrawing them on lavapipe after this merges (Task 40 or the next UI task that touches them).

Follow-ups: #604, #605.

Review round 1, what changed per finding (commit 51c070b; `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally): 1. **Ring corners on hover / `.contextMenuHover`**: fixed. `add_guild::ring_svg(size)` always draws the fully round ring, so hovering now only changes its colour to `--text-primary`. `rail_button(open, menu_open)` keeps that hover colour while the add button's menu is open: `guild_rail::view` gets `local.add_guild.menu.is_some()`. New test `add_button_ring_round_and_lit_with_menu`. The resting look did not change, so no golden moved. 2. **Crop step, guidelines note, 3 s "Copied" reset**: not fixed here. They are now follow-up #604, linked from this PR. 3. **app.rs overlaps with Task 35**: no code change. The edits to app.rs are additions only (Local fields, the icon pick and read tasks, an Escape arm). The orchestrator needs to set the merge order of 34b and 35, and the later branch rebases mechanically. 4. **Custom expiry/max-uses inputs show the clamped number**: no change, because this matches the original. `InviteModal.tsx` binds `value={maxAge}` / `value={maxUses}` to state that `clampNumber` sets, and `clampNumber('')` returns `'0'` (lines 248-253 and 448-449, 476-477). Clearing the field shows "0" in the Electron app too. 5. **Main-screen goldens differ by about 300 px**: not changed here. Follow-up #605 tracks redrawing them on lavapipe after this merges (Task 40 or the next UI task that touches them). Follow-ups: #604, #605.
Author
Owner

Review round 1, what changed per finding (commit 51c070b; FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally):

  1. Ring corners on hover / .contextMenuHover: fixed. add_guild::ring_svg(size) always draws the fully round ring, so hovering now only changes its colour to --text-primary. rail_button(open, menu_open) keeps that hover colour while the add button's menu is open: guild_rail::view gets local.add_guild.menu.is_some(). New test add_button_ring_round_and_lit_with_menu. The resting look did not change, so no golden moved.
  2. Crop step, guidelines note, 3 s "Copied" reset: not fixed here. They are now follow-up #604, linked from this PR.
  3. app.rs overlaps with Task 35: no code change. The edits to app.rs are additions only (Local fields, the icon pick and read tasks, an Escape arm). The orchestrator needs to set the merge order of 34b and 35, and the later branch rebases mechanically.
  4. Custom expiry/max-uses inputs show the clamped number: no change, because this matches the original. InviteModal.tsx binds value={maxAge} / value={maxUses} to state that clampNumber sets, and clampNumber('') returns '0' (lines 248-253 and 448-449, 476-477). Clearing the field shows "0" in the Electron app too.
  5. Main-screen goldens differ by about 300 px: not changed here. Follow-up #605 tracks redrawing them on lavapipe after this merges (Task 40 or the next UI task that touches them).

Follow-ups: #604, #605.

Review round 1, what changed per finding (commit 51c070b; `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally): 1. **Ring corners on hover / `.contextMenuHover`**: fixed. `add_guild::ring_svg(size)` always draws the fully round ring, so hovering now only changes its colour to `--text-primary`. `rail_button(open, menu_open)` keeps that hover colour while the add button's menu is open: `guild_rail::view` gets `local.add_guild.menu.is_some()`. New test `add_button_ring_round_and_lit_with_menu`. The resting look did not change, so no golden moved. 2. **Crop step, guidelines note, 3 s "Copied" reset**: not fixed here. They are now follow-up #604, linked from this PR. 3. **app.rs overlaps with Task 35**: no code change. The edits to app.rs are additions only (Local fields, the icon pick and read tasks, an Escape arm). The orchestrator needs to set the merge order of 34b and 35, and the later branch rebases mechanically. 4. **Custom expiry/max-uses inputs show the clamped number**: no change, because this matches the original. `InviteModal.tsx` binds `value={maxAge}` / `value={maxUses}` to state that `clampNumber` sets, and `clampNumber('')` returns `'0'` (lines 248-253 and 448-449, 476-477). Clearing the field shows "0" in the Electron app too. 5. **Main-screen goldens differ by about 300 px**: not changed here. Follow-up #605 tracks redrawing them on lavapipe after this merges (Task 40 or the next UI task that touches them). Follow-ups: #604, #605.
Author
Owner

Independent review of Daily use 34b (only this task's own changes: 769e2ca9..51c070b6)

  1. Plan tests: add_guild_views, invite_settings_lists, copy_link_emits, leave_community_uses_shared_modal exist in crates/fluxer-ui/tests/add_guild.rs. They assert the spec §3.6 strings and values: Expire after Never/30 min/1 h/6 h/12 h/1 day/7 days (default, selected index 6)/Custom… clamped to 604800; Max uses No limit (default)/1/5/10/25/50/100/Custom… clamped to 100; "Your invite link expires in 7 days.". The goldens add_guild_landing, add_guild_create, invite_modal and invite_settings are in screenshots.rs, fixtures/golden and docs/screenshots.
  2. Interfaces: the rail add button (tooltip "Create or join a community", right-click menu "Create community" (House) / "Join community" (Link)) is there. The landing view has no template tile. The create view takes its icon through the injected Dialogs/LocalFiles and shows a round cover-crop preview. The join view and the invite modal (friends list, link and copy, expiry text, "Edit invite link" settings view) are there. Leave community goes through Task 33's modals/leave.rs.
  3. Invariants: no new I/O path in fluxer-ui. Icon picking and reading use the injected Dialogs, LocalFiles and SoundFileReader through Task::perform. No indexing or unwrap on server data (option lookups use .get). No new fixtures. No secrets.
  4. Parity, checked against the fork: AddGuildButton.tsx (label, HouseIcon/LinkIcon, bold Plus); GuildsLayout.module.css .createGuildButtonIcon (0.125rem dashed --background-modifier-accent ring, --text-primary on hover and with .contextMenuHover); InviteModal.tsx L214-250 (option lists and values, default 604800/0/false, clamping). All match.
  5. Review Focus: no item is specific to 34b. Item 5 (leave community confirm without a Shift bypass) holds: LeaveGuild confirmed:false, then the shared modal, then confirmed:true.
  6. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci run locally in the review worktree: green (exit 0).

Findings:

  • [minor] The task also touches crates/fluxer-ui/src/app.rs, screens/main/media.rs and screens/main/menus/mod.rs. None of these is in the plan's Files list or among the registration files. The additions are short and mechanical (shell wiring for the icon dialog and read, avatar requests, two menu icons), but File ownership says to flag them.
  • [minor] Documented divergences: there is no AssetCropModal step (the whole picture is sent, like the original's "Skip"); there is no guidelines note; "Copied" does not reset after 3 s. These are acceptable but deserve a parity row.

Verdict: APPROVED (0 blocking, ci green).

Independent review of Daily use 34b (only this task's own changes: 769e2ca9..51c070b6) 1. Plan tests: `add_guild_views`, `invite_settings_lists`, `copy_link_emits`, `leave_community_uses_shared_modal` exist in crates/fluxer-ui/tests/add_guild.rs. They assert the spec §3.6 strings and values: Expire after Never/30 min/1 h/6 h/12 h/1 day/7 days (default, selected index 6)/Custom… clamped to 604800; Max uses No limit (default)/1/5/10/25/50/100/Custom… clamped to 100; "Your invite link expires in 7 days.". The goldens `add_guild_landing`, `add_guild_create`, `invite_modal` and `invite_settings` are in screenshots.rs, fixtures/golden and docs/screenshots. 2. Interfaces: the rail add button (tooltip "Create or join a community", right-click menu "Create community" (House) / "Join community" (Link)) is there. The landing view has no template tile. The create view takes its icon through the injected Dialogs/LocalFiles and shows a round cover-crop preview. The join view and the invite modal (friends list, link and copy, expiry text, "Edit invite link" settings view) are there. Leave community goes through Task 33's modals/leave.rs. 3. Invariants: no new I/O path in fluxer-ui. Icon picking and reading use the injected Dialogs, LocalFiles and SoundFileReader through Task::perform. No indexing or unwrap on server data (option lookups use .get). No new fixtures. No secrets. 4. Parity, checked against the fork: AddGuildButton.tsx (label, HouseIcon/LinkIcon, bold Plus); GuildsLayout.module.css .createGuildButtonIcon (0.125rem dashed --background-modifier-accent ring, --text-primary on hover and with .contextMenuHover); InviteModal.tsx L214-250 (option lists and values, default 604800/0/false, clamping). All match. 5. Review Focus: no item is specific to 34b. Item 5 (leave community confirm without a Shift bypass) holds: LeaveGuild confirmed:false, then the shared modal, then confirmed:true. 6. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` run locally in the review worktree: green (exit 0). Findings: - [minor] The task also touches crates/fluxer-ui/src/app.rs, screens/main/media.rs and screens/main/menus/mod.rs. None of these is in the plan's Files list or among the registration files. The additions are short and mechanical (shell wiring for the icon dialog and read, avatar requests, two menu icons), but File ownership says to flag them. - [minor] Documented divergences: there is no AssetCropModal step (the whole picture is sent, like the original's "Skip"); there is no guidelines note; "Copied" does not reset after 3 s. These are acceptable but deserve a parity row. Verdict: APPROVED (0 blocking, ci green).
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/tests/dailyuse_ports.rs
#	crates/fluxer-ui/README.md
#	crates/fluxer-ui/src/screens/main/menus/mod.rs
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/src/screens/main/modals/mod.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	crates/fluxer-ui/tests/screenshots.rs
#	docs/screenshots/README.md
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Author
Owner

Merged into dailyuse and textchat at 1089e6a1 (combined merge).

Merged into `dailyuse` and `textchat` at 1089e6a1 (combined merge).
charles closed this pull request 2026-11-15 09:58:44 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.