Daily use 39: Report message modal (#531) #593

Closed
charles wants to merge 0 commits from dailyuse-39-ui-report-modal into dailyuse
Owner

What

The "Report message" modal (Daily use spec §3.12; fork feat/moderation/components/report_flow/ReportFlowModal.tsx and its parts): crates/fluxer-ui/src/screens/main/modals/report.rs draws fluxer_core::report::report_modal (Daily use 23) for whatever screens the server sends:

  • header: the screen's title and subtitle (summary: "Check your report" / "Make sure this looks right before you send it."; end: "Report sent" / "Thanks for flagging this"), the close X;
  • a screen: the reported message (drawn as in the list, in a bordered box) on the first screen, the urgent banner, the options heading and the option list (caret, or the external-link icon for link outcomes), checklists (box + label + description; Next enabled at min_checked), Next on info screens, Back;
  • the summary: the good-faith statement with the "community guidelines" link, "Message you're reporting", "Your answers" (the timeline list), the reason a send failed, Back and the red "Send report" (both disabled while sending; "Done" after a final refusal);
  • notices; the thank-you screen with "Your options" / "Block {name}" / "Hides their messages and stops them messaging you" and the red Block (→ ReportAction::BlockAuthor, the generic block confirm opens over the modal; "Blocked", disabled, once blocked);
  • "Couldn't load the report form." with "Try again" (re-sends ReportAction::Open for the same message), the loading dots.

Wiring: screens::main::Message::Report, routed to modals::report::update; the modal is drawn under message_actions_over so the relationship confirm of "Block" appears on top. The message menu's "Report message" already emitted ReportAction::Open (Daily use 23), so message_actions/menu.rs needed no change.

Tests

  • crates/fluxer-ui/tests/report.rs (headless, clicks on the drawn texts): renders_options_and_navigates, checklist_enables_next_at_min, info_screen_next, review_and_submit, done_offers_block, plus load_failure_offers_try_again_and_main_screen_routes.
  • Goldens report_root, report_checklist, report_review, report_done (in tests/screenshots.rs), drawn with UPDATE_GOLDEN=1 on lavapipe in the fluxer-native-shots:u2204 image; references in docs/screenshots/report-*.png, table rows in docs/screenshots/README.md.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No FLUXER_DESKTOP_TESTS tests involved.
  • No Electron side-by-side attached (no access to the live instance from this agent); the layout follows the fork's CSS values cited in the module.

Deviations

  • The store's one-off flash ("The report form changed. Please start again.") is drawn as a note banner at the top of the card rather than as a toast; the step slide animation (SteppedCarousel) is not drawn; the spinner is the repo's still three-dot spinner.
  • Merge of the stacked branches needed a hand resolution in crates/fluxer-core/tests/dailyuse_ports.rs and crates/fluxer-core/README.md (both sides kept).

Stacked on: dailyuse-23-core-profile-report-flow, dailyuse-31-ui-user-dm-menus

Closes #531

🤖 Generated with Claude Code

## What The "Report message" modal (Daily use spec §3.12; fork `feat/moderation/components/report_flow/ReportFlowModal.tsx` and its parts): `crates/fluxer-ui/src/screens/main/modals/report.rs` draws `fluxer_core::report::report_modal` (Daily use 23) for whatever screens the server sends: - header: the screen's title and subtitle (summary: "Check your report" / "Make sure this looks right before you send it."; end: "Report sent" / "Thanks for flagging this"), the close X; - a screen: the reported message (drawn as in the list, in a bordered box) on the first screen, the urgent banner, the options heading and the option list (caret, or the external-link icon for `link` outcomes), checklists (box + label + description; Next enabled at `min_checked`), Next on info screens, Back; - the summary: the good-faith statement with the "community guidelines" link, "Message you're reporting", "Your answers" (the timeline list), the reason a send failed, Back and the red "Send report" (both disabled while sending; "Done" after a final refusal); - notices; the thank-you screen with "Your options" / "Block {name}" / "Hides their messages and stops them messaging you" and the red Block (→ `ReportAction::BlockAuthor`, the generic block confirm opens over the modal; "Blocked", disabled, once blocked); - "Couldn't load the report form." with "Try again" (re-sends `ReportAction::Open` for the same message), the loading dots. Wiring: `screens::main::Message::Report`, routed to `modals::report::update`; the modal is drawn under `message_actions_over` so the relationship confirm of "Block" appears on top. The message menu's "Report message" already emitted `ReportAction::Open` (Daily use 23), so `message_actions/menu.rs` needed no change. ## Tests - `crates/fluxer-ui/tests/report.rs` (headless, clicks on the drawn texts): `renders_options_and_navigates`, `checklist_enables_next_at_min`, `info_screen_next`, `review_and_submit`, `done_offers_block`, plus `load_failure_offers_try_again_and_main_screen_routes`. - Goldens `report_root`, `report_checklist`, `report_review`, `report_done` (in `tests/screenshots.rs`), drawn with `UPDATE_GOLDEN=1` on lavapipe in the `fluxer-native-shots:u2204` image; references in `docs/screenshots/report-*.png`, table rows in `docs/screenshots/README.md`. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No `FLUXER_DESKTOP_TESTS` tests involved. - No Electron side-by-side attached (no access to the live instance from this agent); the layout follows the fork's CSS values cited in the module. ## Deviations - The store's one-off `flash` ("The report form changed. Please start again.") is drawn as a note banner at the top of the card rather than as a toast; the step slide animation (`SteppedCarousel`) is not drawn; the spinner is the repo's still three-dot spinner. - Merge of the stacked branches needed a hand resolution in `crates/fluxer-core/tests/dailyuse_ports.rs` and `crates/fluxer-core/README.md` (both sides kept). Stacked on: dailyuse-23-core-profile-report-flow, dailyuse-31-ui-user-dm-menus Closes #531 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings from READY, USER_GUILD_SETTINGS_UPDATE and the patch answers;
immediate menu mutes (guild scalars, whole channel_overrides map for
channels, categories and DMs in @me), mute_config in ms, local expiry
timers, 3 s debounced modal changes, revert on failure, selectors
is_muted / muted_until / level / guild_settings_modal, and the shared
mute menu row (MuteTargetMenuItem.tsx, MuteOptions.ts,
UserGuildSettings.ts, UserGuildSettingsCommands.ts).

Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
format_date_time shifted the end with to_offset, which panics when the
local date leaves year 9999 (a 9999-12-31T23:30Z end read east of UTC).
It now uses checked_to_offset and falls back to UTC. The
event_replaces_guild_settings test now checks the staff override is
really gone instead of an always-true assertion.

Refs #497

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Uses the existing server-shaped fixtures: rest/invite_metadata.json
(POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the
metadata fields), rest/guild.json (POST /guilds, GuildResponse) and
gateway/guild_create.json.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The invite modal (default invite at open, settings clamped to the
server's limits, link, expiry text, friends and group DMs with
Invite -> Sent through SendMessage), can_invite / invite_channel for the
menus, "Create or join a community" (name, static icon, create then
select the system channel once its GUILD_CREATE is in, join through the
accept flow), and "Leave community" (Confirm::LeaveGuild, no Shift
bypass, no delete_messages; hidden for the owner; on success the guild
goes as its GUILD_DELETE would, so a selected one leaves for the DMs).

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dailyuse_ports listed them among the stubs that do nothing.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Table tests for the notification decision (Notification.ts:187-256) and
tests for mute consumers: unread, guild pill, hide muted channels, DM
mentions. Stubs for SidebarSection.{category_muted,muted} and
notif_settings::hides_muted_channels so the tests compile.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notif_settings::mentions_me as MessageUtils.isMentioned and
  Notification.isMessageMentionLike: blocked author no, user mention,
  @everyone unless suppressed or in an unjoined thread, own role unless
  suppressed, unmuted DM.
- notification_for follows Notification.ts:187-256: own, blocked, DND,
  SUPPRESS_NOTIFICATIONS, then thread levels (member level, parent level,
  forum new-post level, else only mentions) or mute at any level and the
  effective level.
- read_state::unread is false for a muted channel (mention counts kept);
  has_unread_messages keeps the raw answer for the new-messages bar and
  the thread menu's Mark as read.
- channel_tree: category_muted and muted rows; hide muted channels per
  guild (default_hide_muted_channels without an entry), unless selected,
  connected or with a mention; all-hidden categories hidden.
- DmRowModel.muted from the @me override; a thread is muted by its
  membership or its parent at any level.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Own presence from the user settings; SetStatus / SetCustomStatus write only
their fields (optimistic, reverted on failure); reset timer; idle and afk
from CoreEvent::Idle; op 3 whenever the computed presence changes; status
popout, custom status modal and custom status selectors.

Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed reset PATCH was re-sent at once by the same refresh, with no
limit (a request storm while offline or on 4xx/429). Remember the reset
whose write failed and skip it until READY, USER_SETTINGS_UPDATE or a
patch answer brings new settings, as StatusExpiry.handleExpiry does not
retry. The custom status test now asserts the profile popout exists.

Refs #499

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Relationship fixtures are shaped like RelationshipResponse
(packages/schema/src/domains/user/UserResponseSchemas.ts:492 of the
fork): id, type, user, nickname (nullable, always sent),
share_voice_activity, friend_shares_voice_activity.

Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests of Daily use 23: profile modal tabs and counts, the mutual tab's
label, local time, its 30 s refresh, badges, notes, Shift+click, and the
report flow's walk (options, checklists, info screens, notices, links,
Back, submission, legacy fallback, the Block offer). The report flow
fixture is fixtures/rest/report_flow_message.json (Daily use 2, shaped
like packages/schema/src/domains/report/ReportFlowSchemas.ts:66-149).

Refs #511

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The full profile modal (tabs "Overview", "Mutual friends (n)" except
for bots, "Mutual communities|groups|places (n)"; overview with voice
activity, local time, member since, roles, connections and the note),
the popout's badges, voice activity, local time (12/24 h, ahead/behind,
redrawn every 30 s) and connections, notes (fetched once per user,
USER_NOTE_UPDATE, SaveNote written only on change), Shift+click
mentions (profiles::user_click), and the report flow over the server's
screens as ReportFlowWalk.ts with the legacy fallback of spec Q14.

Refs #511

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
# Conflicts:
#	crates/fluxer-core/src/app.rs
Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generic confirm draws every daily-use confirm of the store; the
leave confirm (group with "Leave silently", community without); the
friends page with its tabs, search, rows, More menu, empty states and
Add friend form; Settings -> Blocked users; the DM welcome's friend
buttons; the DM list's Friends entry; the group X asks Leave group; the
group settings preview the picked icon (#383).

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six new goldens from the dailyuse scenario's READY
(fixtures/gateway/dailyuse_ready.json): friends_online, friends_pending,
friends_add, friends_empty, blocked_users and leave_group_confirm, with
their reference images and README rows. dm_list, friend_picker,
group_dm_welcome, group_settings and personal_notes_welcome are redrawn:
the DM list now starts with the Friends entry. Rendered on lavapipe in
the fluxer-native-shots:u2204 (Ubuntu 22.04) image like the Linux
runner; the whole suite (129 tests) passes there.

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
menus::user and menus::dm with the rows of GuildMemberContextMenu,
UserContextMenu, DMContextMenu and GroupDMContextMenu that this client
builds; Mention into the composer; Pin DM; Close DM and Open DM (blocked)
confirms; Invite to community; Report message in the message menu.

Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/src/screens/main/dms/mod.rs
Refs #520

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A right press on a member row, a message author's avatar or name, a
user mention or a DM row opens the user, member or DM menu that
fluxer_core::menus builds (spec 3.2 (e), (f)). Relationship rows ask
through the generic confirm; Shift sends them confirmed only where
social::confirm_rule lets it (block, unblock, remove, accept), never
for Close DM, Open DM or Leave group. "Change friend nickname" opens
its modal ("Change nickname", "Clear nickname", 32 characters). The
voice participant menu gains Mention and Message from the same builder
(#476).

Refs #520

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
member_menu, member_menu_moderator, dm_menu, group_dm_menu and
block_confirm; participant_menu and its entrance submenu redrawn with
Mention and Message first (#476).

Refs #520

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/tests/dailyuse_ports.rs
The report flow modal (spec 3.12, ReportFlowModal.tsx and its parts):
it draws fluxer_core::report::report_modal whatever screens the server
sends: title and subtitle, the reported message on the first screen and
the summary, the urgent banner, options with a caret or the external
link icon, checklists (Next at min_checked), Next on info screens,
Back; "Check your report" with the guidelines link, "Your answers" and
the red "Send report"; notices; "Report sent" / "Thanks for flagging
this" with "Block {name}" through the generic block confirm; "Try
again" after a failed load. Opened by the message menu's "Report
message"; drawn under the message actions' confirms.

Refs #531

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
report_root, report_checklist, report_review and report_done, over
fixtures/rest/report_flow_message.json.

Refs #531

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Daily use 39 (report message modal)

I reviewed git diff ed6d2a5..origin/dailyuse-39-ui-report-modal (69c7e64).

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci passed every step, including fmt, clippy, deny, core-isolation, parity, test, vendored-tests, screenshot-tests and livekit-interop. I ran it from a fresh target dir.

Checks

  1. Plan tests. These five tests exist in crates/fluxer-ui/tests/report.rs: renders_options_and_navigates, checklist_enables_next_at_min, info_screen_next, review_and_submit and done_offers_block. They click drawn texts in a headless frame and check the outcomes:

    • screen, link and urgent outcomes, then Back to the start;
    • Next is disabled until min_checked is met and disabled again after unticking;
    • an info screen with next_screen_id gets a Next button;
    • the submission carries revision_hash and the steps, with Back and Send disabled while it is submitting;
    • Block goes through the generic block confirm, which accepts with confirmed: true, and reads "Blocked" once the user is blocked.

    The four goldens report_root/checklist/review/done are in screenshots.rs and fixtures/golden/, with reference copies in docs/screenshots/.

  2. Interfaces. The modal draws the server's screens generically. It covers title and subtitle, the urgent banner, the options heading and options with a caret or link icon, checklists, Next on info screens, notices, the guidelines link and Back, plus "Check your report" / "Send report" and "Report sent" with "Block {name}". It has no hard-coded categories, as Q14 requires. message_actions/menu.rs is unchanged, and the test shows the menu already emits ReportAction::Open.

  3. Invariants. fluxer-ui gains no I/O: the guidelines link goes through ReportAction::OpenLink and core Effect::OpenUrl. The only fixture is the existing report_flow_message.json. Unknown or missing data falls back to the Loading or empty body without panicking. I found no secrets or paths.

  4. Parity spot-checks against fork:.../moderation/components/report_flow/:

    • The strings match ReportFlowCopy.ts exactly: Check your report, Make sure this looks right…, Your answers, Send report, Report sent, Thanks for flagging this, Your options, Hides their messages and stops them messaging you, Blocked, and the urgent banner. The linked disclaimer also matches ReportFlowSummary.tsx:44.
    • On the thank-you screen, Block is danger and becomes a disabled secondary "Blocked" (ReportFlowThankYou.tsx:68-79).
    • The footer matches ReportFlowModal.tsx:474-565. Back is disabled while submitting, Next is disabled below the checklist minimum, Send is danger and the footers are stretched.
    • The preview max height is min(13.75rem, 40vh) (ReportFlowPreview.module.css:4). .submitNote uses danger at 12%.
  5. Review Focus. Item 7 (unknown outcome types) belongs to the core and proto tasks. The UI only draws ReportModalModel, so it has nothing to add there.

  6. The two points the implementer asked about:

    • Overlay order. report_over sits directly under message_actions_over, so the generic block confirm (app.chat.confirm) is drawn on top of the report. done_offers_block covers this.
    • Preview wrapping. In report_root and report_review, "Cheap followers, best prices, DM me / now!" wraps about 60 px before the box edge. That comes from the message row's own right padding, which is the same as in the list. I accept it.

Findings

  • minor, modals/report.rs preview_box: a message taller than 13.75 rem is clipped, but the original's .messageScroller is a Scroller, so it scrolls there. Long reported messages are therefore cut off in the native client. This should be a follow-up, not a blocker.
  • minor, modals/report.rs: the store's flash ("The report form changed…") is shown as a banner in the card instead of a toast. The spinner does not move, and there is no step slide. All three are documented deviations. They should be listed in docs/parity/dailyuse.md (Task 40) if they are not already.
  • minor, tests/report.rs renders_options_and_navigates: "The X closes it" calls report::update(Message::Close) directly instead of clicking the X. done_offers_block reads the "Block …" name but does not assert that it is "Block ada". These are test-strength nits only.
  • minor, PR description: no Electron side-by-side is attached, as CLAUDE.md asks for UI PRs.

Verdict: approve. There are no blocking findings, and local CI is green.

🤖 Generated with Claude Code

## Independent review: Daily use 39 (report message modal) I reviewed `git diff ed6d2a5..origin/dailyuse-39-ui-report-modal` (69c7e64). **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` passed every step, including fmt, clippy, deny, core-isolation, parity, test, vendored-tests, screenshot-tests and livekit-interop. I ran it from a fresh target dir. ### Checks 1. **Plan tests.** These five tests exist in `crates/fluxer-ui/tests/report.rs`: `renders_options_and_navigates`, `checklist_enables_next_at_min`, `info_screen_next`, `review_and_submit` and `done_offers_block`. They click drawn texts in a headless frame and check the outcomes: - `screen`, `link` and urgent outcomes, then Back to the start; - Next is disabled until `min_checked` is met and disabled again after unticking; - an info screen with `next_screen_id` gets a Next button; - the submission carries `revision_hash` and the steps, with Back and Send disabled while it is submitting; - Block goes through the generic block confirm, which accepts with `confirmed: true`, and reads "Blocked" once the user is blocked. The four goldens `report_root/checklist/review/done` are in `screenshots.rs` and `fixtures/golden/`, with reference copies in `docs/screenshots/`. 2. **Interfaces.** The modal draws the server's screens generically. It covers title and subtitle, the urgent banner, the options heading and options with a caret or link icon, checklists, Next on info screens, notices, the guidelines link and Back, plus "Check your report" / "Send report" and "Report sent" with "Block {name}". It has no hard-coded categories, as Q14 requires. `message_actions/menu.rs` is unchanged, and the test shows the menu already emits `ReportAction::Open`. 3. **Invariants.** `fluxer-ui` gains no I/O: the guidelines link goes through `ReportAction::OpenLink` and core `Effect::OpenUrl`. The only fixture is the existing `report_flow_message.json`. Unknown or missing data falls back to the Loading or empty body without panicking. I found no secrets or paths. 4. **Parity spot-checks** against `fork:.../moderation/components/report_flow/`: - The strings match `ReportFlowCopy.ts` exactly: Check your report, Make sure this looks right…, Your answers, Send report, Report sent, Thanks for flagging this, Your options, Hides their messages and stops them messaging you, Blocked, and the urgent banner. The linked disclaimer also matches `ReportFlowSummary.tsx:44`. - On the thank-you screen, Block is `danger` and becomes a disabled `secondary` "Blocked" (`ReportFlowThankYou.tsx:68-79`). - The footer matches `ReportFlowModal.tsx:474-565`. Back is disabled while submitting, Next is disabled below the checklist minimum, Send is `danger` and the footers are stretched. - The preview max height is `min(13.75rem, 40vh)` (`ReportFlowPreview.module.css:4`). `.submitNote` uses danger at 12%. 5. **Review Focus.** Item 7 (unknown outcome types) belongs to the core and proto tasks. The UI only draws `ReportModalModel`, so it has nothing to add there. 6. **The two points the implementer asked about:** - **Overlay order.** `report_over` sits directly under `message_actions_over`, so the generic block confirm (`app.chat.confirm`) is drawn on top of the report. `done_offers_block` covers this. - **Preview wrapping.** In `report_root` and `report_review`, "Cheap followers, best prices, DM me / now!" wraps about 60 px before the box edge. That comes from the message row's own right padding, which is the same as in the list. I accept it. ### Findings - **minor**, `modals/report.rs` `preview_box`: a message taller than 13.75 rem is clipped, but the original's `.messageScroller` is a `Scroller`, so it scrolls there. Long reported messages are therefore cut off in the native client. This should be a follow-up, not a blocker. - **minor**, `modals/report.rs`: the store's `flash` ("The report form changed…") is shown as a banner in the card instead of a toast. The spinner does not move, and there is no step slide. All three are documented deviations. They should be listed in `docs/parity/dailyuse.md` (Task 40) if they are not already. - **minor**, `tests/report.rs` `renders_options_and_navigates`: "The X closes it" calls `report::update(Message::Close)` directly instead of clicking the X. `done_offers_block` reads the "Block …" name but does not assert that it is "Block ada". These are test-strength nits only. - **minor**, PR description: no Electron side-by-side is attached, as `CLAUDE.md` asks for UI PRs. **Verdict: approve.** There are no blocking findings, and local CI is green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
Owner

Independent review, Daily use 39 (report message modal), diff origin/dailyuse..origin/dailyuse-39-ui-report-modal at 948433f6.

Checks

  1. Plan tests: renders_options_and_navigates, checklist_enables_next_at_min, info_screen_next, review_and_submit, done_offers_block exist in crates/fluxer-ui/tests/report.rs, plus goldens report_root, report_checklist, report_review, report_done in tests/screenshots.rs, with images in fixtures/golden/ and docs/screenshots/. The tests check the server's screens, Next enabled only at min_checked, the info screen's Next, a submission with revision_hash 4be1c09a7f3d2e65 and one step spam, Back and Send disabled while sending, "Report sent", and Block going through the block confirm and then showing a disabled "Blocked".
  2. Interfaces: the modal draws title, subtitle, the urgent banner, the options heading and options (with the external-link icon for link), checklists, Next on info screens, notices, the guidelines link, Back, "Check your report" / "Send report", the notice or "Report sent" end screen, and "Block {name}". "Report message" was already wired in message_actions (Task 23/18), so menu.rs did not need changing.
  3. Invariants: the modal does no I/O. It only reads the store (fluxer_core::report) and emits UserAction::Report. It adds no new fixture: it reuses Task 23's report_flow_message.json. No secrets. Only registration files are touched outside the new module.
  4. Parity, checked against fluxer_app/src/features/moderation/components/report_flow/: the strings ("Check your report", "Make sure this looks right before you send it.", "Your options", "Hides their messages and stops them messaging you", "Blocked") match ReportFlowCopy.ts. Modal.Root size="small" matches 27.5 rem. The preview's max height of 13.75 rem and the option row's min height of 3.25 rem match the CSS. Back is disabled while submitting, Block is secondary and disabled once blocked (ReportFlowThankYou.tsx:69-78), and the urgent banner shows on the summary (ReportFlowSummary urgent=).
  5. Review Focus 5/7: Block asks through the generic confirm (showBlockUserConfirmation), and the modal stays under it. The report modal is layered beneath message_actions_over, as it should be.
  6. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci run locally in the review worktree: all steps passed.

Findings

  • minor: done_offers_block finds the "Block …" title but binds it to _name and never checks it equals "Block ada" (BLOCK_NAME_DESCRIPTOR with the nickname). The golden covers it visually, but the test does not.
  • minor: the original's account-gate notice on the summary ("Finish account setup first") is not drawn. The spec does not ask for it.

Verdict: approved (no blocking findings, local CI green).

Independent review, Daily use 39 (report message modal), diff origin/dailyuse..origin/dailyuse-39-ui-report-modal at 948433f6. **Checks** 1. Plan tests: `renders_options_and_navigates`, `checklist_enables_next_at_min`, `info_screen_next`, `review_and_submit`, `done_offers_block` exist in `crates/fluxer-ui/tests/report.rs`, plus goldens `report_root`, `report_checklist`, `report_review`, `report_done` in `tests/screenshots.rs`, with images in `fixtures/golden/` and `docs/screenshots/`. The tests check the server's screens, Next enabled only at `min_checked`, the info screen's Next, a submission with `revision_hash` 4be1c09a7f3d2e65 and one step `spam`, Back and Send disabled while sending, "Report sent", and Block going through the block confirm and then showing a disabled "Blocked". 2. Interfaces: the modal draws title, subtitle, the urgent banner, the options heading and options (with the external-link icon for `link`), checklists, Next on info screens, notices, the guidelines link, Back, "Check your report" / "Send report", the notice or "Report sent" end screen, and "Block {name}". "Report message" was already wired in `message_actions` (Task 23/18), so `menu.rs` did not need changing. 3. Invariants: the modal does no I/O. It only reads the store (`fluxer_core::report`) and emits `UserAction::Report`. It adds no new fixture: it reuses Task 23's `report_flow_message.json`. No secrets. Only registration files are touched outside the new module. 4. Parity, checked against `fluxer_app/src/features/moderation/components/report_flow/`: the strings ("Check your report", "Make sure this looks right before you send it.", "Your options", "Hides their messages and stops them messaging you", "Blocked") match `ReportFlowCopy.ts`. `Modal.Root size="small"` matches 27.5 rem. The preview's max height of 13.75 rem and the option row's min height of 3.25 rem match the CSS. Back is disabled while submitting, Block is secondary and disabled once blocked (`ReportFlowThankYou.tsx:69-78`), and the urgent banner shows on the summary (`ReportFlowSummary urgent=`). 5. Review Focus 5/7: Block asks through the generic confirm (`showBlockUserConfirmation`), and the modal stays under it. The report modal is layered beneath `message_actions_over`, as it should be. 6. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` run locally in the review worktree: all steps passed. **Findings** - minor: `done_offers_block` finds the "Block …" title but binds it to `_name` and never checks it equals "Block ada" (`BLOCK_NAME_DESCRIPTOR` with the nickname). The golden covers it visually, but the test does not. - minor: the original's account-gate notice on the summary ("Finish account setup first") is not drawn. The spec does not ask for it. **Verdict: approved** (no blocking findings, local CI green).
Author
Owner

Merged into dailyuse and textchat at 1089e6a1 (combined merge).

Merged into `dailyuse` and `textchat` at 1089e6a1 (combined merge).
charles closed this pull request 2026-11-15 09:58:46 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.