Daily use 37a: Attachment actions, audio player, group icon crop (#527) #590

Closed
charles wants to merge 0 commits from dailyuse-37a-ui-attachment-audio-group-icon into dailyuse
Owner

Stacked on: dailyuse-22a-core-mark-unread-attachments, dailyuse-25-audio-attachments, dailyuse-33-ui-confirm-friends-page

What

  • Lightbox toolbar (media_viewer.rs, MediaControls.tsx:167-375): toolbar() in the original's order — Close; Open in browser, Copy link, "Copy media to clipboard", the star (Add to / Remove from favorites), "Download media", "Delete attachment" (author + "Show the delete button"); rotations, reset, zoom (reset/zoom drawn disabled for videos, as the original); large gap, "Reply to message" (only where the user may send), "Forward media". act(state, msg, app, shift) sends CopyAttachmentImage, DeleteAttachment { confirmed: shift }, opens "Add to saved media" or the forward modal with one item (forward::State::for_media → ForwardAttachment).
  • Attachment hover toolbar (attachments.rs, MediaContainer.tsx + ActionToolbar.module.css): Delete (danger colour), Download, star; hover_tools(); attachments::Message::{Delete, Favorite}.
  • "Add to saved media" (modals/add_saved_media.rs, AddFavoriteMemeModal.tsx/MemeFormFields.tsx/TagListField.tsx): name (required, ≤100), alt text (≤500), tags (≤10, ≤30 chars, no repeats); Save → FavoriteAttachment; a saved item's star removes it at once.
  • Audio player (audio.rs, InlineAudioPlayer.tsx): header with play button, name, size · M:SS; progress bar (press/drag seeks on release), M:SS / M:SS (H:MM:SS over an hour); compact volume (slider on hover, committed on release) and mute; rate button (1x… tooltip "Playback speed: 1.5x", accent when ≠1), star, download. ←/→ ±5 % go to the card under the pointer (audio::Local::key, wired in app.rs like the video players). Data from Daily use 25's audio_player selector.
  • Group icon crop (dms/group_settings.rs, AssetCropModal.tsx CHANNEL_ICON / ImageCropModal.tsx): "Crop group icon" with the description, round mask (rgba(47,49,54,.6) + 5 px white ring), drag, zoom 1–3 (slider/wheel), rotate clockwise; Reset / Cancel (drops the pick) / "Skip cropping" (only square ≤1024, as canSkipOriginalAssetImage) / "Save icon" (crop at source resolution, ≤1024 px, PNG). Untouched + skippable Save acts as Skip (handleSave). The PNG is named by the shell via LocalFiles::keep_pasted → Message::Cropped(FileRef). Unreadable pick → "Unsupported icon format"; SVG goes as picked. Refusals now show IconRefusal messages from 22a (incl. animated).

Tests

  • tests/attachment_actions.rs: viewer_toolbar_items_by_permission, delete_confirm_shift_skips, saved_media_modal_validation, group_icon_crop_and_skip (+ routing check).
  • tests/audio_player.rs: audio_seek_and_rate.
  • Goldens (tests/screenshots.rs): new media_viewer_toolbar, attachment_hover_toolbar, audio_player_playing; redrawn media_viewer (new toolbar buttons) and attachment_file_card (new audio card layout). Drawn on lavapipe in fluxer-native-shots:u2204; the whole suite (132) passed there before the update, with exactly these 5 failing. References copied to docs/screenshots/, README rows added. No Electron side-by-side capture (no test account here); dimensions are from the CSS files named above.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No FLUXER_DESKTOP_TESTS tests apply.

Deviations / notes for review

  • Files outside the task list, kept minimal: screens/main/mod.rs (route Favorite/Delete/audio drags, viewer act, overlays: lightbox now drawn under the message confirms/forward modal so Delete/Forward from the viewer are visible; saved-media and crop modals), messages.rs (map new attachment messages), media.rs (audio::Local), message_row.rs (pass it), forward.rs (media field), app.rs (Local::saved_media, crop PNG naming, ←/→ for audio), dms/mod.rs (IconRead now carries bytes), testing/offscreen.rs (render_with_cursor for the hover golden).
  • Merge of 33 into dailyuse conflicted in dms/mod.rs (DM list X): kept 33's group → "Leave group" confirm and dailyuse's DM → close at once (useDMListItemHandlers.tsx:139-143); fixed 33's friends test expecting confirmed: false for the DM X.
  • The play button stops rather than pauses (store has no pause for attachments). Voice messages keep the ordinary card (no 32-bar waveform yet). The volume slider shows while the card is hovered rather than the volume control itself.
  • The cropped icon is a FileSource::Clipboard FileRef; the runtime's EditGroupDmIcon (Task 28) must read clipboard sources.

Closes #527
Closes #376
Closes #378

🤖 Generated with Claude Code

Stacked on: dailyuse-22a-core-mark-unread-attachments, dailyuse-25-audio-attachments, dailyuse-33-ui-confirm-friends-page ## What - **Lightbox toolbar** (`media_viewer.rs`, `MediaControls.tsx:167-375`): `toolbar()` in the original's order — Close; Open in browser, Copy link, "Copy media to clipboard", the star (Add to / Remove from favorites), "Download media", "Delete attachment" (author + "Show the delete button"); rotations, reset, zoom (reset/zoom drawn disabled for videos, as the original); large gap, "Reply to message" (only where the user may send), "Forward media". `act(state, msg, app, shift)` sends `CopyAttachmentImage`, `DeleteAttachment { confirmed: shift }`, opens "Add to saved media" or the forward modal with one item (`forward::State::for_media` → `ForwardAttachment`). - **Attachment hover toolbar** (`attachments.rs`, `MediaContainer.tsx` + `ActionToolbar.module.css`): Delete (danger colour), Download, star; `hover_tools()`; `attachments::Message::{Delete, Favorite}`. - **"Add to saved media"** (`modals/add_saved_media.rs`, `AddFavoriteMemeModal.tsx`/`MemeFormFields.tsx`/`TagListField.tsx`): name (required, ≤100), alt text (≤500), tags (≤10, ≤30 chars, no repeats); Save → `FavoriteAttachment`; a saved item's star removes it at once. - **Audio player** (`audio.rs`, `InlineAudioPlayer.tsx`): header with play button, name, `size · M:SS`; progress bar (press/drag seeks on release), `M:SS / M:SS` (H:MM:SS over an hour); compact volume (slider on hover, committed on release) and mute; rate button (`1x`… tooltip "Playback speed: 1.5x", accent when ≠1), star, download. ←/→ ±5 % go to the card under the pointer (`audio::Local::key`, wired in `app.rs` like the video players). Data from Daily use 25's `audio_player` selector. - **Group icon crop** (`dms/group_settings.rs`, `AssetCropModal.tsx` CHANNEL_ICON / `ImageCropModal.tsx`): "Crop group icon" with the description, round mask (rgba(47,49,54,.6) + 5 px white ring), drag, zoom 1–3 (slider/wheel), rotate clockwise; Reset / Cancel (drops the pick) / "Skip cropping" (only square ≤1024, as `canSkipOriginalAssetImage`) / "Save icon" (crop at source resolution, ≤1024 px, PNG). Untouched + skippable Save acts as Skip (`handleSave`). The PNG is named by the shell via `LocalFiles::keep_pasted` → `Message::Cropped(FileRef)`. Unreadable pick → "Unsupported icon format"; SVG goes as picked. Refusals now show `IconRefusal` messages from 22a (incl. animated). ## Tests - `tests/attachment_actions.rs`: `viewer_toolbar_items_by_permission`, `delete_confirm_shift_skips`, `saved_media_modal_validation`, `group_icon_crop_and_skip` (+ routing check). - `tests/audio_player.rs`: `audio_seek_and_rate`. - Goldens (`tests/screenshots.rs`): new `media_viewer_toolbar`, `attachment_hover_toolbar`, `audio_player_playing`; redrawn `media_viewer` (new toolbar buttons) and `attachment_file_card` (new audio card layout). Drawn on lavapipe in `fluxer-native-shots:u2204`; the whole suite (132) passed there before the update, with exactly these 5 failing. References copied to `docs/screenshots/`, README rows added. No Electron side-by-side capture (no test account here); dimensions are from the CSS files named above. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No FLUXER_DESKTOP_TESTS tests apply. ## Deviations / notes for review - Files outside the task list, kept minimal: `screens/main/mod.rs` (route Favorite/Delete/audio drags, viewer `act`, overlays: lightbox now drawn *under* the message confirms/forward modal so Delete/Forward from the viewer are visible; saved-media and crop modals), `messages.rs` (map new attachment messages), `media.rs` (`audio::Local`), `message_row.rs` (pass it), `forward.rs` (`media` field), `app.rs` (`Local::saved_media`, crop PNG naming, ←/→ for audio), `dms/mod.rs` (`IconRead` now carries bytes), `testing/offscreen.rs` (`render_with_cursor` for the hover golden). - Merge of 33 into dailyuse conflicted in `dms/mod.rs` (DM list X): kept 33's group → "Leave group" confirm and dailyuse's DM → close at once (`useDMListItemHandlers.tsx:139-143`); fixed 33's friends test expecting `confirmed: false` for the DM X. - The play button stops rather than pauses (store has no pause for attachments). Voice messages keep the ordinary card (no 32-bar waveform yet). The volume slider shows while the card is hovered rather than the volume control itself. - The cropped icon is a `FileSource::Clipboard` FileRef; the runtime's `EditGroupDmIcon` (Task 28) must read clipboard sources. Closes #527 Closes #376 Closes #378 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Core table tests for the audio attachment player and an app test that plays a
three-minute Ogg Opus file (fixtures/media/three_minutes.ogg, a 440 Hz tone made
with ffmpeg) past 30 s of virtual time on the NullHost.

Refs #513

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
PlayAttachment opens a media-playback player (range streaming, as videos)
instead of FetchMedia + PlayClip; AudioPlayerModel per attachment with position,
duration, rate and the shared media volume; SeekAttachment and
CycleAttachmentRate ([1, 1.5, 2, 0.75], voice messages [0.75, 1, 1.5, 2]);
StopAttachment closes the player (#352). The attachment's player counts against
MAX_VIDEO_PLAYERS. The devserver serves fixtures/media audio files for
attachments of that name.

Refs #513

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings from READY, USER_GUILD_SETTINGS_UPDATE and the patch answers;
immediate menu mutes (guild scalars, whole channel_overrides map for
channels, categories and DMs in @me), mute_config in ms, local expiry
timers, 3 s debounced modal changes, revert on failure, selectors
is_muted / muted_until / level / guild_settings_modal, and the shared
mute menu row (MuteTargetMenuItem.tsx, MuteOptions.ts,
UserGuildSettings.ts, UserGuildSettingsCommands.ts).

Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
format_date_time shifted the end with to_offset, which panics when the
local date leaves year 9999 (a 9999-12-31T23:30Z end read east of UTC).
It now uses checked_to_offset and falls back to UTC. The
event_replaces_guild_settings test now checks the staff override is
really gone instead of an always-true assertion.

Refs #497

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Uses the existing server-shaped fixtures: rest/invite_metadata.json
(POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the
metadata fields), rest/guild.json (POST /guilds, GuildResponse) and
gateway/guild_create.json.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The invite modal (default invite at open, settings clamped to the
server's limits, link, expiry text, friends and group DMs with
Invite -> Sent through SendMessage), can_invite / invite_channel for the
menus, "Create or join a community" (name, static icon, create then
select the system channel once its GUILD_CREATE is in, join through the
accept flow), and "Leave community" (Confirm::LeaveGuild, no Shift
bypass, no delete_messages; hidden for the owner; on success the guild
goes as its GUILD_DELETE would, so a selected one leaves for the DMs).

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dailyuse_ports listed them among the stubs that do nothing.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Table tests for the notification decision (Notification.ts:187-256) and
tests for mute consumers: unread, guild pill, hide muted channels, DM
mentions. Stubs for SidebarSection.{category_muted,muted} and
notif_settings::hides_muted_channels so the tests compile.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notif_settings::mentions_me as MessageUtils.isMentioned and
  Notification.isMessageMentionLike: blocked author no, user mention,
  @everyone unless suppressed or in an unjoined thread, own role unless
  suppressed, unmuted DM.
- notification_for follows Notification.ts:187-256: own, blocked, DND,
  SUPPRESS_NOTIFICATIONS, then thread levels (member level, parent level,
  forum new-post level, else only mentions) or mute at any level and the
  effective level.
- read_state::unread is false for a muted channel (mention counts kept);
  has_unread_messages keeps the raw answer for the new-messages bar and
  the thread menu's Mark as read.
- channel_tree: category_muted and muted rows; hide muted channels per
  guild (default_hide_muted_channels without an entry), unless selected,
  connected or with a mention; all-hidden categories hidden.
- DmRowModel.muted from the @me override; a thread is muted by its
  membership or its parent at any level.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Own presence from the user settings; SetStatus / SetCustomStatus write only
their fields (optimistic, reverted on failure); reset timer; idle and afk
from CoreEvent::Idle; op 3 whenever the computed presence changes; status
popout, custom status modal and custom status selectors.

Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
menus::{channel, category, guild} build the original's desktop menus
(AM/ChannelContextMenu.tsx, ChannelMenuData.tsx:429-632,
CategoryMenuData.tsx:263-339, GuildMenuData.tsx:314-497) with the "B"
rows of spec 3.2 (a)-(d). MarkCategoryRead and MarkGuildRead ack in
bulk through POST /read-states/ack; CopyId, CopyChannelLink and the
link channel's "Copy link" write the clipboard. Collapsed categories
are synced as the category override's `collapsed`
(UserGuildSettingsCommands.ts:198-246), written debounced 3 s with the
whole override map; "Hide muted channels" likewise. The sidebar reads
notif_settings::is_collapsed and emits UserAction::ToggleCategory
instead of keeping a local set.

New UserAction variants: CopyLinkChannelUrl, OpenNotificationSettings,
OpenFollowChannel (the last two open UI-owned modals).

Refs #503

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A failed reset PATCH was re-sent at once by the same refresh, with no
limit (a request storm while offline or on 4xx/429). Remember the reset
whose write failed and skip it until READY, USER_SETTINGS_UPDATE or a
patch answer brings new settings, as StatusExpiry.handleExpiry does not
retry. The custom status test now asserts the profile popout exists.

Refs #499

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Relationship fixtures are shaped like RelationshipResponse
(packages/schema/src/domains/user/UserResponseSchemas.ts:492 of the
fork): id, type, user, nickname (nullable, always sent),
share_voice_activity, friend_shares_voice_activity.

Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
# Conflicts:
#	crates/fluxer-core/src/app.rs
Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generic confirm draws every daily-use confirm of the store; the
leave confirm (group with "Leave silently", community without); the
friends page with its tabs, search, rows, More menu, empty states and
Add friend form; Settings -> Blocked users; the DM welcome's friend
buttons; the DM list's Friends entry; the group X asks Leave group; the
group settings preview the picked icon (#383).

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six new goldens from the dailyuse scenario's READY
(fixtures/gateway/dailyuse_ready.json): friends_online, friends_pending,
friends_add, friends_empty, blocked_users and leave_group_confirm, with
their reference images and README rows. dm_list, friend_picker,
group_dm_welcome, group_settings and personal_notes_welcome are redrawn:
the DM list now starts with the Friends entry. Rendered on lavapipe in
the fluxer-native-shots:u2204 (Ubuntu 22.04) image like the Linux
runner; the whole suite (129 tests) passes there.

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
menus::user and menus::dm with the rows of GuildMemberContextMenu,
UserContextMenu, DMContextMenu and GroupDMContextMenu that this client
builds; Mention into the composer; Pin DM; Close DM and Open DM (blocked)
confirms; Invite to community; Report message in the message menu.

Refs #504

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/README.md
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/tests/dailyuse_ports.rs
Refs #508

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Nullish string, as packages/schema/src/domains/message/MessageResponseSchemas.ts:29
and EmbedSchemas.ts:33; saved media recognises an item by it
(FavoriteMemeUtils.isFavorited). The existing fixtures already carry it.

Refs #508

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #508

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-ui/src/screens/main/dms/mod.rs
Lightbox toolbar as MediaControls.tsx (Copy media, favourite star, Delete
attachment with Shift skipping the confirm, Forward media with one item,
Reply where the user may send); the attachment hover toolbar of
MediaContainer.tsx (Delete, Download, star); "Add to saved media"
(AddFavoriteMemeModal.tsx); the audio player of InlineAudioPlayer.tsx
(size · M:SS, progress bar seek, ←/→ ±5 %, rate button, volume, star);
"Crop group icon" (AssetCropModal/ImageCropModal: round mask, zoom 1–3,
drag, quarter turns, Skip cropping, Save icon ≤ 1024 px PNG named by the
shell through LocalFiles::keep_pasted). Goldens media_viewer_toolbar,
attachment_hover_toolbar, audio_player_playing added and media_viewer,
attachment_file_card redrawn on lavapipe (fluxer-native-shots:u2204).

Refs #527

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Daily use 37a (a07c4a0, diff 119686f..a07c4a0)

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a clean review worktree: all steps passed (fmt, clippy, deny, core-isolation, parity, test, vendored-tests, screenshot-tests; the three new goldens media_viewer_toolbar, attachment_hover_toolbar, audio_player_playing ran and matched).

What I checked

  • Plan tests exist and assert the spec's values: viewer_toolbar_items_by_permission, delete_confirm_shift_skips (title/body/primary exact, no Shift tip, Shift → confirmed: true), saved_media_modal_validation (name required and ≤ 100, tags ≤ 10 × ≤ 30, trimmed save, saved star → DeleteMeme), audio_seek_and_rate (2.9MB · 3:00, 0:45 / 3:00, ±5 %, rates 1 → 1.5 → 2 → 0.75, "Playback speed: 1.5x", 1:02:05), group_icon_crop_and_skip; the three goldens.
  • Interfaces: delete goes through the existing store confirm (DeleteAttachment { confirmed }), the forward modal is reused (forward::State::for_media → ForwardAttachment); no duplicated actions.
  • Invariants: no new I/O path in fluxer-ui (picture decode/encode is in memory; the cropped PNG is named through the sanctioned LocalFiles::keep_pasted, as the paste path already does); no core changes; no secrets or paths in fixtures; undecodable icon bytes give "Unsupported icon format" rather than a panic.
  • Parity spot-checks against the fork: toolbar order and gaps match MediaControls.tsx:167-375 (incl. Delete after Download, large gap only with Reply/Forward, filled/active star); Shift bypass and confirm strings match useDeleteAttachment.tsx; hover bar order Delete, Download, star matches MediaContainer.tsx:103-166; AUDIO_PLAYBACK_RATES = [1, 1.5, 2, 0.75], ±5 step and meta/time strings match InlineAudioPlayer.tsx:159-170,380-390; crop zoom 1–3, max 1024, skip rule and untouched-save-sends-original match AssetCropModal.tsx:155-245 / ImageCropModal.tsx; name ≤ 100 / alt ≤ 500 / 10 tags match MemeFormFields.tsx and LimitConstants.ts:72.
  • Review Focus 5 (delete attachment confirms, Shift skips) is met on the hover bar, the thread panel and the lightbox.

Findings (none blocking)

  1. minor (parity): after a successful delete from the lightbox the original closes the viewer (MediaViewerModal.tsx:455-461, onDeleted → closeMediaViewer); here the lightbox stays open on whatever item now sits at that index.
  2. minor (parity): lightbox rights() limits Forward to Default/Reply messages, whereas the viewer's canForwardMessage only excludes client system messages; Reply ignores the original's interactionsBlocked (system DM), guild disabledOperations SEND_MESSAGE and verification checks (MessageActionUtils.tsx:186-215).
  3. minor (test): in viewer_toolbar_items_by_permission, the "Show the delete button" off case is assert!(… || app.settings.is_none()); the test app has no settings, so the case asserts nothing. Give the app settings so the setting is actually exercised.
  4. minor (process): the deferrals recorded in docs/parity/textchat.md (play stops instead of pausing; no voice-message waveform bars) and the Task 28 dependency (runtime EditGroupDmIcon must read FileSource::Clipboard) should each get a follow-up issue linked from this PR before merge, per CLAUDE.md.
  5. minor: the lightbox is now drawn under the profile popout, leave/update modals and follow modal, not only under the confirms and forward modal; a popout opened before the lightbox would now cover it. Consider placing only message_actions_over and add_saved_media above it.
  6. minor (perf): the picked icon is decoded to RGBA (and re-rotated) synchronously in update; a 10 MiB picture can stall a frame. Fine for now; could move to Task::perform later.

Verdict: APPROVED — no blocking findings, local CI green.

## Independent review: Daily use 37a (a07c4a0, diff 119686f..a07c4a0) **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a clean review worktree: **all steps passed** (fmt, clippy, deny, core-isolation, parity, test, vendored-tests, screenshot-tests; the three new goldens `media_viewer_toolbar`, `attachment_hover_toolbar`, `audio_player_playing` ran and matched). **What I checked** - Plan tests exist and assert the spec's values: `viewer_toolbar_items_by_permission`, `delete_confirm_shift_skips` (title/body/primary exact, no Shift tip, Shift → `confirmed: true`), `saved_media_modal_validation` (name required and ≤ 100, tags ≤ 10 × ≤ 30, trimmed save, saved star → `DeleteMeme`), `audio_seek_and_rate` (`2.9MB · 3:00`, `0:45 / 3:00`, ±5 %, rates 1 → 1.5 → 2 → 0.75, "Playback speed: 1.5x", `1:02:05`), `group_icon_crop_and_skip`; the three goldens. - Interfaces: delete goes through the existing store confirm (`DeleteAttachment { confirmed }`), the forward modal is reused (`forward::State::for_media` → `ForwardAttachment`); no duplicated actions. - Invariants: no new I/O path in fluxer-ui (picture decode/encode is in memory; the cropped PNG is named through the sanctioned `LocalFiles::keep_pasted`, as the paste path already does); no core changes; no secrets or paths in fixtures; undecodable icon bytes give "Unsupported icon format" rather than a panic. - Parity spot-checks against the fork: toolbar order and gaps match `MediaControls.tsx:167-375` (incl. Delete after Download, large gap only with Reply/Forward, filled/active star); Shift bypass and confirm strings match `useDeleteAttachment.tsx`; hover bar order Delete, Download, star matches `MediaContainer.tsx:103-166`; `AUDIO_PLAYBACK_RATES = [1, 1.5, 2, 0.75]`, ±5 step and meta/time strings match `InlineAudioPlayer.tsx:159-170,380-390`; crop zoom 1–3, max 1024, skip rule and untouched-save-sends-original match `AssetCropModal.tsx:155-245` / `ImageCropModal.tsx`; name ≤ 100 / alt ≤ 500 / 10 tags match `MemeFormFields.tsx` and `LimitConstants.ts:72`. - Review Focus 5 (delete attachment confirms, Shift skips) is met on the hover bar, the thread panel and the lightbox. **Findings** (none blocking) 1. *minor (parity)*: after a successful delete from the lightbox the original closes the viewer (`MediaViewerModal.tsx:455-461`, `onDeleted` → `closeMediaViewer`); here the lightbox stays open on whatever item now sits at that index. 2. *minor (parity)*: lightbox `rights()` limits Forward to Default/Reply messages, whereas the viewer's `canForwardMessage` only excludes client system messages; Reply ignores the original's `interactionsBlocked` (system DM), guild `disabledOperations` SEND_MESSAGE and verification checks (`MessageActionUtils.tsx:186-215`). 3. *minor (test)*: in `viewer_toolbar_items_by_permission`, the "Show the delete button" off case is `assert!(… || app.settings.is_none())`; the test app has no settings, so the case asserts nothing. Give the app settings so the setting is actually exercised. 4. *minor (process)*: the deferrals recorded in `docs/parity/textchat.md` (play stops instead of pausing; no voice-message waveform bars) and the Task 28 dependency (runtime `EditGroupDmIcon` must read `FileSource::Clipboard`) should each get a `follow-up` issue linked from this PR before merge, per CLAUDE.md. 5. *minor*: the lightbox is now drawn under the profile popout, leave/update modals and follow modal, not only under the confirms and forward modal; a popout opened before the lightbox would now cover it. Consider placing only `message_actions_over` and `add_saved_media` above it. 6. *minor (perf)*: the picked icon is decoded to RGBA (and re-rotated) synchronously in `update`; a 10 MiB picture can stall a frame. Fine for now; could move to `Task::perform` later. **Verdict: APPROVED** — no blocking findings, local CI green.
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-ui/src/screens/main/dms/mod.rs
#	crates/fluxer-ui/src/screens/main/modals/mod.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	docs/screenshots/README.md
Author
Owner

Merged into dailyuse and textchat at 1089e6a1 (combined merge).

Merged into `dailyuse` and `textchat` at 1089e6a1 (combined merge).
charles closed this pull request 2026-11-15 09:58:48 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.