Daily use 29: Channel, category and guild context menus (#518) #571
Closed
charles
wants to merge 0 commits from
dailyuse-29-ui-channel-guild-menus into dailyuse
pull from: dailyuse-29-ui-channel-guild-menus
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!571
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-29-ui-channel-guild-menus"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-17-core-channel-guild-menus
What
Right-click menus of the sidebar and the guild rail (spec §3.2 (a)-(d)), drawn from the store's
MenuModels of Daily use 17:screens/main/menus/{mod,channel,guild}.rs:Target::{Channel, Category, Guild},menus::State(inLocal::menus),menus::Message::{Open, Close, Submenu, Pick(row), PickSub { row, item }},menus::model,menus::items(the sharedMenuModel -> context_menu::Itemconversion: order kept, one separator between groups, disabled rows, the "Hide muted channels" checkbox, the mute row as a submenu whose own click mutes until turned back on),menus::update,menus::over.sidebar.rs), a guild icon (guild_rail.rs) and the guild header (the sidebar's guild name, the original'sGuildHeader) opens the menu at the cursor (via the existingmessage_actions::row_input, which corrects for the scrollable's offset).TextCopyCommands.copywithout its own text,GuildMenuData.tsx:265-268), 3 s, through the forum's existing toast (forum::toast_over, madepub(crate)).app.rs) and a click outside close the menu; opening it closes the participant/stream menus and vice versa.ContextMenuIcons.tsx(Eye, UserPlus, Link, Bell, BellSlash for Unmute, CaretDown/CaretRight for collapse, SignOut, Snowflake, ChatCircle); two new Phosphor iconsmegaphone-simple-fill(Follow channel) andarrow-square-out-regular(Open link) from@phosphor-icons/core2.1.1.Tests
crates/fluxer-ui/tests/menus_channel_guild.rs(dailyuse READY):right_press_opens_menu_at_cursor(sidebar header, category, channel rows, voice rows, rail icon; position = cursor; the opened menu draws),model_to_items_preserves_order_and_separators,disabled_category_mark_read_does_nothing,mute_submenu_click_parent_mutes_forever(click in the drawn menu, then the 15-minute duration from the submenu),voice_row_open_chat,copy_rows_show_their_toast,outside_click_closes.channel_menu,channel_menu_mute_submenu,category_menu,guild_menu(dailyuse READY), rendered on lavapipe in thefluxer-native-shots:u2204image; the whole screenshot suite (127) passes there. Reference images indocs/screenshots/, rows in its README. No Electron side-by-side is available here; dimensions come fromContextMenu.module.cssviawidgets::context_menu(Daily use 8).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. NoFLUXER_DESKTOP_TESTStests are involved.Deviations / notes for the reviewer
header.rsis untouched: the "guild header" of the original is the sidebar's guild name (GuildHeader.tsx), so the trigger is insidebar.rs.app.rs(theLocal::menusfield and one Escape arm),forum/mod.rs(toast_overmadepub(crate)to reuse the existing toast),tests/voice_sidebar.rs(one assertion said "no right-press reacts in a collapsed category"; it now checks for no participant menu, since rows open their own menus),crates/fluxer-ui/README.md.OpenNotificationSettings-> Task 30,Invite(Create)-> 34b,LeaveGuildconfirm -> 33) are sent as is.docs/parity/dailyuse.mddoes not exist yet (Task 40); no parity rows added here.Closes #518
🤖 Generated with Claude Code
Uses the existing server-shaped fixtures: rest/invite_metadata.json (POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the metadata fields), rest/guild.json (POST /guilds, GuildResponse) and gateway/guild_create.json. Refs #502 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>menus::{channel, category, guild} build the original's desktop menus (AM/ChannelContextMenu.tsx, ChannelMenuData.tsx:429-632, CategoryMenuData.tsx:263-339, GuildMenuData.tsx:314-497) with the "B" rows of spec 3.2 (a)-(d). MarkCategoryRead and MarkGuildRead ack in bulk through POST /read-states/ack; CopyId, CopyChannelLink and the link channel's "Copy link" write the clipboard. Collapsed categories are synced as the category override's `collapsed` (UserGuildSettingsCommands.ts:198-246), written debounced 3 s with the whole override map; "Hide muted channels" likewise. The sidebar reads notif_settings::is_collapsed and emits UserAction::ToggleCategory instead of keeping a local set. New UserAction variants: CopyLinkChannelUrl, OpenNotificationSettings, OpenFollowChannel (the last two open UI-owned modals). Refs #503 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Independent review: Daily use 29 (channel, category and guild menus)
Reviewed
6db33abf..af170c2cold. LocalFLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed (exit 0).What I checked
right_press_opens_menu_at_cursor(sidebar guild header, category, text and voice rows, rail guild icon only; position equals cursor),model_to_items_preserves_order_and_separators(labels equal to the core builders for all four targets, no leading or trailing separator),mute_submenu_click_parent_mutes_forever(parent click givesMute(Channel, Forever); hover opens 9 durations; the first givesMinutes(15)),voice_row_open_chat. All four goldens are present (channel_menu,channel_menu_mute_submenu,category_menu,guild_menu) withdocs/screenshotscopies. There are extra tests for the copy toasts and for closing on an outside click.fluxer_core::menus::{channel, category, guild, MenuModel, MenuRow}) as it is. The sharedMenuModel → context_menu::Itemconversion is inmenus/mod.rs, as the plan says. Every core item id (copy-*,mark-read,open-chat,open-link,follow-channel,invite-*,unmute,notification-settings,toggle-collapse*,leave-community,hide-muted-channels) is mapped.Effect::Clipboard(menus/channel.rsreduce). No new fixtures, no secrets. A pick on a stale or out-of-range index returnsNoneand does not panic.ChannelMenuData.tsx:94-104), "Category ID copied" (CategoryMenuData.tsx:66-68), "Link copied to clipboard" (CommonMessageDescriptors.ts:394), "Copied to clipboard" for the community ID (TextCopyCommands.copy,GuildMenuData.tsx:266). The guild header opensGuildContextMenu(GuildHeader.tsx:65-111). A click on the submenu trigger acts (ContextMenu.tsx:485-497). All match.Findings
menus::pickstamps the toast withlocal.messages.now_unix, butShell::updateonly refreshes that value on aSnapshot(app.rs:528), not beforemain::update. A copy does not dirty the store, so how long the toast stays depends on when the next snapshot arrives: it can vanish right away in a busy guild, or stay until the next gateway event in a quiet one. The tests setnow_unixby hand, so they don't catch this. Fix: refreshnow_unixbeforemain::update(or stamp in the shell), plus a timer to hide the toast after 3 s. The forum toast already has the second half of this problem.pickcloses on every row, toggles included. In the original,CheckboxItemdefaults tocloseOnChange = falseandcloseOnClick={false}(ContextMenu.tsx:624-646,DataMenuRenderer.tsx:86-96), so the menu stays open with the box toggled.preserveInitialMarkAsReadVisibility; spec: "unread when opened"). Picks stay consistent with what is drawn, so no wrong action is sent. This belongs to Task 17's builder signature; follow-up material.Leave communitydanger check is skipped when the row is absent, anddisabled_category_mark_read_does_nothingis skipped when Lobby has unreads. They pass vacuously.menus/{user,dm}.rs, which needpub modlines andTargetvariants in this task'smenus/mod.rs, but Task 31 does not list 29 underDepends on. The orchestrator should serialise them.None of these breaks an interface or an invariant, or touches user data. Suggest follow-up issues for 1 to 3.
Verdict: APPROVE (0 blocking findings, local CI green).
Review: Daily use 29 (
git diff 6db33ab..af170c2)Checked
right_press_opens_menu_at_cursor,model_to_items_preserves_order_and_separators,mute_submenu_click_parent_mutes_forever(parent click givesMute(Channel, Forever), first duration givesMinutes(15)) andvoice_row_open_chatare all present. The goldenschannel_menu,channel_menu_mute_submenu,category_menuandguild_menuare inscreenshots.rs,fixtures/golden/anddocs/screenshots/.app.rs) and a click outside all work. The rows come fromfluxer_core::menus::{channel,category,guild}in the model's order, with separators between groups.Nonefor an out-of-range index, so they cannot panic.ChannelMenuData.tsx:94-104,264-280,399-402,CategoryMenuData.tsx:66-68,236-239,CommonMessageDescriptors.ts:394). The guild ID usesTextCopyCommands.copy's "Copied to clipboard" (GuildMenuData.tsx:265-268). The mute group comes last inCategoryContextMenu.tsxandGuildContextMenu.tsx, and the row icons matchContextMenuIcons.tsx(Eye fill, Snowflake regular, Link bold, ArrowSquareOut regular, UserPlus, Bell, SignOut, ChatCircle).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: green (EXIT=0) ataf170c2.Findings
menus/mod.rs:403-407,pickstamps the copy toast withlocal.messages.now_unix. That value is only refreshed when a snapshot arrives (app.rs:528). The pick's own action (CopyIdorCopyChannelLink) is dispatched, which setsdirty(runtime.rs:823) and publishes a snapshot, and that snapshot setsnow_unixto the real time. So if the previous snapshot was 3 s or more old (any quiet moment), the toast has already expired when it would first be drawn, and "Channel ID copied" and the others never appear. The tests setnow_unixby hand, so they do not catch this. Fix: stamp with the wall clock (app.rs'snow_unix()), or start the toast's clock on the next snapshot, asforum::State::syncdoes.disabled_category_mark_read_does_nothingtests nothing in this fixture. Lobby holds the unread #general, so its "Mark as read" is enabled (see thecategory_menugolden) and theifbody never runs. Pick a category with nothing unread, or assert that the row is disabled.preserveInitialMarkAsReadVisibility: true(GuildContextMenu.tsx), so its "Mark as read" stays while the menu is open. Here the row disappears if the guild becomes read during that time.mod.rs:550-561) does not clearlocal.menus.open, although opening a participant menu does. The context-menu backdrop makes it hard to hit in practice.Verdict: changes requested (1 blocking finding: the copy toasts usually do not show).
Review round 1 fixes, in
b696526:menus::State::sync(now_unix), called from the shell on every snapshot, starts its 3 s clock, asforum::State::syncdoes. The copy's own snapshot therefore starts it at the real time. Test:copy_toast_starts_with_the_next_snapshot(stale clock 1000, snapshot at 5000, shows until 5003). It fails to build on the old code.State::toast_until()gives the end time, and the shell runs a one-shotToastAttimer while a toast runs (a short-lived thread, like the image retry timer). When it fires,UiMessage::ToastDuemoves the screen clock on and callssync, which removes the toast. The forum toast is unchanged.Open::keep_mark_readrecords whether the guild menu opened with the row.menus::open_modelputs it back first while that menu stays open, aspreserveInitialMarkAsReadVisibility: truedoes. Test:guild_mark_read_stays_while_the_menu_is_open.stream_menu_closes_the_channel_menu.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally. On the first run, thefluxerlib tests crashed with SIGSEGV at process exit after all 82 passed. That is the known flake (#549, #304), and the rerun passed.Independent review: Daily use 29 (
b696526, diff 6db33ab..origin/dailyuse-29-ui-channel-guild-menus)Checked
right_press_opens_menu_at_cursor,model_to_items_preserves_order_and_separators,mute_submenu_click_parent_mutes_forever(Forever on the parent,Minutes(15)for the first duration, 9 durations),voice_row_open_chat. The goldenschannel_menu,channel_menu_mute_submenu,category_menuandguild_menuare inscreenshots.rs,fixtures/golden/anddocs/screenshots/. The extra tests for the earlier review findings are present too.forum::toast_over. Escape (app.rs) and an outside click close the menu.retry_due), no fixtures added, no secrets, and an unknown target gives an empty model with no panic.ChannelMenuData.tsx:94-104,CategoryMenuData.tsx:66-68,CommonMessageDescriptors.ts:394andTextCopyCommands.ts:11("Copied to clipboard" for the community ID).ContextMenuIcons.tsx: Eye fill, UserPlus fill, ArrowSquareOut regular, Snowflake regular, CaretDown bold.preserveInitialMarkAsReadVisibilityis checked below.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed onb696526(all steps, including the four new goldens on lavapipe).Findings
ChannelContextMenu.tsx:31passespreserveInitialMarkAsReadVisibility: true,ChannelMenuData.tsx:217-218).menus::open_modelkeeps the row only forTarget::Guild. For a channel, the open menu is rebuilt from the liveread_state::has_unread_messages, so the row disappears when the channel is acked while the menu is open (for example, the selected channel getting a message) and appears when a message lands in an unread-when-closed channel. Apart from the parity gap, the rows below it move by one.Pick(index)is resolved against a model rebuilt from the newest store (pick->open_model->action_at), so a snapshot between the draw and the click makes a click on "Notification settings" run the mute row or "Copy channel link" instead. Fix: record the opening state for channels as for guilds (and both ways, see 2). Also add a test where the channel becomes read and then unread while its menu is open.initialHasGuildUnreadboth ways (GuildMenuData.tsx:157-158): a guild that was read when its menu opened shows no "Mark as read" even if it becomes unread while the menu is open. Here,open_modeladds the row when it was there at opening, butfluxer_core::menus::guildalso adds it when the guild becomes unread later. This is the same row-shift problem as 1, on a smaller scale.screens/main/header.rsfor the guild header. The trigger is on the sidebar title insidebar.rsinstead, which is where the guild header is drawn. That is fine, and the test covers it.Verdict: changes requested (1 blocking: channel "Mark as read" must keep its opening state; ci green).
Daily use reviewer (independent)
Round 2 fixes (commit
67276ce):Open::keep_mark_readis replaced byOpen::mark_read: Option<bool>, the opening state for channel and guild menus (Nonefor a category, whose row is always there and only toggles disabled).open_modelnow keeps the row exactly as it was when the menu opened: it adds it back (channel menu: first row of the second group, after a voice channel's "Open chat"; guild menu: first row) if the target became read, and removes it if the target became unread. Rows keep their indices, soPick(index)runs the row that was drawn. Tests (failing before the fix):channel_mark_read_stays_while_the_menu_is_open(drawn rows unchanged after MarkRead; picking the drawn "Notification settings" index gives OpenNotificationSettings; the drawn "Mark as read" still gives MarkRead) andchannel_read_when_opened_gains_no_mark_read(a MESSAGE_CREATE under the open menu adds no row).initialHasGuildUnread). Test:guild_read_when_opened_gains_no_mark_read.Local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed.Independent review: Daily use 29 (
67276ce, diff 6db33ab..origin/dailyuse-29-ui-channel-guild-menus)Checked
right_press_opens_menu_at_cursor,model_to_items_preserves_order_and_separators,mute_submenu_click_parent_mutes_forever(row click ->Mute(Channel, Forever), first duration ->Minutes(15), 9 durations),voice_row_open_chat(row 0 ->SelectChannel) and the goldenschannel_menu,channel_menu_mute_submenu,category_menu,guild_menuare all present and assert what the plan asks for. The new tests (channel_mark_read_stays_while_the_menu_is_open,channel_read_when_opened_gains_no_mark_read,guild_read_when_opened_gains_no_mark_read) cover the previous blocking finding.fluxer_core::menus::{channel, category, guild}, so the order is the core's.retry_due's shell-side subscription pattern inapp.rs. There are no secrets, tokens or paths in the code or tests. Nothing panics on server data: a missing target or guild gives an empty model and nothing is drawn, and stale indices resolve toNoneinaction_at.preserveInitialMarkAsReadVisibility: trueis passed byChannelContextMenu.tsx:31andGuildContextMenu.tsx:26but not byCategoryContextMenu. This matchesOpen::mark_read(Nonefor a category).ChannelMenuData.tsx:95), "Channel ID copied" (:103), "Category ID copied" (CategoryMenuData.tsx:67), "Link copied to clipboard" (CommonMessageDescriptors.ts:395) and "Copied to clipboard" (TextCopyCommands, guild ID) all match.CategoryContextMenu.tsx:27-39), as the golden does.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree: all steps passed (exit 0).Findings
open_modelputs "Mark as read" back at hard-coded group indices (guild group 0, channel group 1). This is correct for today's core builders, but it will silently break if the core's group layout changes. A shared constant or a core helper would be safer. Not blocking.overdraws nothing butstate.openstaysSomeuntil the next Escape or open. Harmless.header.rsunder Modify, but the guild header trigger is insidebar.rs(where the title is built). The behaviour is there, so this is fine.Verdict: approve. No blocking findings, and local CI is green.
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed