Daily use 19: core quick switcher (#505) #568
Closed
charles
wants to merge 0 commits from
dailyuse-19-core-quick-switcher into dailyuse
pull from: dailyuse-19-core-quick-switcher
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!568
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-19-core-quick-switcher"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Daily use 19: the quick switcher in
fluxer-core(spec §3.7, §6.2 "Quick switcher").Stacked on: origin/dailyuse-13-core-honour-mutes
What it does
switcher::switcher(&App) -> SwitcherModel { placeholder, mode_header, sections: Vec<SwitcherSection { header, rows: Vec<SwitcherRow { kind, title, subtitle, icon: SwitcherIcon, meta, unread, mentions }> }>, selected, empty }, as in the Interfaces block.SwitcherAction::{Open, Close, Toggle, Edit, Up, Down, Select(Option<usize>)}driveapp.switcher.generateDefaultResults).SearchTextMatching.ts:41-47andForwardDestinationSearch.ts(exact 10, prefix 7, substring 5, every word 3, fuzzy 1; channel context and whole-query terms; users' confusable/diacritic fuzzy fallback). Ties between users are broken alphabetically.@(in a guild: its friends and members, header "Searching friends and members of {name}"),@@,#,!,*with the original's headers. With no text after the prefix: recent authors, or channel listings scored 7 / 6 (voice in a text listing) +3 for a recently used channel, capped at 10 (7) (QuickSwitcherResultGenerators.ts:84-90,410-416), or all guilds./channels/...link on this instance's web app host comes first as "Go to message".selectedindexes rows, and headers are not rows, so they are skipped. Select opens the row:SelectGuild+SelectChannel,MessageUserfor a user without a DM, orJumpToMessagefor a message link. It then closes the switcher.recentlyVisitedChannels): loaded from[navigation]at startup. Every change of the selected channel records a visit (newest first, deduped, max 20) and writes it withPersistOp::Navigation.Tests
crates/fluxer-core/tests/switcher.rs: all 12 tests from the plan (empty_query_sections_and_caps,previous_excludes_current_and_dedups,previous_survives_restart,prefix_modes_and_headers,category_limits_5_then_100,scoring_exact_prefix_substring_words_fuzzy,listing_scores_and_recent_bonus,diacritics_fold,unread_excludes_muted,selection_wraps_skipping_headers,link_row_first,enter_selects_and_records_visit), plus unit tests for the fold tables, the whole-query term and prefix parsing. I watched the tests fail against stubs, then pass.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally. No desktop tests apply (core only).Deviations
app.rs, afterui.reduce, from the change ofui.selected_channel, not inchat/navigation.rs. That is the only place that sees every selection, including the channel a guild switch restores, as the original's route reaction does. Theapp.rschanges are wiring only: the rows read before the event, loading the visits, routing the follow-ups, and recording the visit. While the switcher's ownSelectGuild+SelectChannelis on its way, the guild's restored channel is not recorded.chat_persist::navigation_round_trip_and_20_visits_kept(opening #general is now a visit) anddailyuse_ports(the switcher actions are no longer no-ops).ChannelFrecency, so "recently used" means "in the recent visits", and no frecency weights are applied.fluxer://deep links ("Open link") are not parsed, since the native client has no protocol handler.MessageUser { confirmed: true }, because the original'sensureDMChanneldoes not confirm.Closes #505
🤖 Generated with Claude Code
Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 19 (core quick switcher)
I reviewed
61e2eba..3a8541d(switcher.rs, theapp.rswiring,tests/switcher.rsand the two updated tests).Findings
1. BLOCKING: the
heading_toguard can get stuck, and then later visits are not recorded (crates/fluxer-core/src/switcher.rs,follow_selection/go_to)go_tosetsheading_to = Some(channel)for every channel, DM or link row.follow_selectionchecksbefore == Some(channel_id)and returns early before it clears the guard. If the selected row is the channel that is already open, nothing changes:SelectGuild(same)does nothing andSelectChannel(X)keeps X.heading_tothen staysSome(X). From then on, every selection of another channel hitstarget != channel_idand is dropped. Visits are lost (in memory and in the[navigation]write) until the user opens X again.This is easy to reach. A query search lists the current channel (only "Previous channels" leaves it out), so typing the open channel's name and pressing Enter is enough. I reproduced it with a throwaway test (not committed):
The original records every route change (
SelectedChannel.tsupdateRecentVisit), so this loses user data and breaks parity. Fix: clearheading_towhen the target is already selected. Either set it ingo_toonly when the target differs fromui.selected_channel, or havefollow_selectionclear it whenever the channel now selected equals the target, before thebefore == Some(channel_id)early return. Add a regression test.2. Minor: the "Unread channels" level treats
INHERIT/NULL(and a guild with no settings) as all messages (unread_in_current_guild)The original's
getGuildMessageNotificationsresolvesINHERIT/NULLto the guild'seffectiveMessageNotifications, i.e. the guild's default (UserGuildSettings.ts:368-374). A guild whose default is "only mentions" therefore has no unread section in the original, but has one here.fluxer-protodoes not carrydefault_message_notificationsyet, so this gap is not this task's to close. Please open afollow-upissue for it.3. Minor: the user tie-break comparator differs slightly (
compare_ranked)The original's
compareSearchResultschecks onlyleft.type === 'user', which makes it non-transitive. Comparing by name only when both results are users is the sound reading, and the results are the same for user-only lists. I agree with the implementer's choice; no change needed.4. Minor: the plan put visit recording in
chat/navigation.rs; it is inapp.rs(follow_selectionafterui.reduce)This deviates from the plan, but it is only wiring and it works. Task 20, which depends on this task, also owns that area, so no other task's file ownership is affected.
Checks
HISTORY_HIDDEN_FROM_SECTIONS3, limits 5/100, the 10/7/5/3/1 scores, listing scores 7/6 with +3 capped at 10/7, the headers and the strings.SwitcherAction,switcher(&App) -> SwitcherModel { placeholder, mode_header, sections, selected, empty },SwitcherSection { header, rows },SwitcherRow { kind, title, subtitle, icon, meta, unread, mentions },SwitcherIconandscore_search_termall exist as written.fluxer-coregains no new dependencies (urlwas already used) and no I/O. Indexing is safe (one-byte prefixes,getlookups, guarded slices). There are no secrets. Visits are deduped by channel and guild, newest first, ≤ 20, and written withPersistOp::Navigationalongside the storedselected_channels.scoreSearchTerm/consumeBestSearchTerm/buildChannelSearchTerms(SearchTextMatching.ts),searchChannels(context weight 0.5, cap 6, voice penalty 1 with floor 0.5, frecency cap 10/7),listChannels(voice only in a text listing outside a guild),generateDefaultResults(history 8−1, the first 3 hidden from the other sections, mentions newest first),parsePrefix(@@first, trim), andSelectedChannel.updateRecentVisit(dedup by channel and guild, 20).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: green (exit 0) at3a8541d, fmt, clippy, deny, isolation, parity and all tests including screenshots.Verdict: changes requested. Finding 1 is blocking: the stuck
heading_toguard loses recent visits.🤖 Generated with Claude Code
Review round 1, fixed in
f1c41cb(localFLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen):follow_selectionnow clearsheading_towhenever the selected channel is the target, before the unchanged-selection early return, so choosing the already-open channel from a search no longer swallows later visits. Regression testselecting_the_open_channel_keeps_recording_visits(tests/switcher.rs: open general, search "general", Enter, then SelectChannel(news): news is recent_visits[0] and the[navigation]write carries it); it failed before the fix.default_message_notificationsin fluxer-proto first.Independent review, round 2: Daily use 19 (core quick switcher)
I reviewed
61e2eba..f1c41cb:switcher.rs, theapp.rswiring,tests/switcher.rs, and the edits tochat_persist.rsanddailyuse_ports.rs. I read it without relying on the implementer's notes.Checks
selecting_the_open_channel_keeps_recording_visitsreproduces round 1's blocking scenario.SwitcherAction(from 11a) is unchanged.switcher(&App) -> SwitcherModel { placeholder, mode_header, sections: Vec<SwitcherSection { header, rows: Vec<SwitcherRow { kind, title, subtitle, icon: SwitcherIcon, meta, unread, mentions }> }>, selected, empty: Option<(String, String)> }matches the plan exactly. Visits load from[navigation]inPersisted, are written withPersistOp::Navigation, and carry the storedselected_channelsunchanged, so Task 20's half of the table is not clobbered.notif_settingsclock. The tests build on the existing READY and USER_GUILD_SETTINGS_UPDATE fixtures, and no new fixture is added. Byte slicing is safe because the prefix characters are ASCII. Link parsing and the fuzzy matcher cannot panic on server data. There are no secrets, tokens or paths.listChannelsmatch (QuickSwitcherResultGenerators.ts:80-91,:405-433).scoreSearchTerm,consumeBestSearchTermandfuzzySearchmatch (SearchTextMatching.ts:30-66).isUnreadInCurrentCommunityandgenerateDefaultResultsmatch (:144-189).SelectedChannel.ts:150-190.switchTomatches for users (ensureDMChannel, no confirm), voice channels and guilds (QuickSwitcherCommands.tsx:63-91).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed.Round 1 fix
heading_tois now cleared before the early return for an unchanged selection. I traced the switcher's follow-ups (SelectGuildthenSelectChannel) throughApp::apply.ui.rssetsselected_channelunconditionally onSelectChannel, so every path that setsheading_tonow clears it. When the guild's last channel is already the target,SelectGuildclears it and the visit is recorded only once. Fixed.Findings
QuickSwitcher.tsx:573-581adds an "Open link" row for app-protocol deep links (isAppDeepLink). The native switcher only builds "Go to message" for/channels/…URLs. The native client has no app-protocol handler yet, so this is acceptable as is. It could get alaterparity row.default_message_notifications.Verdict: approved. There are no blocking findings, and local CI is green.
Review round 3 (independent, cold read) — Daily use 19 quick switcher
Scope:
git diff 61e2eba..origin/dailyuse-19-core-quick-switcher(f1c41cb).Checked
crates/fluxer-core/tests/switcher.rsand assert the spec values (caps 3/7, ≤5 then 100, scores 10/7/5/3/1/0, listing 7/6 with +3 capped at 10/7, strings "Previous channels", "Mentions", "Unread channels", the mode headers, the placeholder, "No matches found" and its hint). There is also the regression testselecting_the_open_channel_keeps_recording_visits.SwitcherAction::{Open, Close, Toggle, Edit, Up, Down, Select(Option<usize>)},switcher(&App) -> SwitcherModel { placeholder, mode_header, sections, selected, empty },SwitcherSection { header, rows }andSwitcherRow { kind, title, subtitle, icon, meta, unread, mentions }all match the plan as written. Visits load from[navigation]at startup and are written back withPersistOp::Navigation. The storedselected_channelsare preserved, newest first, deduped, ≤ 20.query[1..]follows an ASCII prefix. A link row needs the host of the instance or the web app. No secrets.SearchTextMatching.ts:41-47scoring andbuildChannelSearchTerms(only the first space becomes( |-)) match.QuickSwitcherResultGenerators.ts:84-95andlistChannels(:410-416) match, including the min(base+3, base>=7?10:7) cap.generateDefaultResultsmatches: history cap 8-1, the first 3 hidden from the other sections, caps 3/7.isUnreadInCurrentCommunitymatches, with badge customisation off: guild ALL only, muted at any level excluded.SelectedChannel.updateRecentVisit(dedup by channel+guild, MAX 20) andparsePrefix(@@, then one-character prefixes, trimmed) match.[navigation].FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh worktree onf1c41cb: all steps passed.The
heading_tofix holds.UiStatealways appliesSelectChannel, and a selected row always has a channel. So the guard clears when the follow-upSelectChannelarrives, and also when the target is the channel already open.Findings
score_termlowercases the value beforefuzzy_search. The originalfuzzySearch(term.loweredText, value)compares against the value as written, so it is case-sensitive. Native therefore gives 1 to some mixed-case fuzzy matches where the original gives 0, for example "gnrl" vs "GeNeRaL". This only affects the fuzzy tier.last_message_id(newest first). The original uses the reverse ofReadStates.mentionChannelIdsinsertion order. They are nearly always the same; this approximation is acceptable.collectskips unknown channels, so nothing user-visible breaks.Deviations stated in the PR (wiring in app.rs, the chat_persist and dailyuse_ports updates, no frecency, the hand-written confusables table, Q12 omissions, #570) are consistent with the spec and the plan.
Verdict: APPROVE (0 blocking, 3 minor; CI green locally).
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed