Daily use 14: core status, custom status, idle and presence (#499) #566
Closed
charles
wants to merge 0 commits from
dailyuse-14-core-status-idle-presence into dailyuse
pull from: dailyuse-14-core-status-idle-presence
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!566
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-14-core-status-idle-presence"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-13-core-honour-mutes
What was built
fluxer-core::presence: the user's own presence from the user settings (READY, USER_SETTINGS_UPDATE, the PATCH answer).SetStatuswrites only{status, status_resets_at, status_resets_to}(null/null, or now+d and "online");SetCustomStatuswrites only{custom_status}(text trimmed, cut to 128 chars; Unicode emoji inemoji_name, custom byemoji_idalone astoApiCustomStatusPayload;expires_atfrom Clear after;Noneor an empty draft sendsnull). Both optimistic, reverted onEffectFailed.status_resets_atPATCHes{status: resets_to (online), null, null}itself; a reset already due when settings arrive is written at once (StatusExpiry.ts).CoreEvent::Idle: idle after 10 min only over Online,afkafterafk_timeout(default 600 s). Op 3{status, afk, mobile: false, custom_status}viaEffect::SendGatewaywhenever the computed frame differs fromlast_sent(connected or not); nothing before settings load (own_frameis invisible then); never re-sent by the core on resume / same-settings READY.PresenceState::custom_by_user(from presences and member-list rows); selectorscustom_status(app, user) -> Option<CustomStatusView>(expired hidden; own expiry timer re-renders and updates op 3),status_popout(app) -> StatusPopoutModel,custom_status_modal(app) -> CustomStatusModalModel,own_status,status_label.DmRowModel.custom_status(DMs) andProfilePopout.custom_statusadded;status_of(me)is the sent status (idle while away) once settings load. README updated.Tests
crates/fluxer-core/tests/own_presence.rs(20 tests: all the plan's names plus READY op 3, invisible-before-load, due reset at READY, settings fixture, popout rows, rows' custom status, logout, malformed settings). Uses fixturesrest/user_settings_status.jsonandgateway/presence_update_custom_status.json(no new fixture: no new event or endpoint).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No FLUXER_DESKTOP_TESTS tests apply.Deviations / notes for review
guilds_channels.rs,messages.rs,presence_ui.rs,dailyuse_ports.rs) now allow only the op 3;dailyuse_portsexcludes SetStatus/SetCustomStatus/Idle from the "ignored" list and ignoreslast_sentinstate_defaults.UserAreaPopout.tsx) shows plain "For 1 hour" there and the suffix only on the custom status modal's "Clear after" options, so that is where it is (custom_status_modal). Times are written asen-US("6:15 PM", "Nov 17, 2026") likemuted_text.app.notif_settings'sClock(one clock for the store) rather than adding a second one.UserSettingsPatchedcarries no request id: it drops the oldest own write in flight (a chat-settings answer could do so first; harmless, the server's word is shown).(GuildMember, UserStatus)shape; the UI askscustom_status(app, user)per row (avoids touchingfluxer-uihere). Other users' expired custom statuses are hidden at read time; only the own one has a timer.Closes #499
🤖 Generated with Claude Code
Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 14 (core status, custom status, idle, presence)
Reviewed
61e2eba2..88b2d2ccold. I checked the plan's test list, the Interfaces block, the invariants and parity against the fork, and ran CI locally.Findings
[BLOCKING] A failed status reset is re-sent immediately, with no limit.
crates/fluxer-core/src/presence.rs, inrefresh.When the reset write (
resets_at <= now && !writing) fails,EffectFailedremoves it frompending.refreshthen runs in the samereduce_owncall. It still sees the confirmedresets_atin the past, so it emits a newPatchUserSettingsin the same batch of effects.user_settings_status.json, clock 19:30Z,READY, then answer each reset PATCH withEffectFailed(Network). All 5 of 5 failures produced a new PATCH right away.StatusExpiry.tshandleExpiry) logs the error and does not retry. The timer is only rescheduled when the settings change.resets_atit was for). Add a test that a failed reset is not retried.[minor] Any
UserSettingsPatcheddrops the oldest status write in flight. This includes answers to the PATCHes ofchat::expressions(synced preferences, sent 1.5 s after expression use) andchat::settings.chat::settingstreats answers today. A guard would help: drop a pending write only when the answer reflects it, or when its own id fails.[minor]
custom_status_in_rowschecks the profile popout insideif let Some(popout). Ifprofile::popoutreturnsNone, that assertion is skipped without a failure. Assert the popout exists.[minor/info] Deviation from the plan, which I agree with. The "(today at …)" suffix is on the custom status modal's "Clear after" options, not on the popout's expiry submenu.
UserAreaPopout.tsx:105-112labels the submenu withSTATUS_EXPIRY_LABEL_MESSAGESand adds no suffix.Checks
tests/own_presence.rs, plus 10 more. They assert the spec's values:{status:"dnd", status_resets_at:"…19:00Z", status_resets_to:"online"}.{status:"online", null, null}.emoji_name; a custom emoji byemoji_idonly.afkatafk_timeout.selectorsre-exports them:OwnPresence(unchanged),SetStatus/SetCustomStatus→PatchUserSettingswith only their fields, op 3 throughEffect::SendGateway(Envelope::presence_update),invisibleuntil loaded,status_popout(&App) -> StatusPopoutModel,custom_status(&App, user) -> Option<CustomStatusView>. Added:DmRowModel.custom_statusandProfilePopout.custom_status.session.rsand identify are untouched.timeandtracing; no I/O.user_settings_status.jsonandpresence_update_custom_status.json.afk_timeoutis clamped in proto; timestamps use saturating maths; month indexing is bounded.malformed_settings_never_paniccovers bad settings.Idle.ts:7,132-133: idle at 10 min,afkat the threshold.LocalPresence.ts: idle only over online, defaultafk_timeout600,invisibleuntil hydrated, expired custom status left out.StatusExpiry.ts:66-139: the payloads match. The no-retry-on-failure behaviour does not (see the blocking finding).CustomStatus.ts:toApiCustomStatusPayloadsends a custom emoji by id only and a Unicode one by name;normalizeCustomStatustrims and cuts to 128, and returnsnullwith neither text nor emoji.UserAreaPopout.tsx:77-95: row order and descriptions match.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree exited 0 (green).Verdict: CHANGES REQUESTED. 1 blocking finding (unbounded retry of a failed status reset) and 3 minor ones. Local CI is green.
🤖 Generated with Claude Code
Review round 1 addressed in
fac6649(localFLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen):OwnBooknow remembers the reset write in flight (reset_write); when it fails, itsresets_atis kept asfailed_resetandrefreshdoes not write that reset again until new settings arrive (take()onREADY,USER_SETTINGS_UPDATEor a patch answer clears it). This matchesStatusExpiry.handleExpiry, which logs and does not retry. New testfailed_reset_is_not_rewritten_until_new_settings: a reset due atREADYfails, five later events send no PATCH, and new settings send one again. README updated.UserSettingsPatcheddrops the oldest pending status write): deferred to #569. Matching answers to writes by content would leave a write pending forever if the server normalises a value, which is worse than the brief flap. The real fix is to giveApiResultthe request'sEffectId, which touches the event type and the runtime, so it needs its own task.if let): fixed.custom_status_in_rowsnow doesprofile::popout(&app).expect("profile popout")and asserts on it.🤖 Generated with Claude Code
Independent review (round 2): Daily use 14 (core status, custom status, idle, presence)
I reviewed
61e2eba2..fac6649(origin/dailyuse-14-core-status-idle-presence) without relying on the earlier review or the implementer's notes.Findings
[minor] The text clamp counts Unicode scalars, but the server counts UTF-16 units. See
presence.rsfrom_draftand the proto clamp:.chars().take(CUSTOM_STATUS_TEXT_LIMIT).text.slice(0, 128)inCustomStatus.ts:38. The server checksvalue.lengthinSchemaPrimitives.ts:164(createStringType(1, 128)). Both count UTF-16 units.[minor]
failed_resetis cleared by any settings that arrive, including answers to other modules' PATCHes. These are thechat::expressions/chat::settingsanswers and theUSER_SETTINGS_UPDATEthat follows them.statusResetsAt/statusResetsTo/statusactually change.failed_resetonly when the confirmedresets_atdiffers from it. This could fold into #569.[minor] #569 also covers a second case. A foreign
UserSettingsPatchedcan drop a reset write that is still in flight.refreshthen sees!writingand sends the reset a second time. This is bounded at one duplicate per foreign answer. Please mention it in #569.[info]
selectors/members.rsdoes not add a custom status to member rows. The rows stay(GuildMember, UserStatus). The UI is expected to callpresence::custom_status(app, user)for each row, as the README says. This is acceptable, but Task 32 (goldenmember_list_custom_status) needs to know.[info]
ProfilePopout.custom_statusnow exists. Task 23's Interfaces also says the popout "gainscustom_status". Task 23 should reuse this field, not add a second one.Checks
tests/own_presence.rsand assert the spec's values:{status:"dnd", status_resets_at:"…19:00:00.000Z", status_resets_to:"online"}.{status:"online", null, null}.emoji_name; a custom emoji byemoji_idalone.afk_timeout.The round-1 fixes check out.
failed_reset_is_not_rewritten_until_new_settingscovers the blocking finding, andcustom_status_in_rowsnow usesexpecton the popout.OwnPresence(fields unchanged),SetStatus/SetCustomStatus→PatchUserSettingswith only their fields, op 3 viaEffect::SendGateway(Envelope::presence_update),invisibleuntil loaded,status_popout(&App) -> StatusPopoutModel, andcustom_status(&App, user) -> Option<CustomStatusView>all exist as written, re-exported fromselectors.session.rsand the identify payload are untouched. The edits to existing tests only allow the op 3 that READY now produces; no assertion was weakened beyond that.user_settings_status.jsonandpresence_update_custom_status.json.malformed_settings_never_paniccovers bad settings.LocalPresence.ts: idle only over online,afkatafk_timeout(default 600), nothing sent before hydration.Idle.ts:>= IDLE_DURATION_MSat 10 min.StatusExpiry.ts: the payloads match, andhandleExpirydoes not retry.CustomStatus.tstoApiCustomStatusPayload: id only for a custom emoji, name for a Unicode one.TimeWindowPresets.ts: "Don't clear" first, the 60 s match tolerance, the fallback to the last preset, 24 h by default.UserAreaPopout.tsx:77-95: row order and descriptions match.UserRequestSchemas.ts:242-269:emoji_nameis dropped whenemoji_idis set.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree finished with "all steps passed" (exit 0).Verdict: APPROVED. 0 blocking findings, 3 minor findings (follow-ups optional), 2 notes for later tasks. Local CI is green.
🤖 Generated with Claude Code
Independent review (round 3): Daily use 14,
fac6649Scope:
git diff 61e2eba..fac6649(presence.rs, selectors members/sidebar/profile/mod, app.rs, README, tests/own_presence.rs and four relaxed helpers).Checks
crates/fluxer-core/tests/own_presence.rswith the spec's values. They check the exact PATCH JSON ({status, status_resets_at: ISO(now+1h), status_resets_to: "online"}andnull/null), the reset PATCH{status: online, null, null}, emoji_name with skin tone and emoji_id alone, the 128 clamp, the "Clear after" labels with the 24 h default, idle only over online, afk at afk_timeout, op 3 not sent twice, no resend on resume, the expired status hidden by a timer, and the revert on failure. There are 9 extra tests (popout rows, a reset already due at READY, failed reset, rows, logout, malformed settings).OwnPresencecomes from READY / USER_SETTINGS_UPDATE / the patch answer.SetStatus,SetCustomStatus(Option<draft>),CoreEvent::Idle, op 3 throughEffect::SendGateway,status_popout(&App) -> StatusPopoutModel,custom_status(&App, user) -> Option<CustomStatusView>, pluscustom_status_modalandown_frame/own_statusare all present.session.rsand the identify payload are untouched. Member list rows stay(GuildMember, UserStatus)and call the selector; the selector is the interface, so this is OK.time::Month, a malformed-settings test). Status and custom-status PATCHes carry only their own fields (Review Focus 1, exact-JSON asserts). No secrets.Idle.tshas idle at 600 s and afk atafk_timeout, independently: matches.LocalPresence.tshas idle only over ONLINE, afk default 600, invisible before hydration: matches.StatusExpiry.handleExpirylogs and does not retry, and with no resets_to it falls back to online: matches.UserAreaPopout.tsxhas STATUS_ORDER and "Until I change it"/"For …" with no time suffix, and the(today at …)suffix is only inCustomStatusModal.tsxformatRelativeDayTimeLabel: the implementation's deviation from the plan's Interfaces wording is correct and matches spec §3.3.last_sent), idle only over online, handed to the gateway while disconnected, and not resent by the core on RESUMED or a new READY. Tested.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree, cold target dir: all steps passed (livekit-interop skipped as usual).Findings
from_draftclamps text to 128 Unicode scalars (chars().take). The original clamps atvalue.slice(0,128)/maxLength=128and the server's zod.max(128)counts UTF-16 units, so a 128-emoji status is 256 units: the server answers 400 and the write is reverted. Clamp by UTF-16 units (Task 32's input should match). Already known from round 2; still open.take()clearsfailed_reseton any settings arrival, includingUserSettingsPatchedfrom unrelated chat-settings or expressions writes, so a failed due reset is retried on unrelated updates. The original's reaction only re-fires whenstatusResetsAt/Tochange. This is bounded and not a storm. It can be folded into #569.UserSettingsPatcheddrops the oldest presence write even when the answer belongs to achat::settingsorchat::expressionsPATCH (those also sendPatchUserSettings). The result is a transient wrong status and op 3 flicker, and a later failure of the dropped write is not reverted (the state still converges on the server's word). Tracked by #569.presence: None. The original identifies with the pre-hydration presence (invisible,PooledGatewayConnection.ts:476-483).own_framedoes returninvisible, and the plan puts the identify payload outside this task, so it belongs to Task 6/28. Worth checking there.No blocking findings.
Verdict: APPROVE (0 blocking, 4 minor; local CI green on
fac6649)Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed