Daily use 34a: Invite cards and the accept modal (#523) #562
Closed
charles
wants to merge 0 commits from
dailyuse-34a-ui-invite-cards-accept into dailyuse
pull from: dailyuse-34a-ui-invite-cards-accept
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!562
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-34a-ui-invite-cards-accept"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: dailyuse-16a-core-invite-links
What
widgets/message_content/invite.rs: invite cards under a message, one per code offluxer_core::invites::cards(InviteEmbed.tsxonEmbedCard.module.css: 22.5 rem max, 12 px corners, 48 px icon in a 56 px slot, 0.85 rem padding, the divider and full-width button). States: loading skeleton, "Unknown invite" / "Try asking for a new invite." / disabled "Invite unavailable", guild ("{n} online", "{n} members", "Join community" / "Go to community" / "Invites disabled" with the paused or raid notice; "Join community" where the original says "Preview", spec §17 Q11), group DM (inviter avatar, "Join group" / "Already joined"). The button sendsInviteAction::Accept(joins at once, no modal); the title opens the guild channel or group DM when the user is in it.screens/main/modals/invite_accept.rs: the accept modal (InviteAcceptModal.{tsx,module.css},InviteHeader.tsx,AuthPageStyles.module.css): 65 rem x 48.75 rem on--brand-primary, the 35 rem card, header variants (guild, group DM "You've been invited to join a group DM by" + inviter, loading, "Invite not found" / "This invite may have expired or been deleted."), notice under the header, the inset X (disabled while accepting); the accept error modal over it (allInviteErrors, incl. "This community is for adults only.").UserAction::OpenExternal, which Task 16a turns into the modal.message_row.rs(aMessage::Invitevariant + pushing the cards under the content),messages.rs(variant, row mapping, update arm),screens/main/mod.rs(Message::InviteAccept,into_action, the modal layer under the external-link warning),app.rs(after every snapshot,InviteAction::Resolvefor the open channel's codes the store has not asked for:invite::unresolved). Test helpertests/common/dailyuse.rs(dailyuse READY + history, invite answers in the devserver'sinvite_jsonshape).Tests
crates/fluxer-ui/tests/invites.rs:card_button_states,card_button_joins_link_opens_modal,accept_modal_header_variants(failing first, then passing).invite_card_guild,invite_card_unknown,invite_accept_modalagainst the dailyuse scenario data, drawn on lavapipe influxer-native-shots:u2204withUPDATE_GOLDEN=1; references indocs/screenshots/invite-*.png; README table rows added. No Electron capture: dimensions come from the CSS files named above.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. NoFLUXER_DESKTOP_TESTStests apply.Deviations
nsfw(protoInviteGuild), so "This community is for adults only." shows as the error modal ofGUILD_VISIT_AGE_RESTRICTED, not before the accept.Closes #523
🤖 Generated with Claude Code
Independent review: Daily use 34a (diff 995e64a..dailyuse-34a-ui-invite-cards-accept)
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciran in a fresh review worktree. Every step passed: fmt, clippy, deny, core-isolation, parity, test, vendored-tests and screenshot-tests. livekit-interop was skipped because FLUXER_LIVEKIT_TESTS is not set.What I checked
card_button_states,card_button_joins_link_opens_modalandaccept_modal_header_variantsexist incrates/fluxer-ui/tests/invites.rs, and the goldensinvite_card_guild,invite_card_unknownandinvite_accept_modalexist inscreenshots.rs,fixtures/golden/anddocs/screenshots/(with README rows). The tests assert the spec §3.6 strings exactly: "Go to community", "Join community", "Already joined", "Invite unavailable", "Unknown invite", "Try asking for a new invite.", "Invites disabled" with the paused notice, "You've been invited to join", "You've been invited to join a group DM by", "Join group DM", "Invite not found", "This invite may have expired or been deleted.", and "This community is for adults only." through theGUILD_VISIT_AGE_RESTRICTEDerror modal.InviteAction::Acceptdirectly and no modal opens. A click on the link text goes throughUserAction::OpenExternal, and 16a'schat/links.rsturns it into the accept modal. Both are tested. The modal wrapsinvites::invite_accept_modal. The work consumes the 16a core API (cards,invite_codes,InviteAction::*) as it exists.common/dailyuse.rsbuilds invite answers in the same shape as the devserver'sinvites.rs::invite_json(guild partial fields, group DMrecipientsas usernames only, 404UNKNOWN_INVITE). I found no tokens, URLs with secrets or paths.EmbedCard.module.cssmatches (max-width 22.5rem, grid gap 0.9rem and padding 0.85rem at ≥640 px, icon slot 3.5rem, icon 3rem). TheInviteEmbed.tsxstrings at L69-106 match.InviteAcceptModal.module.cssmatches (root min(65rem)/min(48.75rem), card 35rem with a 1.125rem radius, padding 1.875rem, state min-height 22.5rem). The title's navigation targets come fromInviteEmbed.tsxL212/L292.InviteCard::UnknownandAcceptBody::NotFoundwithout panicking, and the tests cover both.Findings
widgets/message_row.rs, near L691): the cards are pushed after attachments, embeds and stickers. The original rendersmessage.invitesbefore stickers, attachments and embeds (MessageAttachments.tsxL617 vs L659/680/707). "Under the message" holds either way, but a message with both an invite link and an embed or attachment shows them in a different order from the original.widgets/message_content/invite.rs,update): the original's title always callsRouterUtils.transitionTo(guildPath / groupDMPath). Here a click does nothing when the user is not in the guild or group. It is harmless, since the client cannot show a guild it is not in, but it is a small divergence that should be noted.app.rs+invite::unresolved): every snapshot runs the invite regex over every loaded message of the open channel. It is correct because the core deduplicates with the cache'sLoadingentry, but it costs O(messages) on each snapshot. A per-channel memo would avoid that. This is a follow-up candidate.InviteGuildhas no nsfw field, which is 16a's design). Other gaps: no invite pictures, splash, guild badge or card context menu; the dedicated error modals are drawn as the generic alert with the core's title and text; and the message row height estimate does not count the cards. I accept these, but each should get afollow-upissue linked from this PR, and the missing badge and menu needlaterrows indocs/parity/dailyuse.md.Verdict: APPROVED. No blocking findings and the local CI is green.
Independent review: Daily use 34a (invite cards and accept modal)
I reviewed
995e64a..1221c1acold.Tests and interfaces. The plan's tests
card_button_states,card_button_joins_link_opens_modalandaccept_modal_header_variantsexist incrates/fluxer-ui/tests/invites.rs. They assert the spec §3.6 strings: "Go to community", "Join community", "Already joined", "Invite unavailable", "Unknown invite", "Try asking for a new invite.", "Invites disabled" with "Invites are paused for this community.", "You've been invited to join (a group DM by)", "Join group DM", "Invite not found" and "This invite may have expired or been deleted.". They also check that the card button sendsInviteAction::Acceptand opens no modal, that a link click goes throughOpenExternalto the modal with no link warning, that the X is disabled while an accept is in flight, and that the error modal closes first. The goldensinvite_card_guild,invite_card_unknownandinvite_accept_modalare infixtures/golden/anddocs/screenshots/. The cards are built frominvites::cards, and the modal frominvite_accept_modal.Invariants. The UI adds no I/O. Server data reaches the views only through core selectors. There are no secrets or tokens. The test helper builds invite answers in the shape the devserver serves them (
invite_json).Parity spot checks against the fork:
EmbedCard.module.csshasmax-width: 22.5rem,gap: 0.9rem,padding: 0.85remand.iconSlot3.5rem. These match.InviteEmbed.tsx:69-106andInviteAcceptModal.tsx:46-68match.RouterUtils.transitionTo(InviteEmbed.tsx:212,292). This matches.invite.guild.nsfw === true, but the server'spackages/schema/src/domains/invite/InviteSchemas.tshas nonsfwfield, so the original never shows it from the invite.Review Focus #7. Unknown invite answers render as the Unknown or Loading card states. Nothing panics.
Findings:
app.rscallsinvite::unresolved, which runs on every snapshot. Each run scans every loaded message of the open channel with the invite regex.message_rowalso re-runsinvite_codeson every draw. This is correct, because a code is asked for only once (resolveinsertsLoading), but it does extra work on every gateway event. A follow-up could cache the codes per message.unresolvedcovers onlyui.selected_channel. A row drawn from another channel, such as a thread's starter message from the parent channel, keeps its skeleton until that channel is opened.message_row.rsandmessages.rs, which Tasks 31 and 38 also list;app.rs, which Tasks 28 and 35 also list; andscreens/main/mod.rs, which is a registration file. Those tasks are not started, and the additions are small, so later rebases should be mechanical. The PR discloses this.CI.
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed every step in the review worktree,EXIT=0.Verdict: approve. There are no blocking findings.
🤖 Generated with Claude Code
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed