Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-search-focus-hover-emoji"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#485: the search box takes only one character
Cause: confirmed. The first
Message::Editsetssearch::State::suggesting, andheader_popouts(screens/main/mod.rs) then returnedstack![screen, backdrop, popout]instead of the barescreen. The root changed shape, so iced diffed the old tree's children (the screen row's own children) against the stack's children, rebuilt the screen's widget state, and the searchtext_inputlost its focus. The new headless test reproduced this before the fix: typing "f" publishedEdit("f"), and the next key, "r", published nothing.Fix:
header_popoutsnow builds the popout as anOptionfor all three (pins, inbox, search suggestions) andoveralways returns a stack whose first layer isscreen. The backdrop and popout layers are pushed only while one is open, so their visuals and click behaviour are the same as before. Opening or closing a popout now leaves the screen's widget state alone (iced'sdiff_childrenkeeps child 0 and only truncates or extends the layers after it).#535: animated quick reactions are still images in the hover bar
Cause: confirmed.
hover_bar.rsdrew every quick reaction withanimate = falseand added no URLs to the playing set. The context menu's quick-reaction row had the same gap.What the original does:
MessageActionBar.tsx,QuickReactionButtonusesuseShouldAnimate({kind: 'emoji', isAnimated, isHovering}). An animated emoji plays all the time while "Animate emoji" is on. When the setting is off, it plays only while the pointer (or focus) is on that button.MessageContextMenu.tsxusesrenderQuickReactionEmoji, which plays the emoji always, whatever the setting.Fix:
hover_bar::animatesholds the rule above.mouse_areathat sendsQuickReactionHovered. That message updatesmessage_actions::State::quick_reaction_hovered, which is cleared when the pointer leaves the bar orclose_allruns.hover_bar::wanted_animatedlists the URLs to play.animate = true, andmenu::wanted_animatedlists its URLs.messages::actions_wanted_animatedcollects the URLs for the bar of the hovered row (or the bar under the pointer) and for the open menu. It runs for the channel view and the thread panel, and the results go intomedia::wanted's animated set so the animation clock runs.The Add reaction and Remove reactions submenus are unchanged.
Tests
crates/fluxer-ui/tests/search_focus.rs::search_bar_keeps_focus_while_suggestions_open(headless, not on Windows): clicks the bar, types "from" over four frames that carry the widget tree (frame_after), and checks eachEdit, the final query,suggesting, and that the popout offersfrom:. It failed before the fix withtyping 'r' edits the query to "fr": [].crates/fluxer-ui/tests/message_actions.rs::animated_quick_reactions_play: partyparrot becomes a quick reaction, then the test checks that it is in the playing set:Before the fix it failed at "the bar plays it".
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipasses locally (all steps, screenshot tests included). No golden changed.Closes #485
Closes #535
🤖 Generated with Claude Code
The message hover bar drew its quick reactions as still images. As in the original (MessageActionBar.tsx, QuickReactionButton: useShouldAnimate({kind: 'emoji', isHovering})), an animated custom emoji there now plays while "Animate emoji" is on, or while the pointer is on it. The context menu's quick-reaction row plays them always, as the original's renderQuickReactionEmoji does. Their animated URLs join the screen's playing set so the animation clock runs. Fixes #535 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>