Text chat 73: Update button in the channel header, Updates settings, client info footer (#435) #468
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-73-ui-update-button"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Text chat 73 (update §6): the updater's UI in
fluxer-ui, reading Text chat 71's selectors.screens::main::update_button): 32 px tool button, 24 pxDownloadSimple/ArrowClockwise,#22c55e(palette::UPDATE_ICON, citingChannelHeader.module.css:9), white in the call view's header (VoiceCallView.module.css:1006),--status-dangerfor a user-started failure; tooltip from the model ("Updating… 42%"); click →UpdateAction::ButtonClicked; disabled while notenabled. Placed between the search bar and the inbox, asChannelHeader.tsx:1152(UpdaterIconafterMessageSearchBar, beforeInboxButton); the header popouts' right offsets account for it. The spinner turns 1 turn/s on the existing animation clock, which now also runs whileupdate_button::spinning(&App)(a one-line change inapp.rs's subscription).screens::main::modals::update): restart-in-call confirmation ("Restart to update?" / "You'll leave {channel} and come back to Flaxative {version}." / Later / Restart), error ("Couldn't check for updates" / "Couldn't download the update", body texts fromUpdaterModalCommands.tsx, "Download manually" →OpenNoteswhen the release has a page, "Try again"), manual download ("Flaxative {version} is downloaded", why perManualReason, incl. "Run the installer once to install Flaxative; after that it updates itself." forPackageFormatChanged, the path, "What's new", "Show in folder").settings::advanced::{updates_content, updates_view},Panel::Updates): version line, "Update channel" dropdown (Stable disabled as "Stable (No stable release yet)" whilestable_published == Some(false); picking it does nothing), channel description, "Check for updates" + status line, switch "Install updates automatically when quitting" with the §6.2 help; a development build shows only "This is a development build. It does not update itself."settings::client_info): under the settings navigation (nav::view_with_footer), "Nightly Flaxative 2026.1113.412 (commit)" + OS line + "Click to copy"; a click copies it through iced's clipboard (Outcome::Copy) and shows "Copied" until the tab changes.Tests
crates/fluxer-ui/tests/update.rs: all 15 plan tests (the three that lay out/click use the headless software renderer and arecfg(not(windows)); the rest run everywhere). Seen failing (missing items) before the implementation, passing after.update_button_available,update_button_downloading,update_button_error,settings_updates_section,settings_client_info_footer; rows added todocs/screenshots/README.md. Existing goldens unchanged.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally (base was green before my changes too).Deviations / notes for the reviewer
ChannelHeader.tsx:1152(after the search bar, before the inbox) rather than "before all right-hand tools"; the testbutton_sits_before_the_existing_header_toolschecks that slot.Spin::reduced_motionis always false; the 60 % static branch is implemented and waits for it.client_info::view(line, copied)takes thecopiedflag besides the line (the plan's interface showsview(line)).UpdateEvent::Started(nothing to say before the runtime reports the build); that also keeps every existing settings golden unchanged.ChannelHeader.module.css);tokens.rsuntouched.crates/fluxer-ui/src/app.rs(animation clock while spinning),tests/settings_nav.rs(Advanced panel order now includes Updates),docs/screenshots/README.md(suite table).advanced-automatic-updates,native-update-channel) are left to Text chat 74.Stacked on: textchat-71-core-updater
Closes #435
🤖 Generated with Claude Code
Review of Text chat 73 (diff 4d68359..textchat-73-ui-update-button), independent reviewer.
Checked:
update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message>exists. Button order checked against fork ChannelHeader.tsx:1152: search bar, UpdaterIcon, (StaffTools), Inbox. That matches the code. 32 px button, 24 px glyph, 1 turn/s. The clock runs only while Spinning (app.rs subscription).Findings:
client_info::view(line, copied), where the plan saysview(line). No other task consumes it, so nothing breaks.Claude Opus 5.5where the repo CLAUDE.md asks forClaude Fable 5.2(the implementer disclosed this). Fixing it needs a force push, so leave it.Local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: NOT COMPLETED. The reviewer session had to end while the build was still compiling dependencies, so the local gate is unverified. The integrator should rely on the remote runners or re-run CI before merging.Verdict: no blocking code findings. Not approved by this review, because the local CI result is unconfirmed.
Round 1 review fixes (commit
f39bbeb):copiedflag is the "Copied" feedback the plan asks for (ClientInfo.tsxbehaviour); the view has no state of its own, so the settings screen passes it in. No other task consumes this function.UpdateAction::OpenNoteshas nothing to open without a release page, so a button that does nothing would be worse than none.update_button::view_withnow resolves the glyph colour inside the svg style closure from the theme being drawn (icon_colorkeeps its signature). Behaviour is unchanged today since DARK is the only theme; goldens unchanged.a850158trailer cannot be rewritten without a force push, which is denied; the new commit carries the repo'sClaude Fable 5.2trailer. The Electron side-by-side screenshots are deferred to follow-up #471.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally.Independent review (round 2) of Text chat 73, diff 4d68359..textchat-73-ui-update-button (head
f39bbeb).Checked:
crates/fluxer-ui/tests/update.rs, and all 5 screenshot goldens are intests/screenshots.rs, with PNGs infixtures/golden. They assert the spec's values (update §4.5, §4.6, §6.1, §6.2):#22c55e, white in the call header,status_dangeron error, "Updating… 42%", "Restart to update?" with "Later" and "Restart", "Couldn't download the update" with "Download manually" (OpenNotes) and "Try again", "{product} {version} is downloaded" with the path, "What's new" and "Show in folder", "Run the installer once to install Flaxative; after that it updates itself.", the install-on-quit switch on by default (SetAutomatic) with the §6.2 help text, Stable disabled as "No stable release yet" (and picking it is a no-op), the dev-build notice only, and the client-info copy with "Copied" until the tab changes.update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message>is exact. 32 px button, 24 px glyph, 1 turn/s. The animation clock runs only whilespinning(&App). The button sits between the search bar and the inbox (ChannelHeader.tsx:1152), and the header popout offsets account for it.f39bbeb: the glyph colour, including the danger red, now resolves from the theme being drawn.icon_colorkeeps its signature. Goldens unchanged.Outcome::Copy(iced clipboard), and the OS line isstd::env::consts. The download path is shown only in the modal and is never logged. No secrets, URLs or real paths in code or goldens.follow-up.Findings:
crates/fluxer-ui/src/screens/settings/client_info.rs: the signature isview(line, copied)where the plan saysview(line). No other task consumes it, and the reason given (the "Copied" state lives in the settings screen) holds. Accepted.fixtures/golden/settings_updates_section.pngandsettings_client_info_footer.pngbake in "Linux (x86_64)" fromstd::env::consts. A screenshot run on a non-x86_64 Linux runner would mismatch. Today's runner is x86_64, so this is not blocking.a850158still carries theClaude Opus 5.5trailer. It cannot be fixed without a force push (denied), andf39bbebuses the repo's trailer. Accepted.notes_url. That is reasonable, because OpenNotes has nothing to open otherwise.Local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: green ("all steps passed"). The 5 update goldens and all update.rs tests ran and passed.Verdict: APPROVED. No blocking findings, and local CI is green.