Text chat 73: Update button in the channel header, Updates settings, client info footer (#435) #468

Manually merged
charles merged 0 commits from textchat-73-ui-update-button into textchat 2026-11-13 17:17:40 +00:00
Owner

What

Text chat 73 (update §6): the updater's UI in fluxer-ui, reading Text chat 71's selectors.

  • Header button (screens::main::update_button): 32 px tool button, 24 px DownloadSimple / ArrowClockwise, #22c55e (palette::UPDATE_ICON, citing ChannelHeader.module.css:9), white in the call view's header (VoiceCallView.module.css:1006), --status-danger for a user-started failure; tooltip from the model ("Updating… 42%"); click → UpdateAction::ButtonClicked; disabled while not enabled. Placed between the search bar and the inbox, as ChannelHeader.tsx:1152 (UpdaterIcon after MessageSearchBar, before InboxButton); the header popouts' right offsets account for it. The spinner turns 1 turn/s on the existing animation clock, which now also runs while update_button::spinning(&App) (a one-line change in app.rs's subscription).
  • Modals (screens::main::modals::update): restart-in-call confirmation ("Restart to update?" / "You'll leave {channel} and come back to Flaxative {version}." / Later / Restart), error ("Couldn't check for updates" / "Couldn't download the update", body texts from UpdaterModalCommands.tsx, "Download manually" → OpenNotes when the release has a page, "Try again"), manual download ("Flaxative {version} is downloaded", why per ManualReason, incl. "Run the installer once to install Flaxative; after that it updates itself." for PackageFormatChanged, the path, "What's new", "Show in folder").
  • Advanced → Updates (settings::advanced::{updates_content, updates_view}, Panel::Updates): version line, "Update channel" dropdown (Stable disabled as "Stable (No stable release yet)" while stable_published == Some(false); picking it does nothing), channel description, "Check for updates" + status line, switch "Install updates automatically when quitting" with the §6.2 help; a development build shows only "This is a development build. It does not update itself."
  • Client info footer (settings::client_info): under the settings navigation (nav::view_with_footer), "Nightly Flaxative 2026.1113.412 (commit)" + OS line + "Click to copy"; a click copies it through iced's clipboard (Outcome::Copy) and shows "Copied" until the tab changes.

Tests

  • crates/fluxer-ui/tests/update.rs: all 15 plan tests (the three that lay out/click use the headless software renderer and are cfg(not(windows)); the rest run everywhere). Seen failing (missing items) before the implementation, passing after.
  • Screenshots (new goldens, lavapipe): update_button_available, update_button_downloading, update_button_error, settings_updates_section, settings_client_info_footer; rows added to docs/screenshots/README.md. Existing goldens unchanged.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally (base was green before my changes too).

Deviations / notes for the reviewer

  • Button order follows the cited ChannelHeader.tsx:1152 (after the search bar, before the inbox) rather than "before all right-hand tools"; the test button_sits_before_the_existing_header_tools checks that slot.
  • No reduced-motion setting exists in the client yet (#213), so Spin::reduced_motion is always false; the 60 % static branch is implemented and waits for it.
  • client_info::view(line, copied) takes the copied flag besides the line (the plan's interface shows view(line)).
  • The client info footer is hidden until UpdateEvent::Started (nothing to say before the runtime reports the build); that also keeps every existing settings golden unchanged.
  • Colour: palette constant (gen-theme does not read ChannelHeader.module.css); tokens.rs untouched.
  • Touched outside the Files list: crates/fluxer-ui/src/app.rs (animation clock while spinning), tests/settings_nav.rs (Advanced panel order now includes Updates), docs/screenshots/README.md (suite table).
  • Parity rows (advanced-automatic-updates, native-update-channel) are left to Text chat 74.
  • No Electron side-by-side: the original only shows its button when its desktop updater has an update, which I could not provoke here; the CSS values are cited in the code instead.
  • The commit trailer says Claude Opus 5.5 (the session's attribution line) where the repo's CLAUDE.md asks for Fable 5.2; it could not be amended without a force push.

Stacked on: textchat-71-core-updater

Closes #435

🤖 Generated with Claude Code

## What Text chat 73 (update §6): the updater's UI in `fluxer-ui`, reading Text chat 71's selectors. - **Header button** (`screens::main::update_button`): 32 px tool button, 24 px `DownloadSimple` / `ArrowClockwise`, `#22c55e` (`palette::UPDATE_ICON`, citing `ChannelHeader.module.css:9`), white in the call view's header (`VoiceCallView.module.css:1006`), `--status-danger` for a user-started failure; tooltip from the model ("Updating… 42%"); click → `UpdateAction::ButtonClicked`; disabled while not `enabled`. Placed between the search bar and the inbox, as `ChannelHeader.tsx:1152` (`UpdaterIcon` after `MessageSearchBar`, before `InboxButton`); the header popouts' right offsets account for it. The spinner turns 1 turn/s on the existing animation clock, which now also runs while `update_button::spinning(&App)` (a one-line change in `app.rs`'s subscription). - **Modals** (`screens::main::modals::update`): restart-in-call confirmation ("Restart to update?" / "You'll leave {channel} and come back to Flaxative {version}." / Later / Restart), error ("Couldn't check for updates" / "Couldn't download the update", body texts from `UpdaterModalCommands.tsx`, "Download manually" → `OpenNotes` when the release has a page, "Try again"), manual download ("Flaxative {version} is downloaded", why per `ManualReason`, incl. "Run the installer once to install Flaxative; after that it updates itself." for `PackageFormatChanged`, the path, "What's new", "Show in folder"). - **Advanced → Updates** (`settings::advanced::{updates_content, updates_view}`, `Panel::Updates`): version line, "Update channel" dropdown (Stable disabled as "Stable (No stable release yet)" while `stable_published == Some(false)`; picking it does nothing), channel description, "Check for updates" + status line, switch "Install updates automatically when quitting" with the §6.2 help; a development build shows only "This is a development build. It does not update itself." - **Client info footer** (`settings::client_info`): under the settings navigation (`nav::view_with_footer`), "Nightly Flaxative 2026.1113.412 (commit)" + OS line + "Click to copy"; a click copies it through iced's clipboard (`Outcome::Copy`) and shows "Copied" until the tab changes. ## Tests - `crates/fluxer-ui/tests/update.rs`: all 15 plan tests (the three that lay out/click use the headless software renderer and are `cfg(not(windows))`; the rest run everywhere). Seen failing (missing items) before the implementation, passing after. - Screenshots (new goldens, lavapipe): `update_button_available`, `update_button_downloading`, `update_button_error`, `settings_updates_section`, `settings_client_info_footer`; rows added to `docs/screenshots/README.md`. Existing goldens unchanged. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally (base was green before my changes too). ## Deviations / notes for the reviewer - Button order follows the cited `ChannelHeader.tsx:1152` (after the search bar, before the inbox) rather than "before all right-hand tools"; the test `button_sits_before_the_existing_header_tools` checks that slot. - No reduced-motion setting exists in the client yet (#213), so `Spin::reduced_motion` is always false; the 60 % static branch is implemented and waits for it. - `client_info::view(line, copied)` takes the `copied` flag besides the line (the plan's interface shows `view(line)`). - The client info footer is hidden until `UpdateEvent::Started` (nothing to say before the runtime reports the build); that also keeps every existing settings golden unchanged. - Colour: palette constant (gen-theme does not read `ChannelHeader.module.css`); `tokens.rs` untouched. - Touched outside the Files list: `crates/fluxer-ui/src/app.rs` (animation clock while spinning), `tests/settings_nav.rs` (Advanced panel order now includes Updates), `docs/screenshots/README.md` (suite table). - Parity rows (`advanced-automatic-updates`, `native-update-channel`) are left to Text chat 74. - No Electron side-by-side: the original only shows its button when its desktop updater has an update, which I could not provoke here; the CSS values are cited in the code instead. - The commit trailer says Claude Opus 5.5 (the session's attribution line) where the repo's CLAUDE.md asks for Fable 5.2; it could not be amended without a force push. Stacked on: textchat-71-core-updater Closes #435 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #433

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The header's update button between the search bar and the inbox
(ChannelHeader.tsx:1152), the updater's modals (restart in a call, error,
manual download), Advanced -> Updates and the settings sidebar's client
info footer, all reading the Text chat 71 selectors.

Refs #435

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Review of Text chat 73 (diff 4d68359..textchat-73-ui-update-button), independent reviewer.

Checked:

  • Plan tests: all 15 tests named in Step 1 are in crates/fluxer-ui/tests/update.rs, and all 5 screenshot goldens are in tests/screenshots.rs with PNGs in fixtures/golden. They assert the spec values: #22c55e, white in the call header, status_danger on error, "Updating… 42%", "Restart to update?", "Couldn't download the update", "Try again" / "Download manually" -> OpenNotes, "{product} {version} is downloaded" with "Show in folder", "Run the installer once to install Flaxative; after that it updates itself.", "Install updates automatically when quitting" on by default -> SetAutomatic, Stable disabled with "No stable release yet", the dev-build notice only, and the client info copy.
  • Interfaces: update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message> exists. Button order checked against fork ChannelHeader.tsx:1152: search bar, UpdaterIcon, (StaffTools), Inbox. That matches the code. 32 px button, 24 px glyph, 1 turn/s. The clock runs only while Spinning (app.rs subscription).
  • Invariants: fluxer-core, fluxer-emoji and the Cargo manifests are untouched. No new I/O in fluxer-ui: the copy goes through Outcome::Copy (iced clipboard), and std::env::consts is a constant. No secrets or URLs in code or fixtures. The downloaded path is shown only in the modal, never logged. Server data is not involved.
  • Review Focus: no item covers Task 73.

Findings:

  • [minor] crates/fluxer-ui/src/screens/settings/client_info.rs: the signature is client_info::view(line, copied), where the plan says view(line). No other task consumes it, so nothing breaks.
  • [minor] crates/fluxer-ui/src/screens/main/modals/update.rs: "Download manually" shows only when the release has a notes_url. The plan lists it unconditionally. That is reasonable, because OpenNotes is a no-op without a URL.
  • [minor] update_button::view_with resolves the danger colour from Theme::DARK, not from the active theme. This matches how the rest of the header uses DARK today.
  • [minor] The commit trailer says Claude Opus 5.5 where the repo CLAUDE.md asks for Claude Fable 5.2 (the implementer disclosed this). Fixing it needs a force push, so leave it.
  • [minor] No Electron side-by-side screenshot is attached (Step 5).

Local FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: NOT COMPLETED. The reviewer session had to end while the build was still compiling dependencies, so the local gate is unverified. The integrator should rely on the remote runners or re-run CI before merging.

Verdict: no blocking code findings. Not approved by this review, because the local CI result is unconfirmed.

Review of Text chat 73 (diff 4d68359..textchat-73-ui-update-button), independent reviewer. Checked: - Plan tests: all 15 tests named in Step 1 are in crates/fluxer-ui/tests/update.rs, and all 5 screenshot goldens are in tests/screenshots.rs with PNGs in fixtures/golden. They assert the spec values: #22c55e, white in the call header, status_danger on error, "Updating… 42%", "Restart to update?", "Couldn't download the update", "Try again" / "Download manually" -> OpenNotes, "{product} {version} is downloaded" with "Show in folder", "Run the installer once to install Flaxative; after that it updates itself.", "Install updates automatically when quitting" on by default -> SetAutomatic, Stable disabled with "No stable release yet", the dev-build notice only, and the client info copy. - Interfaces: `update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message>` exists. Button order checked against fork ChannelHeader.tsx:1152: search bar, UpdaterIcon, (StaffTools), Inbox. That matches the code. 32 px button, 24 px glyph, 1 turn/s. The clock runs only while Spinning (app.rs subscription). - Invariants: fluxer-core, fluxer-emoji and the Cargo manifests are untouched. No new I/O in fluxer-ui: the copy goes through Outcome::Copy (iced clipboard), and std::env::consts is a constant. No secrets or URLs in code or fixtures. The downloaded path is shown only in the modal, never logged. Server data is not involved. - Review Focus: no item covers Task 73. Findings: - [minor] crates/fluxer-ui/src/screens/settings/client_info.rs: the signature is `client_info::view(line, copied)`, where the plan says `view(line)`. No other task consumes it, so nothing breaks. - [minor] crates/fluxer-ui/src/screens/main/modals/update.rs: "Download manually" shows only when the release has a notes_url. The plan lists it unconditionally. That is reasonable, because OpenNotes is a no-op without a URL. - [minor] update_button::view_with resolves the danger colour from Theme::DARK, not from the active theme. This matches how the rest of the header uses DARK today. - [minor] The commit trailer says `Claude Opus 5.5` where the repo CLAUDE.md asks for `Claude Fable 5.2` (the implementer disclosed this). Fixing it needs a force push, so leave it. - [minor] No Electron side-by-side screenshot is attached (Step 5). Local `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`: NOT COMPLETED. The reviewer session had to end while the build was still compiling dependencies, so the local gate is unverified. The integrator should rely on the remote runners or re-run CI before merging. Verdict: no blocking code findings. Not approved by this review, because the local CI result is unconfirmed.
The error glyph's danger colour is resolved in the svg style closure
from the theme being drawn, not from Theme::DARK.

Refs #435

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Round 1 review fixes (commit f39bbeb):

  1. client_info::view(line, copied) (minor): kept as is. The copied flag is the "Copied" feedback the plan asks for (ClientInfo.tsx behaviour); the view has no state of its own, so the settings screen passes it in. No other task consumes this function.
  2. "Download manually" only with a notes_url (minor): kept as is. UpdateAction::OpenNotes has nothing to open without a release page, so a button that does nothing would be worse than none.
  3. Danger colour from Theme::DARK (minor): fixed. update_button::view_with now resolves the glyph colour inside the svg style closure from the theme being drawn (icon_color keeps its signature). Behaviour is unchanged today since DARK is the only theme; goldens unchanged.
  4. Commit trailer / missing Electron side-by-side (minor): the a850158 trailer cannot be rewritten without a force push, which is denied; the new commit carries the repo's Claude Fable 5.2 trailer. The Electron side-by-side screenshots are deferred to follow-up #471.

FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally.

Round 1 review fixes (commit f39bbeb): 1. **client_info::view(line, copied)** (minor): kept as is. The `copied` flag is the "Copied" feedback the plan asks for (`ClientInfo.tsx` behaviour); the view has no state of its own, so the settings screen passes it in. No other task consumes this function. 2. **"Download manually" only with a notes_url** (minor): kept as is. `UpdateAction::OpenNotes` has nothing to open without a release page, so a button that does nothing would be worse than none. 3. **Danger colour from Theme::DARK** (minor): fixed. `update_button::view_with` now resolves the glyph colour inside the svg style closure from the theme being drawn (`icon_color` keeps its signature). Behaviour is unchanged today since DARK is the only theme; goldens unchanged. 4. **Commit trailer / missing Electron side-by-side** (minor): the a850158 trailer cannot be rewritten without a force push, which is denied; the new commit carries the repo's `Claude Fable 5.2` trailer. The Electron side-by-side screenshots are deferred to follow-up #471. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally.
Author
Owner

Independent review (round 2) of Text chat 73, diff 4d68359..textchat-73-ui-update-button (head f39bbeb).

Checked:

  • Plan tests: all 15 Step 1 tests are in crates/fluxer-ui/tests/update.rs, and all 5 screenshot goldens are in tests/screenshots.rs, with PNGs in fixtures/golden. They assert the spec's values (update §4.5, §4.6, §6.1, §6.2): #22c55e, white in the call header, status_danger on error, "Updating… 42%", "Restart to update?" with "Later" and "Restart", "Couldn't download the update" with "Download manually" (OpenNotes) and "Try again", "{product} {version} is downloaded" with the path, "What's new" and "Show in folder", "Run the installer once to install Flaxative; after that it updates itself.", the install-on-quit switch on by default (SetAutomatic) with the §6.2 help text, Stable disabled as "No stable release yet" (and picking it is a no-op), the dev-build notice only, and the client-info copy with "Copied" until the tab changes.
  • Interfaces: update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message> is exact. 32 px button, 24 px glyph, 1 turn/s. The animation clock runs only while spinning(&App). The button sits between the search bar and the inbox (ChannelHeader.tsx:1152), and the header popout offsets account for it.
  • f39bbeb: the glyph colour, including the danger red, now resolves from the theme being drawn. icon_color keeps its signature. Goldens unchanged.
  • Invariants: fluxer-core, fluxer-emoji, Cargo.toml and Cargo.lock are untouched. fluxer-ui gains no I/O path: the copy goes through Outcome::Copy (iced clipboard), and the OS line is std::env::consts. The download path is shown only in the modal and is never logged. No secrets, URLs or real paths in code or goldens.
  • Review Focus: no item covers this task.
  • Follow-up #471 (Electron side-by-side) exists, open, labelled follow-up.

Findings:

  • [minor] crates/fluxer-ui/src/screens/settings/client_info.rs: the signature is view(line, copied) where the plan says view(line). No other task consumes it, and the reason given (the "Copied" state lives in the settings screen) holds. Accepted.
  • [minor] fixtures/golden/settings_updates_section.png and settings_client_info_footer.png bake in "Linux (x86_64)" from std::env::consts. A screenshot run on a non-x86_64 Linux runner would mismatch. Today's runner is x86_64, so this is not blocking.
  • [minor] a850158 still carries the Claude Opus 5.5 trailer. It cannot be fixed without a force push (denied), and f39bbeb uses the repo's trailer. Accepted.
  • [minor] "Download manually" is shown only when the release has a notes_url. That is reasonable, because OpenNotes has nothing to open otherwise.

Local FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: green ("all steps passed"). The 5 update goldens and all update.rs tests ran and passed.

Verdict: APPROVED. No blocking findings, and local CI is green.

Independent review (round 2) of Text chat 73, diff 4d68359..textchat-73-ui-update-button (head f39bbeb). Checked: - Plan tests: all 15 Step 1 tests are in `crates/fluxer-ui/tests/update.rs`, and all 5 screenshot goldens are in `tests/screenshots.rs`, with PNGs in `fixtures/golden`. They assert the spec's values (update §4.5, §4.6, §6.1, §6.2): `#22c55e`, white in the call header, `status_danger` on error, "Updating… 42%", "Restart to update?" with "Later" and "Restart", "Couldn't download the update" with "Download manually" (OpenNotes) and "Try again", "{product} {version} is downloaded" with the path, "What's new" and "Show in folder", "Run the installer once to install Flaxative; after that it updates itself.", the install-on-quit switch on by default (SetAutomatic) with the §6.2 help text, Stable disabled as "No stable release yet" (and picking it is a no-op), the dev-build notice only, and the client-info copy with "Copied" until the tab changes. - Interfaces: `update_button::view(&UpdateButtonModel, call_header: bool) -> Element<Message>` is exact. 32 px button, 24 px glyph, 1 turn/s. The animation clock runs only while `spinning(&App)`. The button sits between the search bar and the inbox (ChannelHeader.tsx:1152), and the header popout offsets account for it. - f39bbeb: the glyph colour, including the danger red, now resolves from the theme being drawn. `icon_color` keeps its signature. Goldens unchanged. - Invariants: fluxer-core, fluxer-emoji, Cargo.toml and Cargo.lock are untouched. fluxer-ui gains no I/O path: the copy goes through `Outcome::Copy` (iced clipboard), and the OS line is `std::env::consts`. The download path is shown only in the modal and is never logged. No secrets, URLs or real paths in code or goldens. - Review Focus: no item covers this task. - Follow-up #471 (Electron side-by-side) exists, open, labelled `follow-up`. Findings: - [minor] `crates/fluxer-ui/src/screens/settings/client_info.rs`: the signature is `view(line, copied)` where the plan says `view(line)`. No other task consumes it, and the reason given (the "Copied" state lives in the settings screen) holds. Accepted. - [minor] `fixtures/golden/settings_updates_section.png` and `settings_client_info_footer.png` bake in "Linux (x86_64)" from `std::env::consts`. A screenshot run on a non-x86_64 Linux runner would mismatch. Today's runner is x86_64, so this is not blocking. - [minor] a850158 still carries the `Claude Opus 5.5` trailer. It cannot be fixed without a force push (denied), and f39bbeb uses the repo's trailer. Accepted. - [minor] "Download manually" is shown only when the release has a `notes_url`. That is reasonable, because OpenNotes has nothing to open otherwise. Local `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: **green** ("all steps passed"). The 5 update goldens and all update.rs tests ran and passed. Verdict: APPROVED. No blocking findings, and local CI is green.
# Conflicts:
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/tests/screenshots.rs
#	docs/screenshots/README.md
charles manually merged commit c1390123e5 into textchat 2026-11-13 17:17:40 +00:00
Sign in to join this conversation.
No description provided.